[Code Origin] DEBUG-4998 Add code origin support for Net Framework MVC and web api #8083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8083) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8083) - mean (69ms) : 67, 70
master - mean (68ms) : 66, 70
section Bailout
This PR (8083) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8083) - mean (1,031ms) : 962, 1099
master - mean (1,020ms) : 975, 1066
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8083) - mean (106ms) : 104, 109
master - mean (106ms) : 104, 108
section Bailout
This PR (8083) - mean (107ms) : 106, 108
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8083) - mean (749ms) : 699, 800
master - mean (741ms) : 684, 797
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8083) - mean (94ms) : 92, 97
master - mean (94ms) : 92, 96
section Bailout
This PR (8083) - mean (95ms) : 93, 96
master - mean (94ms) : 94, 95
section CallTarget+Inlining+NGEN
This PR (8083) - mean (728ms) : 705, 751
master - mean (728ms) : 700, 756
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8083) - mean (92ms) : 90, 95
master - mean (92ms) : 90, 94
section Bailout
This PR (8083) - mean (93ms) : 92, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8083) - mean (640ms) : 623, 657
master - mean (640ms) : 625, 655
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8083) - mean (195ms) : 192, 199
master - mean (196ms) : 189, 204
section Bailout
This PR (8083) - mean (200ms) : 196, 204
master - mean (203ms) : 193, 213
section CallTarget+Inlining+NGEN
This PR (8083) - mean (1,153ms) : 1094, 1212
master - mean (1,160ms) : 1086, 1234
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8083) - mean (280ms) : 275, 286
master - mean (279ms) : 273, 284
section Bailout
This PR (8083) - mean (280ms) : 276, 284
master - mean (279ms) : 275, 283
section CallTarget+Inlining+NGEN
This PR (8083) - mean (950ms) : 897, 1002
master - mean (933ms) : 878, 989
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8083) - mean (278ms) : 264, 291
master - mean (272ms) : 266, 279
section Bailout
This PR (8083) - mean (279ms) : 266, 293
master - mean (273ms) : 268, 279
section CallTarget+Inlining+NGEN
This PR (8083) - mean (937ms) : 884, 990
master - mean (936ms) : 888, 984
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8083) - mean (275ms) : 269, 280
master - mean (273ms) : 264, 283
section Bailout
This PR (8083) - mean (276ms) : 269, 282
master - mean (275ms) : 260, 290
section CallTarget+Inlining+NGEN
This PR (8083) - mean (847ms) : 828, 866
master - mean (849ms) : 823, 874
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 962ba7063e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AspNet/AspNetWebApi2CodeOriginTests.cs
Show resolved
Hide resolved
dudikeleti
force-pushed
the
dudik/co/add-netframework-support
branch
from
962ba70 to
34ebc7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Code Origin for Spans was already supported on ASP.NET Core entry spans, but classic ASP.NET (.NET Framework) MVC/Web API entry spans (aspnet.request) were missing _dd.code_origin.* tags, preventing file/line enrichment and consistent “entry span origin” behavior across runtimes. There is open customer ticket for this.
Implementation details
MVC: Added code origin tagging for root entry span (aspnet.request) in ControllerActionInvoker_InvokeAction_Integration.
Web API: Added code origin tagging for root entry span root entry span (aspnet.request) in ReflectedHttpActionDescriptor_ExecuteAsync_Integration.
PDB enrichment support: Extended EndpointDetector to recognize .NET Framework MVC/Web API controller endpoints so sequence points can be loaded for file/line/column.
Out of scope of this PR
This change focuses only on entry spans for .NET Framework ASP.NET MVC 4/5 and Web API 2. It does not add Code Origin for Spans support for the following:
Test coverage
Unit tests:
Updated
EndpointDetectorTeststo validate detection of .NET Framework MVC/WebApi2 endpoints.Integration tests:
AspNetMvc5CodeOriginTests&AspNetWebApi2CodeOriginTestsEnabled code origin via env var and verified emitted span snapshots include code origin tags.