Skip to content

Conversation

@chrisnas
Copy link
Contributor

Summary of changes

Add Windows PDB format support in addition to the existing Portable PDB format.

Reason for change

Needed for old .NET Framework applications

Implementation details

Limited to the start of the method (not the exact position in the source code file based on the Instruction pointer)

Test coverage

Unit tests have been added for both Portable and Windows parsers

Other details

@chrisnas chrisnas requested a review from a team as a code owner January 22, 2026 18:16
@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Jan 22, 2026
@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2026

Benchmarks

Benchmark execution time: 2026-01-29 17:28:04

Comparing candidate commit 71de755 in PR branch chrisnas/support_windows_pdb with baseline commit 339b936 in branch master.

Found 5 performance improvements and 9 performance regressions! Performance is the same for 164 metrics, 14 unstable metrics.

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+91.839ms; +92.223ms] or [+82.311%; +82.655%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 execution_time [-21.304ms; -15.258ms] or [-9.682%; -6.934%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟩 execution_time [-101.790ms; -101.070ms] or [-51.941%; -51.574%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟩 execution_time [-10.970ms; -5.957ms] or [-10.270%; -5.577%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟩 throughput [+102.261op/s; +166.740op/s] or [+10.566%; +17.229%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+17.232ms; +22.634ms] or [+9.946%; +13.064%]
  • 🟥 throughput [-173.440op/s; -131.968op/s] or [-11.732%; -8.927%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+11.513ms; +17.277ms] or [+6.304%; +9.460%]
  • 🟥 throughput [-131.890op/s; -86.470op/s] or [-8.835%; -5.792%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • 🟥 throughput [-188.345op/s; -138.205op/s] or [-35.644%; -26.155%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+43.732ms; +44.944ms] or [+28.952%; +29.754%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 throughput [-9243.304op/s; -8223.314op/s] or [-6.119%; -5.444%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟩 throughput [+14752.722op/s; +16997.314op/s] or [+6.568%; +7.567%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+29.888ms; +31.269ms] or [+30.149%; +31.543%]

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8096) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration77.82 ± (77.77 - 78.08) ms78.74 ± (78.75 - 79.11) ms+1.2%✅⬆️
.NET Framework 4.8 - Bailout
duration82.56 ± (82.47 - 82.84) ms83.06 ± (82.99 - 83.39) ms+0.6%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1095.76 ± (1096.42 - 1102.28) ms1099.45 ± (1096.81 - 1104.28) ms+0.3%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms24.06 ± (24.01 - 24.10) ms23.80 ± (23.75 - 23.85) ms-1.1%
process.time_to_main_ms92.42 ± (92.21 - 92.63) ms91.72 ± (91.51 - 91.94) ms-0.8%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.88 ± (10.88 - 10.89) MB10.89 ± (10.89 - 10.90) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms24.10 ± (24.03 - 24.17) ms23.88 ± (23.81 - 23.95) ms-0.9%
process.time_to_main_ms93.68 ± (93.44 - 93.92) ms94.22 ± (94.05 - 94.39) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.92) MB10.91 ± (10.91 - 10.92) MB-0.0%
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms235.15 ± (231.61 - 238.70) ms237.94 ± (234.35 - 241.54) ms+1.2%✅⬆️
process.time_to_main_ms525.26 ± (524.19 - 526.33) ms523.36 ± (522.50 - 524.22) ms-0.4%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.48 ± (48.46 - 48.51) MB48.48 ± (48.45 - 48.50) MB-0.0%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%
.NET 6 - Baseline
process.internal_duration_ms22.34 ± (22.29 - 22.40) ms22.25 ± (22.19 - 22.30) ms-0.4%
process.time_to_main_ms78.48 ± (78.30 - 78.65) ms79.06 ± (78.86 - 79.27) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.60 ± (10.59 - 10.60) MB10.62 ± (10.62 - 10.62) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms22.34 ± (22.29 - 22.39) ms22.41 ± (22.35 - 22.47) ms+0.3%✅⬆️
process.time_to_main_ms80.14 ± (79.92 - 80.36) ms81.32 ± (81.09 - 81.55) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.65 ± (10.65 - 10.66) MB10.75 ± (10.73 - 10.76) MB+0.9%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms240.37 ± (236.22 - 244.51) ms237.30 ± (233.16 - 241.44) ms-1.3%
process.time_to_main_ms496.27 ± (495.39 - 497.15) ms496.30 ± (495.58 - 497.01) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed49.11 ± (49.09 - 49.14) MB49.14 ± (49.13 - 49.16) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms20.54 ± (20.49 - 20.59) ms20.34 ± (20.29 - 20.39) ms-1.0%
process.time_to_main_ms78.01 ± (77.84 - 78.18) ms77.82 ± (77.64 - 78.00) ms-0.2%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.66 ± (7.66 - 7.67) MB7.67 ± (7.66 - 7.67) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms20.44 ± (20.38 - 20.50) ms20.28 ± (20.22 - 20.33) ms-0.8%
process.time_to_main_ms79.02 ± (78.84 - 79.21) ms78.51 ± (78.31 - 78.70) ms-0.7%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.72) MB7.73 ± (7.71 - 7.74) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms196.20 ± (195.48 - 196.92) ms197.21 ± (196.52 - 197.91) ms+0.5%✅⬆️
process.time_to_main_ms477.65 ± (476.82 - 478.48) ms478.09 ± (477.32 - 478.85) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed37.04 ± (36.99 - 37.09) MB37.04 ± (37.00 - 37.08) MB-0.0%
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration200.09 ± (199.97 - 200.84) ms194.68 ± (194.55 - 195.42) ms-2.7%
.NET Framework 4.8 - Bailout
duration203.57 ± (203.38 - 204.03) ms198.48 ± (198.30 - 199.06) ms-2.5%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1162.91 ± (1162.16 - 1171.51) ms1161.78 ± (1161.37 - 1172.16) ms-0.1%
.NET Core 3.1 - Baseline
process.internal_duration_ms192.96 ± (192.37 - 193.54) ms192.51 ± (192.04 - 192.97) ms-0.2%
process.time_to_main_ms83.80 ± (83.52 - 84.08) ms83.18 ± (82.95 - 83.41) ms-0.7%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.03 ± (16.01 - 16.04) MB16.11 ± (16.09 - 16.13) MB+0.5%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.2%
.NET Core 3.1 - Bailout
process.internal_duration_ms194.04 ± (193.44 - 194.65) ms189.72 ± (189.29 - 190.14) ms-2.2%
process.time_to_main_ms85.83 ± (85.49 - 86.17) ms83.77 ± (83.57 - 83.96) ms-2.4%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.09 ± (16.07 - 16.11) MB16.06 ± (16.03 - 16.08) MB-0.2%
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.2%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms433.33 ± (430.10 - 436.56) ms427.86 ± (424.70 - 431.02) ms-1.3%
process.time_to_main_ms492.33 ± (491.18 - 493.49) ms481.42 ± (480.72 - 482.12) ms-2.2%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed58.82 ± (58.71 - 58.94) MB59.07 ± (58.96 - 59.18) MB+0.4%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.1%
.NET 6 - Baseline
process.internal_duration_ms193.52 ± (193.11 - 193.94) ms192.52 ± (192.20 - 192.85) ms-0.5%
process.time_to_main_ms71.50 ± (71.31 - 71.70) ms70.66 ± (70.46 - 70.87) ms-1.2%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.38 ± (16.35 - 16.41) MB16.09 ± (15.96 - 16.23) MB-1.8%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.9%
.NET 6 - Bailout
process.internal_duration_ms192.57 ± (192.20 - 192.93) ms192.59 ± (192.22 - 192.96) ms+0.0%✅⬆️
process.time_to_main_ms72.14 ± (71.98 - 72.29) ms71.66 ± (71.51 - 71.81) ms-0.7%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.18 ± (16.05 - 16.30) MB16.37 ± (16.29 - 16.45) MB+1.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.1%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms441.61 ± (438.14 - 445.08) ms441.93 ± (438.69 - 445.17) ms+0.1%✅⬆️
process.time_to_main_ms461.49 ± (460.87 - 462.11) ms460.71 ± (460.11 - 461.31) ms-0.2%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed59.02 ± (58.89 - 59.15) MB59.12 ± (59.00 - 59.25) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%
.NET 8 - Baseline
process.internal_duration_ms191.38 ± (191.00 - 191.77) ms191.57 ± (191.24 - 191.89) ms+0.1%✅⬆️
process.time_to_main_ms70.74 ± (70.52 - 70.96) ms70.64 ± (70.45 - 70.84) ms-0.1%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.75 ± (11.71 - 11.78) MB11.71 ± (11.69 - 11.74) MB-0.3%
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.5%
.NET 8 - Bailout
process.internal_duration_ms191.04 ± (190.71 - 191.36) ms191.00 ± (190.59 - 191.41) ms-0.0%
process.time_to_main_ms71.52 ± (71.36 - 71.67) ms71.86 ± (71.67 - 72.05) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.82 ± (11.79 - 11.84) MB11.80 ± (11.76 - 11.83) MB-0.2%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms369.55 ± (368.19 - 370.91) ms370.78 ± (369.36 - 372.21) ms+0.3%✅⬆️
process.time_to_main_ms444.29 ± (443.36 - 445.22) ms445.48 ± (444.73 - 446.23) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed48.33 ± (48.29 - 48.36) MB48.40 ± (48.38 - 48.43) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.7%
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8096) - mean (79ms)  : 76, 82
    master - mean (78ms)  : 76, 80

    section Bailout
    This PR (8096) - mean (83ms)  : 81, 85
    master - mean (83ms)  : 80, 85

    section CallTarget+Inlining+NGEN
    This PR (8096) - mean (1,101ms)  : 1055, 1147
    master - mean (1,099ms)  : 1057, 1142

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8096) - mean (123ms)  : 119, 127
    master - mean (124ms)  : 120, 128

    section Bailout
    This PR (8096) - mean (125ms)  : 123, 128
    master - mean (125ms)  : 122, 128

    section CallTarget+Inlining+NGEN
    This PR (8096) - mean (803ms)  : 739, 867
    master - mean (801ms)  : 743, 859

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8096) - mean (108ms)  : 103, 112
    master - mean (107ms)  : 104, 111

    section Bailout
    This PR (8096) - mean (110ms)  : 107, 114
    master - mean (109ms)  : 106, 112

    section CallTarget+Inlining+NGEN
    This PR (8096) - mean (768ms)  : 693, 842
    master - mean (766ms)  : 690, 842

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8096) - mean (106ms)  : 103, 110
    master - mean (107ms)  : 103, 111

    section Bailout
    This PR (8096) - mean (107ms)  : 104, 109
    master - mean (107ms)  : 105, 110

    section CallTarget+Inlining+NGEN
    This PR (8096) - mean (710ms)  : 686, 734
    master - mean (709ms)  : 686, 732

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8096) - mean (195ms)  : 190, 199
    master - mean (200ms)  : 194, 206

    section Bailout
    This PR (8096) - mean (199ms)  : 195, 203
    master - mean (204ms)  : 201, 207

    section CallTarget+Inlining+NGEN
    This PR (8096) - mean (1,167ms)  : 1083, 1250
    master - mean (1,167ms)  : 1097, 1236

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8096) - mean (285ms)  : 275, 295
    master - mean (285ms)  : 273, 298

    section Bailout
    This PR (8096) - mean (282ms)  : 276, 288
    master - mean (289ms)  : 280, 297

    section CallTarget+Inlining+NGEN
    This PR (8096) - mean (938ms)  : 883, 992
    master - mean (959ms)  : 911, 1008

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8096) - mean (272ms)  : 267, 276
    master - mean (274ms)  : 269, 279

    section Bailout
    This PR (8096) - mean (272ms)  : 268, 276
    master - mean (273ms)  : 269, 277

    section CallTarget+Inlining+NGEN
    This PR (8096) - mean (932ms)  : 879, 985
    master - mean (934ms)  : 867, 1002

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8096) - mean (272ms)  : 268, 276
    master - mean (272ms)  : 266, 278

    section Bailout
    This PR (8096) - mean (273ms)  : 266, 279
    master - mean (273ms)  : 268, 277

    section CallTarget+Inlining+NGEN
    This PR (8096) - mean (846ms)  : 825, 867
    master - mean (844ms)  : 827, 862

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:profiler Issues related to the continous-profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants