Skip to content

Fix flaky test metrics tag values #8099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NachoEchevarria merged 8 commits into from
Feb 3, 2026
+19 −6
Merged

Fix flaky test metrics tag values #8099

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c6f9e29
Fix test full name in flaky metrics
NachoEchevarria Jan 22, 2026
7d3bf3e
Fix missing tags
NachoEchevarria Jan 23, 2026
304e1a1
Do not normalize framework version
NachoEchevarria Jan 23, 2026
e9a7d9a
Merge branch 'master' into nacho/FlakyFullNameTests
NachoEchevarria Jan 27, 2026
168eb9b
Update tracer/test/Datadog.Trace.TestHelpers/CustomTestFramework.cs
NachoEchevarria Jan 29, 2026
9a49df3
move max length to const
NachoEchevarria Jan 29, 2026
ceaccdc
Fix target_framework tag
NachoEchevarria Feb 2, 2026
dafc31b
Merge branch 'nacho/FlakyFullNameTests' of https://github.com/DataDog…
NachoEchevarria Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tracer/test/Datadog.Trace.TestHelpers/CustomTestFramework.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,15 @@ protected override async Task<RunSummary> RunTestCaseAsync(IXunitTestCase testCa
}

_diagnosticMessageSink.OnMessage(new DiagnosticMessage($"RETRYING: {test} ({attemptsRemaining} attempts remaining, {retryReason})"));
var testFullName = $"{TestMethod.TestClass.Class.Name}.{testCase.DisplayName}";
var testFullName = (testCase.DisplayName.StartsWith(TestMethod.TestClass.Class.Name) ?
testCase.DisplayName :
$"{TestMethod.TestClass.Class.Name}.{testCase.DisplayName}").Trim();

if (testFullName.Length > 200)
Copy link
Collaborator

@bouwkast bouwkast Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For readability in the future can we just extract 200 to some variable to note that it is the maximum name length? var maxTestNameLength = 200

Copy link
Collaborator Author

@NachoEchevarria NachoEchevarria Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Done!

{
testFullName = testFullName.Substring(0, 200);
}

await SendMetric(_diagnosticMessageSink, "dd_trace_dotnet.ci.tests.retries", testFullName, retryReason);
}
}
Expand Down Expand Up @@ -349,7 +357,7 @@ async Task SendMetric(IMessageSink outputHelper, string metricName, string testF
var tags = $$"""
"os.platform:{{SanitizeTagValue(FrameworkDescription.Instance.OSPlatform)}}",
"os.architecture:{{SanitizeTagValue(EnvironmentTools.GetPlatform())}}",
"target.framework:{{SanitizeTagValue(FrameworkDescription.Instance.ProductVersion)}}",
"target.framework:{FrameworkDescription.Instance.ProductVersion}",
"test.name:{{SanitizeTagValue(testFullName)}}",
"git.branch:{{SanitizeTagValue(Environment.GetEnvironmentVariable("DD_LOGGER_BUILD_SOURCEBRANCH"))}}",
"flaky_retry_reason: {{SanitizeTagValue(reason)}}"
Expand Down
Loading