Add ErrorCode enum to feature flag evaluations #8109
Draft
+58
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a structured ErrorCode enum that maps to OpenFeature's ErrorType, allowing providers to programmatically check error conditions without parsing error strings. - Add ErrorCode enum with values: None, ProviderNotReady, FlagNotFound, TypeMismatch, ParseError, TargetingKeyMissing, InvalidContext, General - Add ErrorCode property to IEvaluation interface - Update Evaluation class to include ErrorCode - Update FeatureFlagsEvaluator to set appropriate ErrorCode for each error case The existing Error string property is preserved for backwards compatibility and to allow custom error messages (e.g., exception details).
github-actions
bot
added
the
area:tracer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When integrating with OpenFeature, providers need to map Datadog's error conditions to OpenFeature's
ErrorTypeenum. Currently, theIEvaluation.Errorproperty is a string, requiring providers to do string matching to determine the error type.Changes
ErrorCodeenum with values that map to OpenFeature'sErrorType:None,ProviderNotReady,FlagNotFound,TypeMismatch,ParseError,TargetingKeyMissing,InvalidContext,GeneralErrorCodeproperty toIEvaluationinterfaceEvaluationclass to includeErrorCodeparameterFeatureFlagsEvaluatorto set appropriateErrorCodefor each error caseDecisions
Error(string) andErrorCode(enum): The string property is preserved for backwards compatibility and to allow custom error messages (e.g., exception details). This follows the same pattern as Java's OpenFeature integration which has botherrorCodeanderrorMessage.