Skip to content

Commit 18bde0b

Browse files
kakkoyunkakkoyun
committed
feat(ci): upgrade golangci-lint
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
1 parent 1e5b2db commit 18bde0b

File tree

5 files changed

+269
-258
lines changed

5 files changed

+269
-258
lines changed

‎.claude/settings.local.json‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,16 @@
11
{
22
"permissions": {
33
"allow": [
4-
"Bash(go test:*)"
4+
"Bash(go test:*)",
5+
"Bash(git worktree add:*)",
6+
"Bash(git -C /Users/kemal.akkoyun/go/src/github.com/DataDog/dd-trace-go-lint-fixes checkout -b kakkoyun/fix-lint-issues)",
7+
"Bash(make tools-install:*)",
8+
"Bash(ZDOTDIR=/dev/null zsh:*)",
9+
"Bash(git -C /Users/kemal.akkoyun/go/src/github.com/DataDog/dd-trace-go-lint-fixes diff --stat)",
10+
"Bash(git -C /Users/kemal.akkoyun/go/src/github.com/DataDog/dd-trace-go-lint-fixes log --oneline -5)",
11+
"WebFetch(domain:github.com)",
12+
"Bash(GOWORK=off go get:*)",
13+
"Bash(GOWORK=off GOPROXY=https://proxy.golang.org,direct go get:*)"
514
],
615
"deny": [],
716
"ask": []

‎.github/workflows/static-checks.yml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@ on:
77
- release-*
88
- mq-working-branch-**
99
tags-ignore:
10-
- 'contrib/**'
11-
- 'instrumentation/**'
12-
- 'internal/**'
13-
- 'orchestrion/**'
14-
- 'scripts/**'
10+
- "contrib/**"
11+
- "instrumentation/**"
12+
- "internal/**"
13+
- "orchestrion/**"
14+
- "scripts/**"
1515
workflow_call:
1616
inputs:
1717
go-version:
1818
required: true
1919
type: string
2020
ref:
21-
description: 'The branch to run the workflow on'
21+
description: "The branch to run the workflow on"
2222
required: true
2323
type: string
2424

@@ -30,7 +30,7 @@ env:
3030
# without having to download a newer one.
3131
GOTOOLCHAIN: local
3232
GODEBUG: "x509negativeserial=1"
33-
GOLANGCI_LINT_VERSION: v2.3.0 # NOTICE: Make sure this is synced with the version in the _tools/go.mod file.
33+
GOLANGCI_LINT_VERSION: v2.9.0 # NOTICE: Make sure this is synced with the version in the _tools/go.mod file.
3434

3535
permissions:
3636
contents: read

‎.pre-commit-config.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ repos:
99
- id: end-of-file-fixer
1010
- id: check-json
1111
- repo: https://github.com/golangci/golangci-lint/
12-
rev: v2.3.0 # NOTICE: Make sure this is synced with the version in the _tools/go.mod file.
12+
rev: v2.9.0 # NOTICE: Make sure this is synced with the version in the _tools/go.mod file.
1313
hooks:
1414
- id: golangci-lint
1515
args:

‎_tools/go.mod‎

Lines changed: 78 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ go 1.25.0
44

55
require (
66
github.com/campoy/embedmd v1.0.0
7-
github.com/golangci/golangci-lint/v2 v2.3.0
7+
github.com/golangci/golangci-lint/v2 v2.9.0
88
github.com/rhysd/actionlint v1.7.9
99
golang.org/x/perf v0.0.0-20250710210952-7b7c2de18447
10-
golang.org/x/tools v0.35.0
10+
golang.org/x/tools v0.42.0
1111
golang.org/x/vuln v1.1.4
1212
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.5.1
13-
google.golang.org/protobuf v1.36.6
13+
google.golang.org/protobuf v1.36.8
1414
gotest.tools/gotestsum v1.12.3
1515
mvdan.cc/sh/v3 v3.12.0
1616
)
@@ -19,50 +19,55 @@ require (
1919
4d63.com/gocheckcompilerdirectives v1.3.0 // indirect
2020
4d63.com/gochecknoglobals v0.2.2 // indirect
2121
codeberg.org/chavacava/garif v0.2.0 // indirect
22-
github.com/4meepo/tagalign v1.4.2 // indirect
23-
github.com/Abirdcfly/dupword v0.1.6 // indirect
22+
codeberg.org/polyfloyd/go-errorlint v1.9.0 // indirect
23+
dev.gaijin.team/go/exhaustruct/v4 v4.0.0 // indirect
24+
dev.gaijin.team/go/golib v0.6.0 // indirect
25+
github.com/4meepo/tagalign v1.4.3 // indirect
26+
github.com/Abirdcfly/dupword v0.1.7 // indirect
27+
github.com/AdminBenni/iota-mixing v1.0.0 // indirect
2428
github.com/AlwxSin/noinlineerr v1.0.5 // indirect
25-
github.com/Antonboom/errname v1.1.0 // indirect
26-
github.com/Antonboom/nilnil v1.1.0 // indirect
27-
github.com/Antonboom/testifylint v1.6.1 // indirect
28-
github.com/BurntSushi/toml v1.5.0 // indirect
29-
github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24 // indirect
30-
github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.1 // indirect
31-
github.com/Masterminds/semver/v3 v3.3.1 // indirect
29+
github.com/Antonboom/errname v1.1.1 // indirect
30+
github.com/Antonboom/nilnil v1.1.1 // indirect
31+
github.com/Antonboom/testifylint v1.6.4 // indirect
32+
github.com/BurntSushi/toml v1.6.0 // indirect
33+
github.com/Djarvur/go-err113 v0.1.1 // indirect
34+
github.com/Masterminds/semver/v3 v3.4.0 // indirect
35+
github.com/MirrexOne/unqueryvet v1.5.3 // indirect
3236
github.com/OpenPeeDeeP/depguard/v2 v2.2.1 // indirect
3337
github.com/aclements/go-moremath v0.0.0-20210112150236-f10218a38794 // indirect
34-
github.com/alecthomas/chroma/v2 v2.19.0 // indirect
38+
github.com/alecthomas/chroma/v2 v2.23.1 // indirect
3539
github.com/alecthomas/go-check-sumtype v0.3.1 // indirect
3640
github.com/alexkohler/nakedret/v2 v2.0.6 // indirect
37-
github.com/alexkohler/prealloc v1.0.0 // indirect
41+
github.com/alexkohler/prealloc v1.0.2 // indirect
42+
github.com/alfatraining/structtag v1.0.0 // indirect
3843
github.com/alingse/asasalint v0.0.11 // indirect
3944
github.com/alingse/nilnesserr v0.2.0 // indirect
40-
github.com/ashanbrown/forbidigo/v2 v2.1.0 // indirect
41-
github.com/ashanbrown/makezero/v2 v2.0.1 // indirect
45+
github.com/ashanbrown/forbidigo/v2 v2.3.0 // indirect
46+
github.com/ashanbrown/makezero/v2 v2.1.0 // indirect
4247
github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
4348
github.com/beorn7/perks v1.0.1 // indirect
4449
github.com/bitfield/gotestdox v0.2.2 // indirect
4550
github.com/bkielbasa/cyclop v1.2.3 // indirect
4651
github.com/blizzy78/varnamelen v0.8.0 // indirect
4752
github.com/bmatcuk/doublestar/v4 v4.9.1 // indirect
4853
github.com/bombsimon/wsl/v4 v4.7.0 // indirect
49-
github.com/bombsimon/wsl/v5 v5.1.0 // indirect
54+
github.com/bombsimon/wsl/v5 v5.6.0 // indirect
5055
github.com/breml/bidichk v0.3.3 // indirect
5156
github.com/breml/errchkjson v0.4.1 // indirect
5257
github.com/butuzov/ireturn v0.4.0 // indirect
5358
github.com/butuzov/mirror v1.3.0 // indirect
54-
github.com/catenacyber/perfsprint v0.9.1 // indirect
59+
github.com/catenacyber/perfsprint v0.10.1 // indirect
5560
github.com/ccojocar/zxcvbn-go v1.0.4 // indirect
5661
github.com/cespare/xxhash/v2 v2.3.0 // indirect
57-
github.com/charithe/durationcheck v0.0.10 // indirect
62+
github.com/charithe/durationcheck v0.0.11 // indirect
5863
github.com/charmbracelet/colorprofile v0.2.3-0.20250311203215-f60798e515dc // indirect
5964
github.com/charmbracelet/lipgloss v1.1.0 // indirect
60-
github.com/charmbracelet/x/ansi v0.8.0 // indirect
65+
github.com/charmbracelet/x/ansi v0.10.1 // indirect
6166
github.com/charmbracelet/x/cellbuf v0.0.13-0.20250311204145-2c3ea96c31dd // indirect
6267
github.com/charmbracelet/x/term v0.2.1 // indirect
6368
github.com/ckaznocha/intrange v0.3.1 // indirect
6469
github.com/curioswitch/go-reassign v0.3.0 // indirect
65-
github.com/daixiang0/gci v0.13.6 // indirect
70+
github.com/daixiang0/gci v0.13.7 // indirect
6671
github.com/dave/dst v0.27.3 // indirect
6772
github.com/davecgh/go-spew v1.1.1 // indirect
6873
github.com/denis-tingaikin/go-header v0.5.0 // indirect
@@ -74,39 +79,41 @@ require (
7479
github.com/firefart/nonamedreturns v1.0.6 // indirect
7580
github.com/fsnotify/fsnotify v1.8.0 // indirect
7681
github.com/fzipp/gocyclo v0.6.0 // indirect
77-
github.com/ghostiam/protogetter v0.3.15 // indirect
78-
github.com/go-critic/go-critic v0.13.0 // indirect
82+
github.com/ghostiam/protogetter v0.3.20 // indirect
83+
github.com/go-critic/go-critic v0.14.3 // indirect
7984
github.com/go-toolsmith/astcast v1.1.0 // indirect
8085
github.com/go-toolsmith/astcopy v1.1.0 // indirect
8186
github.com/go-toolsmith/astequal v1.2.0 // indirect
8287
github.com/go-toolsmith/astfmt v1.1.0 // indirect
8388
github.com/go-toolsmith/astp v1.1.0 // indirect
8489
github.com/go-toolsmith/strparse v1.1.0 // indirect
8590
github.com/go-toolsmith/typep v1.1.0 // indirect
86-
github.com/go-viper/mapstructure/v2 v2.4.0 // indirect
91+
github.com/go-viper/mapstructure/v2 v2.5.0 // indirect
8792
github.com/go-xmlfmt/xmlfmt v1.1.3 // indirect
8893
github.com/gobwas/glob v0.2.3 // indirect
89-
github.com/gofrs/flock v0.12.1 // indirect
94+
github.com/godoc-lint/godoc-lint v0.11.1 // indirect
95+
github.com/gofrs/flock v0.13.0 // indirect
9096
github.com/golang/protobuf v1.5.3 // indirect
97+
github.com/golangci/asciicheck v0.5.0 // indirect
9198
github.com/golangci/dupl v0.0.0-20250308024227-f665c8d69b32 // indirect
92-
github.com/golangci/go-printf-func-name v0.1.0 // indirect
99+
github.com/golangci/go-printf-func-name v0.1.1 // indirect
93100
github.com/golangci/gofmt v0.0.0-20250106114630-d62b90e6713d // indirect
94-
github.com/golangci/golines v0.0.0-20250217134842-442fd0091d95 // indirect
95-
github.com/golangci/misspell v0.7.0 // indirect
101+
github.com/golangci/golines v0.15.0 // indirect
102+
github.com/golangci/misspell v0.8.0 // indirect
96103
github.com/golangci/plugin-module-register v0.1.2 // indirect
97104
github.com/golangci/revgrep v0.8.0 // indirect
98105
github.com/golangci/swaggoswag v0.0.0-20250504205917-77f2aca3143e // indirect
99106
github.com/golangci/unconvert v0.0.0-20250410112200-a129a6e6413e // indirect
100107
github.com/google/go-cmp v0.7.0 // indirect
101108
github.com/google/renameio/v2 v2.0.0 // indirect
102109
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
103-
github.com/gordonklaus/ineffassign v0.1.0 // indirect
110+
github.com/gordonklaus/ineffassign v0.2.0 // indirect
104111
github.com/gostaticanalysis/analysisutil v0.7.1 // indirect
105112
github.com/gostaticanalysis/comment v1.5.0 // indirect
106113
github.com/gostaticanalysis/forcetypeassert v0.2.0 // indirect
107-
github.com/gostaticanalysis/nilerr v0.1.1 // indirect
114+
github.com/gostaticanalysis/nilerr v0.1.2 // indirect
108115
github.com/hashicorp/go-immutable-radix/v2 v2.1.0 // indirect
109-
github.com/hashicorp/go-version v1.7.0 // indirect
116+
github.com/hashicorp/go-version v1.8.0 // indirect
110117
github.com/hashicorp/golang-lru/v2 v2.0.7 // indirect
111118
github.com/hashicorp/hcl v1.0.0 // indirect
112119
github.com/hexops/gotextdiff v1.0.3 // indirect
@@ -115,50 +122,50 @@ require (
115122
github.com/jingyugao/rowserrcheck v1.1.1 // indirect
116123
github.com/jjti/go-spancheck v0.6.5 // indirect
117124
github.com/julz/importas v0.2.0 // indirect
118-
github.com/karamaru-alpha/copyloopvar v1.2.1 // indirect
125+
github.com/karamaru-alpha/copyloopvar v1.2.2 // indirect
119126
github.com/kisielk/errcheck v1.9.0 // indirect
120127
github.com/kkHAIKE/contextcheck v1.1.6 // indirect
121-
github.com/kulti/thelper v0.6.3 // indirect
122-
github.com/kunwardeep/paralleltest v1.0.14 // indirect
128+
github.com/kulti/thelper v0.7.1 // indirect
129+
github.com/kunwardeep/paralleltest v1.0.15 // indirect
123130
github.com/lasiar/canonicalheader v1.1.2 // indirect
124-
github.com/ldez/exptostd v0.4.4 // indirect
125-
github.com/ldez/gomoddirectives v0.7.0 // indirect
126-
github.com/ldez/grignotin v0.9.0 // indirect
127-
github.com/ldez/tagliatelle v0.7.1 // indirect
131+
github.com/ldez/exptostd v0.4.5 // indirect
132+
github.com/ldez/gomoddirectives v0.8.0 // indirect
133+
github.com/ldez/grignotin v0.10.1 // indirect
134+
github.com/ldez/structtags v0.6.1 // indirect
135+
github.com/ldez/tagliatelle v0.7.2 // indirect
128136
github.com/ldez/usetesting v0.5.0 // indirect
129137
github.com/leonklingele/grouper v1.1.2 // indirect
130138
github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
131139
github.com/macabu/inamedparam v0.2.0 // indirect
132140
github.com/magiconair/properties v1.8.6 // indirect
133-
github.com/manuelarte/embeddedstructfieldcheck v0.3.0 // indirect
141+
github.com/manuelarte/embeddedstructfieldcheck v0.4.0 // indirect
134142
github.com/manuelarte/funcorder v0.5.0 // indirect
135-
github.com/maratori/testableexamples v1.0.0 // indirect
136-
github.com/maratori/testpackage v1.1.1 // indirect
143+
github.com/maratori/testableexamples v1.0.1 // indirect
144+
github.com/maratori/testpackage v1.1.2 // indirect
137145
github.com/matoous/godox v1.1.0 // indirect
138146
github.com/mattn/go-colorable v0.1.14 // indirect
139147
github.com/mattn/go-isatty v0.0.20 // indirect
140148
github.com/mattn/go-runewidth v0.0.17 // indirect
141149
github.com/mattn/go-shellwords v1.0.12 // indirect
142150
github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
143-
github.com/mgechev/revive v1.11.0 // indirect
151+
github.com/mgechev/revive v1.14.0 // indirect
144152
github.com/mitchellh/go-homedir v1.1.0 // indirect
145153
github.com/mitchellh/mapstructure v1.5.0 // indirect
146154
github.com/moricho/tparallel v0.3.2 // indirect
147155
github.com/muesli/termenv v0.16.0 // indirect
148156
github.com/nakabonne/nestif v0.3.1 // indirect
149157
github.com/nishanths/exhaustive v0.12.0 // indirect
150158
github.com/nishanths/predeclared v0.2.2 // indirect
151-
github.com/nunnatsa/ginkgolinter v0.20.0 // indirect
159+
github.com/nunnatsa/ginkgolinter v0.22.0 // indirect
152160
github.com/pelletier/go-toml v1.9.5 // indirect
153161
github.com/pelletier/go-toml/v2 v2.2.4 // indirect
154162
github.com/pmezard/go-difflib v1.0.0 // indirect
155-
github.com/polyfloyd/go-errorlint v1.8.0 // indirect
156163
github.com/prometheus/client_golang v1.12.1 // indirect
157164
github.com/prometheus/client_model v0.2.0 // indirect
158165
github.com/prometheus/common v0.32.1 // indirect
159166
github.com/prometheus/procfs v0.7.3 // indirect
160-
github.com/quasilyte/go-ruleguard v0.4.4 // indirect
161-
github.com/quasilyte/go-ruleguard/dsl v0.3.22 // indirect
167+
github.com/quasilyte/go-ruleguard v0.4.5 // indirect
168+
github.com/quasilyte/go-ruleguard/dsl v0.3.23 // indirect
162169
github.com/quasilyte/gogrep v0.5.0 // indirect
163170
github.com/quasilyte/regex/syntax v0.0.0-20210819130434-b3f0c404a727 // indirect
164171
github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect
@@ -172,27 +179,26 @@ require (
172179
github.com/santhosh-tekuri/jsonschema/v6 v6.0.2 // indirect
173180
github.com/sashamelentyev/interfacebloat v1.1.0 // indirect
174181
github.com/sashamelentyev/usestdlibvars v1.29.0 // indirect
175-
github.com/securego/gosec/v2 v2.22.6 // indirect
176-
github.com/sirupsen/logrus v1.9.3 // indirect
182+
github.com/securego/gosec/v2 v2.22.11 // indirect
183+
github.com/sirupsen/logrus v1.9.4 // indirect
177184
github.com/sivchari/containedctx v1.0.3 // indirect
178-
github.com/sonatard/noctx v0.3.5 // indirect
185+
github.com/sonatard/noctx v0.4.0 // indirect
179186
github.com/sourcegraph/go-diff v0.7.0 // indirect
180-
github.com/spf13/afero v1.14.0 // indirect
187+
github.com/spf13/afero v1.15.0 // indirect
181188
github.com/spf13/cast v1.5.0 // indirect
182-
github.com/spf13/cobra v1.9.1 // indirect
189+
github.com/spf13/cobra v1.10.2 // indirect
183190
github.com/spf13/jwalterweatherman v1.1.0 // indirect
184-
github.com/spf13/pflag v1.0.7 // indirect
191+
github.com/spf13/pflag v1.0.10 // indirect
185192
github.com/spf13/viper v1.12.0 // indirect
186193
github.com/ssgreg/nlreturn/v2 v2.2.1 // indirect
187-
github.com/stbenjam/no-sprintf-host-port v0.2.0 // indirect
194+
github.com/stbenjam/no-sprintf-host-port v0.3.1 // indirect
188195
github.com/stretchr/objx v0.5.2 // indirect
189-
github.com/stretchr/testify v1.10.0 // indirect
196+
github.com/stretchr/testify v1.11.1 // indirect
190197
github.com/subosito/gotenv v1.4.1 // indirect
191-
github.com/tdakkota/asciicheck v0.4.1 // indirect
192-
github.com/tetafro/godot v1.5.1 // indirect
198+
github.com/tetafro/godot v1.5.4 // indirect
193199
github.com/timakin/bodyclose v0.0.0-20241222091800-1db5c5ca4d67 // indirect
194200
github.com/timonwong/loggercheck v0.11.0 // indirect
195-
github.com/tomarrell/wrapcheck/v2 v2.11.0 // indirect
201+
github.com/tomarrell/wrapcheck/v2 v2.12.0 // indirect
196202
github.com/tommy-muehle/go-mnd/v2 v2.5.1 // indirect
197203
github.com/ultraware/funlen v0.2.0 // indirect
198204
github.com/ultraware/whitespace v0.2.0 // indirect
@@ -204,27 +210,26 @@ require (
204210
github.com/yeya24/promlinter v0.3.0 // indirect
205211
github.com/ykadowak/zerologlint v0.1.5 // indirect
206212
gitlab.com/bosi/decorder v0.4.2 // indirect
207-
go-simpler.org/musttag v0.13.1 // indirect
213+
go-simpler.org/musttag v0.14.0 // indirect
208214
go-simpler.org/sloglint v0.11.1 // indirect
209-
go.augendre.info/arangolint v0.2.0 // indirect
210-
go.augendre.info/fatcontext v0.8.0 // indirect
211-
go.uber.org/atomic v1.7.0 // indirect
212-
go.uber.org/automaxprocs v1.6.0 // indirect
213-
go.uber.org/multierr v1.6.0 // indirect
214-
go.uber.org/zap v1.24.0 // indirect
215+
go.augendre.info/arangolint v0.4.0 // indirect
216+
go.augendre.info/fatcontext v0.9.0 // indirect
217+
go.uber.org/multierr v1.10.0 // indirect
218+
go.uber.org/zap v1.27.0 // indirect
219+
go.yaml.in/yaml/v3 v3.0.4 // indirect
215220
go.yaml.in/yaml/v4 v4.0.0-rc.3 // indirect
216-
golang.org/x/exp/typeparams v0.0.0-20250620022241-b7579e27df2b // indirect
217-
golang.org/x/mod v0.26.0 // indirect
218-
golang.org/x/sync v0.18.0 // indirect
219-
golang.org/x/sys v0.38.0 // indirect
220-
golang.org/x/telemetry v0.0.0-20250710130107-8d8967aff50b // indirect
221-
golang.org/x/term v0.33.0 // indirect
222-
golang.org/x/text v0.27.0 // indirect
221+
golang.org/x/exp/typeparams v0.0.0-20251125195548-87e1e737ad39 // indirect
222+
golang.org/x/mod v0.33.0 // indirect
223+
golang.org/x/sync v0.19.0 // indirect
224+
golang.org/x/sys v0.41.0 // indirect
225+
golang.org/x/telemetry v0.0.0-20260209163413-e7419c687ee4 // indirect
226+
golang.org/x/term v0.39.0 // indirect
227+
golang.org/x/text v0.33.0 // indirect
223228
gopkg.in/ini.v1 v1.67.0 // indirect
224229
gopkg.in/yaml.v2 v2.4.0 // indirect
225230
gopkg.in/yaml.v3 v3.0.1 // indirect
226231
honnef.co/go/tools v0.6.1 // indirect
227232
mvdan.cc/editorconfig v0.3.0 // indirect
228-
mvdan.cc/gofumpt v0.8.0 // indirect
229-
mvdan.cc/unparam v0.0.0-20250301125049-0df0534333a4 // indirect
233+
mvdan.cc/gofumpt v0.9.2 // indirect
234+
mvdan.cc/unparam v0.0.0-20251027182757-5beb8c8f8f15 // indirect
230235
)

0 commit comments

Comments
 (0)