Skip to content

feat(internal/config): Introduce internal config package #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

feat(internal/config): Introduce internal config package #4064

wants to merge 22 commits into from

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Oct 22, 2025

…ct, ConfigSource object, and tests

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-11-06 21:53:22

Comparing candidate commit 0be643e in PR branch mtoff/config-revamp with baseline commit 9db3a3d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@datadog-official

This comment has been minimized.

Sign in to view
mtoffl01 added 18 commits October 27, 2025 11:42
@mtoffl01
fix test env vars; only use real settings
8bdab95
@mtoffl01
restore unrelated files to their status on main
0513a96
@mtoffl01
restore unrelated files to their status on main
ee521b4
@mtoffl01
Fix file format in supported_configurations.json
c3c69fe
@mtoffl01
cleanup/nits
eeebfd1
@mtoffl01
Fix references to fake configs: DD_TRACE_HOSTNAME DD_TRACE_HTTP_CLIEN…
0e2527e 
…T_TIMEOUT DD_TRACE_LOG_TO_STDOUT DD_TRACE_PROFILER_ENDPOINTS DD_TRACE_PROFILER_HOTSPOTS DD_TRACE_RUNTIME_METRICS DD_TRACE_RUNTIME_METRICS_V2 DD_TRACE_SEND_RETRIES DD_TRACE_SPAN_TIMEOUT
@mtoffl01
remove reference to DD_RUNTIME_METRICS
85ae251
@mtoffl01
Introduce otelenvconfigsource, and add tests for it in configprovider…
2e5e8e6 
…_test.go
@mtoffl01
Remove DD_TRACE_AGENT_TIMEOUT; use DD_TRACE_STARTUP_LOGS in tests ins…
378f08d 
…tead
@mtoffl01
Make loadConfig threadsafe
7d873f4
@mtoffl01
Add godocs to loadConfig() and GlobalConfig() to document thread safe…
f148316 
…ty behavior of the methods
@mtoffl01
Merge branch 'main' into mtoff/config-revamp
6c45c9a
@mtoffl01
merge main and remove refs to DD_TRACE_AGENT_PROTOCOL
4057354
@mtoffl01
Fix c.debug assignment in tracer config
bfdaae7
@mtoffl01
Always reload config in testing environment
2595c88
@mtoffl01
Fix otel test that expects panic
2fe6e13
@mtoffl01
Report telemetry in configprovider
d4960bb
@mtoffl01
Report telemetry adn add tests
0be643e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtoffl01