feat(openfeature): After Hook Exposure event writer #4094

eliottness · 2025-11-03T14:28:46Z

What does this PR do?

This PR implements feature flag exposure tracking for the Datadog OpenFeature provider. It adds the ability to automatically capture and report
feature flag evaluations to Datadog's Event Platform Intake, providing visibility into which feature flags are being evaluated and by which users.

Key changes:

Adds exposureWriter for buffering and flushing exposure events to the Datadog agent via EVP proxy
Implements exposureHook that integrates with the OpenFeature SDK to capture evaluation details
Introduces ProviderConfig field to allow configuration of exposure flush intervals
Adds attribute flattening utilities to ensure subject attributes comply with EVP intake schema
Updates documentation with configuration options and environment variables

Out of scope refactoring

Moved the tracer private method udsClient, defaultHTTPClient and defaultDialer to the internal package to simply code between telemetry/tracer/openfeature writers

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
Add an appropriate team label so this PR gets put in the right place for the release notes.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

pr-commenter · 2025-11-03T14:45:44Z

Benchmarks

Benchmark execution time: 2025-11-07 14:45:12

Comparing candidate commit 11e5b93 in PR branch eliottness/ffe-exposures with baseline commit 1557bbd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 0 unstable metrics.

eliottness · 2025-11-03T15:18:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

openfeature/exposure.go

datadog-datadog-prod-us1 · 2025-11-03T15:27:08Z

⚠️ Tests

⚠️ Warnings

❄️ 7 New flaky tests detected

    TestReportAbandonedSpans from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer

    TestReportAbandonedSpans/wait from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer

    TestStructLiteral from github.com/DataDog/dd-trace-go/v2/internal/orchestrion/_integration/aws.v2
View all

🧪 12 Tests failed

    Test from github.com/DataDog/dd-trace-go/v2/internal/orchestrion/_integration/aws.v1

    Test from github.com/DataDog/dd-trace-go/v2/internal/orchestrion/_integration/confluent-kafka-go.v1

    Test from github.com/DataDog/dd-trace-go/v2/internal/orchestrion/_integration/confluent-kafka-go.v2
View all

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 11e5b93 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

openfeature/exposure.go

eliottness · 2025-11-03T18:56:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

openfeature/exposure.go

eliottness · 2025-11-04T13:23:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

openfeature/exposure.go

# Conflicts: # openfeature/provider.go

Signed-off-by: Eliott Bouhana <[email protected]>

genesor

LGTM, smalls comments/questions

genesor · 2025-11-07T14:26:24Z

internal/telemetry/internal/writer.go


 	if config.HTTPClient == nil {
-		config.HTTPClient = defaultHTTPClient
+		config.HTTPClient = internal.DefaultHTTPClient(5*time.Second, true)


Is the change from 30s to 5s expected ?

openfeature/exposure.go

eliottness changed the title ~~feat(openfeature): After Hook Exposure events~~ feat(openfeature): After Hook Exposure event writer Nov 3, 2025

github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Nov 3, 2025

eliottness force-pushed the eliottness/ffe-exposures branch from 2b6db30 to 2804703 Compare November 3, 2025 15:13

eliottness added enhancement quick change/addition that does not need full team approval AI Assisted AI/LLM assistance used in this PR (partially or fully) and removed apm:ecosystem contrib/* related feature requests or bugs labels Nov 3, 2025

github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Nov 3, 2025

eliottness marked this pull request as ready for review November 3, 2025 15:17

eliottness requested a review from a team as a code owner November 3, 2025 15:17

chatgpt-codex-connector bot reviewed Nov 3, 2025

View reviewed changes

openfeature/exposure.go Show resolved Hide resolved

eliottness commented Nov 3, 2025

View reviewed changes

openfeature/exposure.go Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Nov 3, 2025

View reviewed changes

openfeature/exposure.go Outdated Show resolved Hide resolved

eliottness force-pushed the eliottness/ffe-exposures branch from 2358c60 to 78bf8d9 Compare November 4, 2025 11:39

eliottness requested review from a team as code owners November 4, 2025 11:39

chatgpt-codex-connector bot reviewed Nov 4, 2025

View reviewed changes

openfeature/exposure.go Show resolved Hide resolved

darccio requested changes Nov 7, 2025

View reviewed changes

openfeature/exposure.go Show resolved Hide resolved

eliottness added 8 commits November 7, 2025 15:26

--wip-- [skip ci]

bdc03f4

# Conflicts: # openfeature/provider.go

--wip-- [skip ci]

d179324

--wip-- [skip ci]

cf0f0da

stabled remoteconfig/state

5537af8

Signed-off-by: Eliott Bouhana <[email protected]>

stabled remoteconfig/state

79a81b3

Signed-off-by: Eliott Bouhana <[email protected]>

finished exposure writer work

429e2f8

Signed-off-by: Eliott Bouhana <[email protected]>

run golangci-lint

e4f3567

Signed-off-by: Eliott Bouhana <[email protected]>

small fixes

7861291

Signed-off-by: Eliott Bouhana <[email protected]>

eliottness added 4 commits November 7, 2025 15:26

small fixes

1857c7c

Signed-off-by: Eliott Bouhana <[email protected]>

rework exposures, add tests and better flattening

d60b485

Signed-off-by: Eliott Bouhana <[email protected]>

fix tracer tests

17659db

Signed-off-by: Eliott Bouhana <[email protected]>

fix initial length

11e5b93

Signed-off-by: Eliott Bouhana <[email protected]>

eliottness force-pushed the eliottness/ffe-exposures branch from 7dff30e to 11e5b93 Compare November 7, 2025 14:26

eliottness requested a review from darccio November 7, 2025 14:26

darccio approved these changes Nov 7, 2025

View reviewed changes

ownership-prod bot requested review from a team November 7, 2025 14:47

genesor approved these changes Nov 7, 2025

View reviewed changes

feat(openfeature): After Hook Exposure event writer #4094

Are you sure you want to change the base?

feat(openfeature): After Hook Exposure event writer #4094

Conversation

eliottness commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Out of scope refactoring

Reviewer's Checklist

Uh oh!

pr-commenter bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

eliottness commented Nov 3, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented Nov 3, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

Uh oh!

Uh oh!

eliottness commented Nov 3, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

eliottness commented Nov 4, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

genesor left a comment

Choose a reason for hiding this comment

Uh oh!

genesor Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eliottness commented Nov 3, 2025 •

edited

Loading

pr-commenter bot commented Nov 3, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Nov 3, 2025 •

edited by datadog-official bot

Loading