fix(contrib/confluentinc/confluent-kafka-go/kafka.v2): ensure kafka.produce span is always finished #4107
+38
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a
nildeliveryChan is passed to theproducer.Produce(msg, nil)call, the producer wraps theproducer.Events()channel and passes this wrapper channel to the inner.Producecall.Motivation
When a
nildeliveryChan was passed to theproducer.Producecall, i.e. when the client was using theproducer.Events()channel to get delivery reports, thekafka.producespan was never finished.Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!