-
Notifications
You must be signed in to change notification settings - Fork 488
fix: codeowner script doesn't change directories as needed #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksBenchmark execution time: 2025-11-06 20:23:42 Comparing candidate commit aed17c6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: aed17c6 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me!
We were missing data on codeowners from tests. This should bring it back and start populating the backend again. example
That link 404s for me for some reason. At any rate, I went to the CI visibility app myself (link) and confirmed that I see values for the most recent runs as well:
Tangential to this PR, but I assume the Go generate failed originally because https://pkg.go.dev/github.com/containerd/containerd/api just released a new version yesterday, and this PR happened to be the first thing to run generation since that happened?
|
@nsrip-dd Interesting, were you on HQ the first time? But glad you were able to find it eventually. And yeah, the generation makes me wonder if we should have a nightly job to check for needed updates, maybe with the assistance of Copilot or something..? Not sure what it would look like. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Fix codeowner reporting for tests by properly checking and changing directories before looking for xml files and running the codeowners script.
Motivation
We were missing data on codeowners from tests. This should bring it back and start populating the backend again. example
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!