Skip to content

Conversation

@hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Nov 6, 2025

What does this PR do?

Fix codeowner reporting for tests by properly checking and changing directories before looking for xml files and running the codeowners script.

Motivation

We were missing data on codeowners from tests. This should bring it back and start populating the backend again. example

image

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2025

Benchmarks

Benchmark execution time: 2025-11-06 20:23:42

Comparing candidate commit aed17c6 in PR branch hannahkm/codeowner-updates with baseline commit 53b84e7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 6, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: aed17c6 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@hannahkm hannahkm marked this pull request as ready for review November 6, 2025 20:27
@hannahkm hannahkm requested a review from a team as a code owner November 6, 2025 20:27
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me!

We were missing data on codeowners from tests. This should bring it back and start populating the backend again. example

That link 404s for me for some reason. At any rate, I went to the CI visibility app myself (link) and confirmed that I see values for the most recent runs as well:

Screenshot 2025-11-06 at 15 58 26

Tangential to this PR, but I assume the Go generate failed originally because https://pkg.go.dev/github.com/containerd/containerd/api just released a new version yesterday, and this PR happened to be the first thing to run generation since that happened?

@hannahkm
Copy link
Contributor Author

hannahkm commented Nov 6, 2025

@nsrip-dd Interesting, were you on HQ the first time? But glad you were able to find it eventually. And yeah, the generation makes me wonder if we should have a nightly job to check for needed updates, maybe with the assistance of Copilot or something..? Not sure what it would look like.

@hannahkm
Copy link
Contributor Author

hannahkm commented Nov 6, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 6, 2025

View all feedbacks in Devflow UI.

2025-11-06 21:54:53 UTC ℹ️ Start processing command /merge


2025-11-06 21:54:57 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 19m (p90).


2025-11-06 22:10:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 0cbdb0c into main Nov 6, 2025
265 checks passed
@dd-mergequeue dd-mergequeue bot deleted the hannahkm/codeowner-updates branch November 6, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants