Skip to content

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 12, 2025

What does this PR do?

Migrate tracer to use Config.spanTimeout. Also, change spanTimeout true default from 0 to 10 minutes. This was always the effective default, although only set if debugAbandonedSpans was enabled. With this change, the default is consistent, but the feature remains unused if debugAbandonedSpans is not enabled.

Motivation

https://datadoghq.atlassian.net/browse/APMAPI-1748

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Copy link
Contributor Author

mtoffl01 commented Dec 12, 2025

@mtoffl01 mtoffl01 marked this pull request as ready for review December 12, 2025 19:54
@mtoffl01 mtoffl01 requested review from a team as code owners December 12, 2025 19:54
@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2025

Benchmarks

Benchmark execution time: 2025-12-19 17:26:25

Comparing candidate commit f74672a in PR branch 12-12-migrate_spantimeout with baseline commit c8b32da in branch 12-12-migrate_debugabandonedspans.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 0 unstable metrics.

@datadog-official
Copy link
Contributor

datadog-official bot commented Dec 12, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f74672a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.53%. Comparing base (c8b32da) to head (f74672a).

Files with missing lines Patch % Lines
internal/config/config.go 9.09% 10 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
ddtrace/tracer/option.go 84.15% <100.00%> (-0.06%) ⬇️
ddtrace/tracer/tracer.go 86.40% <100.00%> (ø)
internal/config/config.go 24.63% <9.09%> (-1.02%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtoffl01 mtoffl01 force-pushed the 12-12-migrate_spantimeout branch from 94067c6 to af44c81 Compare December 17, 2025 17:28
@mtoffl01 mtoffl01 force-pushed the 12-12-migrate_debugabandonedspans branch from c24f1b3 to 3d498ae Compare December 17, 2025 17:29
@mtoffl01 mtoffl01 mentioned this pull request Dec 17, 2025
7 tasks
@mtoffl01 mtoffl01 changed the base branch from 12-12-migrate_debugabandonedspans to graphite-base/4263 December 18, 2025 16:52
@mtoffl01 mtoffl01 force-pushed the 12-12-migrate_spantimeout branch from af44c81 to e8ff61c Compare December 18, 2025 16:53
@mtoffl01 mtoffl01 changed the base branch from graphite-base/4263 to 12-12-migrate_debugabandonedspans December 18, 2025 16:53
@mtoffl01 mtoffl01 force-pushed the 12-12-migrate_debugabandonedspans branch from f39cc0c to e9e8dd2 Compare December 19, 2025 15:16
@mtoffl01 mtoffl01 force-pushed the 12-12-migrate_spantimeout branch from e8ff61c to bd2f3c0 Compare December 19, 2025 15:16
@mtoffl01 mtoffl01 changed the base branch from 12-12-migrate_debugabandonedspans to graphite-base/4263 December 19, 2025 16:48
@mtoffl01 mtoffl01 force-pushed the 12-12-migrate_spantimeout branch from bd2f3c0 to f74672a Compare December 19, 2025 16:49
@mtoffl01 mtoffl01 changed the base branch from graphite-base/4263 to 12-12-migrate_debugabandonedspans December 19, 2025 16:49
@mtoffl01 mtoffl01 closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants