Skip to content

feat: new gotip workflow #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darccio merged 10 commits into from
Jan 7, 2026
Merged

feat: new gotip workflow #4314

darccio merged 10 commits into from
Jan 7, 2026

Conversation

@hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Dec 26, 2025 •
edited
Loading

What does this PR do?

Creates a new nightly workflow to test with gotip and datadog-agent@latest

Includes making changes to our core testing script to support using both go test and gotip test with gotestsum.

Motivation

The Go language and the Datadog Agent are our most important dependencies. Unexpected changes can cause major issues in the Go tracer. Similar to how we smoke test our contribs, we should look ahead to the latest versions of Go and the Agent to ensure we can upgrade without issue.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Dec 26, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2026-01-05 15:01:22

Comparing candidate commit 9b622bc in PR branch hannahkm/tip-dependencies with baseline commit d598bab in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 0 unstable metrics.

@codecov
Copy link

codecov bot commented Dec 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.82%. Comparing base (d598bab) to head (9b622bc).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hannahkm
Copy link
Contributor Author

hannahkm commented Jan 5, 2026

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Jan 5, 2026

To use Codex here, create a Codex account and connect to github.

@hannahkm hannahkm marked this pull request as ready for review January 6, 2026 15:44
@hannahkm hannahkm requested a review from a team as a code owner January 6, 2026 15:44
@hannahkm hannahkm marked this pull request as draft January 6, 2026 15:50
@hannahkm hannahkm marked this pull request as ready for review January 6, 2026 16:38
@darccio
Copy link
Member

darccio commented Jan 7, 2026

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Jan 7, 2026

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@darccio
Copy link
Member

darccio commented Jan 7, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 7, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-07 09:36:01 UTC ℹ️ Start processing command /merge

2026-01-07 09:36:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 31m (p90).

2026-01-07 10:03:56 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit b714cb4:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@darccio
Copy link
Member

darccio commented Jan 7, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 7, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-07 10:36:55 UTC ℹ️ Start processing command /merge

2026-01-07 10:37:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 31m (p90).

2026-01-07 10:50:26 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.

2026-01-07 12:09:09 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit b78b20c:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@darccio
Copy link
Member

darccio commented Jan 7, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 7, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-07 12:16:01 UTC ℹ️ Start processing command /merge

2026-01-07 12:16:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 31m (p90).

2026-01-07 12:50:08 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.

2026-01-07 13:16:33 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit e45aaa5:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@darccio darccio merged commit de19749 into main Jan 7, 2026
281 of 282 checks passed
@darccio darccio deleted the hannahkm/tip-dependencies branch January 7, 2026 13:30
@darccio darccio mentioned this pull request Jan 7, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

mergequeue-status: rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hannahkm @darccio @kakkoyun