Skip to content

feat(version): drop v1 version detection#4409

Merged
darccio merged 2 commits intomainfrom
dario.castane/ktlo/drop-v1-debuginfo-report
Feb 12, 2026
Merged

feat(version): drop v1 version detection#4409
darccio merged 2 commits intomainfrom
dario.castane/ktlo/drop-v1-debuginfo-report

Conversation

@darccio
Copy link
Member

@darccio darccio commented Feb 12, 2026

What does this PR do?

Drops v1 version detection based on DebugInfo.

Motivation

V1 shim version isn't updated anymore as the end-of-life deadline passed, thus reporting the v1 version doesn't help to track dogfooding and adoption of v2.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

V1 shim version isn't updated anymore as the end-of-life deadline passed,
thus reporting the v1 version doesn't help to track dogfooding and
adoption of v2.
@darccio darccio requested review from a team as code owners February 12, 2026 11:11
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.48%. Comparing base (3379e30) to head (053a357).

Additional details and impacted files
Files with missing lines Coverage Δ
internal/version/version.go 70.83% <ø> (ø)

... and 369 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2026

Benchmarks

Benchmark execution time: 2026-02-12 19:26:05

Comparing candidate commit 053a357 in PR branch dario.castane/ktlo/drop-v1-debuginfo-report with baseline commit 3379e30 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 156 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@darccio darccio merged commit e1c020b into main Feb 12, 2026
182 checks passed
@darccio darccio deleted the dario.castane/ktlo/drop-v1-debuginfo-report branch February 12, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant