Revert HTTP client sharing in CI Vis components (#7734)

Author: nikita-tkachenko-datadog

communication/src/main/java/datadog/communication/BackendApiFactory.java

@@ -3,11 +3,13 @@
 import datadog.communication.ddagent.DDAgentFeaturesDiscovery;
 import datadog.communication.ddagent.SharedCommunicationObjects;
 import datadog.communication.http.HttpRetryPolicy;
+import datadog.communication.http.OkHttpUtils;
 import datadog.trace.api.Config;
 import datadog.trace.util.throwable.FatalAgentMisconfigurationError;
 import java.util.function.Function;
 import javax.annotation.Nullable;
 import okhttp3.HttpUrl;
+import okhttp3.OkHttpClient;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -34,13 +36,10 @@ public BackendApiFactory(Config config, SharedCommunicationObjects sharedCommuni
             "Agentless mode is enabled and api key is not set. Please set application key");
       }
       String traceId = config.getIdGenerationStrategy().generateTraceId().toString();
-      return new IntakeApi(
-          agentlessUrl,
-          apiKey,
-          traceId,
-          retryPolicyFactory,
-          sharedCommunicationObjects.okHttpClient,
-          true);
+      OkHttpClient httpClient =
+          OkHttpUtils.buildHttpClient(
+              agentlessUrl, config.getCiVisibilityBackendApiTimeoutMillis());
+      return new IntakeApi(agentlessUrl, apiKey, traceId, retryPolicyFactory, httpClient, true);
     }
 
     DDAgentFeaturesDiscovery featuresDiscovery =

communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java

@@ -36,21 +36,11 @@ public void createRemaining(Config config) {
       }
     }
     if (okHttpClient == null) {
-      String unixDomainSocket;
-      String namedPipe;
-      HttpUrl url;
-      if (!config.isCiVisibilityAgentlessEnabled()) {
-        unixDomainSocket = SocketUtils.discoverApmSocket(config);
-        namedPipe = config.getAgentNamedPipe();
-        url = agentUrl;
-      } else {
-        unixDomainSocket = null;
-        namedPipe = null;
-        url = null;
-      }
+      String unixDomainSocket = SocketUtils.discoverApmSocket(config);
+      String namedPipe = config.getAgentNamedPipe();
       okHttpClient =
           OkHttpUtils.buildHttpClient(
-              url, unixDomainSocket, namedPipe, getHttpClientTimeout(config));
+              agentUrl, unixDomainSocket, namedPipe, getHttpClientTimeout(config));
     }
   }
 

dd-trace-core/src/main/java/datadog/trace/common/writer/WriterFactory.java

@@ -188,7 +188,6 @@ private static RemoteApi createDDIntakeRemoteApi(
       }
       return DDIntakeApi.builder()
           .hostUrl(hostUrl)
-          .httpClient(commObjects.okHttpClient)
           .apiKey(config.getApiKey())
           .trackType(trackType)
           .build();