feat: headless and agentless changes

Author: daniel-mohedano

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java

@@ -577,6 +577,7 @@ public void execute() {
       }
 
       maybeStartAppSec(scoClass, sco);
+      // start before debugger to enable Failed Test Replay correctly
       maybeStartCiVisibility(instrumentation, scoClass, sco);
       // start debugger before remote config to subscribe to it before starting to poll
       maybeStartDebugger(instrumentation, scoClass, sco);
@@ -1153,10 +1154,6 @@ && isExplicitlyDisabled(TraceInstrumentationConfig.CODE_ORIGIN_FOR_SPANS_ENABLED
         && isExplicitlyDisabled(DebuggerConfig.DISTRIBUTED_DEBUGGER_ENABLED)) {
       return;
     }
-    if (!remoteConfigEnabled) {
-      log.warn("Cannot enable Dynamic Instrumentation because Remote Configuration is not enabled");
-      return;
-    }
     startDebuggerAgent(inst, scoClass, sco);
   }
 

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/CiVisibilitySystem.java

@@ -102,7 +102,7 @@ public static void start(Instrumentation inst, SharedCommunicationObjects sco) {
       }
 
       if (executionSettings.isFailedTestReplayEnabled()) {
-        // TODO
+        config.setCiVisibilityFailedTestReplayEnabled(true);
       }
 
       CiVisibilityCoverageServices.Child coverageServices =

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/domain/buildsystem/BuildSystemModuleImpl.java

@@ -193,9 +193,6 @@ private Map<String, String> getPropertiesPropagatedToChildProcess(
       propagatedSystemProperties.put(
           Strings.propertyNameToSystemPropertyName(DebuggerConfig.EXCEPTION_REPLAY_ENABLED),
           "true");
-      propagatedSystemProperties.put(
-          Strings.propertyNameToSystemPropertyName(RemoteConfigConfig.REMOTE_CONFIGURATION_ENABLED),
-          "true");
     }
 
     // explicitly disable build instrumentation in child processes,

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/exception/DefaultExceptionDebugger.java

@@ -74,7 +74,8 @@ public DefaultExceptionDebugger(
 
   @Override
   public void handleException(Throwable t, AgentSpan span) {
-    if (t instanceof Error && !Config.get().isCiVisibilityEnabled()) {
+    // CIVIS Failed Test Replay acts on errors
+    if (t instanceof Error && !Config.get().isCiVisibilityFailedTestReplayEnabled()) {
       if (LOGGER.isDebugEnabled()) {
         LOGGER.debug("Skip handling error: {}", t.toString());
       }
@@ -98,7 +99,6 @@ public void handleException(Throwable t, AgentSpan span) {
     if (exceptionProbeManager.isAlreadyInstrumented(fingerprint)) {
       ThrowableState state = exceptionProbeManager.getStateByThrowable(innerMostException);
       if (state == null) {
-        LOGGER.info("Unable to find state for throwable: {}", innerMostException.toString());
         LOGGER.debug("Unable to find state for throwable: {}", innerMostException.toString());
         return;
       }
@@ -114,8 +114,9 @@ public void handleException(Throwable t, AgentSpan span) {
             exceptionProbeManager.createProbesForException(
                 throwable.getStackTrace(), chainedExceptionIdx);
         if (creationResult.probesCreated > 0) {
-          LOGGER.info("Creating probes for: {}", t.getMessage());
-          if (Config.get().isCiVisibilityEnabled()) {
+          if (Config.get().isCiVisibilityFailedTestReplayEnabled()) {
+              // Assume Exception Replay is working under Failed Test Replay logic,
+              // instrumentation applied sync for immediate test retries
              applyExceptionConfiguration(fingerprint);
           } else {
             AgentTaskScheduler.INSTANCE.execute(() -> applyExceptionConfiguration(fingerprint));
@@ -158,7 +159,6 @@ private static void processSnapshotsAndSetTags(
                 }
               });
     }
-    LOGGER.info("Processing exception snapshot for: {}", t.getMessage());
     boolean snapshotAssigned = false;
     List<Snapshot> snapshots = state.getSnapshots();
     int maxSnapshotSize = Math.min(snapshots.size(), maxCapturedFrames);
@@ -197,7 +197,6 @@ private static void processSnapshotsAndSetTags(
         DebuggerAgent.getSink().addSnapshot(snapshot);
       }
       snapshotAssigned = true;
-      LOGGER.info("Capture for {}: {}", t.getMessage(), snapshots.get(i).getVariables());
     }
     if (snapshotAssigned) {
       state.markAsSnapshotSent();

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/Snapshot.java

@@ -12,7 +12,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
-import java.util.stream.Collectors;
 
 /** Data class representing all data collected at a probe location */
 public class Snapshot {
@@ -162,18 +161,6 @@ public List<EvaluationError> getEvaluationErrors() {
     return evaluationErrors;
   }
 
-  public String getVariables() {
-    String variables = "";
-    CapturedContext returnContext = captures.getReturn();
-    if (returnContext != null) {
-      Map<String, CapturedContext.CapturedValue> allVars = new HashMap<>();
-      if (returnContext.getArguments() != null) allVars.putAll(returnContext.getArguments());
-      if (returnContext.getLocals() != null) allVars.putAll(returnContext.getLocals());
-      variables = allVars.entrySet().stream().map(e -> e.getKey() + "=" + e.getValue().getStrValue()).collect(Collectors.joining(", "));
-    }
-    return variables;
-  }
-
   public void addEvaluationErrors(List<EvaluationError> errors) {
     if (errors == null || errors.isEmpty()) {
       return;

internal-api/src/main/java/datadog/trace/api/Config.java

@@ -1003,7 +1003,7 @@ public static String getHostName() {
   private final String gitPullRequestBaseBranch;
   private final String gitPullRequestBaseBranchSha;
   private final String gitCommitHeadSha;
-  private final boolean ciVisibilityFailedTestReplayEnabled;
+  private boolean ciVisibilityFailedTestReplayEnabled;
 
   private final boolean remoteConfigEnabled;
   private final boolean remoteConfigIntegrityCheckEnabled;
@@ -3840,6 +3840,10 @@ public boolean isCiVisibilityFailedTestReplayEnabled() {
     return ciVisibilityFailedTestReplayEnabled;
   }
 
+  public void setCiVisibilityFailedTestReplayEnabled(boolean enabled) {
+    ciVisibilityFailedTestReplayEnabled = enabled;
+  }
+
   public String getGitPullRequestBaseBranch() {
     return gitPullRequestBaseBranch;
   }
@@ -3961,7 +3965,7 @@ public boolean isSymbolDatabaseCompressed() {
   }
 
   public boolean isDebuggerExceptionEnabled() {
-    return debuggerExceptionEnabled;
+    return debuggerExceptionEnabled || ciVisibilityFailedTestReplayEnabled;
   }
 
   public int getDebuggerMaxExceptionPerSecond() {
@@ -4009,13 +4013,7 @@ public Set<String> getThirdPartyShadingIdentifiers() {
   }
 
   private String getFinalDebuggerBaseUrl() {
-    if (isCiVisibilityEnabled() && isCiVisibilityAgentlessEnabled()) {
-      String agentlessUrl = getCiVisibilityAgentlessUrl();
-      if (Strings.isNotBlank(agentlessUrl)) {
-        return agentlessUrl;
-      }
-      return "https://http-intake.logs." + getSite();
-    } else if (agentUrl.startsWith("unix:")) {
+    if (agentUrl.startsWith("unix:")) {
       // provide placeholder agent URL, in practice we'll be tunnelling over UDS
       return "http://" + agentHost + ":" + agentPort;
     } else {
@@ -4024,7 +4022,16 @@ private String getFinalDebuggerBaseUrl() {
   }
 
   public String getFinalDebuggerSnapshotUrl() {
-    return getFinalDebuggerBaseUrl() + "/debugger/v1/input";
+    if (isCiVisibilityFailedTestReplayEnabled() && isCiVisibilityAgentlessEnabled()) {
+      // Used in Failed Test Replay agentless
+      String agentlessUrl = getCiVisibilityAgentlessUrl();
+      if (Strings.isBlank(agentlessUrl)) {
+        agentlessUrl = "https://http-intake.logs." + getSite();
+      }
+      return agentlessUrl + "/api/v2/logs";
+    } else {
+      return getFinalDebuggerBaseUrl() + "/debugger/v1/input";
+    }
   }
 
   public String getFinalDebuggerSymDBUrl() {