feat(env): Migrate security libraries to environment component

Author: PerfectSlayer

dd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WafInitialization.java

@@ -2,6 +2,7 @@
 
 import com.datadog.appsec.util.StandardizedLogging;
 import com.datadog.ddwaf.Waf;
+import datadog.environment.SystemProperties;
 import java.io.File;
 import java.io.IOException;
 import java.util.Scanner;
@@ -13,7 +14,7 @@ public class WafInitialization {
 
   private static boolean initWAF() {
     try {
-      boolean simpleLoad = System.getProperty("POWERWAF_SIMPLE_LOAD") != null;
+      boolean simpleLoad = SystemProperties.get("POWERWAF_SIMPLE_LOAD") != null;
       Waf.initialize(simpleLoad);
     } catch (Throwable e) {
       Logger logger = LoggerFactory.getLogger(WafInitialization.class);
@@ -26,7 +27,7 @@ private static boolean initWAF() {
   }
 
   private static String getLibc() {
-    String os = System.getProperty("os.name");
+    String os = SystemProperties.get("os.name");
     if ("Linux".equals(os)) {
       File file = new File("/proc/self/maps");
       try (Scanner sc = new Scanner(file, "ISO-8859-1")) {

dd-java-agent/appsec/src/main/java/com/datadog/appsec/util/AppSecVersion.java

@@ -1,12 +1,16 @@
 package com.datadog.appsec.util;
 
+import datadog.environment.SystemProperties;
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
 
 public class AppSecVersion {
-  public static final String JAVA_VERSION = System.getProperty("java.version", "unknown");
-  public static final String JAVA_VM_NAME = System.getProperty("java.vm.name", "unknown");
-  public static final String JAVA_VM_VENDOR = System.getProperty("java.vm.vendor", "unknown");
+  public static final String JAVA_VERSION =
+      SystemProperties.getOrDefault("java.version", "unknown");
+  public static final String JAVA_VM_NAME =
+      SystemProperties.getOrDefault("java.vm.name", "unknown");
+  public static final String JAVA_VM_VENDOR =
+      SystemProperties.getOrDefault("java.vm.vendor", "unknown");
   public static final String VERSION;
 
   static {

dd-java-agent/appsec/src/main/java/com/datadog/appsec/util/StandardizedLogging.java

@@ -5,6 +5,7 @@
 import com.datadog.appsec.event.data.Address;
 import com.datadog.appsec.report.AppSecEvent;
 import com.datadog.ddwaf.Waf;
+import datadog.environment.SystemProperties;
 import org.slf4j.Logger;
 import org.slf4j.Marker;
 import org.slf4j.MarkerFactory;
@@ -42,11 +43,11 @@ public static void libddwafCannotBeLoaded(Logger logger, String libc) {
             + "AppSec could not start. No security activities will be collected. "
             + "Please contact support at https://docs.datadoghq.com/help/ for help. "
             + "Host information: operating_system: {}, libc: {}, arch: {}, runtime: {} {}",
-        System.getProperty("os.name"),
+        SystemProperties.get("os.name"),
         libc,
-        System.getProperty("os.arch"),
-        System.getProperty("java.vm.vendor"),
-        System.getProperty("java.version"));
+        SystemProperties.get("os.arch"),
+        SystemProperties.get("java.vm.vendor"),
+        SystemProperties.get("java.version"));
   }
 
   // C4:

dd-java-agent/cws-tls/src/main/java/datadog/cws/tls/ErpcTls.java

@@ -10,6 +10,7 @@
 import com.sun.jna.Pointer;
 import datadog.cws.erpc.Erpc;
 import datadog.cws.erpc.Request;
+import datadog.environment.SystemProperties;
 import datadog.trace.api.DD128bTraceId;
 import datadog.trace.api.DDTraceId;
 
@@ -40,7 +41,7 @@ public interface CLibrary extends Library {
   }
 
   static int getGettidSyscallId() {
-    String arch = System.getProperty("os.arch");
+    String arch = SystemProperties.get("os.arch");
     if (arch.equals("amd64")) {
       return 186; // 186 is the syscall ID for "gettid" on amd64
     } else if (arch.equals("arm64")) {