Skip to content

Commit f596731

Browse files
authored
Add new assert to help troubleshoot flaky test (#7729)
make run flaky tests for debuger module
1 parent 5a70635 commit f596731

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

.circleci/config.continue.yml.j2

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1217,6 +1217,20 @@ build_test_jobs: &build_test_jobs
12171217
parallelism: 4
12181218
maxWorkers: 4
12191219
testJvm: "8"
1220+
1221+
- tests:
1222+
requires:
1223+
- ok_to_test
1224+
name: z_test_8_flaky_debugger
1225+
gradleTarget: ":debuggerTest"
1226+
gradleParameters: "-PrunFlakyTests"
1227+
continueOnFailure: true
1228+
triggeredBy: *debugger_modules
1229+
stage: debugger
1230+
cacheType: base
1231+
parallelism: 4
1232+
maxWorkers: 4
1233+
testJvm: "8"
12201234
{% endif %}
12211235
12221236
- tests:

dd-smoke-tests/debugger-integration-tests/src/test/java/datadog/smoketest/BaseIntegrationTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -507,6 +507,8 @@ protected void assertCaptureArgs(
507507
CapturedContext.CapturedValue capturedValue = context.getArguments().get(name);
508508
assertEquals(typeName, capturedValue.getType());
509509
Object objValue = capturedValue.getValue();
510+
assertNotNull(
511+
"objValue null for argName=" + name + " capturedValue=" + capturedValue, objValue);
510512
if (objValue.getClass().isArray()) {
511513
assertEquals(value, Arrays.toString((Object[]) objValue));
512514
} else {

dd-smoke-tests/debugger-integration-tests/src/test/java/datadog/smoketest/LogProbesIntegrationTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import datadog.trace.bootstrap.debugger.CapturedContext;
2727
import datadog.trace.bootstrap.debugger.MethodLocation;
2828
import datadog.trace.bootstrap.debugger.ProbeId;
29+
import datadog.trace.test.util.Flaky;
2930
import java.util.ArrayList;
3031
import java.util.HashMap;
3132
import java.util.HashSet;
@@ -53,6 +54,7 @@ void testInaccessibleObject() throws Exception {
5354
assertFalse(logHasErrors(logFilePath, it -> false));
5455
}
5556

57+
@Flaky
5658
@Test
5759
@DisplayName("testFullMethod")
5860
void testFullMethod() throws Exception {

0 commit comments

Comments
 (0)