Enable Spotbugs and Spotless for modules that require JDK21+.#10092
Merged
AlexeyKuznetsov-DD merged 5 commits intomasterfrom Dec 11, 2025
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~ecca0dc97d, baseline=1.57.0-SNAPSHOT~ee5e0f490a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077025
Total [baseline] (10.797 s) : 0, 10797009
Agent [candidate] (1.094 s) : 0, 1093738
Total [candidate] (10.962 s) : 0, 10962034
section appsec
Agent [baseline] (1.265 s) : 0, 1264557
Total [baseline] (11.054 s) : 0, 11054077
Agent [candidate] (1.264 s) : 0, 1264455
Total [candidate] (11.184 s) : 0, 11183886
section iast
Agent [baseline] (1.219 s) : 0, 1219064
Total [baseline] (11.365 s) : 0, 11365320
Agent [candidate] (1.231 s) : 0, 1230895
Total [candidate] (11.145 s) : 0, 11145462
section profiling
Agent [baseline] (1.214 s) : 0, 1213684
Total [baseline] (11.007 s) : 0, 11006545
Agent [candidate] (1.204 s) : 0, 1204394
Total [candidate] (10.951 s) : 0, 10950845
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~ecca0dc97d, baseline=1.57.0-SNAPSHOT~ee5e0f490a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (646.123 ms) : 0, 646123
BytebuddyAgent [candidate] (655.545 ms) : 0, 655545
GlobalTracer [baseline] (280.308 ms) : 0, 280308
GlobalTracer [candidate] (286.019 ms) : 0, 286019
AppSec [baseline] (32.238 ms) : 0, 32238
AppSec [candidate] (32.936 ms) : 0, 32936
Debugger [baseline] (68.216 ms) : 0, 68216
Debugger [candidate] (68.889 ms) : 0, 68889
Remote Config [baseline] (644.748 µs) : 0, 645
Remote Config [candidate] (636.588 µs) : 0, 637
Telemetry [baseline] (9.005 ms) : 0, 9005
Telemetry [candidate] (9.023 ms) : 0, 9023
Flare Poller [baseline] (3.851 ms) : 0, 3851
Flare Poller [candidate] (3.821 ms) : 0, 3821
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (687.989 ms) : 0, 687989
BytebuddyAgent [candidate] (688.838 ms) : 0, 688838
GlobalTracer [baseline] (260.069 ms) : 0, 260069
GlobalTracer [candidate] (258.833 ms) : 0, 258833
AppSec [baseline] (174.809 ms) : 0, 174809
AppSec [candidate] (174.806 ms) : 0, 174806
Debugger [baseline] (66.641 ms) : 0, 66641
Debugger [candidate] (66.896 ms) : 0, 66896
Remote Config [baseline] (708.447 µs) : 0, 708
Remote Config [candidate] (704.639 µs) : 0, 705
Telemetry [baseline] (8.997 ms) : 0, 8997
Telemetry [candidate] (9.141 ms) : 0, 9141
Flare Poller [baseline] (3.885 ms) : 0, 3885
Flare Poller [candidate] (3.867 ms) : 0, 3867
IAST [baseline] (24.763 ms) : 0, 24763
IAST [candidate] (24.667 ms) : 0, 24667
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (788.53 ms) : 0, 788530
BytebuddyAgent [candidate] (796.159 ms) : 0, 796159
GlobalTracer [baseline] (254.739 ms) : 0, 254739
GlobalTracer [candidate] (257.061 ms) : 0, 257061
AppSec [baseline] (35.04 ms) : 0, 35040
AppSec [candidate] (35.391 ms) : 0, 35391
Debugger [baseline] (65.333 ms) : 0, 65333
Debugger [candidate] (65.856 ms) : 0, 65856
Remote Config [baseline] (530.939 µs) : 0, 531
Remote Config [candidate] (557.016 µs) : 0, 557
Telemetry [baseline] (8.359 ms) : 0, 8359
Telemetry [candidate] (8.507 ms) : 0, 8507
Flare Poller [baseline] (3.442 ms) : 0, 3442
Flare Poller [candidate] (3.551 ms) : 0, 3551
IAST [baseline] (26.639 ms) : 0, 26639
IAST [candidate] (27.138 ms) : 0, 27138
section profiling
ProfilingAgent [baseline] (97.781 ms) : 0, 97781
ProfilingAgent [candidate] (97.095 ms) : 0, 97095
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (707.545 ms) : 0, 707545
BytebuddyAgent [candidate] (702.085 ms) : 0, 702085
GlobalTracer [baseline] (222.69 ms) : 0, 222690
GlobalTracer [candidate] (220.634 ms) : 0, 220634
AppSec [baseline] (32.779 ms) : 0, 32779
AppSec [candidate] (32.492 ms) : 0, 32492
Debugger [baseline] (68.292 ms) : 0, 68292
Debugger [candidate] (68.149 ms) : 0, 68149
Remote Config [baseline] (649.311 µs) : 0, 649
Remote Config [candidate] (613.381 µs) : 0, 613
Telemetry [baseline] (9.01 ms) : 0, 9010
Telemetry [candidate] (8.98 ms) : 0, 8980
Flare Poller [baseline] (3.765 ms) : 0, 3765
Flare Poller [candidate] (3.775 ms) : 0, 3775
Profiling [baseline] (98.367 ms) : 0, 98367
Profiling [candidate] (97.682 ms) : 0, 97682
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~ecca0dc97d, baseline=1.57.0-SNAPSHOT~ee5e0f490a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076609
Total [baseline] (8.723 s) : 0, 8722757
Agent [candidate] (1.085 s) : 0, 1085330
Total [candidate] (8.76 s) : 0, 8759726
section iast
Agent [baseline] (1.219 s) : 0, 1219238
Total [baseline] (9.44 s) : 0, 9440313
Agent [candidate] (1.219 s) : 0, 1218619
Total [candidate] (9.432 s) : 0, 9432409
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~ecca0dc97d, baseline=1.57.0-SNAPSHOT~ee5e0f490a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (646.928 ms) : 0, 646928
BytebuddyAgent [candidate] (651.796 ms) : 0, 651796
GlobalTracer [baseline] (280.702 ms) : 0, 280702
GlobalTracer [candidate] (283.33 ms) : 0, 283330
AppSec [baseline] (32.207 ms) : 0, 32207
AppSec [candidate] (32.521 ms) : 0, 32521
Debugger [baseline] (66.741 ms) : 0, 66741
Debugger [candidate] (67.597 ms) : 0, 67597
Remote Config [baseline] (652.521 µs) : 0, 653
Remote Config [candidate] (651.015 µs) : 0, 651
Telemetry [baseline] (8.992 ms) : 0, 8992
Telemetry [candidate] (9.065 ms) : 0, 9065
Flare Poller [baseline] (3.699 ms) : 0, 3699
Flare Poller [candidate] (3.699 ms) : 0, 3699
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (789.137 ms) : 0, 789137
BytebuddyAgent [candidate] (788.83 ms) : 0, 788830
GlobalTracer [baseline] (254.856 ms) : 0, 254856
GlobalTracer [candidate] (254.95 ms) : 0, 254950
AppSec [baseline] (33.568 ms) : 0, 33568
AppSec [candidate] (35.185 ms) : 0, 35185
Debugger [baseline] (65.963 ms) : 0, 65963
Debugger [candidate] (64.162 ms) : 0, 64162
Remote Config [baseline] (542.575 µs) : 0, 543
Remote Config [candidate] (537.48 µs) : 0, 537
Telemetry [baseline] (8.45 ms) : 0, 8450
Telemetry [candidate] (8.377 ms) : 0, 8377
Flare Poller [baseline] (3.429 ms) : 0, 3429
Flare Poller [candidate] (3.425 ms) : 0, 3425
IAST [baseline] (26.744 ms) : 0, 26744
IAST [candidate] (26.676 ms) : 0, 26676
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~ecca0dc97d, baseline=1.57.0-SNAPSHOT~ee5e0f490a
dateFormat X
axisFormat %s
section baseline
no_agent (1.193 ms) : 1181, 1204
. : milestone, 1193,
iast (3.238 ms) : 3194, 3282
. : milestone, 3238,
iast_FULL (5.927 ms) : 5867, 5987
. : milestone, 5927,
iast_GLOBAL (3.433 ms) : 3379, 3487
. : milestone, 3433,
profiling (1.964 ms) : 1948, 1980
. : milestone, 1964,
tracing (1.881 ms) : 1865, 1897
. : milestone, 1881,
section candidate
no_agent (1.215 ms) : 1203, 1227
. : milestone, 1215,
iast (3.179 ms) : 3144, 3214
. : milestone, 3179,
iast_FULL (5.618 ms) : 5563, 5674
. : milestone, 5618,
iast_GLOBAL (3.677 ms) : 3621, 3732
. : milestone, 3677,
profiling (2.036 ms) : 2019, 2053
. : milestone, 2036,
tracing (1.798 ms) : 1784, 1813
. : milestone, 1798,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~ecca0dc97d, baseline=1.57.0-SNAPSHOT~ee5e0f490a
dateFormat X
axisFormat %s
section baseline
no_agent (18.103 ms) : 17918, 18289
. : milestone, 18103,
appsec (18.462 ms) : 18273, 18651
. : milestone, 18462,
code_origins (17.811 ms) : 17636, 17986
. : milestone, 17811,
iast (17.789 ms) : 17612, 17966
. : milestone, 17789,
profiling (18.933 ms) : 18745, 19121
. : milestone, 18933,
tracing (17.454 ms) : 17281, 17628
. : milestone, 17454,
section candidate
no_agent (18.295 ms) : 18103, 18488
. : milestone, 18295,
appsec (18.684 ms) : 18498, 18870
. : milestone, 18684,
code_origins (17.815 ms) : 17638, 17992
. : milestone, 17815,
iast (17.8 ms) : 17622, 17978
. : milestone, 17800,
profiling (20.242 ms) : 20033, 20451
. : milestone, 20242,
tracing (17.755 ms) : 17577, 17933
. : milestone, 17755,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~ecca0dc97d, baseline=1.57.0-SNAPSHOT~ee5e0f490a
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (2.535 ms) : 2482, 2589
. : milestone, 2535,
iast (2.221 ms) : 2157, 2285
. : milestone, 2221,
iast_GLOBAL (2.273 ms) : 2208, 2337
. : milestone, 2273,
profiling (2.074 ms) : 2021, 2126
. : milestone, 2074,
tracing (2.063 ms) : 2012, 2113
. : milestone, 2063,
section candidate
no_agent (1.485 ms) : 1473, 1497
. : milestone, 1485,
appsec (2.474 ms) : 2422, 2526
. : milestone, 2474,
iast (2.229 ms) : 2165, 2293
. : milestone, 2229,
iast_GLOBAL (2.276 ms) : 2212, 2341
. : milestone, 2276,
profiling (2.072 ms) : 2020, 2124
. : milestone, 2072,
tracing (2.056 ms) : 2006, 2107
. : milestone, 2056,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~ecca0dc97d, baseline=1.57.0-SNAPSHOT~ee5e0f490a
dateFormat X
axisFormat %s
section baseline
no_agent (15.607 s) : 15607000, 15607000
. : milestone, 15607000,
appsec (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
iast (18.231 s) : 18231000, 18231000
. : milestone, 18231000,
iast_GLOBAL (17.854 s) : 17854000, 17854000
. : milestone, 17854000,
profiling (15.193 s) : 15193000, 15193000
. : milestone, 15193000,
tracing (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
section candidate
no_agent (15.736 s) : 15736000, 15736000
. : milestone, 15736000,
appsec (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
iast (18.166 s) : 18166000, 18166000
. : milestone, 18166000,
iast_GLOBAL (17.92 s) : 17920000, 17920000
. : milestone, 17920000,
profiling (14.688 s) : 14688000, 14688000
. : milestone, 14688000,
tracing (14.843 s) : 14843000, 14843000
. : milestone, 14843000,
|
PerfectSlayer
approved these changes
Dec 8, 2025
Contributor
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the follow up 🙏
bric3
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Enable
SpotbugsandSpotlessfor modules that require JDK21+.Motivation
Apply tools to whole code base.
Additional Notes
Previously those tools not worked correctly with latest JDKs, now they are.