-
Notifications
You must be signed in to change notification settings - Fork 323
Refactor mongodb instrumentation modules #10271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~59f47ebd85, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085031
Total [baseline] (8.752 s) : 0, 8752288
Agent [candidate] (1.085 s) : 0, 1084545
Total [candidate] (8.767 s) : 0, 8767321
section iast
Agent [baseline] (1.221 s) : 0, 1221239
Total [baseline] (9.286 s) : 0, 9285859
Agent [candidate] (1.224 s) : 0, 1223841
Total [candidate] (9.365 s) : 0, 9364866
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~59f47ebd85, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (651.396 ms) : 0, 651396
BytebuddyAgent [candidate] (651.765 ms) : 0, 651765
GlobalTracer [baseline] (282.645 ms) : 0, 282645
GlobalTracer [candidate] (282.656 ms) : 0, 282656
AppSec [baseline] (32.871 ms) : 0, 32871
AppSec [candidate] (32.659 ms) : 0, 32659
Debugger [baseline] (68.053 ms) : 0, 68053
Debugger [candidate] (67.325 ms) : 0, 67325
Remote Config [baseline] (625.051 µs) : 0, 625
Remote Config [candidate] (627.255 µs) : 0, 627
Telemetry [baseline] (8.981 ms) : 0, 8981
Telemetry [candidate] (9.058 ms) : 0, 9058
Flare Poller [baseline] (3.795 ms) : 0, 3795
Flare Poller [candidate] (3.778 ms) : 0, 3778
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (790.574 ms) : 0, 790574
BytebuddyAgent [candidate] (792.145 ms) : 0, 792145
GlobalTracer [baseline] (254.75 ms) : 0, 254750
GlobalTracer [candidate] (254.95 ms) : 0, 254950
IAST [baseline] (27.151 ms) : 0, 27151
IAST [candidate] (27.148 ms) : 0, 27148
AppSec [baseline] (34.6 ms) : 0, 34600
AppSec [candidate] (32.067 ms) : 0, 32067
Debugger [baseline] (64.992 ms) : 0, 64992
Debugger [candidate] (68.279 ms) : 0, 68279
Remote Config [baseline] (582.305 µs) : 0, 582
Remote Config [candidate] (601.211 µs) : 0, 601
Telemetry [baseline] (8.532 ms) : 0, 8532
Telemetry [candidate] (8.566 ms) : 0, 8566
Flare Poller [baseline] (3.551 ms) : 0, 3551
Flare Poller [candidate] (3.568 ms) : 0, 3568
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~59f47ebd85, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091256
Total [baseline] (10.841 s) : 0, 10841458
Agent [candidate] (1.088 s) : 0, 1088400
Total [candidate] (10.891 s) : 0, 10890823
section appsec
Agent [baseline] (1.277 s) : 0, 1276775
Total [baseline] (10.921 s) : 0, 10921410
Agent [candidate] (1.266 s) : 0, 1265853
Total [candidate] (10.899 s) : 0, 10899023
section iast
Agent [baseline] (1.234 s) : 0, 1234237
Total [baseline] (11.187 s) : 0, 11187034
Agent [candidate] (1.232 s) : 0, 1231882
Total [candidate] (11.196 s) : 0, 11195662
section profiling
Agent [baseline] (1.21 s) : 0, 1209557
Total [baseline] (10.891 s) : 0, 10891113
Agent [candidate] (1.207 s) : 0, 1206662
Total [candidate] (11.044 s) : 0, 11043757
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~59f47ebd85, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (655.606 ms) : 0, 655606
BytebuddyAgent [candidate] (653.701 ms) : 0, 653701
GlobalTracer [baseline] (283.894 ms) : 0, 283894
GlobalTracer [candidate] (283.103 ms) : 0, 283103
AppSec [baseline] (33.041 ms) : 0, 33041
AppSec [candidate] (32.833 ms) : 0, 32833
Debugger [baseline] (68.437 ms) : 0, 68437
Debugger [candidate] (68.68 ms) : 0, 68680
Remote Config [baseline] (619.318 µs) : 0, 619
Remote Config [candidate] (604.75 µs) : 0, 605
Telemetry [baseline] (9.042 ms) : 0, 9042
Telemetry [candidate] (9.046 ms) : 0, 9046
Flare Poller [baseline] (3.766 ms) : 0, 3766
Flare Poller [candidate] (3.779 ms) : 0, 3779
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (698.315 ms) : 0, 698315
BytebuddyAgent [candidate] (691.362 ms) : 0, 691362
GlobalTracer [baseline] (260.106 ms) : 0, 260106
GlobalTracer [candidate] (257.47 ms) : 0, 257470
IAST [baseline] (24.745 ms) : 0, 24745
IAST [candidate] (24.83 ms) : 0, 24830
AppSec [baseline] (175.3 ms) : 0, 175300
AppSec [candidate] (173.327 ms) : 0, 173327
Debugger [baseline] (67.501 ms) : 0, 67501
Debugger [candidate] (68.452 ms) : 0, 68452
Remote Config [baseline] (784.381 µs) : 0, 784
Remote Config [candidate] (754.086 µs) : 0, 754
Telemetry [baseline] (9.434 ms) : 0, 9434
Telemetry [candidate] (9.498 ms) : 0, 9498
Flare Poller [baseline] (3.726 ms) : 0, 3726
Flare Poller [candidate] (3.73 ms) : 0, 3730
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (799.47 ms) : 0, 799470
BytebuddyAgent [candidate] (797.764 ms) : 0, 797764
GlobalTracer [baseline] (257.597 ms) : 0, 257597
GlobalTracer [candidate] (256.988 ms) : 0, 256988
IAST [baseline] (27.393 ms) : 0, 27393
IAST [candidate] (27.264 ms) : 0, 27264
AppSec [baseline] (34.572 ms) : 0, 34572
AppSec [candidate] (34.446 ms) : 0, 34446
Debugger [baseline] (65.815 ms) : 0, 65815
Debugger [candidate] (66.026 ms) : 0, 66026
Remote Config [baseline] (565.596 µs) : 0, 566
Remote Config [candidate] (601.769 µs) : 0, 602
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.507 ms) : 0, 8507
Flare Poller [baseline] (3.53 ms) : 0, 3530
Flare Poller [candidate] (3.544 ms) : 0, 3544
section profiling
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (704.849 ms) : 0, 704849
BytebuddyAgent [candidate] (704.061 ms) : 0, 704061
GlobalTracer [baseline] (221.784 ms) : 0, 221784
GlobalTracer [candidate] (220.266 ms) : 0, 220266
AppSec [baseline] (32.584 ms) : 0, 32584
AppSec [candidate] (32.234 ms) : 0, 32234
Debugger [baseline] (68.272 ms) : 0, 68272
Debugger [candidate] (67.832 ms) : 0, 67832
Remote Config [baseline] (662.309 µs) : 0, 662
Remote Config [candidate] (624.062 µs) : 0, 624
Telemetry [baseline] (8.834 ms) : 0, 8834
Telemetry [candidate] (8.821 ms) : 0, 8821
Flare Poller [baseline] (3.704 ms) : 0, 3704
Flare Poller [candidate] (3.716 ms) : 0, 3716
ProfilingAgent [baseline] (97.671 ms) : 0, 97671
ProfilingAgent [candidate] (98.085 ms) : 0, 98085
Profiling [baseline] (98.249 ms) : 0, 98249
Profiling [candidate] (98.674 ms) : 0, 98674
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~59f47ebd85, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section baseline
no_agent (18.176 ms) : 17984, 18367
. : milestone, 18176,
appsec (18.324 ms) : 18133, 18516
. : milestone, 18324,
code_origins (17.948 ms) : 17768, 18128
. : milestone, 17948,
iast (17.782 ms) : 17604, 17960
. : milestone, 17782,
profiling (18.375 ms) : 18191, 18560
. : milestone, 18375,
tracing (17.788 ms) : 17614, 17962
. : milestone, 17788,
section candidate
no_agent (17.293 ms) : 17121, 17465
. : milestone, 17293,
appsec (18.283 ms) : 18098, 18469
. : milestone, 18283,
code_origins (17.971 ms) : 17791, 18151
. : milestone, 17971,
iast (17.585 ms) : 17411, 17760
. : milestone, 17585,
profiling (19.561 ms) : 19365, 19758
. : milestone, 19561,
tracing (17.922 ms) : 17742, 18103
. : milestone, 17922,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~59f47ebd85, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section baseline
no_agent (1.162 ms) : 1151, 1174
. : milestone, 1162,
iast (3.194 ms) : 3147, 3241
. : milestone, 3194,
iast_FULL (5.617 ms) : 5562, 5673
. : milestone, 5617,
iast_GLOBAL (3.58 ms) : 3524, 3637
. : milestone, 3580,
profiling (1.93 ms) : 1914, 1946
. : milestone, 1930,
tracing (1.728 ms) : 1714, 1742
. : milestone, 1728,
section candidate
no_agent (1.198 ms) : 1186, 1209
. : milestone, 1198,
iast (3.059 ms) : 3020, 3098
. : milestone, 3059,
iast_FULL (5.701 ms) : 5645, 5758
. : milestone, 5701,
iast_GLOBAL (3.586 ms) : 3534, 3638
. : milestone, 3586,
profiling (2.001 ms) : 1983, 2020
. : milestone, 2001,
tracing (1.796 ms) : 1780, 1811
. : milestone, 1796,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~59f47ebd85, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section baseline
no_agent (14.681 s) : 14681000, 14681000
. : milestone, 14681000,
appsec (14.789 s) : 14789000, 14789000
. : milestone, 14789000,
iast (18.457 s) : 18457000, 18457000
. : milestone, 18457000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
. : milestone, 17912000,
profiling (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
tracing (14.513 s) : 14513000, 14513000
. : milestone, 14513000,
section candidate
no_agent (15.499 s) : 15499000, 15499000
. : milestone, 15499000,
appsec (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
iast (18.79 s) : 18790000, 18790000
. : milestone, 18790000,
iast_GLOBAL (17.907 s) : 17907000, 17907000
. : milestone, 17907000,
profiling (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
tracing (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~59f47ebd85, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.741 ms) : 3522, 3960
. : milestone, 3741,
iast (2.214 ms) : 2150, 2279
. : milestone, 2214,
iast_GLOBAL (2.254 ms) : 2188, 2319
. : milestone, 2254,
profiling (2.062 ms) : 2010, 2114
. : milestone, 2062,
tracing (2.047 ms) : 1996, 2097
. : milestone, 2047,
section candidate
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (3.741 ms) : 3523, 3958
. : milestone, 3741,
iast (2.211 ms) : 2146, 2275
. : milestone, 2211,
iast_GLOBAL (2.252 ms) : 2187, 2316
. : milestone, 2252,
profiling (2.067 ms) : 2015, 2120
. : milestone, 2067,
tracing (2.051 ms) : 2000, 2101
. : milestone, 2051,
|
bric3
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: mongodb
MongoDB instrumentation
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Do some in-depth renaming for the mongodb instrumentations to comply with the naming conventions
Notes:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]