-
Notifications
You must be signed in to change notification settings - Fork 323
Update embedded copy of SerialVersionUIDAdder #10274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~770a68691c, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084498
Total [baseline] (10.771 s) : 0, 10771288
Agent [candidate] (1.085 s) : 0, 1084795
Total [candidate] (10.883 s) : 0, 10882672
section appsec
Agent [baseline] (1.276 s) : 0, 1276355
Total [baseline] (11.008 s) : 0, 11008079
Agent [candidate] (1.267 s) : 0, 1267464
Total [candidate] (10.852 s) : 0, 10852452
section iast
Agent [baseline] (1.225 s) : 0, 1224807
Total [baseline] (11.177 s) : 0, 11176741
Agent [candidate] (1.234 s) : 0, 1234174
Total [candidate] (11.33 s) : 0, 11330253
section profiling
Agent [baseline] (1.214 s) : 0, 1214124
Total [baseline] (11.024 s) : 0, 11023518
Agent [candidate] (1.207 s) : 0, 1206679
Total [candidate] (10.922 s) : 0, 10921873
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~770a68691c, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (651.578 ms) : 0, 651578
BytebuddyAgent [candidate] (651.132 ms) : 0, 651132
GlobalTracer [baseline] (281.943 ms) : 0, 281943
GlobalTracer [candidate] (282.745 ms) : 0, 282745
AppSec [baseline] (32.606 ms) : 0, 32606
AppSec [candidate] (32.524 ms) : 0, 32524
Debugger [baseline] (68.327 ms) : 0, 68327
Debugger [candidate] (68.329 ms) : 0, 68329
Remote Config [baseline] (609.345 µs) : 0, 609
Remote Config [candidate] (604.639 µs) : 0, 605
Telemetry [baseline] (8.993 ms) : 0, 8993
Telemetry [candidate] (9.011 ms) : 0, 9011
Flare Poller [baseline] (3.658 ms) : 0, 3658
Flare Poller [candidate] (3.803 ms) : 0, 3803
section appsec
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (699.987 ms) : 0, 699987
BytebuddyAgent [candidate] (693.85 ms) : 0, 693850
GlobalTracer [baseline] (260.655 ms) : 0, 260655
GlobalTracer [candidate] (258.349 ms) : 0, 258349
AppSec [baseline] (174.37 ms) : 0, 174370
AppSec [candidate] (174.202 ms) : 0, 174202
Debugger [baseline] (65.706 ms) : 0, 65706
Debugger [candidate] (65.917 ms) : 0, 65917
Remote Config [baseline] (795.322 µs) : 0, 795
Remote Config [candidate] (773.479 µs) : 0, 773
Telemetry [baseline] (9.343 ms) : 0, 9343
Telemetry [candidate] (9.345 ms) : 0, 9345
Flare Poller [baseline] (3.719 ms) : 0, 3719
Flare Poller [candidate] (3.673 ms) : 0, 3673
IAST [baseline] (24.939 ms) : 0, 24939
IAST [candidate] (24.799 ms) : 0, 24799
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (792.007 ms) : 0, 792007
BytebuddyAgent [candidate] (799.003 ms) : 0, 799003
GlobalTracer [baseline] (255.545 ms) : 0, 255545
GlobalTracer [candidate] (257.491 ms) : 0, 257491
AppSec [baseline] (35.373 ms) : 0, 35373
AppSec [candidate] (35.571 ms) : 0, 35571
Debugger [baseline] (65.328 ms) : 0, 65328
Debugger [candidate] (65.178 ms) : 0, 65178
Remote Config [baseline] (578.466 µs) : 0, 578
Remote Config [candidate] (625.608 µs) : 0, 626
Telemetry [baseline] (8.586 ms) : 0, 8586
Telemetry [candidate] (8.537 ms) : 0, 8537
Flare Poller [baseline] (3.563 ms) : 0, 3563
Flare Poller [candidate] (3.55 ms) : 0, 3550
IAST [baseline] (27.223 ms) : 0, 27223
IAST [candidate] (27.493 ms) : 0, 27493
section profiling
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (709.036 ms) : 0, 709036
BytebuddyAgent [candidate] (705.051 ms) : 0, 705051
GlobalTracer [baseline] (221.983 ms) : 0, 221983
GlobalTracer [candidate] (220.263 ms) : 0, 220263
AppSec [baseline] (32.593 ms) : 0, 32593
AppSec [candidate] (31.999 ms) : 0, 31999
Debugger [baseline] (68.51 ms) : 0, 68510
Debugger [candidate] (68.368 ms) : 0, 68368
Remote Config [baseline] (652.404 µs) : 0, 652
Remote Config [candidate] (619.22 µs) : 0, 619
Telemetry [baseline] (8.831 ms) : 0, 8831
Telemetry [candidate] (8.708 ms) : 0, 8708
Flare Poller [baseline] (3.691 ms) : 0, 3691
Flare Poller [candidate] (3.68 ms) : 0, 3680
ProfilingAgent [baseline] (97.404 ms) : 0, 97404
ProfilingAgent [candidate] (96.883 ms) : 0, 96883
Profiling [baseline] (97.982 ms) : 0, 97982
Profiling [candidate] (97.449 ms) : 0, 97449
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~770a68691c, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087749
Total [baseline] (8.78 s) : 0, 8779546
Agent [candidate] (1.084 s) : 0, 1084278
Total [candidate] (8.746 s) : 0, 8745906
section iast
Agent [baseline] (1.227 s) : 0, 1226622
Total [baseline] (9.349 s) : 0, 9349072
Agent [candidate] (1.223 s) : 0, 1223353
Total [candidate] (9.333 s) : 0, 9333456
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~770a68691c, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (652.03 ms) : 0, 652030
BytebuddyAgent [candidate] (651.947 ms) : 0, 651947
GlobalTracer [baseline] (284.341 ms) : 0, 284341
GlobalTracer [candidate] (282.552 ms) : 0, 282552
AppSec [baseline] (32.825 ms) : 0, 32825
AppSec [candidate] (32.653 ms) : 0, 32653
Debugger [baseline] (68.17 ms) : 0, 68170
Debugger [candidate] (66.873 ms) : 0, 66873
Remote Config [baseline] (621.943 µs) : 0, 622
Remote Config [candidate] (602.765 µs) : 0, 603
Telemetry [baseline] (9.025 ms) : 0, 9025
Telemetry [candidate] (9.063 ms) : 0, 9063
Flare Poller [baseline] (3.765 ms) : 0, 3765
Flare Poller [candidate] (3.764 ms) : 0, 3764
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (794.12 ms) : 0, 794120
BytebuddyAgent [candidate] (792.381 ms) : 0, 792381
GlobalTracer [baseline] (256.236 ms) : 0, 256236
GlobalTracer [candidate] (255.708 ms) : 0, 255708
AppSec [baseline] (32.748 ms) : 0, 32748
AppSec [candidate] (33.614 ms) : 0, 33614
Debugger [baseline] (66.863 ms) : 0, 66863
Debugger [candidate] (65.349 ms) : 0, 65349
Remote Config [baseline] (595.88 µs) : 0, 596
Remote Config [candidate] (610.767 µs) : 0, 611
Telemetry [baseline] (8.518 ms) : 0, 8518
Telemetry [candidate] (8.476 ms) : 0, 8476
Flare Poller [baseline] (3.549 ms) : 0, 3549
Flare Poller [candidate] (3.579 ms) : 0, 3579
IAST [baseline] (27.282 ms) : 0, 27282
IAST [candidate] (27.016 ms) : 0, 27016
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~770a68691c, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.172 ms) : 1161, 1184
. : milestone, 1172,
iast (3.153 ms) : 3111, 3195
. : milestone, 3153,
iast_FULL (5.736 ms) : 5678, 5794
. : milestone, 5736,
iast_GLOBAL (3.558 ms) : 3498, 3618
. : milestone, 3558,
profiling (2.13 ms) : 2110, 2149
. : milestone, 2130,
tracing (1.798 ms) : 1781, 1816
. : milestone, 1798,
section candidate
no_agent (1.176 ms) : 1165, 1187
. : milestone, 1176,
iast (3.166 ms) : 3129, 3203
. : milestone, 3166,
iast_FULL (5.769 ms) : 5711, 5826
. : milestone, 5769,
iast_GLOBAL (3.431 ms) : 3384, 3477
. : milestone, 3431,
profiling (2.065 ms) : 2045, 2085
. : milestone, 2065,
tracing (1.777 ms) : 1762, 1792
. : milestone, 1777,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~770a68691c, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section baseline
no_agent (19.349 ms) : 19146, 19552
. : milestone, 19349,
appsec (19.549 ms) : 19349, 19750
. : milestone, 19549,
code_origins (17.802 ms) : 17622, 17982
. : milestone, 17802,
iast (17.7 ms) : 17524, 17875
. : milestone, 17700,
profiling (18.615 ms) : 18430, 18800
. : milestone, 18615,
tracing (17.876 ms) : 17699, 18053
. : milestone, 17876,
section candidate
no_agent (17.16 ms) : 16990, 17330
. : milestone, 17160,
appsec (18.622 ms) : 18431, 18813
. : milestone, 18622,
code_origins (17.83 ms) : 17651, 18009
. : milestone, 17830,
iast (17.779 ms) : 17604, 17954
. : milestone, 17779,
profiling (18.495 ms) : 18311, 18679
. : milestone, 18495,
tracing (18.016 ms) : 17832, 18199
. : milestone, 18016,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~770a68691c, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.74 ms) : 3519, 3961
. : milestone, 3740,
iast (2.225 ms) : 2160, 2289
. : milestone, 2225,
iast_GLOBAL (2.26 ms) : 2196, 2325
. : milestone, 2260,
profiling (2.076 ms) : 2023, 2128
. : milestone, 2076,
tracing (2.054 ms) : 2003, 2105
. : milestone, 2054,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.739 ms) : 3519, 3960
. : milestone, 3739,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.258 ms) : 2194, 2323
. : milestone, 2258,
profiling (2.068 ms) : 2016, 2121
. : milestone, 2068,
tracing (2.045 ms) : 1994, 2095
. : milestone, 2045,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~770a68691c, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section baseline
no_agent (14.842 s) : 14842000, 14842000
. : milestone, 14842000,
appsec (14.469 s) : 14469000, 14469000
. : milestone, 14469000,
iast (18.695 s) : 18695000, 18695000
. : milestone, 18695000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
. : milestone, 17958000,
profiling (14.876 s) : 14876000, 14876000
. : milestone, 14876000,
tracing (14.454 s) : 14454000, 14454000
. : milestone, 14454000,
section candidate
no_agent (15.587 s) : 15587000, 15587000
. : milestone, 15587000,
appsec (14.617 s) : 14617000, 14617000
. : milestone, 14617000,
iast (18.246 s) : 18246000, 18246000
. : milestone, 18246000,
iast_GLOBAL (17.809 s) : 17809000, 17809000
. : milestone, 17809000,
profiling (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
tracing (14.697 s) : 14697000, 14697000
. : milestone, 14697000,
|
Motivation
to pick up changes in ASM 9.9, specifically https://gitlab.ow2.org/asm/asm/-/issues/318032
(note I kept the recent local patch which checks
nameis notnull)Additional Notes
Original file: https://gitlab.ow2.org/asm/asm/-/raw/ASM_9_9/asm-commons/src/main/java/org/objectweb/asm/commons/SerialVersionUIDAdder.java
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]