-
Notifications
You must be signed in to change notification settings - Fork 323
Refactor multiple modules names #10276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~22470142cb, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086969
Total [baseline] (10.882 s) : 0, 10882320
Agent [candidate] (1.086 s) : 0, 1086230
Total [candidate] (10.86 s) : 0, 10860338
section appsec
Agent [baseline] (1.286 s) : 0, 1286086
Total [baseline] (11.137 s) : 0, 11136922
Agent [candidate] (1.279 s) : 0, 1279313
Total [candidate] (10.936 s) : 0, 10936334
section iast
Agent [baseline] (1.223 s) : 0, 1223153
Total [baseline] (11.148 s) : 0, 11147753
Agent [candidate] (1.225 s) : 0, 1225234
Total [candidate] (11.082 s) : 0, 11081689
section profiling
Agent [baseline] (1.207 s) : 0, 1206947
Total [baseline] (10.926 s) : 0, 10925558
Agent [candidate] (1.225 s) : 0, 1224542
Total [candidate] (11.007 s) : 0, 11007202
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~22470142cb, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (652.576 ms) : 0, 652576
BytebuddyAgent [candidate] (652.051 ms) : 0, 652051
GlobalTracer [baseline] (282.781 ms) : 0, 282781
GlobalTracer [candidate] (282.998 ms) : 0, 282998
AppSec [baseline] (32.676 ms) : 0, 32676
AppSec [candidate] (32.523 ms) : 0, 32523
Debugger [baseline] (68.588 ms) : 0, 68588
Debugger [candidate] (68.42 ms) : 0, 68420
Remote Config [baseline] (616.394 µs) : 0, 616
Remote Config [candidate] (618.657 µs) : 0, 619
Telemetry [baseline] (9.205 ms) : 0, 9205
Telemetry [candidate] (9.014 ms) : 0, 9014
Flare Poller [baseline] (3.79 ms) : 0, 3790
Flare Poller [candidate] (3.813 ms) : 0, 3813
section appsec
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (705.782 ms) : 0, 705782
BytebuddyAgent [candidate] (701.5 ms) : 0, 701500
GlobalTracer [baseline] (262.265 ms) : 0, 262265
GlobalTracer [candidate] (260.449 ms) : 0, 260449
IAST [baseline] (25.373 ms) : 0, 25373
IAST [candidate] (25.1 ms) : 0, 25100
AppSec [baseline] (173.59 ms) : 0, 173590
AppSec [candidate] (175.2 ms) : 0, 175200
Debugger [baseline] (68.121 ms) : 0, 68121
Debugger [candidate] (66.391 ms) : 0, 66391
Remote Config [baseline] (753.666 µs) : 0, 754
Remote Config [candidate] (748.193 µs) : 0, 748
Telemetry [baseline] (9.517 ms) : 0, 9517
Telemetry [candidate] (9.351 ms) : 0, 9351
Flare Poller [baseline] (3.709 ms) : 0, 3709
Flare Poller [candidate] (3.693 ms) : 0, 3693
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (791.387 ms) : 0, 791387
BytebuddyAgent [candidate] (792.957 ms) : 0, 792957
GlobalTracer [baseline] (255.285 ms) : 0, 255285
GlobalTracer [candidate] (255.873 ms) : 0, 255873
IAST [baseline] (26.837 ms) : 0, 26837
IAST [candidate] (27.091 ms) : 0, 27091
AppSec [baseline] (33.499 ms) : 0, 33499
AppSec [candidate] (34.171 ms) : 0, 34171
Debugger [baseline] (66.902 ms) : 0, 66902
Debugger [candidate] (65.835 ms) : 0, 65835
Remote Config [baseline] (567.857 µs) : 0, 568
Remote Config [candidate] (599.803 µs) : 0, 600
Telemetry [baseline] (8.449 ms) : 0, 8449
Telemetry [candidate] (8.526 ms) : 0, 8526
Flare Poller [baseline] (3.56 ms) : 0, 3560
Flare Poller [candidate] (3.468 ms) : 0, 3468
section profiling
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.247 ms) : 0, 1247
BytebuddyAgent [baseline] (704.504 ms) : 0, 704504
BytebuddyAgent [candidate] (716.006 ms) : 0, 716006
GlobalTracer [baseline] (220.648 ms) : 0, 220648
GlobalTracer [candidate] (223.851 ms) : 0, 223851
AppSec [baseline] (32.329 ms) : 0, 32329
AppSec [candidate] (32.724 ms) : 0, 32724
Debugger [baseline] (68.124 ms) : 0, 68124
Debugger [candidate] (69.247 ms) : 0, 69247
Remote Config [baseline] (636.979 µs) : 0, 637
Remote Config [candidate] (626.59 µs) : 0, 627
Telemetry [baseline] (8.796 ms) : 0, 8796
Telemetry [candidate] (8.789 ms) : 0, 8789
Flare Poller [baseline] (3.673 ms) : 0, 3673
Flare Poller [candidate] (3.749 ms) : 0, 3749
ProfilingAgent [baseline] (97.136 ms) : 0, 97136
ProfilingAgent [candidate] (97.581 ms) : 0, 97581
Profiling [baseline] (97.712 ms) : 0, 97712
Profiling [candidate] (98.159 ms) : 0, 98159
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~22470142cb, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084952
Total [baseline] (8.746 s) : 0, 8746250
Agent [candidate] (1.101 s) : 0, 1100596
Total [candidate] (8.846 s) : 0, 8846449
section iast
Agent [baseline] (1.223 s) : 0, 1222875
Total [baseline] (9.309 s) : 0, 9308706
Agent [candidate] (1.23 s) : 0, 1230123
Total [candidate] (9.351 s) : 0, 9351280
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~22470142cb, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (651.814 ms) : 0, 651814
BytebuddyAgent [candidate] (660.35 ms) : 0, 660350
GlobalTracer [baseline] (282.77 ms) : 0, 282770
GlobalTracer [candidate] (286.849 ms) : 0, 286849
AppSec [baseline] (32.698 ms) : 0, 32698
AppSec [candidate] (33.455 ms) : 0, 33455
Debugger [baseline] (67.401 ms) : 0, 67401
Debugger [candidate] (69.171 ms) : 0, 69171
Remote Config [baseline] (657.348 µs) : 0, 657
Remote Config [candidate] (646.363 µs) : 0, 646
Telemetry [baseline] (9.058 ms) : 0, 9058
Telemetry [candidate] (9.233 ms) : 0, 9233
Flare Poller [baseline] (3.791 ms) : 0, 3791
Flare Poller [candidate] (3.927 ms) : 0, 3927
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (791.843 ms) : 0, 791843
BytebuddyAgent [candidate] (796.785 ms) : 0, 796785
GlobalTracer [baseline] (255.089 ms) : 0, 255089
GlobalTracer [candidate] (256.753 ms) : 0, 256753
IAST [baseline] (27.248 ms) : 0, 27248
IAST [candidate] (27.369 ms) : 0, 27369
AppSec [baseline] (34.424 ms) : 0, 34424
AppSec [candidate] (34.576 ms) : 0, 34576
Debugger [baseline] (65.03 ms) : 0, 65030
Debugger [candidate] (65.137 ms) : 0, 65137
Remote Config [baseline] (584.995 µs) : 0, 585
Remote Config [candidate] (571.709 µs) : 0, 572
Telemetry [baseline] (8.513 ms) : 0, 8513
Telemetry [candidate] (8.611 ms) : 0, 8611
Flare Poller [baseline] (3.596 ms) : 0, 3596
Flare Poller [candidate] (3.565 ms) : 0, 3565
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~22470142cb, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.198 ms) : 1186, 1210
. : milestone, 1198,
iast (3.246 ms) : 3200, 3292
. : milestone, 3246,
iast_FULL (6.136 ms) : 6072, 6200
. : milestone, 6136,
iast_GLOBAL (3.64 ms) : 3581, 3700
. : milestone, 3640,
profiling (2.045 ms) : 2027, 2062
. : milestone, 2045,
tracing (1.864 ms) : 1847, 1880
. : milestone, 1864,
section candidate
no_agent (1.179 ms) : 1167, 1190
. : milestone, 1179,
iast (3.24 ms) : 3201, 3279
. : milestone, 3240,
iast_FULL (5.738 ms) : 5681, 5795
. : milestone, 5738,
iast_GLOBAL (3.722 ms) : 3666, 3778
. : milestone, 3722,
profiling (1.984 ms) : 1967, 2000
. : milestone, 1984,
tracing (1.806 ms) : 1790, 1822
. : milestone, 1806,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~22470142cb, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section baseline
no_agent (19.074 ms) : 18878, 19270
. : milestone, 19074,
appsec (18.316 ms) : 18129, 18503
. : milestone, 18316,
code_origins (17.643 ms) : 17471, 17815
. : milestone, 17643,
iast (17.635 ms) : 17455, 17814
. : milestone, 17635,
profiling (18.475 ms) : 18288, 18662
. : milestone, 18475,
tracing (17.831 ms) : 17656, 18005
. : milestone, 17831,
section candidate
no_agent (18.12 ms) : 17934, 18307
. : milestone, 18120,
appsec (19.754 ms) : 19550, 19958
. : milestone, 19754,
code_origins (18.691 ms) : 18505, 18877
. : milestone, 18691,
iast (17.596 ms) : 17424, 17768
. : milestone, 17596,
profiling (18.581 ms) : 18393, 18769
. : milestone, 18581,
tracing (17.496 ms) : 17325, 17668
. : milestone, 17496,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~22470142cb, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section baseline
no_agent (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
appsec (14.477 s) : 14477000, 14477000
. : milestone, 14477000,
iast (18.342 s) : 18342000, 18342000
. : milestone, 18342000,
iast_GLOBAL (17.854 s) : 17854000, 17854000
. : milestone, 17854000,
profiling (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
tracing (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
section candidate
no_agent (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
appsec (14.733 s) : 14733000, 14733000
. : milestone, 14733000,
iast (18.494 s) : 18494000, 18494000
. : milestone, 18494000,
iast_GLOBAL (17.749 s) : 17749000, 17749000
. : milestone, 17749000,
profiling (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
tracing (14.52 s) : 14520000, 14520000
. : milestone, 14520000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~22470142cb, baseline=1.58.0-SNAPSHOT~a1ce9aec9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.736 ms) : 3516, 3956
. : milestone, 3736,
iast (2.21 ms) : 2145, 2275
. : milestone, 2210,
iast_GLOBAL (2.244 ms) : 2179, 2309
. : milestone, 2244,
profiling (2.09 ms) : 2036, 2144
. : milestone, 2090,
tracing (2.045 ms) : 1994, 2096
. : milestone, 2045,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.667 ms) : 3451, 3883
. : milestone, 3667,
iast (2.203 ms) : 2139, 2268
. : milestone, 2203,
iast_GLOBAL (2.251 ms) : 2186, 2316
. : milestone, 2251,
profiling (2.068 ms) : 2015, 2120
. : milestone, 2068,
tracing (2.045 ms) : 1995, 2096
. : milestone, 2045,
|
bric3
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactor / Move module names to comply with naming specification. Also the plugin logic has been slightly modified to allow leaf containing the parent name chars in any order (it allows having
:apache-httoclient:apache-httpasyncclient-4.0).Also, as special configuration:
-iastsuffixorg-json-20230227from checking (this artifact does not comply to semver..it's the only exception)Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]