Adds crashtracking addresses and error thread name#10984
Open
Adds crashtracking addresses and error thread name#10984
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~9520985a70, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054650
Total [baseline] (11.082 s) : 0, 11081701
Agent [candidate] (1.061 s) : 0, 1061233
Total [candidate] (11.08 s) : 0, 11080103
section appsec
Agent [baseline] (1.252 s) : 0, 1252498
Total [baseline] (11.134 s) : 0, 11133775
Agent [candidate] (1.255 s) : 0, 1254896
Total [candidate] (11.161 s) : 0, 11161173
section iast
Agent [baseline] (1.227 s) : 0, 1226525
Total [baseline] (11.345 s) : 0, 11344529
Agent [candidate] (1.245 s) : 0, 1244650
Total [candidate] (11.363 s) : 0, 11362581
section profiling
Agent [baseline] (1.19 s) : 0, 1189642
Total [baseline] (11.034 s) : 0, 11034169
Agent [candidate] (1.183 s) : 0, 1183161
Total [candidate] (11.012 s) : 0, 11011765
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~9520985a70, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (628.079 ms) : 0, 628079
BytebuddyAgent [candidate] (632.045 ms) : 0, 632045
AgentMeter [baseline] (29.293 ms) : 0, 29293
AgentMeter [candidate] (29.674 ms) : 0, 29674
GlobalTracer [baseline] (256.242 ms) : 0, 256242
GlobalTracer [candidate] (257.681 ms) : 0, 257681
AppSec [baseline] (31.717 ms) : 0, 31717
AppSec [candidate] (31.91 ms) : 0, 31910
Debugger [baseline] (60.061 ms) : 0, 60061
Debugger [candidate] (60.448 ms) : 0, 60448
Remote Config [baseline] (600.017 µs) : 0, 600
Remote Config [candidate] (599.755 µs) : 0, 600
Telemetry [baseline] (8.017 ms) : 0, 8017
Telemetry [candidate] (8.082 ms) : 0, 8082
Flare Poller [baseline] (3.512 ms) : 0, 3512
Flare Poller [candidate] (3.565 ms) : 0, 3565
section appsec
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (662.109 ms) : 0, 662109
BytebuddyAgent [candidate] (664.073 ms) : 0, 664073
AgentMeter [baseline] (12.231 ms) : 0, 12231
AgentMeter [candidate] (12.202 ms) : 0, 12202
GlobalTracer [baseline] (259.183 ms) : 0, 259183
GlobalTracer [candidate] (259.33 ms) : 0, 259330
IAST [baseline] (24.293 ms) : 0, 24293
IAST [candidate] (24.335 ms) : 0, 24335
AppSec [baseline] (177.84 ms) : 0, 177840
AppSec [candidate] (178.145 ms) : 0, 178145
Debugger [baseline] (66.762 ms) : 0, 66762
Debugger [candidate] (66.584 ms) : 0, 66584
Remote Config [baseline] (627.292 µs) : 0, 627
Remote Config [candidate] (632.952 µs) : 0, 633
Telemetry [baseline] (8.316 ms) : 0, 8316
Telemetry [candidate] (8.396 ms) : 0, 8396
Flare Poller [baseline] (3.548 ms) : 0, 3548
Flare Poller [candidate] (3.578 ms) : 0, 3578
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (795.52 ms) : 0, 795520
BytebuddyAgent [candidate] (808.206 ms) : 0, 808206
AgentMeter [baseline] (11.422 ms) : 0, 11422
AgentMeter [candidate] (11.942 ms) : 0, 11942
GlobalTracer [baseline] (246.987 ms) : 0, 246987
GlobalTracer [candidate] (249.677 ms) : 0, 249677
IAST [baseline] (25.314 ms) : 0, 25314
IAST [candidate] (25.728 ms) : 0, 25728
AppSec [baseline] (26.49 ms) : 0, 26490
AppSec [candidate] (26.945 ms) : 0, 26945
Debugger [baseline] (70.548 ms) : 0, 70548
Debugger [candidate] (71.479 ms) : 0, 71479
Remote Config [baseline] (526.123 µs) : 0, 526
Remote Config [candidate] (538.891 µs) : 0, 539
Telemetry [baseline] (9.137 ms) : 0, 9137
Telemetry [candidate] (9.159 ms) : 0, 9159
Flare Poller [baseline] (3.383 ms) : 0, 3383
Flare Poller [candidate] (3.49 ms) : 0, 3490
section profiling
crashtracking [baseline] (1.168 ms) : 0, 1168
crashtracking [candidate] (1.167 ms) : 0, 1167
BytebuddyAgent [baseline] (687.777 ms) : 0, 687777
BytebuddyAgent [candidate] (683.746 ms) : 0, 683746
AgentMeter [baseline] (9.076 ms) : 0, 9076
AgentMeter [candidate] (8.993 ms) : 0, 8993
GlobalTracer [baseline] (216.133 ms) : 0, 216133
GlobalTracer [candidate] (214.855 ms) : 0, 214855
AppSec [baseline] (32.519 ms) : 0, 32519
AppSec [candidate] (32.351 ms) : 0, 32351
Debugger [baseline] (66.281 ms) : 0, 66281
Debugger [candidate] (65.18 ms) : 0, 65180
Remote Config [baseline] (558.103 µs) : 0, 558
Remote Config [candidate] (559.742 µs) : 0, 560
Telemetry [baseline] (7.707 ms) : 0, 7707
Telemetry [candidate] (7.715 ms) : 0, 7715
Flare Poller [baseline] (3.439 ms) : 0, 3439
Flare Poller [candidate] (4.18 ms) : 0, 4180
ProfilingAgent [baseline] (93.728 ms) : 0, 93728
ProfilingAgent [candidate] (93.528 ms) : 0, 93528
Profiling [baseline] (94.291 ms) : 0, 94291
Profiling [candidate] (94.084 ms) : 0, 94084
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~9520985a70, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062005
Total [baseline] (8.844 s) : 0, 8843575
Agent [candidate] (1.057 s) : 0, 1056757
Total [candidate] (8.853 s) : 0, 8852772
section iast
Agent [baseline] (1.227 s) : 0, 1226507
Total [baseline] (9.527 s) : 0, 9526899
Agent [candidate] (1.225 s) : 0, 1225025
Total [candidate] (9.587 s) : 0, 9586752
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~9520985a70, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (633.538 ms) : 0, 633538
BytebuddyAgent [candidate] (629.349 ms) : 0, 629349
AgentMeter [baseline] (29.688 ms) : 0, 29688
AgentMeter [candidate] (29.342 ms) : 0, 29342
GlobalTracer [baseline] (257.134 ms) : 0, 257134
GlobalTracer [candidate] (256.573 ms) : 0, 256573
AppSec [baseline] (31.797 ms) : 0, 31797
AppSec [candidate] (31.805 ms) : 0, 31805
Debugger [baseline] (59.512 ms) : 0, 59512
Debugger [candidate] (59.544 ms) : 0, 59544
Remote Config [baseline] (588.854 µs) : 0, 589
Remote Config [candidate] (586.845 µs) : 0, 587
Telemetry [baseline] (7.978 ms) : 0, 7978
Telemetry [candidate] (7.996 ms) : 0, 7996
Flare Poller [baseline] (4.281 ms) : 0, 4281
Flare Poller [candidate] (4.23 ms) : 0, 4230
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (796.672 ms) : 0, 796672
BytebuddyAgent [candidate] (795.186 ms) : 0, 795186
AgentMeter [baseline] (11.395 ms) : 0, 11395
AgentMeter [candidate] (11.387 ms) : 0, 11387
GlobalTracer [baseline] (246.967 ms) : 0, 246967
GlobalTracer [candidate] (246.74 ms) : 0, 246740
AppSec [baseline] (26.445 ms) : 0, 26445
AppSec [candidate] (26.373 ms) : 0, 26373
Debugger [baseline] (68.793 ms) : 0, 68793
Debugger [candidate] (69.712 ms) : 0, 69712
Remote Config [baseline] (523.894 µs) : 0, 524
Remote Config [candidate] (524.399 µs) : 0, 524
Telemetry [baseline] (9.781 ms) : 0, 9781
Telemetry [candidate] (9.163 ms) : 0, 9163
Flare Poller [baseline] (3.456 ms) : 0, 3456
Flare Poller [candidate] (3.484 ms) : 0, 3484
IAST [baseline] (25.288 ms) : 0, 25288
IAST [candidate] (25.276 ms) : 0, 25276
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~9520985a70, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section baseline
no_agent (1.198 ms) : 1186, 1210
. : milestone, 1198,
iast (3.255 ms) : 3211, 3299
. : milestone, 3255,
iast_FULL (5.871 ms) : 5812, 5931
. : milestone, 5871,
iast_GLOBAL (3.413 ms) : 3360, 3467
. : milestone, 3413,
profiling (2.021 ms) : 2003, 2038
. : milestone, 2021,
tracing (1.826 ms) : 1809, 1842
. : milestone, 1826,
section candidate
no_agent (1.178 ms) : 1166, 1190
. : milestone, 1178,
iast (3.219 ms) : 3174, 3264
. : milestone, 3219,
iast_FULL (5.865 ms) : 5807, 5923
. : milestone, 5865,
iast_GLOBAL (3.471 ms) : 3413, 3529
. : milestone, 3471,
profiling (2.236 ms) : 2217, 2256
. : milestone, 2236,
tracing (1.769 ms) : 1755, 1784
. : milestone, 1769,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~9520985a70, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section baseline
no_agent (17.735 ms) : 17560, 17909
. : milestone, 17735,
appsec (18.481 ms) : 18292, 18670
. : milestone, 18481,
code_origins (18.609 ms) : 18424, 18794
. : milestone, 18609,
iast (17.833 ms) : 17659, 18008
. : milestone, 17833,
profiling (19.702 ms) : 19508, 19896
. : milestone, 19702,
tracing (18.023 ms) : 17838, 18209
. : milestone, 18023,
section candidate
no_agent (17.909 ms) : 17722, 18096
. : milestone, 17909,
appsec (18.526 ms) : 18337, 18715
. : milestone, 18526,
code_origins (18.781 ms) : 18592, 18970
. : milestone, 18781,
iast (17.638 ms) : 17462, 17813
. : milestone, 17638,
profiling (18.726 ms) : 18537, 18915
. : milestone, 18726,
tracing (18.803 ms) : 18616, 18991
. : milestone, 18803,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~9520985a70, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.799 ms) : 3579, 4019
. : milestone, 3799,
iast (2.25 ms) : 2181, 2319
. : milestone, 2250,
iast_GLOBAL (2.297 ms) : 2228, 2367
. : milestone, 2297,
profiling (2.111 ms) : 2053, 2168
. : milestone, 2111,
tracing (2.067 ms) : 2013, 2120
. : milestone, 2067,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (3.784 ms) : 3563, 4006
. : milestone, 3784,
iast (2.259 ms) : 2190, 2328
. : milestone, 2259,
iast_GLOBAL (2.299 ms) : 2230, 2369
. : milestone, 2299,
profiling (2.083 ms) : 2028, 2138
. : milestone, 2083,
tracing (2.065 ms) : 2011, 2119
. : milestone, 2065,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~9520985a70, baseline=1.61.0-SNAPSHOT~517a89d1ec3
dateFormat X
axisFormat %s
section baseline
no_agent (15.522 s) : 15522000, 15522000
. : milestone, 15522000,
appsec (14.801 s) : 14801000, 14801000
. : milestone, 14801000,
iast (17.982 s) : 17982000, 17982000
. : milestone, 17982000,
iast_GLOBAL (17.939 s) : 17939000, 17939000
. : milestone, 17939000,
profiling (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
tracing (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
section candidate
no_agent (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
appsec (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
iast (18.183 s) : 18183000, 18183000
. : milestone, 18183000,
iast_GLOBAL (17.527 s) : 17527000, 17527000
. : milestone, 17527000,
profiling (15.788 s) : 15788000, 15788000
. : milestone, 15788000,
tracing (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
The hotspot crash logs missed some useful addresses and were missing the thread name that crashed
https://github.com/DataDog/libdatadog/blob/main/docs/RFCs/0011-crashtracker-structured-log-format-V1_X.md
Moreover, this PR fixes some frames that were incorrectly parsed.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.