Skip to content

Add a smoke test for Gradle Launcher instrumentation #8014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikita-tkachenko-datadog merged 4 commits into from
Nov 26, 2024
Merged

Add a smoke test for Gradle Launcher instrumentation #8014

nikita-tkachenko-datadog merged 4 commits into from
Nov 26, 2024

Conversation

@nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Nov 25, 2024 •
edited by atlassian bot
Loading

What Does This Do

Adds a smoke test for Gradle Launcher instrumentation.
The test runs Gradle Launcher with the Java Tracer injected and verifies that the tracer is injected into the Gradle Daemon.

Contributor Checklist

Jira ticket: STV-15

@nikita-tkachenko-datadog nikita-tkachenko-datadog added comp: testing Testing tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility run-tests: all Run all tests labels Nov 25, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 25, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/gradle-launcher-smoke-test
git_commit_date 1732641502 1732649148
git_commit_sha ac4977a d9e656e
release_version 1.44.0-SNAPSHOT~ac4977af17 1.44.0-SNAPSHOT~d9e656ed04
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732651459 1732651459
ci_job_id 721248687 721248687
ci_pipeline_id 50009893 50009893
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~d9e656ed04, baseline=1.44.0-SNAPSHOT~ac4977af17

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1100112
Total [baseline] (10.492 s) : 0, 10492231
Agent [candidate] (1.104 s) : 0, 1104104
Total [candidate] (10.46 s) : 0, 10460319
section appsec
Agent [baseline] (1.234 s) : 0, 1233751
Total [baseline] (10.753 s) : 0, 10753384
Agent [candidate] (1.226 s) : 0, 1226178
Total [candidate] (10.764 s) : 0, 10764282
section iast
Agent [baseline] (1.22 s) : 0, 1219625
Total [baseline] (10.912 s) : 0, 10911698
Agent [candidate] (1.22 s) : 0, 1220083
Total [candidate] (10.913 s) : 0, 10913058
section profiling
Agent [baseline] (1.313 s) : 0, 1312637
Total [baseline] (10.807 s) : 0, 10807452
Agent [candidate] (1.325 s) : 0, 1325076
Total [candidate] (10.806 s) : 0, 10805663
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.1 s -
Agent appsec 1.234 s 133.639 ms (12.1%)
Agent iast 1.22 s 119.513 ms (10.9%)
Agent profiling 1.313 s 212.525 ms (19.3%)
Total tracing 10.492 s -
Total appsec 10.753 s 261.154 ms (2.5%)
Total iast 10.912 s 419.467 ms (4.0%)
Total profiling 10.807 s 315.221 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.104 s -
Agent appsec 1.226 s 122.073 ms (11.1%)
Agent iast 1.22 s 115.979 ms (10.5%)
Agent profiling 1.325 s 220.972 ms (20.0%)
Total tracing 10.46 s -
Total appsec 10.764 s 303.962 ms (2.9%)
Total iast 10.913 s 452.739 ms (4.3%)
Total profiling 10.806 s 345.343 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~d9e656ed04, baseline=1.44.0-SNAPSHOT~ac4977af17

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.333 ms) : 0, 698333
BytebuddyAgent [candidate] (703.416 ms) : 0, 703416
GlobalTracer [baseline] (320.13 ms) : 0, 320130
GlobalTracer [candidate] (321.655 ms) : 0, 321655
AppSec [baseline] (55.136 ms) : 0, 55136
AppSec [candidate] (55.131 ms) : 0, 55131
Remote Config [baseline] (684.954 µs) : 0, 685
Remote Config [candidate] (690.181 µs) : 0, 690
Telemetry [baseline] (11.988 ms) : 0, 11988
Telemetry [candidate] (9.306 ms) : 0, 9306
section appsec
BytebuddyAgent [baseline] (715.811 ms) : 0, 715811
BytebuddyAgent [candidate] (711.407 ms) : 0, 711407
GlobalTracer [baseline] (317.177 ms) : 0, 317177
GlobalTracer [candidate] (314.867 ms) : 0, 314867
AppSec [baseline] (167.325 ms) : 0, 167325
AppSec [candidate] (167.893 ms) : 0, 167893
Remote Config [baseline] (653.579 µs) : 0, 654
Remote Config [candidate] (651.501 µs) : 0, 652
Telemetry [baseline] (8.615 ms) : 0, 8615
Telemetry [candidate] (8.203 ms) : 0, 8203
IAST [baseline] (20.704 ms) : 0, 20704
IAST [candidate] (18.879 ms) : 0, 18879
section iast
BytebuddyAgent [baseline] (812.031 ms) : 0, 812031
BytebuddyAgent [candidate] (811.525 ms) : 0, 811525
GlobalTracer [baseline] (306.656 ms) : 0, 306656
GlobalTracer [candidate] (307.434 ms) : 0, 307434
AppSec [baseline] (57.412 ms) : 0, 57412
AppSec [candidate] (57.456 ms) : 0, 57456
Remote Config [baseline] (628.267 µs) : 0, 628
Remote Config [candidate] (628.358 µs) : 0, 628
Telemetry [baseline] (7.548 ms) : 0, 7548
Telemetry [candidate] (7.568 ms) : 0, 7568
IAST [baseline] (21.613 ms) : 0, 21613
IAST [candidate] (21.739 ms) : 0, 21739
section profiling
BytebuddyAgent [baseline] (685.632 ms) : 0, 685632
BytebuddyAgent [candidate] (693.616 ms) : 0, 693616
GlobalTracer [baseline] (433.427 ms) : 0, 433427
GlobalTracer [candidate] (435.63 ms) : 0, 435630
AppSec [baseline] (53.586 ms) : 0, 53586
AppSec [candidate] (53.588 ms) : 0, 53588
Remote Config [baseline] (666.897 µs) : 0, 667
Remote Config [candidate] (654.712 µs) : 0, 655
Telemetry [baseline] (7.685 ms) : 0, 7685
Telemetry [candidate] (7.76 ms) : 0, 7760
ProfilingAgent [baseline] (92.704 ms) : 0, 92704
ProfilingAgent [candidate] (94.395 ms) : 0, 94395
Profiling [baseline] (92.727 ms) : 0, 92727
Profiling [candidate] (94.42 ms) : 0, 94420
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~d9e656ed04, baseline=1.44.0-SNAPSHOT~ac4977af17

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101348
Total [baseline] (8.714 s) : 0, 8713678
Agent [candidate] (1.091 s) : 0, 1091182
Total [candidate] (8.678 s) : 0, 8678362
section iast
Agent [baseline] (1.219 s) : 0, 1219347
Total [baseline] (9.191 s) : 0, 9190724
Agent [candidate] (1.219 s) : 0, 1218934
Total [candidate] (9.229 s) : 0, 9228635
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.239 s) : 0, 1238649
Total [baseline] (9.265 s) : 0, 9264531
Agent [candidate] (1.219 s) : 0, 1219027
Total [candidate] (9.156 s) : 0, 9156358
section iast_TELEMETRY_OFF
Agent [baseline] (1.217 s) : 0, 1217221
Total [baseline] (9.201 s) : 0, 9201224
Agent [candidate] (1.216 s) : 0, 1215756
Total [candidate] (9.192 s) : 0, 9191843
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.101 s -
Agent iast 1.219 s 117.999 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.239 s 137.301 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.217 s 115.873 ms (10.5%)
Total tracing 8.714 s -
Total iast 9.191 s 477.046 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.265 s 550.853 ms (6.3%)
Total iast_TELEMETRY_OFF 9.201 s 487.546 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.219 s 127.752 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.219 s 127.845 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.216 s 124.574 ms (11.4%)
Total tracing 8.678 s -
Total iast 9.229 s 550.273 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.156 s 477.997 ms (5.5%)
Total iast_TELEMETRY_OFF 9.192 s 513.481 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~d9e656ed04, baseline=1.44.0-SNAPSHOT~ac4977af17

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (700.135 ms) : 0, 700135
BytebuddyAgent [candidate] (694.184 ms) : 0, 694184
GlobalTracer [baseline] (322.367 ms) : 0, 322367
GlobalTracer [candidate] (318.099 ms) : 0, 318098
AppSec [baseline] (55.12 ms) : 0, 55120
AppSec [candidate] (54.661 ms) : 0, 54661
Remote Config [baseline] (696.218 µs) : 0, 696
Remote Config [candidate] (676.655 µs) : 0, 677
Telemetry [baseline] (9.186 ms) : 0, 9186
Telemetry [candidate] (9.804 ms) : 0, 9804
section iast
BytebuddyAgent [baseline] (812.021 ms) : 0, 812021
BytebuddyAgent [candidate] (811.372 ms) : 0, 811372
GlobalTracer [baseline] (306.853 ms) : 0, 306853
GlobalTracer [candidate] (306.798 ms) : 0, 306798
AppSec [baseline] (56.877 ms) : 0, 56877
AppSec [candidate] (57.225 ms) : 0, 57225
Remote Config [baseline] (623.303 µs) : 0, 623
Remote Config [candidate] (646.359 µs) : 0, 646
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.574 ms) : 0, 7574
IAST [baseline] (21.655 ms) : 0, 21655
IAST [candidate] (21.541 ms) : 0, 21541
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (823.882 ms) : 0, 823882
BytebuddyAgent [candidate] (811.517 ms) : 0, 811517
GlobalTracer [baseline] (312.352 ms) : 0, 312352
GlobalTracer [candidate] (306.701 ms) : 0, 306701
AppSec [baseline] (58.91 ms) : 0, 58910
AppSec [candidate] (57.125 ms) : 0, 57125
Remote Config [baseline] (653.34 µs) : 0, 653
Remote Config [candidate] (649.467 µs) : 0, 649
Telemetry [baseline] (7.707 ms) : 0, 7707
Telemetry [candidate] (7.543 ms) : 0, 7543
IAST [baseline] (21.201 ms) : 0, 21201
IAST [candidate] (21.733 ms) : 0, 21733
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (809.844 ms) : 0, 809844
BytebuddyAgent [candidate] (808.8 ms) : 0, 808800
GlobalTracer [baseline] (306.848 ms) : 0, 306848
GlobalTracer [candidate] (306.943 ms) : 0, 306943
AppSec [baseline] (58.252 ms) : 0, 58252
AppSec [candidate] (57.837 ms) : 0, 57837
Remote Config [baseline] (622.319 µs) : 0, 622
Remote Config [candidate] (640.819 µs) : 0, 641
Telemetry [baseline] (7.428 ms) : 0, 7428
Telemetry [candidate] (7.435 ms) : 0, 7435
IAST [baseline] (20.472 ms) : 0, 20472
IAST [candidate] (20.339 ms) : 0, 20339
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-26T19:36:29 2024-11-26T19:43:29
git_branch master nikita-tkachenko/gradle-launcher-smoke-test
git_commit_date 1732641502 1732649148
git_commit_sha ac4977a d9e656e
release_version 1.44.0-SNAPSHOT~ac4977af17 1.44.0-SNAPSHOT~d9e656ed04
start_time 2024-11-26T19:36:16 2024-11-26T19:43:16
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732650563 1732650563
ci_job_id 721248688 721248688
ci_pipeline_id 50009893 50009893
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~d9e656ed04, baseline=1.44.0-SNAPSHOT~ac4977af17
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.795 µs) : 363, 404
.   : milestone, 384,
iast (493.125 µs) : 472, 515
.   : milestone, 493,
iast_FULL (650.361 µs) : 629, 672
.   : milestone, 650,
iast_GLOBAL (529.053 µs) : 507, 551
.   : milestone, 529,
iast_HARDCODED_SECRET_DISABLED (491.826 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (455.957 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (492.07 µs) : 470, 514
.   : milestone, 492,
tracing (454.027 µs) : 433, 475
.   : milestone, 454,
section candidate
no_agent (381.343 µs) : 362, 401
.   : milestone, 381,
iast (487.907 µs) : 466, 509
.   : milestone, 488,
iast_FULL (658.2 µs) : 637, 680
.   : milestone, 658,
iast_GLOBAL (534.581 µs) : 511, 558
.   : milestone, 535,
iast_HARDCODED_SECRET_DISABLED (497.549 µs) : 476, 519
.   : milestone, 498,
iast_INACTIVE (450.22 µs) : 430, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (481.875 µs) : 461, 503
.   : milestone, 482,
tracing (453.582 µs) : 433, 474
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.795 µs [363.496 µs, 404.093 µs] -
iast 493.125 µs [471.693 µs, 514.557 µs] 109.33 µs (28.5%)
iast_FULL 650.361 µs [628.88 µs, 671.841 µs] 266.566 µs (69.5%)
iast_GLOBAL 529.053 µs [507.288 µs, 550.818 µs] 145.258 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 491.826 µs [470.755 µs, 512.897 µs] 108.031 µs (28.1%)
iast_INACTIVE 455.957 µs [434.655 µs, 477.259 µs] 72.162 µs (18.8%)
iast_TELEMETRY_OFF 492.07 µs [470.284 µs, 513.855 µs] 108.275 µs (28.2%)
tracing 454.027 µs [433.076 µs, 474.977 µs] 70.232 µs (18.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.343 µs [361.555 µs, 401.132 µs] -
iast 487.907 µs [466.439 µs, 509.375 µs] 106.564 µs (27.9%)
iast_FULL 658.2 µs [636.737 µs, 679.662 µs] 276.856 µs (72.6%)
iast_GLOBAL 534.581 µs [510.963 µs, 558.2 µs] 153.238 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED 497.549 µs [476.002 µs, 519.097 µs] 116.206 µs (30.5%)
iast_INACTIVE 450.22 µs [429.516 µs, 470.923 µs] 68.876 µs (18.1%)
iast_TELEMETRY_OFF 481.875 µs [460.584 µs, 503.165 µs] 100.531 µs (26.4%)
tracing 453.582 µs [432.801 µs, 474.362 µs] 72.238 µs (18.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~d9e656ed04, baseline=1.44.0-SNAPSHOT~ac4977af17
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1373
.   : milestone, 1354,
appsec (1.755 ms) : 1730, 1780
.   : milestone, 1755,
appsec_no_iast (1.731 ms) : 1705, 1757
.   : milestone, 1731,
iast (1.486 ms) : 1464, 1509
.   : milestone, 1486,
profiling (1.549 ms) : 1524, 1574
.   : milestone, 1549,
tracing (1.502 ms) : 1478, 1527
.   : milestone, 1502,
section candidate
no_agent (1.358 ms) : 1338, 1377
.   : milestone, 1358,
appsec (1.748 ms) : 1723, 1773
.   : milestone, 1748,
appsec_no_iast (1.757 ms) : 1732, 1782
.   : milestone, 1757,
iast (1.481 ms) : 1457, 1504
.   : milestone, 1481,
profiling (1.531 ms) : 1504, 1557
.   : milestone, 1531,
tracing (1.516 ms) : 1491, 1541
.   : milestone, 1516,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.334 ms, 1.373 ms] -
appsec 1.755 ms [1.73 ms, 1.78 ms] 401.121 µs (29.6%)
appsec_no_iast 1.731 ms [1.705 ms, 1.757 ms] 377.103 µs (27.9%)
iast 1.486 ms [1.464 ms, 1.509 ms] 132.538 µs (9.8%)
profiling 1.549 ms [1.524 ms, 1.574 ms] 195.218 µs (14.4%)
tracing 1.502 ms [1.478 ms, 1.527 ms] 148.439 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.338 ms, 1.377 ms] -
appsec 1.748 ms [1.723 ms, 1.773 ms] 390.516 µs (28.8%)
appsec_no_iast 1.757 ms [1.732 ms, 1.782 ms] 399.276 µs (29.4%)
iast 1.481 ms [1.457 ms, 1.504 ms] 122.789 µs (9.0%)
profiling 1.531 ms [1.504 ms, 1.557 ms] 172.881 µs (12.7%)
tracing 1.516 ms [1.491 ms, 1.541 ms] 158.05 µs (11.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/gradle-launcher-smoke-test
git_commit_date 1732641502 1732649148
git_commit_sha ac4977a d9e656e
release_version 1.44.0-SNAPSHOT~ac4977af17 1.44.0-SNAPSHOT~d9e656ed04
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732651123 1732651123
ci_job_id 721248689 721248689
ci_pipeline_id 50009893 50009893
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~d9e656ed04, baseline=1.44.0-SNAPSHOT~ac4977af17
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
appsec (14.869 s) : 14869000, 14869000
.   : milestone, 14869000,
iast (18.984 s) : 18984000, 18984000
.   : milestone, 18984000,
iast_GLOBAL (17.729 s) : 17729000, 17729000
.   : milestone, 17729000,
profiling (15.167 s) : 15167000, 15167000
.   : milestone, 15167000,
tracing (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,
section candidate
no_agent (15.426 s) : 15426000, 15426000
.   : milestone, 15426000,
appsec (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
iast (18.772 s) : 18772000, 18772000
.   : milestone, 18772000,
iast_GLOBAL (17.799 s) : 17799000, 17799000
.   : milestone, 17799000,
profiling (15.701 s) : 15701000, 15701000
.   : milestone, 15701000,
tracing (15.085 s) : 15085000, 15085000
.   : milestone, 15085000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.023 s [15.023 s, 15.023 s] -
appsec 14.869 s [14.869 s, 14.869 s] -154.0 ms (-1.0%)
iast 18.984 s [18.984 s, 18.984 s] 3.961 s (26.4%)
iast_GLOBAL 17.729 s [17.729 s, 17.729 s] 2.706 s (18.0%)
profiling 15.167 s [15.167 s, 15.167 s] 144.0 ms (1.0%)
tracing 14.912 s [14.912 s, 14.912 s] -111.0 ms (-0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.426 s [15.426 s, 15.426 s] -
appsec 15.052 s [15.052 s, 15.052 s] -374.0 ms (-2.4%)
iast 18.772 s [18.772 s, 18.772 s] 3.346 s (21.7%)
iast_GLOBAL 17.799 s [17.799 s, 17.799 s] 2.373 s (15.4%)
profiling 15.701 s [15.701 s, 15.701 s] 275.0 ms (1.8%)
tracing 15.085 s [15.085 s, 15.085 s] -341.0 ms (-2.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~d9e656ed04, baseline=1.44.0-SNAPSHOT~ac4977af17
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.347 ms) : 2306, 2388
.   : milestone, 2347,
iast (2.088 ms) : 2036, 2141
.   : milestone, 2088,
iast_GLOBAL (2.133 ms) : 2079, 2186
.   : milestone, 2133,
profiling (1.967 ms) : 1924, 2010
.   : milestone, 1967,
tracing (1.934 ms) : 1894, 1974
.   : milestone, 1934,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.346 ms) : 2305, 2388
.   : milestone, 2346,
iast (2.084 ms) : 2032, 2137
.   : milestone, 2084,
iast_GLOBAL (2.121 ms) : 2068, 2173
.   : milestone, 2121,
profiling (1.954 ms) : 1912, 1996
.   : milestone, 1954,
tracing (1.932 ms) : 1892, 1972
.   : milestone, 1932,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 2.347 ms [2.306 ms, 2.388 ms] 876.742 µs (59.6%)
iast 2.088 ms [2.036 ms, 2.141 ms] 618.085 µs (42.0%)
iast_GLOBAL 2.133 ms [2.079 ms, 2.186 ms] 662.278 µs (45.0%)
profiling 1.967 ms [1.924 ms, 2.01 ms] 496.933 µs (33.8%)
tracing 1.934 ms [1.894 ms, 1.974 ms] 463.51 µs (31.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.346 ms [2.305 ms, 2.388 ms] 878.611 µs (59.9%)
iast 2.084 ms [2.032 ms, 2.137 ms] 616.589 µs (42.0%)
iast_GLOBAL 2.121 ms [2.068 ms, 2.173 ms] 652.92 µs (44.5%)
profiling 1.954 ms [1.912 ms, 1.996 ms] 486.413 µs (33.1%)
tracing 1.932 ms [1.892 ms, 1.972 ms] 464.236 µs (31.6%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review November 25, 2024 16:01
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner November 25, 2024 16:01
PerfectSlayer
PerfectSlayer approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding more tests

dd-smoke-tests/gradle/src/test/groovy/datadog/smoketest/GradleDaemonSmokeTest.groovy Outdated
import org.gradle.wrapper.WrapperConfiguration
import org.junit.jupiter.api.Assumptions
import spock.lang.AutoCleanup
import org.gradle.wrapper.*
Copy link
Contributor

@PerfectSlayer PerfectSlayer Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid using wildcard imports? (it's weird spotless did not complained about it)

Copy link
Contributor Author

@nikita-tkachenko-datadog nikita-tkachenko-datadog Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird indeed, given that I have Intellij set up to use individual imports. Fixed now

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 983bf0f into master Nov 26, 2024
161 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/gradle-launcher-smoke-test branch November 26, 2024 20:26
@github-actions github-actions bot added this to the 1.44.0 milestone Nov 26, 2024
PerfectSlayer pushed a commit that referenced this pull request Nov 28, 2024
@nikita-tkachenko-datadog @PerfectSlayer
Add a smoke test for Gradle Launcher instrumentation (#8014)
78f6bab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@tonyredondo tonyredondo Awaiting requested review from tonyredondo tonyredondo is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility comp: testing Testing run-tests: all Run all tests tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.44.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nikita-tkachenko-datadog @PerfectSlayer