Skip to content

Skip spotless on check_* jobs #8101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smola merged 3 commits into from
Jan 20, 2025
Merged

Skip spotless on check_* jobs #8101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d1ad1
[ci] Skip spotless on check_* jobs
smola Dec 17, 2024
80745c3
Merge branch 'master' into smola/check-no-spotless
smola Jan 16, 2025
a7da99d
Merge branch 'master' into smola/check-no-spotless
smola Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.continue.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ jobs:
-PgitBaseRef=origin/{{ pr_base_ref }}
{% endif %}
-PrunBuildSrcTests
-PskipSpotless
-PtaskPartitionCount=${CIRCLE_NODE_TOTAL} -PtaskPartition=${CIRCLE_NODE_INDEX}
<< pipeline.parameters.gradle_flags >>
--max-workers=8
Expand Down
7 changes: 7 additions & 0 deletions gradle/spotless.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ def configPath = rootProject.hasProperty('sharedConfigDirectory') ? sharedConfig
boolean groovySkipJavaExclude = project.hasProperty('groovySkipJavaExclude') ? groovySkipJavaExclude : false

spotless {

if (rootProject.hasProperty('skipSpotless')) {
// Spotless in JDK 8 uses an older eclipse formatter, and it has a (flaky) bug crashing check_profiling.
// We disable it in CI, since we have a job dedicated to spotless anyway.
enforceCheck false
}

if (project.plugins.hasPlugin('java')) {
java {
toggleOffOn()
Expand Down
Loading