-
Notifications
You must be signed in to change notification settings - Fork 323
Exclude flaky errors from error log checks #8123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc6f306 to
dac2889
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~7f02a02aa4, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061708
Total [baseline] (8.63 s) : 0, 8629684
Agent [candidate] (1.063 s) : 0, 1063286
Total [candidate] (8.61 s) : 0, 8610148
section iast
Agent [baseline] (1.187 s) : 0, 1187082
Total [baseline] (9.175 s) : 0, 9174584
Agent [candidate] (1.189 s) : 0, 1188676
Total [candidate] (9.221 s) : 0, 9221391
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1186458
Total [baseline] (9.168 s) : 0, 9168226
Agent [candidate] (1.19 s) : 0, 1190320
Total [candidate] (9.197 s) : 0, 9197188
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1175560
Total [baseline] (9.163 s) : 0, 9162933
Agent [candidate] (1.187 s) : 0, 1187291
Total [candidate] (9.188 s) : 0, 9188229
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~7f02a02aa4, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.806 ms) : 0, 717806
BytebuddyAgent [candidate] (718.361 ms) : 0, 718361
GlobalTracer [baseline] (257.837 ms) : 0, 257837
GlobalTracer [candidate] (258.859 ms) : 0, 258859
AppSec [baseline] (56.852 ms) : 0, 56852
AppSec [candidate] (55.903 ms) : 0, 55903
Remote Config [baseline] (727.23 µs) : 0, 727
Remote Config [candidate] (733.916 µs) : 0, 734
Telemetry [baseline] (13.374 ms) : 0, 13374
Telemetry [candidate] (14.337 ms) : 0, 14337
section iast
BytebuddyAgent [baseline] (835.35 ms) : 0, 835350
BytebuddyAgent [candidate] (836.406 ms) : 0, 836406
GlobalTracer [baseline] (247.656 ms) : 0, 247656
GlobalTracer [candidate] (248.147 ms) : 0, 248147
AppSec [baseline] (58.547 ms) : 0, 58547
AppSec [candidate] (58.361 ms) : 0, 58361
IAST [baseline] (21.24 ms) : 0, 21240
IAST [candidate] (21.424 ms) : 0, 21424
Remote Config [baseline] (672.683 µs) : 0, 673
Remote Config [candidate] (660.344 µs) : 0, 660
Telemetry [baseline] (8.584 ms) : 0, 8584
Telemetry [candidate] (8.616 ms) : 0, 8616
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.081 ms) : 0, 835081
BytebuddyAgent [candidate] (837.425 ms) : 0, 837425
GlobalTracer [baseline] (247.387 ms) : 0, 247387
GlobalTracer [candidate] (248.517 ms) : 0, 248517
AppSec [baseline] (58.27 ms) : 0, 58270
AppSec [candidate] (58.495 ms) : 0, 58495
IAST [baseline] (21.358 ms) : 0, 21358
IAST [candidate] (21.399 ms) : 0, 21399
Remote Config [baseline] (656.131 µs) : 0, 656
Remote Config [candidate] (671.95 µs) : 0, 672
Telemetry [baseline] (8.616 ms) : 0, 8616
Telemetry [candidate] (8.687 ms) : 0, 8687
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.179 ms) : 0, 827179
BytebuddyAgent [candidate] (835.46 ms) : 0, 835460
GlobalTracer [baseline] (245.982 ms) : 0, 245982
GlobalTracer [candidate] (248.695 ms) : 0, 248695
AppSec [baseline] (57.763 ms) : 0, 57763
AppSec [candidate] (57.993 ms) : 0, 57993
IAST [baseline] (20.642 ms) : 0, 20642
IAST [candidate] (20.819 ms) : 0, 20819
Remote Config [baseline] (640.307 µs) : 0, 640
Remote Config [candidate] (667.455 µs) : 0, 667
Telemetry [baseline] (8.34 ms) : 0, 8340
Telemetry [candidate] (8.494 ms) : 0, 8494
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~7f02a02aa4, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056235
Total [baseline] (10.485 s) : 0, 10485224
Agent [candidate] (1.052 s) : 0, 1051749
Total [candidate] (10.396 s) : 0, 10396218
section appsec
Agent [baseline] (1.191 s) : 0, 1190561
Total [baseline] (10.743 s) : 0, 10742960
Agent [candidate] (1.191 s) : 0, 1190746
Total [candidate] (10.658 s) : 0, 10657838
section iast
Agent [baseline] (1.185 s) : 0, 1184674
Total [baseline] (10.951 s) : 0, 10950510
Agent [candidate] (1.183 s) : 0, 1183081
Total [candidate] (10.958 s) : 0, 10958357
section profiling
Agent [baseline] (1.295 s) : 0, 1294939
Total [baseline] (10.84 s) : 0, 10839979
Agent [candidate] (1.284 s) : 0, 1284299
Total [candidate] (10.943 s) : 0, 10943079
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~7f02a02aa4, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.803 ms) : 0, 713803
BytebuddyAgent [candidate] (713.03 ms) : 0, 713030
GlobalTracer [baseline] (256.05 ms) : 0, 256050
GlobalTracer [candidate] (255.61 ms) : 0, 255610
AppSec [baseline] (56.274 ms) : 0, 56274
AppSec [candidate] (55.34 ms) : 0, 55340
Remote Config [baseline] (725.347 µs) : 0, 725
Remote Config [candidate] (725.04 µs) : 0, 725
Telemetry [baseline] (14.318 ms) : 0, 14318
Telemetry [candidate] (11.932 ms) : 0, 11932
section appsec
BytebuddyAgent [baseline] (732.085 ms) : 0, 732085
BytebuddyAgent [candidate] (732.66 ms) : 0, 732660
GlobalTracer [baseline] (254.066 ms) : 0, 254066
GlobalTracer [candidate] (253.786 ms) : 0, 253786
AppSec [baseline] (170.886 ms) : 0, 170886
AppSec [candidate] (169.911 ms) : 0, 169911
Remote Config [baseline] (670.187 µs) : 0, 670
Remote Config [candidate] (653.51 µs) : 0, 654
Telemetry [baseline] (8.005 ms) : 0, 8005
Telemetry [candidate] (8.277 ms) : 0, 8277
IAST [baseline] (19.653 ms) : 0, 19653
IAST [candidate] (20.722 ms) : 0, 20722
section iast
BytebuddyAgent [baseline] (835.118 ms) : 0, 835118
BytebuddyAgent [candidate] (832.907 ms) : 0, 832907
GlobalTracer [baseline] (246.239 ms) : 0, 246239
GlobalTracer [candidate] (246.976 ms) : 0, 246976
AppSec [baseline] (57.927 ms) : 0, 57927
AppSec [candidate] (58.038 ms) : 0, 58038
Remote Config [baseline] (662.332 µs) : 0, 662
Remote Config [candidate] (670.094 µs) : 0, 670
Telemetry [baseline] (8.538 ms) : 0, 8538
Telemetry [candidate] (8.499 ms) : 0, 8499
IAST [baseline] (21.128 ms) : 0, 21128
IAST [candidate] (20.934 ms) : 0, 20934
section profiling
BytebuddyAgent [baseline] (716.177 ms) : 0, 716177
BytebuddyAgent [candidate] (707.54 ms) : 0, 707540
GlobalTracer [baseline] (376.115 ms) : 0, 376115
GlobalTracer [candidate] (374.879 ms) : 0, 374879
AppSec [baseline] (54.452 ms) : 0, 54452
AppSec [candidate] (54.501 ms) : 0, 54501
Remote Config [baseline] (669.386 µs) : 0, 669
Remote Config [candidate] (662.971 µs) : 0, 663
Telemetry [baseline] (7.923 ms) : 0, 7923
Telemetry [candidate] (7.959 ms) : 0, 7959
ProfilingAgent [baseline] (96.946 ms) : 0, 96946
ProfilingAgent [candidate] (96.607 ms) : 0, 96607
Profiling [baseline] (96.97 ms) : 0, 96970
Profiling [candidate] (96.631 ms) : 0, 96631
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~7f02a02aa4, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section baseline
no_agent (373.024 µs) : 353, 393
. : milestone, 373,
iast (492.133 µs) : 471, 514
. : milestone, 492,
iast_FULL (654.481 µs) : 633, 676
. : milestone, 654,
iast_GLOBAL (526.891 µs) : 505, 549
. : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (490.549 µs) : 469, 512
. : milestone, 491,
iast_INACTIVE (459.995 µs) : 438, 482
. : milestone, 460,
iast_TELEMETRY_OFF (486.725 µs) : 465, 509
. : milestone, 487,
tracing (453.3 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (376.165 µs) : 356, 396
. : milestone, 376,
iast (498.978 µs) : 477, 521
. : milestone, 499,
iast_FULL (659.342 µs) : 638, 681
. : milestone, 659,
iast_GLOBAL (525.907 µs) : 504, 548
. : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (498.481 µs) : 477, 520
. : milestone, 498,
iast_INACTIVE (459.116 µs) : 438, 480
. : milestone, 459,
iast_TELEMETRY_OFF (482.926 µs) : 461, 505
. : milestone, 483,
tracing (459.248 µs) : 438, 480
. : milestone, 459,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~7f02a02aa4, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.747 ms) : 1724, 1771
. : milestone, 1747,
appsec_no_iast (1.748 ms) : 1723, 1773
. : milestone, 1748,
iast (1.504 ms) : 1480, 1527
. : milestone, 1504,
profiling (1.516 ms) : 1493, 1540
. : milestone, 1516,
tracing (1.499 ms) : 1474, 1524
. : milestone, 1499,
section candidate
no_agent (1.348 ms) : 1328, 1367
. : milestone, 1348,
appsec (1.747 ms) : 1723, 1772
. : milestone, 1747,
appsec_no_iast (1.766 ms) : 1742, 1790
. : milestone, 1766,
iast (1.491 ms) : 1468, 1515
. : milestone, 1491,
profiling (1.514 ms) : 1489, 1540
. : milestone, 1514,
tracing (1.497 ms) : 1472, 1521
. : milestone, 1497,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~7f02a02aa4, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section baseline
no_agent (15.112 s) : 15112000, 15112000
. : milestone, 15112000,
appsec (14.743 s) : 14743000, 14743000
. : milestone, 14743000,
iast (18.631 s) : 18631000, 18631000
. : milestone, 18631000,
iast_GLOBAL (17.875 s) : 17875000, 17875000
. : milestone, 17875000,
profiling (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
tracing (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
section candidate
no_agent (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
appsec (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
iast (19.1 s) : 19100000, 19100000
. : milestone, 19100000,
iast_GLOBAL (17.659 s) : 17659000, 17659000
. : milestone, 17659000,
profiling (15.081 s) : 15081000, 15081000
. : milestone, 15081000,
tracing (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~7f02a02aa4, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.369 ms) : 2326, 2411
. : milestone, 2369,
iast (2.13 ms) : 2076, 2184
. : milestone, 2130,
iast_GLOBAL (2.167 ms) : 2112, 2221
. : milestone, 2167,
profiling (1.988 ms) : 1944, 2033
. : milestone, 1988,
tracing (1.947 ms) : 1906, 1989
. : milestone, 1947,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.374 ms) : 2332, 2417
. : milestone, 2374,
iast (2.115 ms) : 2061, 2169
. : milestone, 2115,
iast_GLOBAL (2.16 ms) : 2106, 2214
. : milestone, 2160,
profiling (1.98 ms) : 1937, 2024
. : milestone, 1980,
tracing (1.964 ms) : 1922, 2006
. : milestone, 1964,
|
Mariovido
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: testing
Testing
run-tests: all
Run all tests
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Follow up to #8111.
Various errors can appear more frequently than I anticipated. They need to be excluded.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]