-
Notifications
You must be signed in to change notification settings - Fork 323
Add GitHub workflow concurrency settings #8136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to prevent race condition and save execution time from long running jobs.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~de97030abf, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048210
Total [baseline] (8.607 s) : 0, 8607328
Agent [candidate] (1.052 s) : 0, 1052056
Total [candidate] (8.592 s) : 0, 8592100
section iast
Agent [baseline] (1.183 s) : 0, 1182729
Total [baseline] (9.237 s) : 0, 9237144
Agent [candidate] (1.185 s) : 0, 1184642
Total [candidate] (9.221 s) : 0, 9221267
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174767
Total [baseline] (9.173 s) : 0, 9172638
Agent [candidate] (1.18 s) : 0, 1179618
Total [candidate] (9.163 s) : 0, 9163182
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1179632
Total [baseline] (9.19 s) : 0, 9190220
Agent [candidate] (1.175 s) : 0, 1175153
Total [candidate] (9.177 s) : 0, 9176586
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~de97030abf, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (710.989 ms) : 0, 710989
BytebuddyAgent [candidate] (711.686 ms) : 0, 711686
GlobalTracer [baseline] (256.066 ms) : 0, 256066
GlobalTracer [candidate] (256.769 ms) : 0, 256769
AppSec [baseline] (54.844 ms) : 0, 54844
AppSec [candidate] (55.218 ms) : 0, 55218
Remote Config [baseline] (712.089 µs) : 0, 712
Remote Config [candidate] (710.466 µs) : 0, 710
Telemetry [baseline] (10.588 ms) : 0, 10588
Telemetry [candidate] (12.625 ms) : 0, 12625
section iast
BytebuddyAgent [baseline] (832.359 ms) : 0, 832359
BytebuddyAgent [candidate] (832.789 ms) : 0, 832789
GlobalTracer [baseline] (247.221 ms) : 0, 247221
GlobalTracer [candidate] (247.93 ms) : 0, 247930
AppSec [baseline] (57.693 ms) : 0, 57693
AppSec [candidate] (57.998 ms) : 0, 57998
Remote Config [baseline] (657.651 µs) : 0, 658
Remote Config [candidate] (661.805 µs) : 0, 662
Telemetry [baseline] (8.456 ms) : 0, 8456
Telemetry [candidate] (8.627 ms) : 0, 8627
IAST [baseline] (21.351 ms) : 0, 21351
IAST [candidate] (21.466 ms) : 0, 21466
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (825.72 ms) : 0, 825720
BytebuddyAgent [candidate] (827.972 ms) : 0, 827972
GlobalTracer [baseline] (245.792 ms) : 0, 245792
GlobalTracer [candidate] (247.0 ms) : 0, 247000
AppSec [baseline] (57.94 ms) : 0, 57940
AppSec [candidate] (58.541 ms) : 0, 58541
Remote Config [baseline] (649.439 µs) : 0, 649
Remote Config [candidate] (665.361 µs) : 0, 665
Telemetry [baseline] (8.462 ms) : 0, 8462
Telemetry [candidate] (8.716 ms) : 0, 8716
IAST [baseline] (21.214 ms) : 0, 21214
IAST [candidate] (21.722 ms) : 0, 21722
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.874 ms) : 0, 828874
BytebuddyAgent [candidate] (825.57 ms) : 0, 825570
GlobalTracer [baseline] (247.481 ms) : 0, 247481
GlobalTracer [candidate] (246.52 ms) : 0, 246520
AppSec [baseline] (57.869 ms) : 0, 57869
AppSec [candidate] (57.905 ms) : 0, 57905
Remote Config [baseline] (674.494 µs) : 0, 674
Remote Config [candidate] (648.886 µs) : 0, 649
Telemetry [baseline] (8.508 ms) : 0, 8508
Telemetry [candidate] (8.437 ms) : 0, 8437
IAST [baseline] (21.185 ms) : 0, 21185
IAST [candidate] (20.998 ms) : 0, 20998
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~de97030abf, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048876
Total [baseline] (10.343 s) : 0, 10343001
Agent [candidate] (1.051 s) : 0, 1050716
Total [candidate] (10.438 s) : 0, 10438247
section appsec
Agent [baseline] (1.189 s) : 0, 1189218
Total [baseline] (10.738 s) : 0, 10737544
Agent [candidate] (1.184 s) : 0, 1184424
Total [candidate] (10.681 s) : 0, 10680961
section iast
Agent [baseline] (1.179 s) : 0, 1179413
Total [baseline] (10.96 s) : 0, 10959847
Agent [candidate] (1.177 s) : 0, 1176969
Total [candidate] (10.91 s) : 0, 10910475
section profiling
Agent [baseline] (1.274 s) : 0, 1273653
Total [baseline] (10.795 s) : 0, 10794698
Agent [candidate] (1.274 s) : 0, 1274160
Total [candidate] (10.818 s) : 0, 10818314
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~de97030abf, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (709.322 ms) : 0, 709322
BytebuddyAgent [candidate] (711.0 ms) : 0, 711000
GlobalTracer [baseline] (255.585 ms) : 0, 255585
GlobalTracer [candidate] (256.305 ms) : 0, 256305
AppSec [baseline] (54.988 ms) : 0, 54988
AppSec [candidate] (54.978 ms) : 0, 54978
Remote Config [baseline] (714.145 µs) : 0, 714
Remote Config [candidate] (710.352 µs) : 0, 710
Telemetry [baseline] (13.291 ms) : 0, 13291
Telemetry [candidate] (12.685 ms) : 0, 12685
section appsec
BytebuddyAgent [baseline] (730.61 ms) : 0, 730610
BytebuddyAgent [candidate] (727.76 ms) : 0, 727760
GlobalTracer [baseline] (253.996 ms) : 0, 253996
GlobalTracer [candidate] (252.972 ms) : 0, 252972
AppSec [baseline] (170.638 ms) : 0, 170638
AppSec [candidate] (170.059 ms) : 0, 170059
IAST [baseline] (20.341 ms) : 0, 20341
IAST [candidate] (20.052 ms) : 0, 20052
Remote Config [baseline] (671.219 µs) : 0, 671
Remote Config [candidate] (655.59 µs) : 0, 656
Telemetry [baseline] (8.135 ms) : 0, 8135
Telemetry [candidate] (7.969 ms) : 0, 7969
section iast
BytebuddyAgent [baseline] (827.808 ms) : 0, 827808
BytebuddyAgent [candidate] (827.258 ms) : 0, 827258
GlobalTracer [baseline] (247.974 ms) : 0, 247974
GlobalTracer [candidate] (246.141 ms) : 0, 246141
AppSec [baseline] (58.051 ms) : 0, 58051
AppSec [candidate] (58.255 ms) : 0, 58255
IAST [baseline] (21.446 ms) : 0, 21446
IAST [candidate] (21.214 ms) : 0, 21214
Remote Config [baseline] (654.686 µs) : 0, 655
Remote Config [candidate] (645.726 µs) : 0, 646
Telemetry [baseline] (8.549 ms) : 0, 8549
Telemetry [candidate] (8.467 ms) : 0, 8467
section profiling
BytebuddyAgent [baseline] (703.028 ms) : 0, 703028
BytebuddyAgent [candidate] (701.227 ms) : 0, 701227
GlobalTracer [baseline] (371.01 ms) : 0, 371010
GlobalTracer [candidate] (372.444 ms) : 0, 372444
AppSec [baseline] (54.034 ms) : 0, 54034
AppSec [candidate] (53.74 ms) : 0, 53740
Remote Config [baseline] (673.854 µs) : 0, 674
Remote Config [candidate] (672.926 µs) : 0, 673
Telemetry [baseline] (7.798 ms) : 0, 7798
Telemetry [candidate] (7.729 ms) : 0, 7729
ProfilingAgent [baseline] (95.147 ms) : 0, 95147
ProfilingAgent [candidate] (96.532 ms) : 0, 96532
Profiling [baseline] (95.171 ms) : 0, 95171
Profiling [candidate] (96.556 ms) : 0, 96556
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~de97030abf, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1384
. : milestone, 1365,
appsec (1.726 ms) : 1702, 1749
. : milestone, 1726,
appsec_no_iast (1.76 ms) : 1735, 1784
. : milestone, 1760,
iast (1.484 ms) : 1460, 1507
. : milestone, 1484,
profiling (1.489 ms) : 1465, 1513
. : milestone, 1489,
tracing (1.497 ms) : 1473, 1521
. : milestone, 1497,
section candidate
no_agent (1.355 ms) : 1335, 1375
. : milestone, 1355,
appsec (1.752 ms) : 1729, 1775
. : milestone, 1752,
appsec_no_iast (1.734 ms) : 1709, 1760
. : milestone, 1734,
iast (1.512 ms) : 1490, 1534
. : milestone, 1512,
profiling (1.511 ms) : 1485, 1536
. : milestone, 1511,
tracing (1.483 ms) : 1459, 1507
. : milestone, 1483,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~de97030abf, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section baseline
no_agent (365.692 µs) : 346, 385
. : milestone, 366,
iast (491.098 µs) : 469, 513
. : milestone, 491,
iast_FULL (645.628 µs) : 624, 667
. : milestone, 646,
iast_GLOBAL (510.909 µs) : 489, 532
. : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (486.041 µs) : 465, 507
. : milestone, 486,
iast_INACTIVE (458.014 µs) : 437, 479
. : milestone, 458,
iast_TELEMETRY_OFF (479.273 µs) : 457, 502
. : milestone, 479,
tracing (445.321 µs) : 424, 466
. : milestone, 445,
section candidate
no_agent (376.334 µs) : 357, 396
. : milestone, 376,
iast (489.204 µs) : 467, 511
. : milestone, 489,
iast_FULL (645.135 µs) : 624, 667
. : milestone, 645,
iast_GLOBAL (515.915 µs) : 495, 537
. : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (487.149 µs) : 465, 509
. : milestone, 487,
iast_INACTIVE (449.143 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (481.533 µs) : 460, 503
. : milestone, 482,
tracing (442.649 µs) : 423, 463
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~de97030abf, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
. : milestone, 1466,
appsec (2.359 ms) : 2316, 2401
. : milestone, 2359,
iast (2.084 ms) : 2032, 2137
. : milestone, 2084,
iast_GLOBAL (2.13 ms) : 2077, 2184
. : milestone, 2130,
profiling (1.948 ms) : 1906, 1990
. : milestone, 1948,
tracing (1.926 ms) : 1886, 1967
. : milestone, 1926,
section candidate
no_agent (1.466 ms) : 1455, 1477
. : milestone, 1466,
appsec (2.34 ms) : 2299, 2382
. : milestone, 2340,
iast (2.08 ms) : 2027, 2134
. : milestone, 2080,
iast_GLOBAL (2.129 ms) : 2076, 2182
. : milestone, 2129,
profiling (1.94 ms) : 1898, 1982
. : milestone, 1940,
tracing (1.927 ms) : 1886, 1968
. : milestone, 1927,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~de97030abf, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section baseline
no_agent (15.615 s) : 15615000, 15615000
. : milestone, 15615000,
appsec (15.186 s) : 15186000, 15186000
. : milestone, 15186000,
iast (19.045 s) : 19045000, 19045000
. : milestone, 19045000,
iast_GLOBAL (18.217 s) : 18217000, 18217000
. : milestone, 18217000,
profiling (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
tracing (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
section candidate
no_agent (15.455 s) : 15455000, 15455000
. : milestone, 15455000,
appsec (15.09 s) : 15090000, 15090000
. : milestone, 15090000,
iast (18.901 s) : 18901000, 18901000
. : milestone, 18901000,
iast_GLOBAL (18.11 s) : 18110000, 18110000
. : milestone, 18110000,
profiling (15.567 s) : 15567000, 15567000
. : milestone, 15567000,
tracing (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
|
mcculls
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This would avoid having some GitHub workflows running in parallel.
Motivation
The goal is to prevent race conditions (PR checks, release asset upload) and save execution time from long running jobs (CodeQL).
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-116