Skip to content

Add check_debugger job to CI #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smola merged 1 commit into from
Jan 20, 2025
Merged

Add check_debugger job to CI #8240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .circleci/config.continue.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,12 +1107,20 @@ build_test_jobs: &build_test_jobs
gradleTarget: ":profilingCheck"
cacheType: profiling

- check:
requires:
- ok_to_test
name: check_debugger
gradleTarget: ":debuggerCheck"
cacheType: base

- fan_in:
requires:
- check_base
- check_inst
- check_smoke
- check_profiling
- check_debugger
name: check
stage: check

Expand Down
2 changes: 2 additions & 0 deletions ...strap/src/main/java/datadog/trace/bootstrap/debugger/el/ReflectiveFieldValueResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import static java.lang.invoke.MethodType.methodType;

import datadog.trace.bootstrap.debugger.CapturedContext;
import de.thetaphi.forbiddenapis.SuppressForbidden;
import java.lang.invoke.MethodHandle;
import java.lang.invoke.MethodHandles;
import java.lang.reflect.Field;
Expand All @@ -12,6 +13,7 @@
import org.slf4j.LoggerFactory;

/** A helper class to resolve a reference path using reflection. */
@SuppressForbidden // Class#forName(String)
public class ReflectiveFieldValueResolver {
private static final Logger LOGGER = LoggerFactory.getLogger(ReflectiveFieldValueResolver.class);
// This is a workaround for the fact that Field.trySetAccessible is not available in Java 8
Expand Down
3 changes: 3 additions & 0 deletions dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/LogProbe.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import datadog.trace.bootstrap.instrumentation.api.AgentTracer.TracerAPI;
import datadog.trace.core.DDSpan;
import datadog.trace.core.DDSpanContext;
import de.thetaphi.forbiddenapis.SuppressForbidden;
import java.io.IOException;
import java.lang.reflect.ParameterizedType;
import java.time.Duration;
Expand All @@ -58,6 +59,7 @@ public class LogProbe extends ProbeDefinition implements Sampled {
private static final Limits LIMITS = new Limits(1, 3, 8192, 5);
private static final int LOG_MSG_LIMIT = 8192;

@SuppressForbidden // String#split(String)
private static Map<String, String> getDebugSessions() {
HashMap<String, String> sessions = new HashMap<>();
TracerAPI tracer = AgentTracer.get();
Expand Down Expand Up @@ -365,6 +367,7 @@ private LogProbe(
this.sampling = sampling;
}

@SuppressForbidden // String#split(String)
private static List<ValueScript> parseWatchesFromTags(Tag[] tags) {
if (tags == null || tags.length == 0) {
return Collections.emptyList();
Expand Down
Loading