Add stacktraces on httpurlconnection requests#8325
Add stacktraces on httpurlconnection requests#8325nayeem-kamal wants to merge 8 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 7 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~b72eac3b16, baseline=1.52.0-SNAPSHOT~89e92d59f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (993.572 ms) : 0, 993572
Total [baseline] (8.571 s) : 0, 8571163
Agent [candidate] (1.021 s) : 0, 1020738
Total [candidate] (8.549 s) : 0, 8548565
section iast
Agent [baseline] (1.131 s) : 0, 1130690
Total [baseline] (9.25 s) : 0, 9250108
Agent [candidate] (1.151 s) : 0, 1151088
Total [candidate] (9.182 s) : 0, 9182200
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.136 s) : 0, 1135974
Total [baseline] (9.243 s) : 0, 9243340
Agent [candidate] (1.15 s) : 0, 1150494
Total [candidate] (9.192 s) : 0, 9191797
section iast_TELEMETRY_OFF
Agent [baseline] (1.136 s) : 0, 1135959
Total [baseline] (9.25 s) : 0, 9250447
Agent [candidate] (1.15 s) : 0, 1150246
Total [candidate] (9.252 s) : 0, 9252104
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~b72eac3b16, baseline=1.52.0-SNAPSHOT~89e92d59f6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.07 ms) : 0, 686070
BytebuddyAgent [candidate] (683.091 ms) : 0, 683091
GlobalTracer [baseline] (241.813 ms) : 0, 241813
GlobalTracer [candidate] (240.234 ms) : 0, 240234
AppSec [baseline] (30.11 ms) : 0, 30110
AppSec [candidate] (57.356 ms) : 0, 57356
Debugger [baseline] (5.952 ms) : 0, 5952
Debugger [candidate] (6.877 ms) : 0, 6877
Remote Config [baseline] (675.576 µs) : 0, 676
Remote Config [candidate] (744.275 µs) : 0, 744
Telemetry [baseline] (8.228 ms) : 0, 8228
Telemetry [candidate] (9.036 ms) : 0, 9036
section iast
BytebuddyAgent [baseline] (806.297 ms) : 0, 806297
BytebuddyAgent [candidate] (803.278 ms) : 0, 803278
GlobalTracer [baseline] (231.762 ms) : 0, 231762
GlobalTracer [candidate] (231.067 ms) : 0, 231067
IAST [baseline] (26.999 ms) : 0, 26999
IAST [candidate] (26.876 ms) : 0, 26876
AppSec [baseline] (30.559 ms) : 0, 30559
AppSec [candidate] (52.034 ms) : 0, 52034
Debugger [baseline] (5.762 ms) : 0, 5762
Debugger [candidate] (5.9 ms) : 0, 5900
Remote Config [baseline] (565.76 µs) : 0, 566
Remote Config [candidate] (599.881 µs) : 0, 600
Telemetry [baseline] (7.938 ms) : 0, 7938
Telemetry [candidate] (7.851 ms) : 0, 7851
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.182 ms) : 0, 809182
BytebuddyAgent [candidate] (802.987 ms) : 0, 802987
GlobalTracer [baseline] (232.973 ms) : 0, 232973
GlobalTracer [candidate] (230.837 ms) : 0, 230837
IAST [baseline] (25.631 ms) : 0, 25631
IAST [candidate] (28.612 ms) : 0, 28612
AppSec [baseline] (32.858 ms) : 0, 32858
AppSec [candidate] (50.229 ms) : 0, 50229
Debugger [baseline] (5.82 ms) : 0, 5820
Debugger [candidate] (5.869 ms) : 0, 5869
Remote Config [baseline] (597.521 µs) : 0, 598
Remote Config [candidate] (593.16 µs) : 0, 593
Telemetry [baseline] (8.057 ms) : 0, 8057
Telemetry [candidate] (7.965 ms) : 0, 7965
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (809.444 ms) : 0, 809444
BytebuddyAgent [candidate] (802.084 ms) : 0, 802084
GlobalTracer [baseline] (233.774 ms) : 0, 233774
GlobalTracer [candidate] (231.806 ms) : 0, 231806
IAST [baseline] (26.743 ms) : 0, 26743
IAST [candidate] (28.014 ms) : 0, 28014
AppSec [baseline] (30.964 ms) : 0, 30964
AppSec [candidate] (50.437 ms) : 0, 50437
Debugger [baseline] (5.778 ms) : 0, 5778
Debugger [candidate] (5.938 ms) : 0, 5938
Remote Config [baseline] (573.354 µs) : 0, 573
Remote Config [candidate] (583.807 µs) : 0, 584
Telemetry [baseline] (7.774 ms) : 0, 7774
Telemetry [candidate] (7.854 ms) : 0, 7854
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~b72eac3b16, baseline=1.52.0-SNAPSHOT~89e92d59f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.002 s) : 0, 1001572
Total [baseline] (10.629 s) : 0, 10629284
Agent [candidate] (1.026 s) : 0, 1026009
Total [candidate] (10.615 s) : 0, 10614688
section appsec
Agent [baseline] (1.172 s) : 0, 1172392
Total [baseline] (10.766 s) : 0, 10765951
Agent [candidate] (1.174 s) : 0, 1173682
Total [candidate] (10.703 s) : 0, 10702921
section iast
Agent [baseline] (1.132 s) : 0, 1132274
Total [baseline] (10.842 s) : 0, 10841955
Agent [candidate] (1.149 s) : 0, 1149360
Total [candidate] (10.905 s) : 0, 10904836
section profiling
Agent [baseline] (1.248 s) : 0, 1247505
Total [baseline] (10.996 s) : 0, 10995675
Agent [candidate] (1.265 s) : 0, 1265084
Total [candidate] (10.913 s) : 0, 10913054
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~b72eac3b16, baseline=1.52.0-SNAPSHOT~89e92d59f6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.52 ms) : 0, 692520
BytebuddyAgent [candidate] (685.044 ms) : 0, 685044
GlobalTracer [baseline] (242.951 ms) : 0, 242951
GlobalTracer [candidate] (241.395 ms) : 0, 241395
AppSec [baseline] (30.278 ms) : 0, 30278
AppSec [candidate] (58.688 ms) : 0, 58688
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (6.155 ms) : 0, 6155
Remote Config [baseline] (691.941 µs) : 0, 692
Remote Config [candidate] (738.736 µs) : 0, 739
Telemetry [baseline] (8.225 ms) : 0, 8225
Telemetry [candidate] (10.517 ms) : 0, 10517
section appsec
BytebuddyAgent [baseline] (711.337 ms) : 0, 711337
BytebuddyAgent [candidate] (707.637 ms) : 0, 707637
GlobalTracer [baseline] (240.357 ms) : 0, 240357
GlobalTracer [candidate] (239.512 ms) : 0, 239512
IAST [baseline] (23.71 ms) : 0, 23710
IAST [candidate] (22.003 ms) : 0, 22003
AppSec [baseline] (171.385 ms) : 0, 171385
AppSec [candidate] (177.759 ms) : 0, 177759
Debugger [baseline] (7.298 ms) : 0, 7298
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (608.736 µs) : 0, 609
Remote Config [candidate] (660.718 µs) : 0, 661
Telemetry [baseline] (8.514 ms) : 0, 8514
Telemetry [candidate] (7.418 ms) : 0, 7418
section iast
BytebuddyAgent [baseline] (807.362 ms) : 0, 807362
BytebuddyAgent [candidate] (801.766 ms) : 0, 801766
GlobalTracer [baseline] (232.209 ms) : 0, 232209
GlobalTracer [candidate] (230.64 ms) : 0, 230640
IAST [baseline] (30.286 ms) : 0, 30286
IAST [candidate] (28.519 ms) : 0, 28519
AppSec [baseline] (27.346 ms) : 0, 27346
AppSec [candidate] (50.475 ms) : 0, 50475
Debugger [baseline] (5.766 ms) : 0, 5766
Debugger [candidate] (5.944 ms) : 0, 5944
Remote Config [baseline] (589.278 µs) : 0, 589
Remote Config [candidate] (612.643 µs) : 0, 613
Telemetry [baseline] (7.901 ms) : 0, 7901
Telemetry [candidate] (7.921 ms) : 0, 7921
section profiling
BytebuddyAgent [baseline] (679.165 ms) : 0, 679165
BytebuddyAgent [candidate] (675.201 ms) : 0, 675201
GlobalTracer [baseline] (362.623 ms) : 0, 362623
GlobalTracer [candidate] (360.005 ms) : 0, 360005
AppSec [baseline] (31.02 ms) : 0, 31020
AppSec [candidate] (61.82 ms) : 0, 61820
Debugger [baseline] (12.85 ms) : 0, 12850
Debugger [candidate] (6.082 ms) : 0, 6082
Remote Config [baseline] (663.797 µs) : 0, 664
Remote Config [candidate] (652.605 µs) : 0, 653
Telemetry [baseline] (8.801 ms) : 0, 8801
Telemetry [candidate] (8.08 ms) : 0, 8080
ProfilingAgent [baseline] (103.701 ms) : 0, 103701
ProfilingAgent [candidate] (102.594 ms) : 0, 102594
Profiling [baseline] (103.726 ms) : 0, 103726
Profiling [candidate] (102.619 ms) : 0, 102619
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 3 metrics, 8 unstable metrics.
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~b72eac3b16, baseline=1.52.0-SNAPSHOT~89e92d59f6
dateFormat X
axisFormat %s
section baseline
no_agent (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
appsec (14.667 s) : 14667000, 14667000
. : milestone, 14667000,
iast (18.23 s) : 18230000, 18230000
. : milestone, 18230000,
iast_GLOBAL (18.294 s) : 18294000, 18294000
. : milestone, 18294000,
profiling (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
tracing (14.817 s) : 14817000, 14817000
. : milestone, 14817000,
section candidate
no_agent (14.721 s) : 14721000, 14721000
. : milestone, 14721000,
appsec (14.805 s) : 14805000, 14805000
. : milestone, 14805000,
iast (19.297 s) : 19297000, 19297000
. : milestone, 19297000,
iast_GLOBAL (17.863 s) : 17863000, 17863000
. : milestone, 17863000,
profiling (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
tracing (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~b72eac3b16, baseline=1.52.0-SNAPSHOT~89e92d59f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (2.426 ms) : 2376, 2476
. : milestone, 2426,
iast (2.219 ms) : 2156, 2282
. : milestone, 2219,
iast_GLOBAL (2.259 ms) : 2196, 2322
. : milestone, 2259,
profiling (2.056 ms) : 2006, 2106
. : milestone, 2056,
tracing (2.041 ms) : 1993, 2090
. : milestone, 2041,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.418 ms) : 2369, 2467
. : milestone, 2418,
iast (2.21 ms) : 2149, 2272
. : milestone, 2210,
iast_GLOBAL (2.244 ms) : 2182, 2306
. : milestone, 2244,
profiling (2.073 ms) : 2022, 2124
. : milestone, 2073,
tracing (2.025 ms) : 1977, 2073
. : milestone, 2025,
|
|
This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it. |
| } | ||
|
|
||
| @Flaky(suites = ["ApacheHttpAsyncClient5Test"]) | ||
| @IgnoreIf({true}) |
There was a problem hiding this comment.
These ignores need to be resolved before this is ready to merge
…ass HttpUrlErrorReportingTest
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it. |
|
This pull request has been closed because it has not had activity over the past quarter. Feel free to reopen the PR if you are still working on it. |
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-14172