Skip to content

Adjust muzzle limit for vertx instrumentations #8846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhlidd merged 8 commits into from
May 20, 2025
Merged

Adjust muzzle limit for vertx instrumentations #8846

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dddf806
removing limits for version 5.0.0 on muzzle
mhlidd May 19, 2025
dd9c7dc
add vertx-pg-client-4.4.2
mhlidd May 19, 2025
15544dd
workaround
amarziali May 19, 2025
333bd0a
use java 11 for vertx mysql client muzzle
amarziali May 19, 2025
47098d0
use java 11 for all the vertx 3.9 checking 5+
amarziali May 20, 2025
692d16a
fix muzzle for vertx-web
amarziali May 20, 2025
f4456cb
modifying vertx-web-4.0
mhlidd May 20, 2025
1e12ac4
skip assertInverse for muzzle vertx web 4
amarziali May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dd-java-agent/instrumentation/vertx-mysql-client-3.9/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ muzzle {
group = 'io.vertx'
module = 'vertx-mysql-client'
versions = '[3.9.0,4)'
javaVersion = '11'
assertInverse = true
}
}
Expand Down
8 changes: 7 additions & 1 deletion dd-java-agent/instrumentation/vertx-pg-client-4.0/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@ muzzle {
// 4.1.1 is the first version where PgConnectionFactory is public
// see https://github.com/eclipse-vertx/vertx-sql-client/pull/986
versions = '[4.1.1,5)'
assertInverse = true
}
fail {
group = 'io.vertx'
module = 'vertx-pg-client'
// 4.1.1 is the first version where PgConnectionFactory is public
// see https://github.com/eclipse-vertx/vertx-sql-client/pull/986
versions = '(,4.1.1)'
}
}

Expand Down
2 changes: 1 addition & 1 deletion dd-java-agent/instrumentation/vertx-pg-client-4.4.2/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ muzzle {
pass {
group = 'io.vertx'
module = 'vertx-pg-client'
versions = '[4.4.2,4.6.0)'
versions = '[4.4.2,)'
assertInverse = true
}
}
Expand Down
1 change: 1 addition & 0 deletions dd-java-agent/instrumentation/vertx-redis-client-3.9/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ muzzle {
group = 'io.vertx'
module = 'vertx-redis-client'
versions = '[3.9.0,)'
javaVersion = '11'
assertInverse = true
}
}
Expand Down
1 change: 1 addition & 0 deletions dd-java-agent/instrumentation/vertx-sql-client-3.9/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ muzzle {
group = "io.vertx"
module = "vertx-sql-client"
versions = "[3.9.0,)"
javaVersion = "11"
}
}

Expand Down
3 changes: 2 additions & 1 deletion dd-java-agent/instrumentation/vertx-web-3.9/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ muzzle {
pass {
group = 'io.vertx'
module = "vertx-web"
versions = "[3.8.1,5)"
versions = "[3.8.1,)" // it won't fail on 5+ since won't apply
javaVersion = "11"
assertInverse = true
}
}
Expand Down
3 changes: 2 additions & 1 deletion dd-java-agent/instrumentation/vertx-web-4.0/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ muzzle {
pass {
group = 'io.vertx'
module = "vertx-web"
versions = "[4.0.0,5)"
versions = "[4.0.0,)"
javaVersion = "11"
Copy link
Contributor Author

@mhlidd mhlidd May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amarziali Made a similar change here. Let me know if this is incorrect 🙇‍♂️

Copy link
Contributor

@amarziali amarziali May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed since it seems that advices are not applying for >=5. It looks passing locally now

assertInverse = true
}
}
Expand Down
Loading