-
Notifications
You must be signed in to change notification settings - Fork 323
Fix for the InitializationTelemetryTest when running on Oracle JDK 8. #8905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 52 metrics, 13 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1030536
Total [baseline] (11.214 s) : 0, 11214182
Agent [candidate] (1.023 s) : 0, 1023100
Total [candidate] (11.052 s) : 0, 11052159
section appsec
Agent [baseline] (1.158 s) : 0, 1158254
Total [baseline] (11.254 s) : 0, 11253897
Agent [candidate] (1.163 s) : 0, 1163047
Total [candidate] (11.282 s) : 0, 11282098
section iast
Agent [baseline] (1.148 s) : 0, 1147505
Total [baseline] (11.282 s) : 0, 11281868
Agent [candidate] (1.158 s) : 0, 1157560
Total [candidate] (11.477 s) : 0, 11477211
section profiling
Agent [baseline] (1.285 s) : 0, 1285290
Total [baseline] (11.477 s) : 0, 11477149
Agent [candidate] (1.265 s) : 0, 1264805
Total [candidate] (11.439 s) : 0, 11439405
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.785 ms) : 0, 689785
BytebuddyAgent [candidate] (683.152 ms) : 0, 683152
GlobalTracer [baseline] (241.157 ms) : 0, 241157
GlobalTracer [candidate] (240.519 ms) : 0, 240519
AppSec [baseline] (55.43 ms) : 0, 55430
AppSec [candidate] (58.213 ms) : 0, 58213
Debugger [baseline] (10.551 ms) : 0, 10551
Debugger [candidate] (6.201 ms) : 0, 6201
Remote Config [baseline] (691.747 µs) : 0, 692
Remote Config [candidate] (724.641 µs) : 0, 725
Telemetry [baseline] (9.138 ms) : 0, 9138
Telemetry [candidate] (10.708 ms) : 0, 10708
section appsec
BytebuddyAgent [baseline] (698.612 ms) : 0, 698612
BytebuddyAgent [candidate] (699.785 ms) : 0, 699785
GlobalTracer [baseline] (235.827 ms) : 0, 235827
GlobalTracer [candidate] (237.927 ms) : 0, 237927
AppSec [baseline] (175.509 ms) : 0, 175509
AppSec [candidate] (176.845 ms) : 0, 176845
Debugger [baseline] (5.884 ms) : 0, 5884
Debugger [candidate] (5.988 ms) : 0, 5988
Remote Config [baseline] (646.893 µs) : 0, 647
Remote Config [candidate] (632.07 µs) : 0, 632
Telemetry [baseline] (7.334 ms) : 0, 7334
Telemetry [candidate] (7.38 ms) : 0, 7380
IAST [baseline] (21.786 ms) : 0, 21786
IAST [candidate] (21.936 ms) : 0, 21936
section iast
BytebuddyAgent [baseline] (800.709 ms) : 0, 800709
BytebuddyAgent [candidate] (807.166 ms) : 0, 807166
GlobalTracer [baseline] (229.835 ms) : 0, 229835
GlobalTracer [candidate] (231.865 ms) : 0, 231865
AppSec [baseline] (48.232 ms) : 0, 48232
AppSec [candidate] (51.528 ms) : 0, 51528
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (6.073 ms) : 0, 6073
Remote Config [baseline] (606.489 µs) : 0, 606
Remote Config [candidate] (610.64 µs) : 0, 611
Telemetry [baseline] (7.848 ms) : 0, 7848
Telemetry [candidate] (8.017 ms) : 0, 8017
IAST [baseline] (30.729 ms) : 0, 30729
IAST [candidate] (28.62 ms) : 0, 28620
section profiling
ProfilingAgent [baseline] (110.87 ms) : 0, 110870
ProfilingAgent [candidate] (103.369 ms) : 0, 103369
BytebuddyAgent [baseline] (673.174 ms) : 0, 673174
BytebuddyAgent [candidate] (674.048 ms) : 0, 674048
GlobalTracer [baseline] (380.789 ms) : 0, 380789
GlobalTracer [candidate] (360.214 ms) : 0, 360214
AppSec [baseline] (54.758 ms) : 0, 54758
AppSec [candidate] (61.64 ms) : 0, 61640
Debugger [baseline] (6.194 ms) : 0, 6194
Debugger [candidate] (6.067 ms) : 0, 6067
Remote Config [baseline] (670.708 µs) : 0, 671
Remote Config [candidate] (652.904 µs) : 0, 653
Telemetry [baseline] (8.19 ms) : 0, 8190
Telemetry [candidate] (8.123 ms) : 0, 8123
Profiling [baseline] (110.895 ms) : 0, 110895
Profiling [candidate] (103.394 ms) : 0, 103394
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022479
Total [baseline] (8.559 s) : 0, 8559274
Agent [candidate] (1.024 s) : 0, 1024147
Total [candidate] (8.517 s) : 0, 8516979
section iast
Agent [baseline] (1.143 s) : 0, 1143379
Total [baseline] (9.163 s) : 0, 9163236
Agent [candidate] (1.152 s) : 0, 1151983
Total [candidate] (9.198 s) : 0, 9197833
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.146 s) : 0, 1145700
Total [baseline] (9.121 s) : 0, 9121202
Agent [candidate] (1.149 s) : 0, 1148598
Total [candidate] (9.168 s) : 0, 9168461
section iast_TELEMETRY_OFF
Agent [baseline] (1.155 s) : 0, 1155251
Total [baseline] (9.265 s) : 0, 9265086
Agent [candidate] (1.15 s) : 0, 1149958
Total [candidate] (9.211 s) : 0, 9211084
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.442 ms) : 0, 682442
BytebuddyAgent [candidate] (683.861 ms) : 0, 683861
GlobalTracer [baseline] (239.846 ms) : 0, 239846
GlobalTracer [candidate] (240.642 ms) : 0, 240642
AppSec [baseline] (54.579 ms) : 0, 54579
AppSec [candidate] (57.145 ms) : 0, 57145
Debugger [baseline] (10.53 ms) : 0, 10530
Debugger [candidate] (6.887 ms) : 0, 6887
Remote Config [baseline] (693.802 µs) : 0, 694
Remote Config [candidate] (732.0 µs) : 0, 732
Telemetry [baseline] (10.709 ms) : 0, 10709
Telemetry [candidate] (11.28 ms) : 0, 11280
section iast
BytebuddyAgent [baseline] (797.883 ms) : 0, 797883
BytebuddyAgent [candidate] (802.905 ms) : 0, 802905
GlobalTracer [baseline] (228.891 ms) : 0, 228891
GlobalTracer [candidate] (231.141 ms) : 0, 231141
IAST [baseline] (29.992 ms) : 0, 29992
IAST [candidate] (25.601 ms) : 0, 25601
AppSec [baseline] (48.002 ms) : 0, 48002
AppSec [candidate] (54.255 ms) : 0, 54255
Debugger [baseline] (5.968 ms) : 0, 5968
Debugger [candidate] (6.039 ms) : 0, 6039
Remote Config [baseline] (604.763 µs) : 0, 605
Remote Config [candidate] (603.319 µs) : 0, 603
Telemetry [baseline] (7.836 ms) : 0, 7836
Telemetry [candidate] (7.883 ms) : 0, 7883
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.038 ms) : 0, 800038
BytebuddyAgent [candidate] (800.598 ms) : 0, 800598
GlobalTracer [baseline] (229.366 ms) : 0, 229366
GlobalTracer [candidate] (230.363 ms) : 0, 230363
IAST [baseline] (28.185 ms) : 0, 28185
IAST [candidate] (28.691 ms) : 0, 28691
AppSec [baseline] (49.521 ms) : 0, 49521
AppSec [candidate] (51.039 ms) : 0, 51039
Debugger [baseline] (5.928 ms) : 0, 5928
Debugger [candidate] (5.954 ms) : 0, 5954
Remote Config [baseline] (586.973 µs) : 0, 587
Remote Config [candidate] (596.524 µs) : 0, 597
Telemetry [baseline] (7.838 ms) : 0, 7838
Telemetry [candidate] (7.941 ms) : 0, 7941
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.163 ms) : 0, 806163
BytebuddyAgent [candidate] (801.364 ms) : 0, 801364
GlobalTracer [baseline] (231.354 ms) : 0, 231354
GlobalTracer [candidate] (231.266 ms) : 0, 231266
IAST [baseline] (22.903 ms) : 0, 22903
IAST [candidate] (29.723 ms) : 0, 29723
AppSec [baseline] (56.582 ms) : 0, 56582
AppSec [candidate] (49.423 ms) : 0, 49423
Debugger [baseline] (6.083 ms) : 0, 6083
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (628.724 µs) : 0, 629
Remote Config [candidate] (603.383 µs) : 0, 603
Telemetry [baseline] (7.788 ms) : 0, 7788
Telemetry [candidate] (7.914 ms) : 0, 7914
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 0 metrics, 11 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (9.894 ms) : 9851, 9936
. : milestone, 9894,
appsec (8.463 ms) : 8437, 8489
. : milestone, 8463,
appsec_no_iast (11.213 ms) : 11147, 11278
. : milestone, 11213,
code_origins (45.023 ms) : 44565, 45480
. : milestone, 45023,
iast (37.674 ms) : 37303, 38046
. : milestone, 37674,
profiling (401.291 µs) : 367, 436
. : milestone, 401,
tracing (1.094 ms) : 1043, 1145
. : milestone, 1094,
section candidate
no_agent (73.82 ms) : 72321, 75320
. : milestone, 73820,
appsec (94.53 ms) : 92097, 96962
. : milestone, 94530,
appsec_no_iast (103.688 ms) : 100499, 106877
. : milestone, 103688,
code_origins (120.374 ms) : 113184, 127563
. : milestone, 120374,
iast (109.11 ms) : 104950, 113270
. : milestone, 109110,
profiling (88.771 ms) : 86728, 90814
. : milestone, 88771,
tracing (79.563 ms) : 77915, 81211
. : milestone, 79563,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
appsec (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
iast (19.074 s) : 19074000, 19074000
. : milestone, 19074000,
iast_GLOBAL (18.127 s) : 18127000, 18127000
. : milestone, 18127000,
profiling (15.952 s) : 15952000, 15952000
. : milestone, 15952000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
section candidate
no_agent (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
appsec (14.709 s) : 14709000, 14709000
. : milestone, 14709000,
iast (19.048 s) : 19048000, 19048000
. : milestone, 19048000,
iast_GLOBAL (18.252 s) : 18252000, 18252000
. : milestone, 18252000,
profiling (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
tracing (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.4 ms) : 2351, 2448
. : milestone, 2400,
iast (2.187 ms) : 2126, 2248
. : milestone, 2187,
iast_GLOBAL (2.234 ms) : 2172, 2296
. : milestone, 2234,
profiling (2.056 ms) : 2006, 2107
. : milestone, 2056,
tracing (2.007 ms) : 1959, 2054
. : milestone, 2007,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (2.407 ms) : 2359, 2456
. : milestone, 2407,
iast (2.177 ms) : 2117, 2238
. : milestone, 2177,
iast_GLOBAL (2.229 ms) : 2168, 2290
. : milestone, 2229,
profiling (2.035 ms) : 1984, 2085
. : milestone, 2035,
tracing (1.999 ms) : 1952, 2046
. : milestone, 1999,
|
dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java
Outdated
Show resolved
Hide resolved
dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java
Outdated
Show resolved
Hide resolved
dd-java-agent/src/test/java/jvmbootstraptest/InitializationTelemetryCheck.java
Show resolved
Hide resolved
dougqh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't want the calls to System.err in AgentBootstrap and BootstrapInitializationTelemetry. Customers are likely to complain about any unexpected output -- especially to stderr.
@dougqh |
Just to clarify, there are a few rare occasions when we have to log output before the logger is available, and for those https://en.wikipedia.org/wiki/Standard_streams#Standard_error_(stderr) |
Okay, I just wanted to make sure. |
What Does This Do
Fixed test
InitializationTelemetryTestthat failed ONLY under Oracle 8.Motivation
All tests should be green on any JDK
Additional Notes
The root cause was in our
CustomSecurityManagerthat was too strict for Oracle 8 and failed on attempt to check some internal files specific ONLY for Oracle 8:Added special check to relax security check for Oracle 8. We already have similar logic for IBM JVM.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]