Skip to content

Conversation

@AlexeyKuznetsov-DD
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented May 30, 2025

What Does This Do

Fixed test InitializationTelemetryTest that failed ONLY under Oracle 8.

Motivation

All tests should be green on any JDK

Additional Notes

The root cause was in our CustomSecurityManager that was too strict for Oracle 8 and failed on attempt to check some internal files specific ONLY for Oracle 8:

 Caused by: java.lang.SecurityException: Blocked ("java.io.FilePermission" "/usr/lib/jvm/oracle8/lib/meta-index" "read") 
 at jvmbootstraptest.CustomSecurityManager.block(CustomSecurityManager.java:745) 

Added special check to relax security check for Oracle 8. We already have similar logic for IBM JVM.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug Bug report and fix comp: core Tracer core tag: no release notes Changes to exclude from release notes run-tests: oracle8 Run tests using Oracle 8 JDK labels May 30, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 30, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/fix-npe-oracle-8
git_commit_date 1746789389 1748960641
git_commit_sha ad6d5fe e387a1a
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~e387a1aaf1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1748963204 1748963204
ci_job_id 965506014 965506014
ci_pipeline_id 66812994 66812994
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-bap2zmvn-project-304-concurrent-0-ti3p8da3 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-bap2zmvn-project-304-concurrent-0-ti3p8da3 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 4 performance improvements and 2 performance regressions! Performance is the same for 52 metrics, 13 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:AppSec better
[-8.635ms; -5.682ms] or [-15.262%; -10.043%]
49.423ms 56.582ms
scenario:startup:insecure-bank:tracing:Remote Config worse
[+14.170µs; +62.227µs] or [+2.042%; +8.969%]
732.000µs 693.802µs
scenario:startup:petclinic:profiling:ProfilingAgent better
[-10.667ms; -4.335ms] or [-9.621%; -3.910%]
103.369ms 110.870ms
scenario:startup:petclinic:profiling:GlobalTracer better
[-24.191ms; -16.960ms] or [-6.353%; -4.454%]
360.214ms 380.789ms
scenario:startup:petclinic:profiling:AppSec worse
[+4.956ms; +8.810ms] or [+9.050%; +16.089%]
61.640ms 54.758ms
scenario:startup:petclinic:profiling:Profiling better
[-10.668ms; -4.335ms] or [-9.620%; -3.909%]
103.394ms 110.895ms
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1030536
Total [baseline] (11.214 s) : 0, 11214182
Agent [candidate] (1.023 s) : 0, 1023100
Total [candidate] (11.052 s) : 0, 11052159
section appsec
Agent [baseline] (1.158 s) : 0, 1158254
Total [baseline] (11.254 s) : 0, 11253897
Agent [candidate] (1.163 s) : 0, 1163047
Total [candidate] (11.282 s) : 0, 11282098
section iast
Agent [baseline] (1.148 s) : 0, 1147505
Total [baseline] (11.282 s) : 0, 11281868
Agent [candidate] (1.158 s) : 0, 1157560
Total [candidate] (11.477 s) : 0, 11477211
section profiling
Agent [baseline] (1.285 s) : 0, 1285290
Total [baseline] (11.477 s) : 0, 11477149
Agent [candidate] (1.265 s) : 0, 1264805
Total [candidate] (11.439 s) : 0, 11439405
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.031 s -
Agent appsec 1.158 s 127.718 ms (12.4%)
Agent iast 1.148 s 116.969 ms (11.4%)
Agent profiling 1.285 s 254.754 ms (24.7%)
Total tracing 11.214 s -
Total appsec 11.254 s 39.715 ms (0.4%)
Total iast 11.282 s 67.686 ms (0.6%)
Total profiling 11.477 s 262.966 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent appsec 1.163 s 139.947 ms (13.7%)
Agent iast 1.158 s 134.46 ms (13.1%)
Agent profiling 1.265 s 241.705 ms (23.6%)
Total tracing 11.052 s -
Total appsec 11.282 s 229.938 ms (2.1%)
Total iast 11.477 s 425.052 ms (3.8%)
Total profiling 11.439 s 387.246 ms (3.5%)
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.785 ms) : 0, 689785
BytebuddyAgent [candidate] (683.152 ms) : 0, 683152
GlobalTracer [baseline] (241.157 ms) : 0, 241157
GlobalTracer [candidate] (240.519 ms) : 0, 240519
AppSec [baseline] (55.43 ms) : 0, 55430
AppSec [candidate] (58.213 ms) : 0, 58213
Debugger [baseline] (10.551 ms) : 0, 10551
Debugger [candidate] (6.201 ms) : 0, 6201
Remote Config [baseline] (691.747 µs) : 0, 692
Remote Config [candidate] (724.641 µs) : 0, 725
Telemetry [baseline] (9.138 ms) : 0, 9138
Telemetry [candidate] (10.708 ms) : 0, 10708
section appsec
BytebuddyAgent [baseline] (698.612 ms) : 0, 698612
BytebuddyAgent [candidate] (699.785 ms) : 0, 699785
GlobalTracer [baseline] (235.827 ms) : 0, 235827
GlobalTracer [candidate] (237.927 ms) : 0, 237927
AppSec [baseline] (175.509 ms) : 0, 175509
AppSec [candidate] (176.845 ms) : 0, 176845
Debugger [baseline] (5.884 ms) : 0, 5884
Debugger [candidate] (5.988 ms) : 0, 5988
Remote Config [baseline] (646.893 µs) : 0, 647
Remote Config [candidate] (632.07 µs) : 0, 632
Telemetry [baseline] (7.334 ms) : 0, 7334
Telemetry [candidate] (7.38 ms) : 0, 7380
IAST [baseline] (21.786 ms) : 0, 21786
IAST [candidate] (21.936 ms) : 0, 21936
section iast
BytebuddyAgent [baseline] (800.709 ms) : 0, 800709
BytebuddyAgent [candidate] (807.166 ms) : 0, 807166
GlobalTracer [baseline] (229.835 ms) : 0, 229835
GlobalTracer [candidate] (231.865 ms) : 0, 231865
AppSec [baseline] (48.232 ms) : 0, 48232
AppSec [candidate] (51.528 ms) : 0, 51528
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (6.073 ms) : 0, 6073
Remote Config [baseline] (606.489 µs) : 0, 606
Remote Config [candidate] (610.64 µs) : 0, 611
Telemetry [baseline] (7.848 ms) : 0, 7848
Telemetry [candidate] (8.017 ms) : 0, 8017
IAST [baseline] (30.729 ms) : 0, 30729
IAST [candidate] (28.62 ms) : 0, 28620
section profiling
ProfilingAgent [baseline] (110.87 ms) : 0, 110870
ProfilingAgent [candidate] (103.369 ms) : 0, 103369
BytebuddyAgent [baseline] (673.174 ms) : 0, 673174
BytebuddyAgent [candidate] (674.048 ms) : 0, 674048
GlobalTracer [baseline] (380.789 ms) : 0, 380789
GlobalTracer [candidate] (360.214 ms) : 0, 360214
AppSec [baseline] (54.758 ms) : 0, 54758
AppSec [candidate] (61.64 ms) : 0, 61640
Debugger [baseline] (6.194 ms) : 0, 6194
Debugger [candidate] (6.067 ms) : 0, 6067
Remote Config [baseline] (670.708 µs) : 0, 671
Remote Config [candidate] (652.904 µs) : 0, 653
Telemetry [baseline] (8.19 ms) : 0, 8190
Telemetry [candidate] (8.123 ms) : 0, 8123
Profiling [baseline] (110.895 ms) : 0, 110895
Profiling [candidate] (103.394 ms) : 0, 103394
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022479
Total [baseline] (8.559 s) : 0, 8559274
Agent [candidate] (1.024 s) : 0, 1024147
Total [candidate] (8.517 s) : 0, 8516979
section iast
Agent [baseline] (1.143 s) : 0, 1143379
Total [baseline] (9.163 s) : 0, 9163236
Agent [candidate] (1.152 s) : 0, 1151983
Total [candidate] (9.198 s) : 0, 9197833
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.146 s) : 0, 1145700
Total [baseline] (9.121 s) : 0, 9121202
Agent [candidate] (1.149 s) : 0, 1148598
Total [candidate] (9.168 s) : 0, 9168461
section iast_TELEMETRY_OFF
Agent [baseline] (1.155 s) : 0, 1155251
Total [baseline] (9.265 s) : 0, 9265086
Agent [candidate] (1.15 s) : 0, 1149958
Total [candidate] (9.211 s) : 0, 9211084
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.022 s -
Agent iast 1.143 s 120.899 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.146 s 123.221 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.155 s 132.772 ms (13.0%)
Total tracing 8.559 s -
Total iast 9.163 s 603.963 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.121 s 561.929 ms (6.6%)
Total iast_TELEMETRY_OFF 9.265 s 705.812 ms (8.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.024 s -
Agent iast 1.152 s 127.836 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.149 s 124.451 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.15 s 125.811 ms (12.3%)
Total tracing 8.517 s -
Total iast 9.198 s 680.853 ms (8.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.168 s 651.481 ms (7.6%)
Total iast_TELEMETRY_OFF 9.211 s 694.105 ms (8.1%)
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.442 ms) : 0, 682442
BytebuddyAgent [candidate] (683.861 ms) : 0, 683861
GlobalTracer [baseline] (239.846 ms) : 0, 239846
GlobalTracer [candidate] (240.642 ms) : 0, 240642
AppSec [baseline] (54.579 ms) : 0, 54579
AppSec [candidate] (57.145 ms) : 0, 57145
Debugger [baseline] (10.53 ms) : 0, 10530
Debugger [candidate] (6.887 ms) : 0, 6887
Remote Config [baseline] (693.802 µs) : 0, 694
Remote Config [candidate] (732.0 µs) : 0, 732
Telemetry [baseline] (10.709 ms) : 0, 10709
Telemetry [candidate] (11.28 ms) : 0, 11280
section iast
BytebuddyAgent [baseline] (797.883 ms) : 0, 797883
BytebuddyAgent [candidate] (802.905 ms) : 0, 802905
GlobalTracer [baseline] (228.891 ms) : 0, 228891
GlobalTracer [candidate] (231.141 ms) : 0, 231141
IAST [baseline] (29.992 ms) : 0, 29992
IAST [candidate] (25.601 ms) : 0, 25601
AppSec [baseline] (48.002 ms) : 0, 48002
AppSec [candidate] (54.255 ms) : 0, 54255
Debugger [baseline] (5.968 ms) : 0, 5968
Debugger [candidate] (6.039 ms) : 0, 6039
Remote Config [baseline] (604.763 µs) : 0, 605
Remote Config [candidate] (603.319 µs) : 0, 603
Telemetry [baseline] (7.836 ms) : 0, 7836
Telemetry [candidate] (7.883 ms) : 0, 7883
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.038 ms) : 0, 800038
BytebuddyAgent [candidate] (800.598 ms) : 0, 800598
GlobalTracer [baseline] (229.366 ms) : 0, 229366
GlobalTracer [candidate] (230.363 ms) : 0, 230363
IAST [baseline] (28.185 ms) : 0, 28185
IAST [candidate] (28.691 ms) : 0, 28691
AppSec [baseline] (49.521 ms) : 0, 49521
AppSec [candidate] (51.039 ms) : 0, 51039
Debugger [baseline] (5.928 ms) : 0, 5928
Debugger [candidate] (5.954 ms) : 0, 5954
Remote Config [baseline] (586.973 µs) : 0, 587
Remote Config [candidate] (596.524 µs) : 0, 597
Telemetry [baseline] (7.838 ms) : 0, 7838
Telemetry [candidate] (7.941 ms) : 0, 7941
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.163 ms) : 0, 806163
BytebuddyAgent [candidate] (801.364 ms) : 0, 801364
GlobalTracer [baseline] (231.354 ms) : 0, 231354
GlobalTracer [candidate] (231.266 ms) : 0, 231266
IAST [baseline] (22.903 ms) : 0, 22903
IAST [candidate] (29.723 ms) : 0, 29723
AppSec [baseline] (56.582 ms) : 0, 56582
AppSec [candidate] (49.423 ms) : 0, 49423
Debugger [baseline] (6.083 ms) : 0, 6083
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (628.724 µs) : 0, 629
Remote Config [candidate] (603.383 µs) : 0, 603
Telemetry [baseline] (7.788 ms) : 0, 7788
Telemetry [candidate] (7.914 ms) : 0, 7914
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-06-03T14:41:33 2025-06-03T14:46:50
git_branch master alexeyk/fix-npe-oracle-8
git_commit_date 1746789389 1748960641
git_commit_sha ad6d5fe e387a1a
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~e387a1aaf1
start_time 2025-06-03T14:39:17 2025-06-03T14:46:03
See matching parameters
Baseline Candidate
application petclinic petclinic
ci_job_date 1748962010 1748962010
ci_job_id 965506015 965506015
ci_pipeline_id 66812994 66812994
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-eqiwq57k-project-304-concurrent-0-252un787 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-eqiwq57k-project-304-concurrent-0-252un787 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
thresholds_or_results results results
variant appsec appsec

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 0 metrics, 11 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:appsec unstable
[+84.216ms; +87.918ms] or [+995.130%; +1038.875%]
worse
[-544.653op/s; -520.106op/s] or [-93.272%; -89.068%]
94.530ms 51.562op/s 8.463ms 583.942op/s
scenario:load:petclinic:appsec_no_iast unstable
[+90.049ms; +94.903ms] or [+803.106%; +846.396%]
worse
[-416.796op/s; -372.700op/s] or [-94.423%; -84.433%]
103.688ms 46.667op/s 11.213ms 441.415op/s
scenario:load:petclinic:no_agent unstable
[+62.785ms; +65.068ms] or [+634.606%; +657.680%]
worse
[-454.629op/s; -411.321op/s] or [-90.926%; -82.264%]
73.820ms 67.025op/s 9.894ms 500.000op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (9.894 ms) : 9851, 9936
.   : milestone, 9894,
appsec (8.463 ms) : 8437, 8489
.   : milestone, 8463,
appsec_no_iast (11.213 ms) : 11147, 11278
.   : milestone, 11213,
code_origins (45.023 ms) : 44565, 45480
.   : milestone, 45023,
iast (37.674 ms) : 37303, 38046
.   : milestone, 37674,
profiling (401.291 µs) : 367, 436
.   : milestone, 401,
tracing (1.094 ms) : 1043, 1145
.   : milestone, 1094,
section candidate
no_agent (73.82 ms) : 72321, 75320
.   : milestone, 73820,
appsec (94.53 ms) : 92097, 96962
.   : milestone, 94530,
appsec_no_iast (103.688 ms) : 100499, 106877
.   : milestone, 103688,
code_origins (120.374 ms) : 113184, 127563
.   : milestone, 120374,
iast (109.11 ms) : 104950, 113270
.   : milestone, 109110,
profiling (88.771 ms) : 86728, 90814
.   : milestone, 88771,
tracing (79.563 ms) : 77915, 81211
.   : milestone, 79563,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 9.894 ms [9.851 ms, 9.936 ms] -
appsec 8.463 ms [8.437 ms, 8.489 ms] -1.431 ms (-14.5%)
appsec_no_iast 11.213 ms [11.147 ms, 11.278 ms] 1.319 ms (13.3%)
code_origins 45.023 ms [44.565 ms, 45.48 ms] 35.129 ms (355.1%)
iast 37.674 ms [37.303 ms, 38.046 ms] 27.781 ms (280.8%)
profiling 401.291 µs [366.98 µs, 435.603 µs] -9.492 ms (-95.9%)
tracing 1.094 ms [1.043 ms, 1.145 ms] -8.8 ms (-88.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 73.82 ms [72.321 ms, 75.32 ms] -
appsec 94.53 ms [92.097 ms, 96.962 ms] 20.71 ms (28.1%)
appsec_no_iast 103.688 ms [100.499 ms, 106.877 ms] 29.868 ms (40.5%)
code_origins 120.374 ms [113.184 ms, 127.563 ms] 46.553 ms (63.1%)
iast 109.11 ms [104.95 ms, 113.27 ms] 35.29 ms (47.8%)
profiling 88.771 ms [86.728 ms, 90.814 ms] 14.951 ms (20.3%)
tracing 79.563 ms [77.915 ms, 81.211 ms] 5.743 ms (7.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/fix-npe-oracle-8
git_commit_date 1746789389 1748960641
git_commit_sha ad6d5fe e387a1a
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~e387a1aaf1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1748962706 1748962706
ci_job_id 965506016 965506016
ci_pipeline_id 66812994 66812994
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-spbqwyzc-project-304-concurrent-0-4hijt6dv 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-spbqwyzc-project-304-concurrent-0-4hijt6dv 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.102 s) : 15102000, 15102000
.   : milestone, 15102000,
appsec (14.796 s) : 14796000, 14796000
.   : milestone, 14796000,
iast (19.074 s) : 19074000, 19074000
.   : milestone, 19074000,
iast_GLOBAL (18.127 s) : 18127000, 18127000
.   : milestone, 18127000,
profiling (15.952 s) : 15952000, 15952000
.   : milestone, 15952000,
tracing (14.916 s) : 14916000, 14916000
.   : milestone, 14916000,
section candidate
no_agent (14.987 s) : 14987000, 14987000
.   : milestone, 14987000,
appsec (14.709 s) : 14709000, 14709000
.   : milestone, 14709000,
iast (19.048 s) : 19048000, 19048000
.   : milestone, 19048000,
iast_GLOBAL (18.252 s) : 18252000, 18252000
.   : milestone, 18252000,
profiling (15.233 s) : 15233000, 15233000
.   : milestone, 15233000,
tracing (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.102 s [15.102 s, 15.102 s] -
appsec 14.796 s [14.796 s, 14.796 s] -306.0 ms (-2.0%)
iast 19.074 s [19.074 s, 19.074 s] 3.972 s (26.3%)
iast_GLOBAL 18.127 s [18.127 s, 18.127 s] 3.025 s (20.0%)
profiling 15.952 s [15.952 s, 15.952 s] 850.0 ms (5.6%)
tracing 14.916 s [14.916 s, 14.916 s] -186.0 ms (-1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.987 s [14.987 s, 14.987 s] -
appsec 14.709 s [14.709 s, 14.709 s] -278.0 ms (-1.9%)
iast 19.048 s [19.048 s, 19.048 s] 4.061 s (27.1%)
iast_GLOBAL 18.252 s [18.252 s, 18.252 s] 3.265 s (21.8%)
profiling 15.233 s [15.233 s, 15.233 s] 246.0 ms (1.6%)
tracing 15.033 s [15.033 s, 15.033 s] 46.0 ms (0.3%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e387a1aaf1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.4 ms) : 2351, 2448
.   : milestone, 2400,
iast (2.187 ms) : 2126, 2248
.   : milestone, 2187,
iast_GLOBAL (2.234 ms) : 2172, 2296
.   : milestone, 2234,
profiling (2.056 ms) : 2006, 2107
.   : milestone, 2056,
tracing (2.007 ms) : 1959, 2054
.   : milestone, 2007,
section candidate
no_agent (1.483 ms) : 1471, 1494
.   : milestone, 1483,
appsec (2.407 ms) : 2359, 2456
.   : milestone, 2407,
iast (2.177 ms) : 2117, 2238
.   : milestone, 2177,
iast_GLOBAL (2.229 ms) : 2168, 2290
.   : milestone, 2229,
profiling (2.035 ms) : 1984, 2085
.   : milestone, 2035,
tracing (1.999 ms) : 1952, 2046
.   : milestone, 1999,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.4 ms [2.351 ms, 2.448 ms] 925.152 µs (62.7%)
iast 2.187 ms [2.126 ms, 2.248 ms] 712.322 µs (48.3%)
iast_GLOBAL 2.234 ms [2.172 ms, 2.296 ms] 759.266 µs (51.5%)
profiling 2.056 ms [2.006 ms, 2.107 ms] 581.725 µs (39.4%)
tracing 2.007 ms [1.959 ms, 2.054 ms] 531.921 µs (36.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.483 ms [1.471 ms, 1.494 ms] -
appsec 2.407 ms [2.359 ms, 2.456 ms] 924.669 µs (62.4%)
iast 2.177 ms [2.117 ms, 2.238 ms] 694.919 µs (46.9%)
iast_GLOBAL 2.229 ms [2.168 ms, 2.29 ms] 746.53 µs (50.4%)
profiling 2.035 ms [1.984 ms, 2.085 ms] 552.022 µs (37.2%)
tracing 1.999 ms [1.952 ms, 2.046 ms] 516.62 µs (34.8%)

Copy link
Contributor

@dougqh dougqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want the calls to System.err in AgentBootstrap and BootstrapInitializationTelemetry. Customers are likely to complain about any unexpected output -- especially to stderr.

@AlexeyKuznetsov-DD
Copy link
Contributor Author

We probably don't want the calls to System.err in AgentBootstrap and BootstrapInitializationTelemetry. Customers are likely to complain about any unexpected output -- especially to stderr.

@dougqh
It is temporary change, trying to debug root cause, will rollback everything before submitting for review.
Looks like I found what is the issue - it is specific to Oracle 8 JVM, very similar for IBM

  protected static final boolean isIbmFile(String filePath) {
    return filePath.endsWith("/tmp/.com_ibm_tools_attach");
  }

@mcculls
Copy link
Contributor

mcculls commented Jun 2, 2025

... are likely to complain about any unexpected output -- especially to stderr

Just to clarify, there are a few rare occasions when we have to log output before the logger is available, and for those stderr is preferred over stdout. This is because stderr is the accepted stream for diagnostic messages, whereas stdout is used for application output. So if you do end up having to use the console, never use stdout only stderr:

https://en.wikipedia.org/wiki/Standard_streams#Standard_error_(stderr)

@dougqh
Copy link
Contributor

dougqh commented Jun 3, 2025

We probably don't want the calls to System.err in AgentBootstrap and BootstrapInitializationTelemetry. Customers are likely to complain about any unexpected output -- especially to stderr.

@dougqh It is temporary change, trying to debug root cause, will rollback everything before submitting for review. Looks like I found what is the issue - it is specific to Oracle 8 JVM, very similar for IBM

  protected static final boolean isIbmFile(String filePath) {
    return filePath.endsWith("/tmp/.com_ibm_tools_attach");
  }

Okay, I just wanted to make sure.

@dougqh dougqh closed this Jun 3, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested a review from dougqh June 3, 2025 14:07
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review June 3, 2025 14:38
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested a review from a team as a code owner June 3, 2025 14:38
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD changed the title Fix for the test when running on Oracle JDK 8. Fix for the InitializationTelemetryTest when running on Oracle JDK 8. Jun 3, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD merged commit 4b9aadc into master Jun 3, 2025
509 of 510 checks passed
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD deleted the alexeyk/fix-npe-oracle-8 branch June 3, 2025 17:20
@github-actions github-actions bot added this to the 1.50.0 milestone Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core run-tests: oracle8 Run tests using Oracle 8 JDK tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants