-
Notifications
You must be signed in to change notification settings - Fork 323
Introduce environment component #8919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
10898d5 to
251c984
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 4 metrics, 8 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (339.739 µs) : 269, 411
. : milestone, 340,
basic (320.033 µs) : 302, 338
. : milestone, 320,
loop (10.19 ms) : 10149, 10230
. : milestone, 10190,
section candidate
noprobe (313.735 µs) : 290, 337
. : milestone, 314,
basic (315.272 µs) : 307, 324
. : milestone, 315,
loop (10.394 ms) : 10326, 10462
. : milestone, 10394,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~359dc42703, baseline=1.51.0-SNAPSHOT~848b0754aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001321
Total [baseline] (8.626 s) : 0, 8625667
Agent [candidate] (999.244 ms) : 0, 999244
Total [candidate] (8.57 s) : 0, 8570287
section iast
Agent [baseline] (1.136 s) : 0, 1136278
Total [baseline] (9.314 s) : 0, 9314322
Agent [candidate] (1.151 s) : 0, 1150908
Total [candidate] (9.32 s) : 0, 9319988
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~359dc42703, baseline=1.51.0-SNAPSHOT~848b0754aa
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.731 ms) : 0, 691731
BytebuddyAgent [candidate] (689.747 ms) : 0, 689747
GlobalTracer [baseline] (243.161 ms) : 0, 243161
GlobalTracer [candidate] (243.282 ms) : 0, 243282
AppSec [baseline] (30.682 ms) : 0, 30682
AppSec [candidate] (30.263 ms) : 0, 30263
Debugger [baseline] (6.067 ms) : 0, 6067
Debugger [candidate] (6.092 ms) : 0, 6092
Remote Config [baseline] (682.498 µs) : 0, 682
Remote Config [candidate] (686.839 µs) : 0, 687
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (8.286 ms) : 0, 8286
section iast
BytebuddyAgent [baseline] (812.397 ms) : 0, 812397
BytebuddyAgent [candidate] (821.992 ms) : 0, 821992
GlobalTracer [baseline] (232.884 ms) : 0, 232884
GlobalTracer [candidate] (236.364 ms) : 0, 236364
AppSec [baseline] (29.388 ms) : 0, 29388
AppSec [candidate] (31.55 ms) : 0, 31550
Debugger [baseline] (5.832 ms) : 0, 5832
Debugger [candidate] (5.914 ms) : 0, 5914
Remote Config [baseline] (577.838 µs) : 0, 578
Remote Config [candidate] (584.109 µs) : 0, 584
Telemetry [baseline] (8.018 ms) : 0, 8018
Telemetry [candidate] (8.115 ms) : 0, 8115
IAST [baseline] (26.316 ms) : 0, 26316
IAST [candidate] (25.149 ms) : 0, 25149
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~359dc42703, baseline=1.51.0-SNAPSHOT~848b0754aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.399 ms) : 0, 997399
Total [baseline] (10.646 s) : 0, 10645923
Agent [candidate] (1.007 s) : 0, 1007365
Total [candidate] (10.817 s) : 0, 10817032
section appsec
Agent [baseline] (1.172 s) : 0, 1172431
Total [baseline] (10.758 s) : 0, 10757912
Agent [candidate] (1.188 s) : 0, 1187947
Total [candidate] (10.818 s) : 0, 10817540
section iast
Agent [baseline] (1.141 s) : 0, 1140748
Total [baseline] (4.426 s) : 0, 4426350
Agent [candidate] (1.141 s) : 0, 1140669
Total [candidate] (10.873 s) : 0, 10872841
section profiling
Agent [baseline] (1.245 s) : 0, 1244847
Total [baseline] (10.98 s) : 0, 10980194
Agent [candidate] (1.25 s) : 0, 1249946
Total [candidate] (11.02 s) : 0, 11020369
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~359dc42703, baseline=1.51.0-SNAPSHOT~848b0754aa
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.588 ms) : 0, 688588
BytebuddyAgent [candidate] (696.128 ms) : 0, 696128
GlobalTracer [baseline] (242.452 ms) : 0, 242452
GlobalTracer [candidate] (244.438 ms) : 0, 244438
AppSec [baseline] (30.562 ms) : 0, 30562
AppSec [candidate] (30.687 ms) : 0, 30687
Debugger [baseline] (6.055 ms) : 0, 6055
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (677.313 µs) : 0, 677
Remote Config [candidate] (688.675 µs) : 0, 689
Telemetry [baseline] (8.215 ms) : 0, 8215
Telemetry [candidate] (8.331 ms) : 0, 8331
section appsec
BytebuddyAgent [baseline] (709.832 ms) : 0, 709832
BytebuddyAgent [candidate] (718.023 ms) : 0, 718023
GlobalTracer [baseline] (235.16 ms) : 0, 235160
GlobalTracer [candidate] (239.526 ms) : 0, 239526
AppSec [baseline] (170.279 ms) : 0, 170279
AppSec [candidate] (172.101 ms) : 0, 172101
Debugger [baseline] (5.79 ms) : 0, 5790
Debugger [candidate] (5.834 ms) : 0, 5834
Remote Config [baseline] (606.879 µs) : 0, 607
Remote Config [candidate] (611.749 µs) : 0, 612
Telemetry [baseline] (8.086 ms) : 0, 8086
Telemetry [candidate] (8.184 ms) : 0, 8184
IAST [baseline] (21.963 ms) : 0, 21963
IAST [candidate] (22.565 ms) : 0, 22565
section iast
BytebuddyAgent [baseline] (814.279 ms) : 0, 814279
BytebuddyAgent [candidate] (813.935 ms) : 0, 813935
GlobalTracer [baseline] (234.591 ms) : 0, 234591
GlobalTracer [candidate] (235.245 ms) : 0, 235245
AppSec [baseline] (32.522 ms) : 0, 32522
AppSec [candidate] (28.722 ms) : 0, 28722
Debugger [baseline] (5.795 ms) : 0, 5795
Debugger [candidate] (5.883 ms) : 0, 5883
Remote Config [baseline] (574.379 µs) : 0, 574
Remote Config [candidate] (582.917 µs) : 0, 583
Telemetry [baseline] (8.14 ms) : 0, 8140
Telemetry [candidate] (8.02 ms) : 0, 8020
IAST [baseline] (23.844 ms) : 0, 23844
IAST [candidate] (27.322 ms) : 0, 27322
section profiling
BytebuddyAgent [baseline] (679.291 ms) : 0, 679291
BytebuddyAgent [candidate] (680.797 ms) : 0, 680797
GlobalTracer [baseline] (361.421 ms) : 0, 361421
GlobalTracer [candidate] (362.864 ms) : 0, 362864
AppSec [baseline] (32.998 ms) : 0, 32998
AppSec [candidate] (31.129 ms) : 0, 31129
Debugger [baseline] (10.68 ms) : 0, 10680
Debugger [candidate] (12.112 ms) : 0, 12112
Remote Config [baseline] (678.719 µs) : 0, 679
Remote Config [candidate] (660.674 µs) : 0, 661
Telemetry [baseline] (7.99 ms) : 0, 7990
Telemetry [candidate] (9.523 ms) : 0, 9523
ProfilingAgent [baseline] (102.453 ms) : 0, 102453
ProfilingAgent [candidate] (104.229 ms) : 0, 104229
Profiling [baseline] (102.477 ms) : 0, 102477
Profiling [candidate] (104.254 ms) : 0, 104254
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~359dc42703, baseline=1.51.0-SNAPSHOT~848b0754aa
dateFormat X
axisFormat %s
section baseline
no_agent (4.416 ms) : 4366, 4465
. : milestone, 4416,
iast (9.128 ms) : 8977, 9279
. : milestone, 9128,
iast_FULL (13.735 ms) : 13466, 14005
. : milestone, 13735,
iast_GLOBAL (10.141 ms) : 9966, 10315
. : milestone, 10141,
profiling (8.803 ms) : 8657, 8948
. : milestone, 8803,
tracing (7.676 ms) : 7568, 7783
. : milestone, 7676,
section candidate
no_agent (4.291 ms) : 4241, 4340
. : milestone, 4291,
iast (9.134 ms) : 8987, 9282
. : milestone, 9134,
iast_FULL (13.933 ms) : 13657, 14209
. : milestone, 13933,
iast_GLOBAL (10.194 ms) : 10015, 10373
. : milestone, 10194,
profiling (8.879 ms) : 8736, 9022
. : milestone, 8879,
tracing (7.613 ms) : 7507, 7719
. : milestone, 7613,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~359dc42703, baseline=1.51.0-SNAPSHOT~848b0754aa
dateFormat X
axisFormat %s
section baseline
no_agent (36.975 ms) : 36681, 37270
. : milestone, 36975,
appsec (46.75 ms) : 46322, 47177
. : milestone, 46750,
code_origins (44.034 ms) : 43645, 44422
. : milestone, 44034,
iast (45.66 ms) : 45260, 46060
. : milestone, 45660,
profiling (49.866 ms) : 49372, 50360
. : milestone, 49866,
tracing (43.359 ms) : 42978, 43740
. : milestone, 43359,
section candidate
no_agent (37.144 ms) : 36840, 37447
. : milestone, 37144,
appsec (45.827 ms) : 45424, 46231
. : milestone, 45827,
code_origins (42.812 ms) : 42457, 43168
. : milestone, 42812,
iast (43.84 ms) : 43451, 44230
. : milestone, 43840,
profiling (48.622 ms) : 48199, 49045
. : milestone, 48622,
tracing (42.314 ms) : 41959, 42668
. : milestone, 42314,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~359dc42703, baseline=1.51.0-SNAPSHOT~848b0754aa
dateFormat X
axisFormat %s
section baseline
no_agent (15.573 s) : 15573000, 15573000
. : milestone, 15573000,
appsec (14.736 s) : 14736000, 14736000
. : milestone, 14736000,
iast (18.598 s) : 18598000, 18598000
. : milestone, 18598000,
iast_GLOBAL (18.156 s) : 18156000, 18156000
. : milestone, 18156000,
profiling (15.372 s) : 15372000, 15372000
. : milestone, 15372000,
tracing (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
section candidate
no_agent (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
appsec (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
iast (18.308 s) : 18308000, 18308000
. : milestone, 18308000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
. : milestone, 17994000,
profiling (15.713 s) : 15713000, 15713000
. : milestone, 15713000,
tracing (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~359dc42703, baseline=1.51.0-SNAPSHOT~848b0754aa
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.399 ms) : 2351, 2448
. : milestone, 2399,
iast (2.187 ms) : 2125, 2248
. : milestone, 2187,
iast_GLOBAL (2.237 ms) : 2175, 2299
. : milestone, 2237,
profiling (2.026 ms) : 1977, 2076
. : milestone, 2026,
tracing (2.014 ms) : 1966, 2063
. : milestone, 2014,
section candidate
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (2.409 ms) : 2360, 2458
. : milestone, 2409,
iast (2.194 ms) : 2132, 2255
. : milestone, 2194,
iast_GLOBAL (2.243 ms) : 2180, 2306
. : milestone, 2243,
profiling (2.051 ms) : 2001, 2102
. : milestone, 2051,
tracing (2.002 ms) : 1954, 2049
. : milestone, 2002,
|
3edbbb7 to
1d156ba
Compare
e1d7b71 to
08a110e
Compare
| import bootstrap.environment.EnvironmentVariables; | ||
| import bootstrap.environment.JavaVirtualMachine; | ||
| import bootstrap.environment.SystemProperties; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import bootstrap.environment.EnvironmentVariables; | |
| import bootstrap.environment.JavaVirtualMachine; | |
| import bootstrap.environment.SystemProperties; | |
| import datadog.trace.bootstrap.environment.EnvironmentVariables; | |
| import datadog.trace.bootstrap.environment.JavaVirtualMachine; | |
| import datadog.trace.bootstrap.environment.SystemProperties; |
| * Add an addition gradle configuration to be consumed by bootstrap only. | ||
| */ | ||
| tasks.shadowJar { | ||
| relocate("datadog.environment", "bootstrap.environment") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bootstrap.environment is not a known excluded package for jacoco instrumentation, this causes the instrumentation of ….core.intr.Instrumenter ….core.internal.instr.ClassInstrumenter to fail.
Relocating under a known excluded prefix solves the issue.
dd-trace-java/dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java
Lines 165 to 167 in 3dc0c20
| static final String DEFAULT_CIVISIBILITY_JACOCO_PLUGIN_EXCLUDES = | |
| "datadog.trace.*:org.apache.commons.*:org.mockito.*"; | |
| static final boolean DEFAULT_CIVISIBILITY_GIT_UPLOAD_ENABLED = true; |
| relocate("datadog.environment", "bootstrap.environment") | |
| relocate("datadog.environment", "datadog.trace.bootstrap.environment") |
FYI datadog.trace.bootstrap is already used for relocation purpose as well, e.g. her
dd-trace-java/dd-java-agent/build.gradle
Line 81 in 3dc0c20
| relocate 'java.util.logging.Logger', 'datadog.trace.bootstrap.PatchLogger' |
1d19e92 to
4d4f97d
Compare
359dc42 to
956f570
Compare
What Does This Do
DRAFT ONLY
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-458