Skip to content

Add peer tags, span kind and trace root flag to MetricKey bucket #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 22, 2025
Merged

Add peer tags, span kind and trace root flag to MetricKey bucket #9178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8d53b58
chore(css): Add peer tags, span kind and trace root flag to MetricKey…
bric3 Jul 15, 2025
a4614de
chore(css): Use a map to create the metric key
bric3 Jul 17, 2025
908548d
Improves CSS peer tag aggregation (#9336)
amarziali Aug 11, 2025
f565188
Hardcode eligible span kind since agent backpropagated are deprecated
amarziali Aug 11, 2025
ce2279b
revisit peer tags aggregation rules according to the rfc
amarziali Aug 12, 2025
81d8a79
IsTraceRoot is a tristate
amarziali Aug 20, 2025
34da211
Don't confuse trace root with top levels
amarziali Aug 21, 2025
bcf4d04
Fix build after rebase
amarziali Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dd-trace-core/src/main/java/datadog/trace/common/metrics/SerializingMetricWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public void add(MetricKey key, AggregateMetric aggregate) {
writer.writeBoolean(key.isSynthetics());

writer.writeUTF8(IS_TRACE_ROOT);
writer.writeBoolean(key.isTraceRoot());
writer.writeInt(key.isTraceRoot() ? 1 : 2); // tristate (0 unknown, 1 true, 2 false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Might be useful to represent the tri state by constants


writer.writeUTF8(SPAN_KIND);
writer.writeUTF8(key.getSpanKind());
Expand Down
2 changes: 1 addition & 1 deletion ...race-core/src/test/groovy/datadog/trace/common/metrics/SerializingMetricWriterTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ class SerializingMetricWriterTest extends DDSpecification {
assert unpacker.unpackBoolean() == key.isSynthetics()
++elementCount
assert unpacker.unpackString() == "IsTraceRoot"
assert unpacker.unpackBoolean() == key.isTraceRoot()
assert unpacker.unpackInt() == (key.isTraceRoot() ? 1 : 2)
++elementCount
assert unpacker.unpackString() == "SpanKind"
assert unpacker.unpackString() == key.getSpanKind() as String
Expand Down