Stable Config improvements #9259

mtoffl01 · 2025-07-28T16:04:31Z

What Does This Do

Refactors matchOperator logic to use method reference comparator for efficiency
Introduces a new exception type StableConfigMappingException for better exception handling and debug logging when our custom YAML parsing fails on the StableConfig class
Adds a debug log message when apm_configuration_rules is set but none of the rules match the active process
Modifies constructors for StableConfig's Rule and Selector classes with a static factoring function from(Map<?, ?>) to enforce type safety at the API level

Motivation

For (1): Suggestion by @PerfectSlayer in previous PR #9201
For (2) & (3): A result of design partner troubleshooting sessions

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-07-28T16:38:13Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg-improvements
git_commit_date	1755014538	1755032331
git_commit_sha	`ee43e5f`	`2706bca`
release_version	1.53.0-SNAPSHOT~ee43e5f19c	1.52.0-SNAPSHOT~2706bcab10

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755034351	1755034351
ci_job_id	1077445669	1077445669
ci_pipeline_id	73488051	73488051
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-aqjqkgrh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-aqjqkgrh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~2706bcab10, baseline=1.53.0-SNAPSHOT~ee43e5f19c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061656
Total [baseline] (10.868 s) : 0, 10867761
Agent [candidate] (1.045 s) : 0, 1045424
Total [candidate] (10.74 s) : 0, 10740275
section appsec
Agent [baseline] (1.222 s) : 0, 1221823
Total [baseline] (10.784 s) : 0, 10784208
Agent [candidate] (1.219 s) : 0, 1219351
Total [candidate] (10.76 s) : 0, 10760438
section iast
Agent [baseline] (1.177 s) : 0, 1176844
Total [baseline] (10.874 s) : 0, 10874193
Agent [candidate] (1.175 s) : 0, 1174667
Total [candidate] (10.913 s) : 0, 10912720
section profiling
Agent [baseline] (1.202 s) : 0, 1201884
Total [baseline] (10.919 s) : 0, 10918978
Agent [candidate] (1.202 s) : 0, 1202465
Total [candidate] (10.929 s) : 0, 10928627

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	appsec	1.222 s	160.167 ms (15.1%)
Agent	iast	1.177 s	115.188 ms (10.8%)
Agent	profiling	1.202 s	140.228 ms (13.2%)
Total	tracing	10.868 s	-
Total	appsec	10.784 s	-83.553 ms (-0.8%)
Total	iast	10.874 s	6.432 ms (0.1%)
Total	profiling	10.919 s	51.218 ms (0.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	appsec	1.219 s	173.926 ms (16.6%)
Agent	iast	1.175 s	129.243 ms (12.4%)
Agent	profiling	1.202 s	157.04 ms (15.0%)
Total	tracing	10.74 s	-
Total	appsec	10.76 s	20.163 ms (0.2%)
Total	iast	10.913 s	172.445 ms (1.6%)
Total	profiling	10.929 s	188.352 ms (1.8%)

gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~2706bcab10, baseline=1.53.0-SNAPSHOT~ee43e5f19c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (741.797 ms) : 0, 741797
BytebuddyAgent [candidate] (732.198 ms) : 0, 732198
GlobalTracer [baseline] (244.869 ms) : 0, 244869
GlobalTracer [candidate] (242.107 ms) : 0, 242107
AppSec [baseline] (30.499 ms) : 0, 30499
AppSec [candidate] (29.986 ms) : 0, 29986
Debugger [baseline] (6.097 ms) : 0, 6097
Debugger [candidate] (6.045 ms) : 0, 6045
Remote Config [baseline] (663.497 µs) : 0, 663
Remote Config [candidate] (656.208 µs) : 0, 656
Telemetry [baseline] (15.028 ms) : 0, 15028
Telemetry [candidate] (11.922 ms) : 0, 11922
section appsec
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (754.518 ms) : 0, 754518
BytebuddyAgent [candidate] (752.711 ms) : 0, 752711
GlobalTracer [baseline] (235.135 ms) : 0, 235135
GlobalTracer [candidate] (234.352 ms) : 0, 234352
AppSec [baseline] (167.635 ms) : 0, 167635
AppSec [candidate] (168.568 ms) : 0, 168568
Debugger [baseline] (7.988 ms) : 0, 7988
Debugger [candidate] (8.773 ms) : 0, 8773
Remote Config [baseline] (623.507 µs) : 0, 624
Remote Config [candidate] (617.526 µs) : 0, 618
Telemetry [baseline] (9.882 ms) : 0, 9882
Telemetry [candidate] (8.282 ms) : 0, 8282
IAST [baseline] (23.498 ms) : 0, 23498
IAST [candidate] (23.534 ms) : 0, 23534
section iast
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (849.766 ms) : 0, 849766
BytebuddyAgent [candidate] (848.136 ms) : 0, 848136
GlobalTracer [baseline] (232.653 ms) : 0, 232653
GlobalTracer [candidate] (231.799 ms) : 0, 231799
AppSec [baseline] (27.371 ms) : 0, 27371
AppSec [candidate] (27.865 ms) : 0, 27865
Debugger [baseline] (7.561 ms) : 0, 7561
Debugger [candidate] (7.601 ms) : 0, 7601
Remote Config [baseline] (567.232 µs) : 0, 567
Remote Config [candidate] (577.484 µs) : 0, 577
Telemetry [baseline] (8.234 ms) : 0, 8234
Telemetry [candidate] (8.086 ms) : 0, 8086
IAST [baseline] (28.149 ms) : 0, 28149
IAST [candidate] (28.158 ms) : 0, 28158
section profiling
crashtracking [baseline] (1.415 ms) : 0, 1415
crashtracking [candidate] (1.415 ms) : 0, 1415
BytebuddyAgent [baseline] (766.359 ms) : 0, 766359
BytebuddyAgent [candidate] (766.368 ms) : 0, 766368
GlobalTracer [baseline] (223.15 ms) : 0, 223150
GlobalTracer [candidate] (222.617 ms) : 0, 222617
AppSec [baseline] (30.335 ms) : 0, 30335
AppSec [candidate] (30.252 ms) : 0, 30252
Debugger [baseline] (6.308 ms) : 0, 6308
Debugger [candidate] (6.321 ms) : 0, 6321
Remote Config [baseline] (677.067 µs) : 0, 677
Remote Config [candidate] (692.276 µs) : 0, 692
Telemetry [baseline] (15.381 ms) : 0, 15381
Telemetry [candidate] (15.969 ms) : 0, 15969
ProfilingAgent [baseline] (108.445 ms) : 0, 108445
ProfilingAgent [candidate] (109.004 ms) : 0, 109004
Profiling [baseline] (109.077 ms) : 0, 109077
Profiling [candidate] (109.674 ms) : 0, 109674

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~2706bcab10, baseline=1.53.0-SNAPSHOT~ee43e5f19c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046047
Total [baseline] (8.653 s) : 0, 8653448
Agent [candidate] (1.05 s) : 0, 1050143
Total [candidate] (8.601 s) : 0, 8601228
section iast
Agent [baseline] (1.172 s) : 0, 1171971
Total [baseline] (9.333 s) : 0, 9332756
Agent [candidate] (1.174 s) : 0, 1174152
Total [candidate] (9.331 s) : 0, 9331000

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	iast	1.172 s	125.924 ms (12.0%)
Total	tracing	8.653 s	-
Total	iast	9.333 s	679.308 ms (7.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.174 s	124.009 ms (11.8%)
Total	tracing	8.601 s	-
Total	iast	9.331 s	729.772 ms (8.5%)

gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~2706bcab10, baseline=1.53.0-SNAPSHOT~ee43e5f19c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (732.13 ms) : 0, 732130
BytebuddyAgent [candidate] (736.394 ms) : 0, 736394
GlobalTracer [baseline] (243.067 ms) : 0, 243067
GlobalTracer [candidate] (242.773 ms) : 0, 242773
AppSec [baseline] (30.26 ms) : 0, 30260
AppSec [candidate] (30.325 ms) : 0, 30325
Debugger [baseline] (6.047 ms) : 0, 6047
Debugger [candidate] (6.088 ms) : 0, 6088
Remote Config [baseline] (660.816 µs) : 0, 661
Remote Config [candidate] (656.841 µs) : 0, 657
Telemetry [baseline] (11.448 ms) : 0, 11448
Telemetry [candidate] (11.317 ms) : 0, 11317
section iast
crashtracking [baseline] (1.418 ms) : 0, 1418
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (845.799 ms) : 0, 845799
BytebuddyAgent [candidate] (848.189 ms) : 0, 848189
GlobalTracer [baseline] (231.841 ms) : 0, 231841
GlobalTracer [candidate] (231.462 ms) : 0, 231462
AppSec [baseline] (26.614 ms) : 0, 26614
AppSec [candidate] (26.162 ms) : 0, 26162
Debugger [baseline] (8.291 ms) : 0, 8291
Debugger [candidate] (6.667 ms) : 0, 6667
Remote Config [baseline] (581.118 µs) : 0, 581
Remote Config [candidate] (593.269 µs) : 0, 593
Telemetry [baseline] (8.172 ms) : 0, 8172
Telemetry [candidate] (8.088 ms) : 0, 8088
IAST [baseline] (28.278 ms) : 0, 28278
IAST [candidate] (30.636 ms) : 0, 30636

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg-improvements
git_commit_date	1755014538	1755032331
git_commit_sha	`ee43e5f`	`2706bca`
release_version	1.53.0-SNAPSHOT~ee43e5f19c	1.52.0-SNAPSHOT~2706bcab10

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755034015	1755034015
ci_job_id	1077445670	1077445670
ci_pipeline_id	73488051	73488051
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-pwce8qez 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-pwce8qez 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	worse [+595.461µs; +920.175µs] or [+6.931%; +10.710%]	unstable [-111.334op/s; +24.896op/s] or [-20.625%; +4.612%]	9.350ms	496.594op/s	8.592ms	539.812op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~2706bcab10, baseline=1.53.0-SNAPSHOT~ee43e5f19c
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.565 ms) : 37252, 37878
.   : milestone, 37565,
appsec (49.305 ms) : 48866, 49744
.   : milestone, 49305,
code_origins (44.595 ms) : 44213, 44977
.   : milestone, 44595,
iast (44.835 ms) : 44432, 45238
.   : milestone, 44835,
profiling (46.373 ms) : 45943, 46804
.   : milestone, 46373,
tracing (44.259 ms) : 43882, 44636
.   : milestone, 44259,
section candidate
no_agent (37.847 ms) : 37547, 38146
.   : milestone, 37847,
appsec (48.614 ms) : 48178, 49050
.   : milestone, 48614,
code_origins (45.784 ms) : 45380, 46188
.   : milestone, 45784,
iast (45.028 ms) : 44637, 45419
.   : milestone, 45028,
profiling (46.887 ms) : 46450, 47325
.   : milestone, 46887,
tracing (44.067 ms) : 43679, 44456
.   : milestone, 44067,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.565 ms [37.252 ms, 37.878 ms]	-
appsec	49.305 ms [48.866 ms, 49.744 ms]	11.74 ms (31.3%)
code_origins	44.595 ms [44.213 ms, 44.977 ms]	7.03 ms (18.7%)
iast	44.835 ms [44.432 ms, 45.238 ms]	7.27 ms (19.4%)
profiling	46.373 ms [45.943 ms, 46.804 ms]	8.808 ms (23.4%)
tracing	44.259 ms [43.882 ms, 44.636 ms]	6.694 ms (17.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.847 ms [37.547 ms, 38.146 ms]	-
appsec	48.614 ms [48.178 ms, 49.05 ms]	10.767 ms (28.4%)
code_origins	45.784 ms [45.38 ms, 46.188 ms]	7.937 ms (21.0%)
iast	45.028 ms [44.637 ms, 45.419 ms]	7.181 ms (19.0%)
profiling	46.887 ms [46.45 ms, 47.325 ms]	9.041 ms (23.9%)
tracing	44.067 ms [43.679 ms, 44.456 ms]	6.221 ms (16.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~2706bcab10, baseline=1.53.0-SNAPSHOT~ee43e5f19c
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.44 ms) : 4388, 4492
.   : milestone, 4440,
iast (9.09 ms) : 8944, 9237
.   : milestone, 9090,
iast_FULL (13.728 ms) : 13453, 14002
.   : milestone, 13728,
iast_GLOBAL (10.35 ms) : 10156, 10545
.   : milestone, 10350,
profiling (8.592 ms) : 8460, 8724
.   : milestone, 8592,
tracing (7.662 ms) : 7553, 7770
.   : milestone, 7662,
section candidate
no_agent (4.451 ms) : 4397, 4505
.   : milestone, 4451,
iast (9.314 ms) : 9161, 9467
.   : milestone, 9314,
iast_FULL (13.712 ms) : 13440, 13984
.   : milestone, 13712,
iast_GLOBAL (10.105 ms) : 9928, 10282
.   : milestone, 10105,
profiling (9.35 ms) : 9182, 9517
.   : milestone, 9350,
tracing (7.686 ms) : 7578, 7795
.   : milestone, 7686,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.44 ms [4.388 ms, 4.492 ms]	-
iast	9.09 ms [8.944 ms, 9.237 ms]	4.651 ms (104.8%)
iast_FULL	13.728 ms [13.453 ms, 14.002 ms]	9.288 ms (209.2%)
iast_GLOBAL	10.35 ms [10.156 ms, 10.545 ms]	5.911 ms (133.1%)
profiling	8.592 ms [8.46 ms, 8.724 ms]	4.152 ms (93.5%)
tracing	7.662 ms [7.553 ms, 7.77 ms]	3.222 ms (72.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.451 ms [4.397 ms, 4.505 ms]	-
iast	9.314 ms [9.161 ms, 9.467 ms]	4.863 ms (109.3%)
iast_FULL	13.712 ms [13.44 ms, 13.984 ms]	9.261 ms (208.1%)
iast_GLOBAL	10.105 ms [9.928 ms, 10.282 ms]	5.654 ms (127.0%)
profiling	9.35 ms [9.182 ms, 9.517 ms]	4.898 ms (110.0%)
tracing	7.686 ms [7.578 ms, 7.795 ms]	3.235 ms (72.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg-improvements
git_commit_date	1755014538	1755032331
git_commit_sha	`ee43e5f`	`2706bca`
release_version	1.53.0-SNAPSHOT~ee43e5f19c	1.52.0-SNAPSHOT~2706bcab10

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755034527	1755034527
ci_job_id	1077445671	1077445671
ci_pipeline_id	73488051	73488051
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-i23mzwas 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-i23mzwas 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:dacapo:tomcat:appsec	better [-1.403ms; -1.067ms] or [-38.567%; -29.331%]	2.403ms	3.638ms

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~2706bcab10, baseline=1.53.0-SNAPSHOT~ee43e5f19c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
appsec (14.765 s) : 14765000, 14765000
.   : milestone, 14765000,
iast (18.223 s) : 18223000, 18223000
.   : milestone, 18223000,
iast_GLOBAL (17.903 s) : 17903000, 17903000
.   : milestone, 17903000,
profiling (15.231 s) : 15231000, 15231000
.   : milestone, 15231000,
tracing (14.855 s) : 14855000, 14855000
.   : milestone, 14855000,
section candidate
no_agent (14.851 s) : 14851000, 14851000
.   : milestone, 14851000,
appsec (14.737 s) : 14737000, 14737000
.   : milestone, 14737000,
iast (18.734 s) : 18734000, 18734000
.   : milestone, 18734000,
iast_GLOBAL (18.134 s) : 18134000, 18134000
.   : milestone, 18134000,
profiling (15.348 s) : 15348000, 15348000
.   : milestone, 15348000,
tracing (14.809 s) : 14809000, 14809000
.   : milestone, 14809000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.009 s [15.009 s, 15.009 s]	-
appsec	14.765 s [14.765 s, 14.765 s]	-244.0 ms (-1.6%)
iast	18.223 s [18.223 s, 18.223 s]	3.214 s (21.4%)
iast_GLOBAL	17.903 s [17.903 s, 17.903 s]	2.894 s (19.3%)
profiling	15.231 s [15.231 s, 15.231 s]	222.0 ms (1.5%)
tracing	14.855 s [14.855 s, 14.855 s]	-154.0 ms (-1.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.851 s [14.851 s, 14.851 s]	-
appsec	14.737 s [14.737 s, 14.737 s]	-114.0 ms (-0.8%)
iast	18.734 s [18.734 s, 18.734 s]	3.883 s (26.1%)
iast_GLOBAL	18.134 s [18.134 s, 18.134 s]	3.283 s (22.1%)
profiling	15.348 s [15.348 s, 15.348 s]	497.0 ms (3.3%)
tracing	14.809 s [14.809 s, 14.809 s]	-42.0 ms (-0.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~2706bcab10, baseline=1.53.0-SNAPSHOT~ee43e5f19c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (3.638 ms) : 3423, 3853
.   : milestone, 3638,
iast (2.191 ms) : 2128, 2254
.   : milestone, 2191,
iast_GLOBAL (2.232 ms) : 2169, 2294
.   : milestone, 2232,
profiling (2.049 ms) : 1997, 2100
.   : milestone, 2049,
tracing (2.018 ms) : 1969, 2067
.   : milestone, 2018,
section candidate
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.403 ms) : 2353, 2453
.   : milestone, 2403,
iast (2.18 ms) : 2118, 2242
.   : milestone, 2180,
iast_GLOBAL (2.23 ms) : 2168, 2292
.   : milestone, 2230,
profiling (2.025 ms) : 1976, 2075
.   : milestone, 2025,
tracing (2.005 ms) : 1957, 2053
.   : milestone, 2005,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	3.638 ms [3.423 ms, 3.853 ms]	2.169 ms (147.6%)
iast	2.191 ms [2.128 ms, 2.254 ms]	721.977 µs (49.1%)
iast_GLOBAL	2.232 ms [2.169 ms, 2.294 ms]	762.448 µs (51.9%)
profiling	2.049 ms [1.997 ms, 2.1 ms]	579.579 µs (39.5%)
tracing	2.018 ms [1.969 ms, 2.067 ms]	548.856 µs (37.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.464 ms, 1.487 ms]	-
appsec	2.403 ms [2.353 ms, 2.453 ms]	927.525 µs (62.9%)
iast	2.18 ms [2.118 ms, 2.242 ms]	704.672 µs (47.8%)
iast_GLOBAL	2.23 ms [2.168 ms, 2.292 ms]	754.591 µs (51.1%)
profiling	2.025 ms [1.976 ms, 2.075 ms]	549.901 µs (37.3%)
tracing	2.005 ms [1.957 ms, 2.053 ms]	529.255 µs (35.9%)

…g parsing errors

mtoffl01 · 2025-07-28T20:41:55Z

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java

@@ -26,12 +26,34 @@ public Rule(List<Selector> selectors, Map<String, Object> configuration) {
  }

  public Rule(Object yaml) {


Let me know if this constructor is too hard to read and if you recommend I move the "require fields" logic into helper functions (in a utils class to be used by both Rule and Selector?)

Overall, I would rather try to bring type safety to the Java API as soon as possible even if SnakeYaml is returning loose Object.

An idiomatic Java would be to have a static builder like static Rule from(Map<?, ?> rules) and check that its parameters is the right time before calling it.
-- Note that a better type for rules would be Map<String, ?> but there is no way to enforce / test it due to type erasure in Java.

So far example, I would check the type ahead in StableConfig before trying to create rule using its fromMap:

this.apmConfigurationRules = parseRules(yaml); // with some helper methods in StableConfig private List<Rule> parseRules(Map<?, ?> yaml) { Object apmConfigurationDefaultObject = map.get("apm_configuration_default"); if (apmConfigurationDefaultObject instanceof List) { return ((List<?>) apmConfigurationDefaultObject).stream() .filter(r -> r instanceof Map) .map(r -> (Map<?, ?>) r) .map(Rule::fromMap) .collect(toList()); } else { return emptyList(); } }

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Selector.java

PerfectSlayer · 2025-07-29T15:12:32Z

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java

@@ -26,12 +26,34 @@ public Rule(List<Selector> selectors, Map<String, Object> configuration) {
  }

  public Rule(Object yaml) {


Overall, I would rather try to bring type safety to the Java API as soon as possible even if SnakeYaml is returning loose Object.

An idiomatic Java would be to have a static builder like static Rule from(Map<?, ?> rules) and check that its parameters is the right time before calling it.
-- Note that a better type for rules would be Map<String, ?> but there is no way to enforce / test it due to type erasure in Java.

So far example, I would check the type ahead in StableConfig before trying to create rule using its fromMap:

this.apmConfigurationRules = parseRules(yaml); // with some helper methods in StableConfig private List<Rule> parseRules(Map<?, ?> yaml) { Object apmConfigurationDefaultObject = map.get("apm_configuration_default"); if (apmConfigurationDefaultObject instanceof List) { return ((List<?>) apmConfigurationDefaultObject).stream() .filter(r -> r instanceof Map) .map(r -> (Map<?, ?>) r) .map(Rule::fromMap) .collect(toList()); } else { return emptyList(); } }

PerfectSlayer · 2025-07-29T15:30:35Z

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java

-          return value.contains(match);
-        default:
-          return false;
+      if (comparator.test(match)) {


…le and Selector classes

datadog-datadog-prod-us1 · 2025-07-31T17:07:49Z

Code coverage: total 57.11%, base diff 0.02%, patch 87.91% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 2706bca | Docs | Was this helpful? Give us feedback!}

…ilure

.../java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfigMappingException.java

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java

github-actions · 2025-08-04T16:37:37Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

PerfectSlayer

Looking good 👍
One question about testing logging though

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java

...al-api/src/test/groovy/datadog/trace/bootstrap/config/provider/StableConfigSourceTest.groovy

PerfectSlayer

Thanks for the follow up PR and the improvements 👍

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Selector.java

...nal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfig.java

.../java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfigMappingException.java

…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <[email protected]>

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Selector.java

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java

.../java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfigMappingException.java

...nal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfig.java

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java

AlexeyKuznetsov-DD · 2025-08-12T18:35:02Z

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java

+      } else if (log.isDebugEnabled()) {
+        log.error("Unexpected error while reading stable configuration file {}: {}", filePath, e);
+      } else {


Not sure I understand this if (log.isDebugEnabled())...
To me it looks like we can log that error always, because all major cases were processed in previous if block.
Also, I feel that here we have a very tricky case: you have 2 placeholders {}, but the second argument e is actually an exception and it will be treaded in a special way. So you should use only one place holder, or provide as second argument something else, for example e.getMessage().

As for the log.isDebugEnabled() check: this was something @mcculls suggested; we want to print the complete exception if and only if debug is enabled, else just print the exception message. An alternative is to only print the message regardless, I suppose. WDYT?

As for the placeholder: I was not aware, thanks for sharing. 🤔 I will change this accordingly, based on what we decide on the above.

got it! make sense in debug to print stack trace
but code should be with one place holder:
log.error("Unexpected error while reading stable configuration file: {}", filePath, e);

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java

.../java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfigMappingException.java

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Selector.java

…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <[email protected]>

…invocations

…-java into mtoff/scfg-improvements

AlexeyKuznetsov-DD · 2025-08-12T20:40:13Z

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java

+      } else if (log.isDebugEnabled()) {
+        log.error("Unexpected error while reading stable configuration file {}: {}", filePath, e);
+      } else {


got it! make sense in debug to print stack trace
but code should be with one place holder:
log.error("Unexpected error while reading stable configuration file: {}", filePath, e);

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java

…ider/StableConfigSource.java Co-authored-by: Alexey Kuznetsov <[email protected]>

Refactor matchOperator to use method reference comparator for efficiency

370e894

Implement better exception handling and debug logging for StableConfi…

df4da2f

…g parsing errors

mtoffl01 commented Jul 28, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Selector.java Outdated Show resolved Hide resolved

Add a debug log about no rules getting applied

7049d36

PerfectSlayer reviewed Jul 29, 2025

View reviewed changes

mtoffl01 added 2 commits July 29, 2025 11:37

Improve test file logic and cleanup in StableConfigSourceTest class

e730cbe

Github suggestions: Use static factory methods as constructors for Ru…

5b639aa

…le and Selector classes

mtoffl01 added 2 commits August 1, 2025 10:03

Improve exception message: include value of object that caused the fa…

85d11cf

…ilure

Add more test cases to StableConfigSourceTest to improve codecov

6ab4b6c

mtoffl01 commented Aug 1, 2025

View reviewed changes

.../java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfigMappingException.java Outdated Show resolved Hide resolved

mtoffl01 commented Aug 1, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java Outdated Show resolved Hide resolved

mtoffl01 and others added 2 commits August 1, 2025 16:28

Add test coverage for StableConfigMappingException

007f58a

Merge branch 'master' into mtoff/scfg-improvements

ac69f2d

mtoffl01 marked this pull request as ready for review August 4, 2025 16:37

mtoffl01 requested a review from a team as a code owner August 4, 2025 16:37

mtoffl01 requested a review from PerfectSlayer August 4, 2025 16:37

PerfectSlayer reviewed Aug 5, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java Outdated Show resolved Hide resolved

...al-api/src/test/groovy/datadog/trace/bootstrap/config/provider/StableConfigSourceTest.groovy Show resolved Hide resolved

PerfectSlayer approved these changes Aug 6, 2025

View reviewed changes

AlexeyKuznetsov-DD requested changes Aug 6, 2025

View reviewed changes

Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…

473c59b

…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <[email protected]>

mtoffl01 requested a review from a team as a code owner August 8, 2025 15:55

mtoffl01 and others added 2 commits August 8, 2025 11:55

Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…

feb1ba0

…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <[email protected]>

Use safeToString when printing stableconfig map

f93546a

mtoffl01 commented Aug 8, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java Outdated Show resolved Hide resolved

mtoffl01 added 2 commits August 8, 2025 13:40

rearrange logic in selectors creation for better readability

780aee3

delete superfluous else

ac5e05a

Use constant to represent max length in safeToString

bcebbcb

mtoffl01 requested a review from AlexeyKuznetsov-DD August 8, 2025 17:50

AlexeyKuznetsov-DD requested changes Aug 11, 2025

View reviewed changes

mtoffl01 added 2 commits August 11, 2025 14:00

use throwStableConfigMappingException helper function

0baccfd

refactor exception catching in StableConfigSource

957d9c9

AlexeyKuznetsov-DD requested changes Aug 11, 2025

View reviewed changes

mtoffl01 added 5 commits August 11, 2025 15:43

restore semicolon in calls to throwStableConfigMappingException

b9870bd

Use static import for throwStableConfigMappingException

5019584

test other kinds of exceptions in StableConfigSource

e8d6e8f

remove duplicate cfg assignments

1fefb17

fix missing operator test case

058cbda

mtoffl01 requested a review from AlexeyKuznetsov-DD August 12, 2025 15:20

mtoffl01 added the type: enhancement Enhancements and improvements label Aug 12, 2025

AlexeyKuznetsov-DD requested changes Aug 12, 2025

View reviewed changes

mtoffl01 and others added 3 commits August 12, 2025 14:59

Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…

5460c8a

…ider/stableconfig/Rule.java Co-authored-by: Alexey Kuznetsov <[email protected]>

Improve readability of StableConfigMappingException and its function …

37da711

…invocations

modify safeToString logic to print first 50 and last 50 chars

5dac7f8

mtoffl01 added comp: core Tracer core comp: logging Tracer internal logging labels Aug 12, 2025

Merge branch 'mtoff/scfg-improvements' of github.com:DataDog/dd-trace…

5104ac5

…-java into mtoff/scfg-improvements

mtoffl01 requested a review from AlexeyKuznetsov-DD August 12, 2025 20:16

AlexeyKuznetsov-DD requested changes Aug 12, 2025

View reviewed changes

remove extra placeholder in string message when printing exception

13bef8d

AlexeyKuznetsov-DD requested changes Aug 12, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java Outdated Show resolved Hide resolved

Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…

2706bca

…ider/StableConfigSource.java Co-authored-by: Alexey Kuznetsov <[email protected]>

		@@ -26,12 +26,34 @@ public Rule(List<Selector> selectors, Map<String, Object> configuration) {
		}

		public Rule(Object yaml) {

Stable Config improvements #9259

Are you sure you want to change the base?

Stable Config improvements #9259

Uh oh!

Conversation

mtoffl01 commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mtoffl01 commented Jul 28, 2025 •

edited

Loading

pr-commenter bot commented Jul 28, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Aug 4, 2025 •

edited

Loading