Skip to content

Container hash tags propagation #9282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ygree
Copy link
Contributor

@ygree ygree commented Jul 30, 2025

What Does This Do

  • [DSM] Populate the base hash with the container tag hash if the process tag propagation feature flag is.
  • [DSM] Inject the base hash into the pathway context?
  • [DBM] Refactor getBaseHash to make it visible in the DBM
  • [DBM] Inject the base hash into the SQL comment when the service mode is enabled.
    • fix SQLCommenterTest
    • add DB_DBM_INJECT_SERVICE_HASH_ENABLED

Motivation

Additional Notes

Contributor Checklist

Jira ticket: AIDM-700

@ygree ygree self-assigned this Jul 30, 2025
@ygree ygree added comp: data streams Data Streams Monitoring comp: database Database Monitoring labels Jul 30, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jul 30, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/container-tags-hash-propagation
git_commit_date 1755127609 1755129673
git_commit_sha 0f3ab90 8eb36bc
release_version 1.53.0-SNAPSHOT~0f3ab90a6f 1.52.0-SNAPSHOT~8eb36bc480
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1755131458 1755131458
ci_job_id 1079771685 1079771685
ci_pipeline_id 73633463 73633463
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-jfwaauxv 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-jfwaauxv 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~8eb36bc480, baseline=1.53.0-SNAPSHOT~0f3ab90a6f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048800
Total [baseline] (8.596 s) : 0, 8595983
Agent [candidate] (1.044 s) : 0, 1044313
Total [candidate] (8.494 s) : 0, 8494234
section iast
Agent [baseline] (1.177 s) : 0, 1177037
Total [baseline] (9.316 s) : 0, 9315858
Agent [candidate] (1.179 s) : 0, 1179331
Total [candidate] (9.253 s) : 0, 9252662
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.177 s 128.237 ms (12.2%)
Total tracing 8.596 s -
Total iast 9.316 s 719.875 ms (8.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.179 s 135.019 ms (12.9%)
Total tracing 8.494 s -
Total iast 9.253 s 758.429 ms (8.9%)
gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~8eb36bc480, baseline=1.53.0-SNAPSHOT~0f3ab90a6f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (732.495 ms) : 0, 732495
BytebuddyAgent [candidate] (731.174 ms) : 0, 731174
GlobalTracer [baseline] (242.651 ms) : 0, 242651
GlobalTracer [candidate] (241.572 ms) : 0, 241572
AppSec [baseline] (30.266 ms) : 0, 30266
AppSec [candidate] (30.038 ms) : 0, 30038
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (6.017 ms) : 0, 6017
Remote Config [baseline] (653.079 µs) : 0, 653
Remote Config [candidate] (654.415 µs) : 0, 654
Telemetry [baseline] (14.224 ms) : 0, 14224
Telemetry [candidate] (12.63 ms) : 0, 12630
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (849.463 ms) : 0, 849463
BytebuddyAgent [candidate] (851.176 ms) : 0, 851176
GlobalTracer [baseline] (232.518 ms) : 0, 232518
GlobalTracer [candidate] (233.236 ms) : 0, 233236
IAST [baseline] (28.591 ms) : 0, 28591
IAST [candidate] (27.498 ms) : 0, 27498
AppSec [baseline] (26.801 ms) : 0, 26801
AppSec [candidate] (27.781 ms) : 0, 27781
Debugger [baseline] (8.421 ms) : 0, 8421
Debugger [candidate] (8.32 ms) : 0, 8320
Remote Config [baseline] (572.772 µs) : 0, 573
Remote Config [candidate] (578.5 µs) : 0, 578
Telemetry [baseline] (8.285 ms) : 0, 8285
Telemetry [candidate] (8.331 ms) : 0, 8331
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~8eb36bc480, baseline=1.53.0-SNAPSHOT~0f3ab90a6f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060300
Total [baseline] (10.801 s) : 0, 10800610
Agent [candidate] (1.044 s) : 0, 1044362
Total [candidate] (10.622 s) : 0, 10621960
section appsec
Agent [baseline] (1.218 s) : 0, 1217666
Total [baseline] (10.806 s) : 0, 10805767
Agent [candidate] (1.226 s) : 0, 1226330
Total [candidate] (10.84 s) : 0, 10839587
section iast
Agent [baseline] (1.183 s) : 0, 1182603
Total [baseline] (10.911 s) : 0, 10910637
Agent [candidate] (1.186 s) : 0, 1185872
Total [candidate] (10.847 s) : 0, 10847435
section profiling
Agent [baseline] (1.202 s) : 0, 1201877
Total [baseline] (10.965 s) : 0, 10964596
Agent [candidate] (1.198 s) : 0, 1197923
Total [candidate] (10.96 s) : 0, 10960070
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.218 s 157.366 ms (14.8%)
Agent iast 1.183 s 122.302 ms (11.5%)
Agent profiling 1.202 s 141.577 ms (13.4%)
Total tracing 10.801 s -
Total appsec 10.806 s 5.157 ms (0.0%)
Total iast 10.911 s 110.027 ms (1.0%)
Total profiling 10.965 s 163.986 ms (1.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent appsec 1.226 s 181.969 ms (17.4%)
Agent iast 1.186 s 141.511 ms (13.5%)
Agent profiling 1.198 s 153.561 ms (14.7%)
Total tracing 10.622 s -
Total appsec 10.84 s 217.627 ms (2.0%)
Total iast 10.847 s 225.475 ms (2.1%)
Total profiling 10.96 s 338.11 ms (3.2%)
gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~8eb36bc480, baseline=1.53.0-SNAPSHOT~0f3ab90a6f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (743.222 ms) : 0, 743222
BytebuddyAgent [candidate] (732.223 ms) : 0, 732223
GlobalTracer [baseline] (245.303 ms) : 0, 245303
GlobalTracer [candidate] (241.789 ms) : 0, 241789
AppSec [baseline] (30.69 ms) : 0, 30690
AppSec [candidate] (29.972 ms) : 0, 29972
Debugger [baseline] (6.09 ms) : 0, 6090
Debugger [candidate] (5.998 ms) : 0, 5998
Remote Config [baseline] (662.094 µs) : 0, 662
Remote Config [candidate] (646.912 µs) : 0, 647
Telemetry [baseline] (11.691 ms) : 0, 11691
Telemetry [candidate] (11.326 ms) : 0, 11326
section appsec
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (752.43 ms) : 0, 752430
BytebuddyAgent [candidate] (757.052 ms) : 0, 757052
GlobalTracer [baseline] (234.322 ms) : 0, 234322
GlobalTracer [candidate] (236.438 ms) : 0, 236438
IAST [baseline] (23.544 ms) : 0, 23544
IAST [candidate] (23.736 ms) : 0, 23736
AppSec [baseline] (169.68 ms) : 0, 169680
AppSec [candidate] (171.039 ms) : 0, 171039
Debugger [baseline] (6.409 ms) : 0, 6409
Debugger [candidate] (6.431 ms) : 0, 6431
Remote Config [baseline] (595.929 µs) : 0, 596
Remote Config [candidate] (639.428 µs) : 0, 639
Telemetry [baseline] (8.334 ms) : 0, 8334
Telemetry [candidate] (8.463 ms) : 0, 8463
section iast
crashtracking [baseline] (1.422 ms) : 0, 1422
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (854.368 ms) : 0, 854368
BytebuddyAgent [candidate] (857.781 ms) : 0, 857781
GlobalTracer [baseline] (233.139 ms) : 0, 233139
GlobalTracer [candidate] (232.817 ms) : 0, 232817
IAST [baseline] (28.656 ms) : 0, 28656
IAST [candidate] (27.044 ms) : 0, 27044
AppSec [baseline] (26.663 ms) : 0, 26663
AppSec [candidate] (28.331 ms) : 0, 28331
Debugger [baseline] (7.45 ms) : 0, 7450
Debugger [candidate] (8.212 ms) : 0, 8212
Remote Config [baseline] (581.844 µs) : 0, 582
Remote Config [candidate] (577.648 µs) : 0, 578
Telemetry [baseline] (9.199 ms) : 0, 9199
Telemetry [candidate] (8.373 ms) : 0, 8373
section profiling
crashtracking [baseline] (1.406 ms) : 0, 1406
crashtracking [candidate] (1.402 ms) : 0, 1402
BytebuddyAgent [baseline] (765.673 ms) : 0, 765673
BytebuddyAgent [candidate] (762.29 ms) : 0, 762290
GlobalTracer [baseline] (223.12 ms) : 0, 223120
GlobalTracer [candidate] (223.129 ms) : 0, 223129
AppSec [baseline] (30.158 ms) : 0, 30158
AppSec [candidate] (30.271 ms) : 0, 30271
Debugger [baseline] (6.253 ms) : 0, 6253
Debugger [candidate] (6.321 ms) : 0, 6321
Remote Config [baseline] (679.025 µs) : 0, 679
Remote Config [candidate] (682.053 µs) : 0, 682
Telemetry [baseline] (16.225 ms) : 0, 16225
Telemetry [candidate] (16.196 ms) : 0, 16196
ProfilingAgent [baseline] (108.667 ms) : 0, 108667
ProfilingAgent [candidate] (108.014 ms) : 0, 108014
Profiling [baseline] (109.335 ms) : 0, 109335
Profiling [candidate] (108.671 ms) : 0, 108671
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/container-tags-hash-propagation
git_commit_date 1755127609 1755129673
git_commit_sha 0f3ab90 8eb36bc
release_version 1.53.0-SNAPSHOT~0f3ab90a6f 1.52.0-SNAPSHOT~8eb36bc480
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1755131131 1755131131
ci_job_id 1079771686 1079771686
ci_pipeline_id 73633463 73633463
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-q010jkmk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-q010jkmk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 5 performance improvements and 2 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast:high_load better
[-619.518µs; -289.736µs] or [-6.698%; -3.132%]
unstable
[-34.401op/s; +85.776op/s] or [-6.855%; +17.092%]
8.795ms 527.531op/s 9.250ms 501.844op/s
scenario:load:insecure-bank:tracing:high_load better
[-850.264µs; -635.688µs] or [-11.158%; -8.342%]
unstable
[-10.402op/s; +139.777op/s] or [-1.711%; +22.998%]
6.877ms 672.469op/s 7.620ms 607.781op/s
scenario:load:insecure-bank:profiling:high_load better
[-669.000µs; -384.316µs] or [-7.664%; -4.403%]
unstable
[-34.827op/s; +101.952op/s] or [-6.553%; +19.183%]
8.202ms 565.031op/s 8.729ms 531.469op/s
scenario:load:petclinic:appsec:high_load worse
[+1.071ms; +2.008ms] or [+2.303%; +4.318%]
unstable
[-10.865op/s; +4.365op/s] or [-10.794%; +4.336%]
48.034ms 97.412op/s 46.494ms 100.662op/s
scenario:load:petclinic:tracing:high_load worse
[+1.376ms; +2.169ms] or [+3.230%; +5.092%]
unstable
[-12.115op/s; +3.490op/s] or [-11.033%; +3.178%]
44.372ms 105.500op/s 42.600ms 109.812op/s
scenario:load:petclinic:iast:high_load better
[-3.051ms; -2.226ms] or [-6.594%; -4.810%]
unstable
[-1.354op/s; +13.579op/s] or [-1.338%; +13.427%]
43.633ms 107.237op/s 46.271ms 101.125op/s
scenario:load:petclinic:code_origins:high_load better
[-3.090ms; -2.249ms] or [-6.618%; -4.816%]
unstable
[-1.043op/s; +13.093op/s] or [-1.040%; +13.062%]
44.027ms 106.263op/s 46.697ms 100.237op/s
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~8eb36bc480, baseline=1.53.0-SNAPSHOT~0f3ab90a6f
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.373 ms) : 4321, 4424
.   : milestone, 4373,
iast (9.25 ms) : 9097, 9403
.   : milestone, 9250,
iast_FULL (13.763 ms) : 13494, 14032
.   : milestone, 13763,
iast_GLOBAL (10.189 ms) : 10009, 10369
.   : milestone, 10189,
profiling (8.729 ms) : 8595, 8863
.   : milestone, 8729,
tracing (7.62 ms) : 7514, 7727
.   : milestone, 7620,
section candidate
no_agent (4.307 ms) : 4258, 4356
.   : milestone, 4307,
iast (8.795 ms) : 8642, 8948
.   : milestone, 8795,
iast_FULL (14.014 ms) : 13733, 14296
.   : milestone, 14014,
iast_GLOBAL (9.815 ms) : 9640, 9990
.   : milestone, 9815,
profiling (8.202 ms) : 8072, 8333
.   : milestone, 8202,
tracing (6.877 ms) : 6785, 6970
.   : milestone, 6877,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.373 ms [4.321 ms, 4.424 ms] -
iast 9.25 ms [9.097 ms, 9.403 ms] 4.877 ms (111.5%)
iast_FULL 13.763 ms [13.494 ms, 14.032 ms] 9.391 ms (214.8%)
iast_GLOBAL 10.189 ms [10.009 ms, 10.369 ms] 5.817 ms (133.0%)
profiling 8.729 ms [8.595 ms, 8.863 ms] 4.356 ms (99.6%)
tracing 7.62 ms [7.514 ms, 7.727 ms] 3.248 ms (74.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.307 ms [4.258 ms, 4.356 ms] -
iast 8.795 ms [8.642 ms, 8.948 ms] 4.488 ms (104.2%)
iast_FULL 14.014 ms [13.733 ms, 14.296 ms] 9.708 ms (225.4%)
iast_GLOBAL 9.815 ms [9.64 ms, 9.99 ms] 5.509 ms (127.9%)
profiling 8.202 ms [8.072 ms, 8.333 ms] 3.895 ms (90.5%)
tracing 6.877 ms [6.785 ms, 6.97 ms] 2.571 ms (59.7%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~8eb36bc480, baseline=1.53.0-SNAPSHOT~0f3ab90a6f
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.684 ms) : 37385, 37983
.   : milestone, 37684,
appsec (46.494 ms) : 46066, 46923
.   : milestone, 46494,
code_origins (46.697 ms) : 46281, 47112
.   : milestone, 46697,
iast (46.271 ms) : 45880, 46663
.   : milestone, 46271,
profiling (46.933 ms) : 46463, 47404
.   : milestone, 46933,
tracing (42.6 ms) : 42236, 42963
.   : milestone, 42600,
section candidate
no_agent (37.234 ms) : 36924, 37545
.   : milestone, 37234,
appsec (48.034 ms) : 47592, 48475
.   : milestone, 48034,
code_origins (44.027 ms) : 43662, 44391
.   : milestone, 44027,
iast (43.633 ms) : 43257, 44009
.   : milestone, 43633,
profiling (47.361 ms) : 46902, 47820
.   : milestone, 47361,
tracing (44.372 ms) : 43999, 44746
.   : milestone, 44372,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.684 ms [37.385 ms, 37.983 ms] -
appsec 46.494 ms [46.066 ms, 46.923 ms] 8.81 ms (23.4%)
code_origins 46.697 ms [46.281 ms, 47.112 ms] 9.012 ms (23.9%)
iast 46.271 ms [45.88 ms, 46.663 ms] 8.587 ms (22.8%)
profiling 46.933 ms [46.463 ms, 47.404 ms] 9.249 ms (24.5%)
tracing 42.6 ms [42.236 ms, 42.963 ms] 4.915 ms (13.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.234 ms [36.924 ms, 37.545 ms] -
appsec 48.034 ms [47.592 ms, 48.475 ms] 10.8 ms (29.0%)
code_origins 44.027 ms [43.662 ms, 44.391 ms] 6.793 ms (18.2%)
iast 43.633 ms [43.257 ms, 44.009 ms] 6.399 ms (17.2%)
profiling 47.361 ms [46.902 ms, 47.82 ms] 10.127 ms (27.2%)
tracing 44.372 ms [43.999 ms, 44.746 ms] 7.138 ms (19.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/container-tags-hash-propagation
git_commit_date 1755127609 1755129673
git_commit_sha 0f3ab90 8eb36bc
release_version 1.53.0-SNAPSHOT~0f3ab90a6f 1.52.0-SNAPSHOT~8eb36bc480
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1755131769 1755131769
ci_job_id 1079771687 1079771687
ci_pipeline_id 73633463 73633463
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-jmw4xy51 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-jmw4xy51 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec better
[-1.411ms; -1.072ms] or [-38.717%; -29.409%]
2.403ms 3.645ms
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~8eb36bc480, baseline=1.53.0-SNAPSHOT~0f3ab90a6f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.204 s) : 15204000, 15204000
.   : milestone, 15204000,
appsec (15.113 s) : 15113000, 15113000
.   : milestone, 15113000,
iast (18.348 s) : 18348000, 18348000
.   : milestone, 18348000,
iast_GLOBAL (18.263 s) : 18263000, 18263000
.   : milestone, 18263000,
profiling (15.123 s) : 15123000, 15123000
.   : milestone, 15123000,
tracing (15.073 s) : 15073000, 15073000
.   : milestone, 15073000,
section candidate
no_agent (15.532 s) : 15532000, 15532000
.   : milestone, 15532000,
appsec (14.72 s) : 14720000, 14720000
.   : milestone, 14720000,
iast (18.415 s) : 18415000, 18415000
.   : milestone, 18415000,
iast_GLOBAL (18.29 s) : 18290000, 18290000
.   : milestone, 18290000,
profiling (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
tracing (14.935 s) : 14935000, 14935000
.   : milestone, 14935000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.204 s [15.204 s, 15.204 s] -
appsec 15.113 s [15.113 s, 15.113 s] -91.0 ms (-0.6%)
iast 18.348 s [18.348 s, 18.348 s] 3.144 s (20.7%)
iast_GLOBAL 18.263 s [18.263 s, 18.263 s] 3.059 s (20.1%)
profiling 15.123 s [15.123 s, 15.123 s] -81.0 ms (-0.5%)
tracing 15.073 s [15.073 s, 15.073 s] -131.0 ms (-0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.532 s [15.532 s, 15.532 s] -
appsec 14.72 s [14.72 s, 14.72 s] -812.0 ms (-5.2%)
iast 18.415 s [18.415 s, 18.415 s] 2.883 s (18.6%)
iast_GLOBAL 18.29 s [18.29 s, 18.29 s] 2.758 s (17.8%)
profiling 15.114 s [15.114 s, 15.114 s] -418.0 ms (-2.7%)
tracing 14.935 s [14.935 s, 14.935 s] -597.0 ms (-3.8%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~8eb36bc480, baseline=1.53.0-SNAPSHOT~0f3ab90a6f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.645 ms) : 3428, 3862
.   : milestone, 3645,
iast (2.19 ms) : 2127, 2253
.   : milestone, 2190,
iast_GLOBAL (2.23 ms) : 2167, 2293
.   : milestone, 2230,
profiling (2.463 ms) : 2296, 2630
.   : milestone, 2463,
tracing (2.013 ms) : 1964, 2061
.   : milestone, 2013,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.403 ms) : 2353, 2453
.   : milestone, 2403,
iast (2.199 ms) : 2136, 2261
.   : milestone, 2199,
iast_GLOBAL (2.24 ms) : 2177, 2303
.   : milestone, 2240,
profiling (2.021 ms) : 1971, 2071
.   : milestone, 2021,
tracing (2.002 ms) : 1954, 2051
.   : milestone, 2002,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 3.645 ms [3.428 ms, 3.862 ms] 2.17 ms (147.2%)
iast 2.19 ms [2.127 ms, 2.253 ms] 715.095 µs (48.5%)
iast_GLOBAL 2.23 ms [2.167 ms, 2.293 ms] 755.403 µs (51.2%)
profiling 2.463 ms [2.296 ms, 2.63 ms] 988.26 µs (67.0%)
tracing 2.013 ms [1.964 ms, 2.061 ms] 537.73 µs (36.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.403 ms [2.353 ms, 2.453 ms] 930.702 µs (63.2%)
iast 2.199 ms [2.136 ms, 2.261 ms] 725.755 µs (49.3%)
iast_GLOBAL 2.24 ms [2.177 ms, 2.303 ms] 767.506 µs (52.1%)
profiling 2.021 ms [1.971 ms, 2.071 ms] 548.271 µs (37.2%)
tracing 2.002 ms [1.954 ms, 2.051 ms] 529.486 µs (36.0%)

Extract getBaseHash to be available for SQLCommenter

TBD: fix SQLCommenterTest
TBD: add DB_DBM_INJECT_SERVICE_HASH_ENABLED
@ygree ygree removed their assignment Jul 30, 2025
builder.append(processTags);
}
return FNV64Hash.generateHash(builder.toString(), FNV64Hash.Version.v1);
return ServiceHash.getBaseHash(wellKnownTags, ContainerInfo.get().getContainerTagsHash());
Copy link
Contributor Author

@ygree ygree Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract this into the ServiceHas class so that it is available in the DBM instrumentation.

}
if (processTags != null) {
builder.append(processTags);
if (containerTagsHash != null && !containerTagsHash.isEmpty()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Populate the base hash with the container tag hash if the process tag propagation feature flag is.

@@ -241,6 +250,8 @@ protected static boolean toComment(
if (injectTrace) {
append(sb, TRACEPARENT, traceparent, sb.length() > emptySize);
}
// TODO only if DB_DBM_INJECT_SERVICE_HASH_ENABLED
append(sb, DD_SERVICE_HASH, serviceHash, sb.length() > emptySize);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inject the base hash into the SQL comment when the service mode is enabled.

Copy link

datadog-official bot commented Aug 13, 2025

Code coverage: total 57.34%, base diff 0.01%, patch 5.00% (view details)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8eb36bc | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: data streams Data Streams Monitoring comp: database Database Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant