Fix `FootprintForkedTest` that was also measuring Spock mock #9298

bric3 · 2025-08-04T10:12:45Z

What Does This Do

Removes the 'features' mock that made the test a bit unpredictable.

This is a cherry pick from

Motivation

The memory footprint of aggregator was including the features Spock mock which included its stubs and its recorded invocations. This single mock could amount to ~22 MiB.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-08-04T10:12:57Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

Removing the 'features' mock makes the test more predicatable.

mcculls · 2025-08-04T10:23:27Z

dd-trace-core/src/test/groovy/datadog/trace/common/metrics/FootprintForkedTest.groovy

-    long baseline = footprint(aggregator)
+      SECONDS
+      )
+    // Removing the 'features' as it's a mock, and mocks are heavyweight, e.g. around 22MiB


nitpick: features is now a stub, not a mock (stubs can still be heavyweight)

That is true, indeed I found that a stub is pretty heavy with all the Spock plus Groovy "magic". I believe this is not what the test wants to measure, so kept it excluded from the footprint.

I found that using a Stub reduces the test memory footprint.

sure, was just thinking the comment should read:

// Removing 'features' as it's a stub, and stubs/mocks are heavyweight, e.g. around 22MiB

but not a big deal

datadog-datadog-prod-us1 · 2025-08-04T10:37:31Z

Code coverage: total 56.93%, patch 100.00% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 172771d | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-04T10:52:07Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	fix-FootprintForkedTest
git_commit_date	1754295155	1754302618
git_commit_sha	`1c2d049`	`172771d`
release_version	1.51.1-SNAPSHOT~1c2d0498a0	1.51.1-SNAPSHOT~172771d40a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1754304363	1754304363
ci_job_id	1062037527	1062037527
ci_pipeline_id	72560023	72560023
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-c5txnjp5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-c5txnjp5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 12 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:iast:Remote Config	better [-61.025µs; -12.715µs] or [-9.999%; -2.083%]	573.431µs	610.301µs

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~172771d40a, baseline=1.51.1-SNAPSHOT~1c2d0498a0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054432
Total [baseline] (8.605 s) : 0, 8604709
Agent [candidate] (1.046 s) : 0, 1046051
Total [candidate] (8.66 s) : 0, 8660412
section iast
Agent [baseline] (1.177 s) : 0, 1177315
Total [baseline] (9.281 s) : 0, 9280914
Agent [candidate] (1.174 s) : 0, 1174124
Total [candidate] (9.309 s) : 0, 9309271

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	iast	1.177 s	122.883 ms (11.7%)
Total	tracing	8.605 s	-
Total	iast	9.281 s	676.205 ms (7.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	iast	1.174 s	128.073 ms (12.2%)
Total	tracing	8.66 s	-
Total	iast	9.309 s	648.859 ms (7.5%)

gantt
    title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~172771d40a, baseline=1.51.1-SNAPSHOT~1c2d0498a0

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (738.016 ms) : 0, 738016
BytebuddyAgent [candidate] (732.331 ms) : 0, 732331
GlobalTracer [baseline] (243.685 ms) : 0, 243685
GlobalTracer [candidate] (242.949 ms) : 0, 242949
AppSec [baseline] (30.197 ms) : 0, 30197
AppSec [candidate] (30.305 ms) : 0, 30305
Debugger [baseline] (6.053 ms) : 0, 6053
Debugger [candidate] (6.039 ms) : 0, 6039
Remote Config [baseline] (654.099 µs) : 0, 654
Remote Config [candidate] (643.361 µs) : 0, 643
Telemetry [baseline] (13.254 ms) : 0, 13254
Telemetry [candidate] (11.318 ms) : 0, 11318
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (850.965 ms) : 0, 850965
BytebuddyAgent [candidate] (847.759 ms) : 0, 847759
GlobalTracer [baseline] (231.246 ms) : 0, 231246
GlobalTracer [candidate] (231.656 ms) : 0, 231656
IAST [baseline] (29.795 ms) : 0, 29795
IAST [candidate] (29.095 ms) : 0, 29095
AppSec [baseline] (26.525 ms) : 0, 26525
AppSec [candidate] (27.931 ms) : 0, 27931
Debugger [baseline] (6.744 ms) : 0, 6744
Debugger [candidate] (6.656 ms) : 0, 6656
Remote Config [baseline] (610.301 µs) : 0, 610
Remote Config [candidate] (573.431 µs) : 0, 573
Telemetry [baseline] (9.005 ms) : 0, 9005
Telemetry [candidate] (8.045 ms) : 0, 8045

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~172771d40a, baseline=1.51.1-SNAPSHOT~1c2d0498a0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039370
Total [baseline] (10.673 s) : 0, 10673440
Agent [candidate] (1.043 s) : 0, 1043461
Total [candidate] (10.692 s) : 0, 10691607
section appsec
Agent [baseline] (1.217 s) : 0, 1217107
Total [baseline] (10.757 s) : 0, 10756968
Agent [candidate] (1.221 s) : 0, 1220807
Total [candidate] (10.768 s) : 0, 10768297
section iast
Agent [baseline] (1.177 s) : 0, 1176812
Total [baseline] (10.915 s) : 0, 10915042
Agent [candidate] (1.174 s) : 0, 1174095
Total [candidate] (10.894 s) : 0, 10893977
section profiling
Agent [baseline] (1.193 s) : 0, 1192607
Total [baseline] (10.91 s) : 0, 10910056
Agent [candidate] (1.191 s) : 0, 1191311
Total [candidate] (10.831 s) : 0, 10830872

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.039 s	-
Agent	appsec	1.217 s	177.737 ms (17.1%)
Agent	iast	1.177 s	137.443 ms (13.2%)
Agent	profiling	1.193 s	153.238 ms (14.7%)
Total	tracing	10.673 s	-
Total	appsec	10.757 s	83.528 ms (0.8%)
Total	iast	10.915 s	241.602 ms (2.3%)
Total	profiling	10.91 s	236.616 ms (2.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.221 s	177.346 ms (17.0%)
Agent	iast	1.174 s	130.634 ms (12.5%)
Agent	profiling	1.191 s	147.85 ms (14.2%)
Total	tracing	10.692 s	-
Total	appsec	10.768 s	76.69 ms (0.7%)
Total	iast	10.894 s	202.37 ms (1.9%)
Total	profiling	10.831 s	139.265 ms (1.3%)

gantt
    title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~172771d40a, baseline=1.51.1-SNAPSHOT~1c2d0498a0

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (729.08 ms) : 0, 729080
BytebuddyAgent [candidate] (730.502 ms) : 0, 730502
GlobalTracer [baseline] (240.972 ms) : 0, 240972
GlobalTracer [candidate] (241.304 ms) : 0, 241304
AppSec [baseline] (29.794 ms) : 0, 29794
AppSec [candidate] (29.933 ms) : 0, 29933
Debugger [baseline] (6.014 ms) : 0, 6014
Debugger [candidate] (6.019 ms) : 0, 6019
Remote Config [baseline] (640.732 µs) : 0, 641
Remote Config [candidate] (643.624 µs) : 0, 644
Telemetry [baseline] (10.507 ms) : 0, 10507
Telemetry [candidate] (12.621 ms) : 0, 12621
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (751.598 ms) : 0, 751598
BytebuddyAgent [candidate] (753.34 ms) : 0, 753340
GlobalTracer [baseline] (234.539 ms) : 0, 234539
GlobalTracer [candidate] (235.234 ms) : 0, 235234
IAST [baseline] (23.415 ms) : 0, 23415
IAST [candidate] (23.629 ms) : 0, 23629
AppSec [baseline] (166.92 ms) : 0, 166920
AppSec [candidate] (169.908 ms) : 0, 169908
Debugger [baseline] (8.55 ms) : 0, 8550
Debugger [candidate] (6.499 ms) : 0, 6499
Remote Config [baseline] (611.516 µs) : 0, 612
Remote Config [candidate] (614.14 µs) : 0, 614
Telemetry [baseline] (8.983 ms) : 0, 8983
Telemetry [candidate] (9.053 ms) : 0, 9053
section iast
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (849.766 ms) : 0, 849766
BytebuddyAgent [candidate] (847.92 ms) : 0, 847920
GlobalTracer [baseline] (231.973 ms) : 0, 231973
GlobalTracer [candidate] (231.437 ms) : 0, 231437
IAST [baseline] (30.969 ms) : 0, 30969
IAST [candidate] (29.166 ms) : 0, 29166
AppSec [baseline] (27.099 ms) : 0, 27099
AppSec [candidate] (27.761 ms) : 0, 27761
Debugger [baseline] (5.838 ms) : 0, 5838
Debugger [candidate] (6.571 ms) : 0, 6571
Remote Config [baseline] (587.67 µs) : 0, 588
Remote Config [candidate] (596.235 µs) : 0, 596
Telemetry [baseline] (8.184 ms) : 0, 8184
Telemetry [candidate] (8.131 ms) : 0, 8131
section profiling
crashtracking [baseline] (1.405 ms) : 0, 1405
crashtracking [candidate] (1.394 ms) : 0, 1394
BytebuddyAgent [baseline] (759.948 ms) : 0, 759948
BytebuddyAgent [candidate] (758.73 ms) : 0, 758730
GlobalTracer [baseline] (221.075 ms) : 0, 221075
GlobalTracer [candidate] (220.8 ms) : 0, 220800
AppSec [baseline] (29.751 ms) : 0, 29751
AppSec [candidate] (29.94 ms) : 0, 29940
Debugger [baseline] (6.245 ms) : 0, 6245
Debugger [candidate] (6.341 ms) : 0, 6341
Remote Config [baseline] (670.056 µs) : 0, 670
Remote Config [candidate] (656.246 µs) : 0, 656
Telemetry [baseline] (15.86 ms) : 0, 15860
Telemetry [candidate] (15.972 ms) : 0, 15972
ProfilingAgent [baseline] (108.407 ms) : 0, 108407
ProfilingAgent [candidate] (108.162 ms) : 0, 108162
Profiling [baseline] (109.063 ms) : 0, 109063
Profiling [candidate] (108.826 ms) : 0, 108826

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	fix-FootprintForkedTest
git_commit_date	1754295155	1754302618
git_commit_sha	`1c2d049`	`172771d`
release_version	1.51.1-SNAPSHOT~1c2d0498a0	1.51.1-SNAPSHOT~172771d40a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1754304045	1754304045
ci_job_id	1062037528	1062037528
ci_pipeline_id	72560023	72560023
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-6mcvvphs 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-6mcvvphs 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	worse [+321.775µs; +554.882µs] or [+4.414%; +7.611%]	unstable [-111.024op/s; +39.961op/s] or [-17.490%; +6.295%]	7.729ms	599.250op/s	7.290ms	634.781op/s
scenario:load:petclinic:profiling:high_load	better [-2.538ms; -1.556ms] or [-5.184%; -3.178%]	unstable [-3.146op/s; +11.421op/s] or [-3.290%; +11.943%]	46.904ms	99.763op/s	48.950ms	95.625op/s
scenario:load:petclinic:iast:high_load	better [-2.422ms; -1.621ms] or [-5.508%; -3.686%]	unstable [-2.855op/s; +12.980op/s] or [-2.683%; +12.199%]	41.948ms	111.463op/s	43.969ms	106.400op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~172771d40a, baseline=1.51.1-SNAPSHOT~1c2d0498a0
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.435 ms) : 4378, 4492
.   : milestone, 4435,
iast (9.317 ms) : 9164, 9470
.   : milestone, 9317,
iast_FULL (14.025 ms) : 13746, 14305
.   : milestone, 14025,
iast_GLOBAL (10.212 ms) : 10032, 10391
.   : milestone, 10212,
profiling (8.714 ms) : 8571, 8857
.   : milestone, 8714,
tracing (7.29 ms) : 7185, 7395
.   : milestone, 7290,
section candidate
no_agent (4.314 ms) : 4261, 4367
.   : milestone, 4314,
iast (9.388 ms) : 9236, 9540
.   : milestone, 9388,
iast_FULL (13.78 ms) : 13505, 14054
.   : milestone, 13780,
iast_GLOBAL (10.389 ms) : 10205, 10573
.   : milestone, 10389,
profiling (8.755 ms) : 8621, 8889
.   : milestone, 8755,
tracing (7.729 ms) : 7617, 7840
.   : milestone, 7729,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.435 ms [4.378 ms, 4.492 ms]	-
iast	9.317 ms [9.164 ms, 9.47 ms]	4.882 ms (110.1%)
iast_FULL	14.025 ms [13.746 ms, 14.305 ms]	9.59 ms (216.2%)
iast_GLOBAL	10.212 ms [10.032 ms, 10.391 ms]	5.776 ms (130.2%)
profiling	8.714 ms [8.571 ms, 8.857 ms]	4.279 ms (96.5%)
tracing	7.29 ms [7.185 ms, 7.395 ms]	2.855 ms (64.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.314 ms [4.261 ms, 4.367 ms]	-
iast	9.388 ms [9.236 ms, 9.54 ms]	5.074 ms (117.6%)
iast_FULL	13.78 ms [13.505 ms, 14.054 ms]	9.466 ms (219.4%)
iast_GLOBAL	10.389 ms [10.205 ms, 10.573 ms]	6.075 ms (140.8%)
profiling	8.755 ms [8.621 ms, 8.889 ms]	4.441 ms (102.9%)
tracing	7.729 ms [7.617 ms, 7.84 ms]	3.415 ms (79.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~172771d40a, baseline=1.51.1-SNAPSHOT~1c2d0498a0
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.741 ms) : 36445, 37037
.   : milestone, 36741,
appsec (47.644 ms) : 47226, 48062
.   : milestone, 47644,
code_origins (44.134 ms) : 43762, 44506
.   : milestone, 44134,
iast (43.969 ms) : 43596, 44343
.   : milestone, 43969,
profiling (48.95 ms) : 48497, 49404
.   : milestone, 48950,
tracing (41.769 ms) : 41423, 42115
.   : milestone, 41769,
section candidate
no_agent (36.861 ms) : 36568, 37153
.   : milestone, 36861,
appsec (47.062 ms) : 46652, 47473
.   : milestone, 47062,
code_origins (44.663 ms) : 44279, 45047
.   : milestone, 44663,
iast (41.948 ms) : 41577, 42319
.   : milestone, 41948,
profiling (46.904 ms) : 46445, 47363
.   : milestone, 46904,
tracing (42.589 ms) : 42209, 42968
.   : milestone, 42589,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.741 ms [36.445 ms, 37.037 ms]	-
appsec	47.644 ms [47.226 ms, 48.062 ms]	10.903 ms (29.7%)
code_origins	44.134 ms [43.762 ms, 44.506 ms]	7.393 ms (20.1%)
iast	43.969 ms [43.596 ms, 44.343 ms]	7.228 ms (19.7%)
profiling	48.95 ms [48.497 ms, 49.404 ms]	12.21 ms (33.2%)
tracing	41.769 ms [41.423 ms, 42.115 ms]	5.028 ms (13.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.861 ms [36.568 ms, 37.153 ms]	-
appsec	47.062 ms [46.652 ms, 47.473 ms]	10.202 ms (27.7%)
code_origins	44.663 ms [44.279 ms, 45.047 ms]	7.803 ms (21.2%)
iast	41.948 ms [41.577 ms, 42.319 ms]	5.087 ms (13.8%)
profiling	46.904 ms [46.445 ms, 47.363 ms]	10.043 ms (27.2%)
tracing	42.589 ms [42.209 ms, 42.968 ms]	5.728 ms (15.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	fix-FootprintForkedTest
git_commit_date	1754295155	1754302618
git_commit_sha	`1c2d049`	`172771d`
release_version	1.51.1-SNAPSHOT~1c2d0498a0	1.51.1-SNAPSHOT~172771d40a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1754304578	1754304578
ci_job_id	1062037529	1062037529
ci_pipeline_id	72560023	72560023
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-w1jyafgx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-w1jyafgx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~172771d40a, baseline=1.51.1-SNAPSHOT~1c2d0498a0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1495
.   : milestone, 1484,
appsec (3.658 ms) : 3441, 3874
.   : milestone, 3658,
iast (2.208 ms) : 2145, 2270
.   : milestone, 2208,
iast_GLOBAL (2.251 ms) : 2188, 2314
.   : milestone, 2251,
profiling (2.063 ms) : 2011, 2114
.   : milestone, 2063,
tracing (2.023 ms) : 1974, 2071
.   : milestone, 2023,
section candidate
no_agent (1.478 ms) : 1466, 1490
.   : milestone, 1478,
appsec (3.67 ms) : 3453, 3888
.   : milestone, 3670,
iast (2.193 ms) : 2130, 2255
.   : milestone, 2193,
iast_GLOBAL (2.252 ms) : 2189, 2315
.   : milestone, 2252,
profiling (2.478 ms) : 2312, 2644
.   : milestone, 2478,
tracing (2.023 ms) : 1974, 2072
.   : milestone, 2023,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.484 ms [1.472 ms, 1.495 ms]	-
appsec	3.658 ms [3.441 ms, 3.874 ms]	2.174 ms (146.5%)
iast	2.208 ms [2.145 ms, 2.27 ms]	723.987 µs (48.8%)
iast_GLOBAL	2.251 ms [2.188 ms, 2.314 ms]	767.112 µs (51.7%)
profiling	2.063 ms [2.011 ms, 2.114 ms]	578.877 µs (39.0%)
tracing	2.023 ms [1.974 ms, 2.071 ms]	538.893 µs (36.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.49 ms]	-
appsec	3.67 ms [3.453 ms, 3.888 ms]	2.192 ms (148.3%)
iast	2.193 ms [2.13 ms, 2.255 ms]	714.409 µs (48.3%)
iast_GLOBAL	2.252 ms [2.189 ms, 2.315 ms]	773.62 µs (52.3%)
profiling	2.478 ms [2.312 ms, 2.644 ms]	999.872 µs (67.6%)
tracing	2.023 ms [1.974 ms, 2.072 ms]	545.099 µs (36.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~172771d40a, baseline=1.51.1-SNAPSHOT~1c2d0498a0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.381 s) : 15381000, 15381000
.   : milestone, 15381000,
appsec (14.93 s) : 14930000, 14930000
.   : milestone, 14930000,
iast (18.762 s) : 18762000, 18762000
.   : milestone, 18762000,
iast_GLOBAL (18.212 s) : 18212000, 18212000
.   : milestone, 18212000,
profiling (15.757 s) : 15757000, 15757000
.   : milestone, 15757000,
tracing (15.136 s) : 15136000, 15136000
.   : milestone, 15136000,
section candidate
no_agent (15.302 s) : 15302000, 15302000
.   : milestone, 15302000,
appsec (14.974 s) : 14974000, 14974000
.   : milestone, 14974000,
iast (18.898 s) : 18898000, 18898000
.   : milestone, 18898000,
iast_GLOBAL (18.058 s) : 18058000, 18058000
.   : milestone, 18058000,
profiling (15.745 s) : 15745000, 15745000
.   : milestone, 15745000,
tracing (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.381 s [15.381 s, 15.381 s]	-
appsec	14.93 s [14.93 s, 14.93 s]	-451.0 ms (-2.9%)
iast	18.762 s [18.762 s, 18.762 s]	3.381 s (22.0%)
iast_GLOBAL	18.212 s [18.212 s, 18.212 s]	2.831 s (18.4%)
profiling	15.757 s [15.757 s, 15.757 s]	376.0 ms (2.4%)
tracing	15.136 s [15.136 s, 15.136 s]	-245.0 ms (-1.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.302 s [15.302 s, 15.302 s]	-
appsec	14.974 s [14.974 s, 14.974 s]	-328.0 ms (-2.1%)
iast	18.898 s [18.898 s, 18.898 s]	3.596 s (23.5%)
iast_GLOBAL	18.058 s [18.058 s, 18.058 s]	2.756 s (18.0%)
profiling	15.745 s [15.745 s, 15.745 s]	443.0 ms (2.9%)
tracing	14.968 s [14.968 s, 14.968 s]	-334.0 ms (-2.2%)

bric3 requested a review from a team as a code owner August 4, 2025 10:12

bric3 requested a review from manuel-alvarez-alvarez August 4, 2025 10:12

bric3 added the tag: no release notes Changes to exclude from release notes label Aug 4, 2025

bric3 added the comp: metrics Metrics label Aug 4, 2025

bric3 requested review from amarziali and mcculls August 4, 2025 10:15

mcculls approved these changes Aug 4, 2025

View reviewed changes

fix: FootprintForkedTest was also measuring Spock mock

172771d

Removing the 'features' mock makes the test more predicatable.

mcculls added the type: refactoring label Aug 4, 2025

bric3 force-pushed the fix-FootprintForkedTest branch from b74dccb to 172771d Compare August 4, 2025 10:17

bric3 enabled auto-merge (squash) August 4, 2025 10:18

mcculls reviewed Aug 4, 2025

View reviewed changes

bric3 merged commit e6a9f29 into master Aug 4, 2025
504 checks passed

bric3 deleted the fix-FootprintForkedTest branch August 4, 2025 11:11

github-actions bot added this to the 1.52.0 milestone Aug 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `FootprintForkedTest` that was also measuring Spock mock #9298

Fix `FootprintForkedTest` that was also measuring Spock mock #9298

Uh oh!

bric3 commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

mcculls Aug 4, 2025

Uh oh!

bric3 Aug 4, 2025 •

edited

Loading

Uh oh!

mcculls Aug 4, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Aug 4, 2025

Uh oh!

Uh oh!

Uh oh!

Fix FootprintForkedTest that was also measuring Spock mock #9298

Fix FootprintForkedTest that was also measuring Spock mock #9298

Uh oh!

Conversation

bric3 commented Aug 4, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

mcculls Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcculls Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 4, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

Fix `FootprintForkedTest` that was also measuring Spock mock #9298

Fix `FootprintForkedTest` that was also measuring Spock mock #9298

bric3 Aug 4, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Aug 4, 2025 •

edited

Loading