-
Notifications
You must be signed in to change notification settings - Fork 311
Report config_id for Hands Off Config files #9299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Code coverage: total 57.09%, base diff 0.00%, patch 61.22% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: f11a0fa | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~f11a0fa322, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051136
Total [baseline] (8.611 s) : 0, 8610810
Agent [candidate] (1.052 s) : 0, 1052265
Total [candidate] (8.607 s) : 0, 8606647
section iast
Agent [baseline] (1.178 s) : 0, 1177986
Total [baseline] (9.377 s) : 0, 9376619
Agent [candidate] (1.185 s) : 0, 1185285
Total [candidate] (9.344 s) : 0, 9344167
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~f11a0fa322, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (736.153 ms) : 0, 736153
BytebuddyAgent [candidate] (736.719 ms) : 0, 736719
GlobalTracer [baseline] (243.222 ms) : 0, 243222
GlobalTracer [candidate] (243.712 ms) : 0, 243712
AppSec [baseline] (30.217 ms) : 0, 30217
AppSec [candidate] (30.356 ms) : 0, 30356
Debugger [baseline] (6.048 ms) : 0, 6048
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (663.57 µs) : 0, 664
Remote Config [candidate] (658.022 µs) : 0, 658
Telemetry [baseline] (12.363 ms) : 0, 12363
Telemetry [candidate] (12.221 ms) : 0, 12221
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (848.322 ms) : 0, 848322
BytebuddyAgent [candidate] (856.835 ms) : 0, 856835
GlobalTracer [baseline] (234.834 ms) : 0, 234834
GlobalTracer [candidate] (233.28 ms) : 0, 233280
IAST [baseline] (31.235 ms) : 0, 31235
IAST [candidate] (28.409 ms) : 0, 28409
AppSec [baseline] (25.507 ms) : 0, 25507
AppSec [candidate] (29.526 ms) : 0, 29526
Debugger [baseline] (6.679 ms) : 0, 6679
Debugger [candidate] (5.801 ms) : 0, 5801
Remote Config [baseline] (595.69 µs) : 0, 596
Remote Config [candidate] (598.752 µs) : 0, 599
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (8.209 ms) : 0, 8209
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~f11a0fa322, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045096
Total [baseline] (10.765 s) : 0, 10765468
Agent [candidate] (1.043 s) : 0, 1043424
Total [candidate] (10.658 s) : 0, 10657685
section appsec
Agent [baseline] (1.228 s) : 0, 1228243
Total [baseline] (10.787 s) : 0, 10787075
Agent [candidate] (1.228 s) : 0, 1228049
Total [candidate] (10.763 s) : 0, 10763492
section iast
Agent [baseline] (1.189 s) : 0, 1189275
Total [baseline] (10.941 s) : 0, 10941482
Agent [candidate] (1.185 s) : 0, 1184917
Total [candidate] (10.937 s) : 0, 10936987
section profiling
Agent [baseline] (1.192 s) : 0, 1191608
Total [baseline] (10.838 s) : 0, 10837685
Agent [candidate] (1.194 s) : 0, 1193998
Total [candidate] (10.863 s) : 0, 10863257
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~f11a0fa322, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.441 ms) : 0, 1441
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (731.832 ms) : 0, 731832
BytebuddyAgent [candidate] (731.513 ms) : 0, 731513
GlobalTracer [baseline] (242.049 ms) : 0, 242049
GlobalTracer [candidate] (242.459 ms) : 0, 242459
AppSec [baseline] (30.073 ms) : 0, 30073
AppSec [candidate] (29.847 ms) : 0, 29847
Debugger [baseline] (6.022 ms) : 0, 6022
Debugger [candidate] (6.026 ms) : 0, 6026
Remote Config [baseline] (644.61 µs) : 0, 645
Remote Config [candidate] (652.769 µs) : 0, 653
Telemetry [baseline] (11.993 ms) : 0, 11993
Telemetry [candidate] (10.468 ms) : 0, 10468
section appsec
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (758.871 ms) : 0, 758871
BytebuddyAgent [candidate] (759.068 ms) : 0, 759068
GlobalTracer [baseline] (236.629 ms) : 0, 236629
GlobalTracer [candidate] (236.361 ms) : 0, 236361
IAST [baseline] (23.731 ms) : 0, 23731
IAST [candidate] (23.807 ms) : 0, 23807
AppSec [baseline] (167.28 ms) : 0, 167280
AppSec [candidate] (169.273 ms) : 0, 169273
Debugger [baseline] (9.447 ms) : 0, 9447
Debugger [candidate] (7.261 ms) : 0, 7261
Remote Config [baseline] (618.154 µs) : 0, 618
Remote Config [candidate] (615.511 µs) : 0, 616
Telemetry [baseline] (9.05 ms) : 0, 9050
Telemetry [candidate] (8.999 ms) : 0, 8999
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (858.845 ms) : 0, 858845
BytebuddyAgent [candidate] (856.359 ms) : 0, 856359
GlobalTracer [baseline] (234.549 ms) : 0, 234549
GlobalTracer [candidate] (233.206 ms) : 0, 233206
IAST [baseline] (26.361 ms) : 0, 26361
IAST [candidate] (27.552 ms) : 0, 27552
AppSec [baseline] (31.048 ms) : 0, 31048
AppSec [candidate] (28.982 ms) : 0, 28982
Debugger [baseline] (6.683 ms) : 0, 6683
Debugger [candidate] (7.444 ms) : 0, 7444
Remote Config [baseline] (589.385 µs) : 0, 589
Remote Config [candidate] (585.259 µs) : 0, 585
Telemetry [baseline] (8.475 ms) : 0, 8475
Telemetry [candidate] (8.184 ms) : 0, 8184
section profiling
crashtracking [baseline] (1.403 ms) : 0, 1403
crashtracking [candidate] (1.417 ms) : 0, 1417
BytebuddyAgent [baseline] (759.348 ms) : 0, 759348
BytebuddyAgent [candidate] (761.392 ms) : 0, 761392
GlobalTracer [baseline] (221.163 ms) : 0, 221163
GlobalTracer [candidate] (221.027 ms) : 0, 221027
AppSec [baseline] (29.838 ms) : 0, 29838
AppSec [candidate] (29.981 ms) : 0, 29981
Debugger [baseline] (6.301 ms) : 0, 6301
Debugger [candidate] (6.262 ms) : 0, 6262
Remote Config [baseline] (688.532 µs) : 0, 689
Remote Config [candidate] (672.269 µs) : 0, 672
Telemetry [baseline] (14.432 ms) : 0, 14432
Telemetry [candidate] (15.304 ms) : 0, 15304
ProfilingAgent [baseline] (108.975 ms) : 0, 108975
ProfilingAgent [candidate] (107.654 ms) : 0, 107654
Profiling [baseline] (109.6 ms) : 0, 109600
Profiling [candidate] (108.313 ms) : 0, 108313
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~f11a0fa322, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (4.208 ms) : 4160, 4256
. : milestone, 4208,
iast (9.337 ms) : 9184, 9491
. : milestone, 9337,
iast_FULL (14.574 ms) : 14282, 14865
. : milestone, 14574,
iast_GLOBAL (10.16 ms) : 9985, 10334
. : milestone, 10160,
profiling (9.424 ms) : 9272, 9576
. : milestone, 9424,
tracing (7.672 ms) : 7557, 7787
. : milestone, 7672,
section candidate
no_agent (4.503 ms) : 4452, 4553
. : milestone, 4503,
iast (9.484 ms) : 9326, 9642
. : milestone, 9484,
iast_FULL (13.843 ms) : 13571, 14115
. : milestone, 13843,
iast_GLOBAL (10.12 ms) : 9946, 10294
. : milestone, 10120,
profiling (8.792 ms) : 8648, 8937
. : milestone, 8792,
tracing (7.854 ms) : 7731, 7978
. : milestone, 7854,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~f11a0fa322, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (38.153 ms) : 37846, 38460
. : milestone, 38153,
appsec (48.93 ms) : 48483, 49376
. : milestone, 48930,
code_origins (47.53 ms) : 47120, 47940
. : milestone, 47530,
iast (44.454 ms) : 44072, 44836
. : milestone, 44454,
profiling (49.084 ms) : 48603, 49565
. : milestone, 49084,
tracing (44.644 ms) : 44256, 45032
. : milestone, 44644,
section candidate
no_agent (37.114 ms) : 36816, 37412
. : milestone, 37114,
appsec (48.039 ms) : 47615, 48463
. : milestone, 48039,
code_origins (45.245 ms) : 44842, 45649
. : milestone, 45245,
iast (45.783 ms) : 45384, 46183
. : milestone, 45783,
profiling (48.917 ms) : 48458, 49375
. : milestone, 48917,
tracing (44.541 ms) : 44147, 44936
. : milestone, 44541,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~f11a0fa322, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.605 ms) : 3393, 3818
. : milestone, 3605,
iast (2.212 ms) : 2149, 2276
. : milestone, 2212,
iast_GLOBAL (2.26 ms) : 2197, 2324
. : milestone, 2260,
profiling (2.056 ms) : 2006, 2107
. : milestone, 2056,
tracing (2.036 ms) : 1987, 2085
. : milestone, 2036,
section candidate
no_agent (1.488 ms) : 1476, 1499
. : milestone, 1488,
appsec (3.679 ms) : 3462, 3896
. : milestone, 3679,
iast (2.213 ms) : 2150, 2276
. : milestone, 2213,
iast_GLOBAL (2.259 ms) : 2196, 2323
. : milestone, 2259,
profiling (2.058 ms) : 2007, 2109
. : milestone, 2058,
tracing (2.042 ms) : 1993, 2091
. : milestone, 2042,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~f11a0fa322, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (14.766 s) : 14766000, 14766000
. : milestone, 14766000,
appsec (14.598 s) : 14598000, 14598000
. : milestone, 14598000,
iast (18.492 s) : 18492000, 18492000
. : milestone, 18492000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
. : milestone, 17912000,
profiling (15.422 s) : 15422000, 15422000
. : milestone, 15422000,
tracing (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
section candidate
no_agent (15.508 s) : 15508000, 15508000
. : milestone, 15508000,
appsec (14.748 s) : 14748000, 14748000
. : milestone, 14748000,
iast (18.687 s) : 18687000, 18687000
. : milestone, 18687000,
iast_GLOBAL (18.064 s) : 18064000, 18064000
. : milestone, 18064000,
profiling (15.32 s) : 15320000, 15320000
. : milestone, 15320000,
tracing (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
|
…va into mtoff/scfg_config-id
What Does This Do
Reports config_id in configuration telemetry payloads when the origin is a stable config file.
Passing system tests: DataDog/system-tests#5062
Motivation
https://datadoghq.atlassian.net/browse/APMAPI-1354
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]