-
Notifications
You must be signed in to change notification settings - Fork 311
Fix jmxfetch workflow #9306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jmxfetch workflow #9306
Conversation
Code coverage: total 57.12%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: aa98b0e | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~aa98b0ed9d, baseline=1.53.0-SNAPSHOT~c6140367d1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043793
Total [baseline] (10.792 s) : 0, 10791890
Agent [candidate] (1.046 s) : 0, 1045796
Total [candidate] (10.734 s) : 0, 10733917
section appsec
Agent [baseline] (1.221 s) : 0, 1220740
Total [baseline] (10.761 s) : 0, 10761359
Agent [candidate] (1.226 s) : 0, 1225612
Total [candidate] (10.867 s) : 0, 10866983
section iast
Agent [baseline] (1.181 s) : 0, 1180871
Total [baseline] (10.852 s) : 0, 10851842
Agent [candidate] (1.177 s) : 0, 1176750
Total [candidate] (10.844 s) : 0, 10843677
section profiling
Agent [baseline] (1.192 s) : 0, 1192013
Total [baseline] (10.856 s) : 0, 10856271
Agent [candidate] (1.208 s) : 0, 1208347
Total [candidate] (11.041 s) : 0, 11040816
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~aa98b0ed9d, baseline=1.53.0-SNAPSHOT~c6140367d1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (731.166 ms) : 0, 731166
BytebuddyAgent [candidate] (732.759 ms) : 0, 732759
GlobalTracer [baseline] (241.931 ms) : 0, 241931
GlobalTracer [candidate] (242.315 ms) : 0, 242315
AppSec [baseline] (30.185 ms) : 0, 30185
AppSec [candidate] (30.26 ms) : 0, 30260
Debugger [baseline] (6.001 ms) : 0, 6001
Debugger [candidate] (6.026 ms) : 0, 6026
Remote Config [baseline] (647.123 µs) : 0, 647
Remote Config [candidate] (645.452 µs) : 0, 645
Telemetry [baseline] (10.665 ms) : 0, 10665
Telemetry [candidate] (11.298 ms) : 0, 11298
section appsec
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (753.354 ms) : 0, 753354
BytebuddyAgent [candidate] (756.956 ms) : 0, 756956
GlobalTracer [baseline] (235.574 ms) : 0, 235574
GlobalTracer [candidate] (236.194 ms) : 0, 236194
AppSec [baseline] (168.892 ms) : 0, 168892
AppSec [candidate] (167.63 ms) : 0, 167630
Debugger [baseline] (7.253 ms) : 0, 7253
Debugger [candidate] (8.689 ms) : 0, 8689
Remote Config [baseline] (628.076 µs) : 0, 628
Remote Config [candidate] (622.735 µs) : 0, 623
Telemetry [baseline] (9.064 ms) : 0, 9064
Telemetry [candidate] (9.162 ms) : 0, 9162
IAST [baseline] (23.431 ms) : 0, 23431
IAST [candidate] (23.745 ms) : 0, 23745
section iast
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (853.548 ms) : 0, 853548
BytebuddyAgent [candidate] (850.246 ms) : 0, 850246
GlobalTracer [baseline] (232.158 ms) : 0, 232158
GlobalTracer [candidate] (231.874 ms) : 0, 231874
AppSec [baseline] (27.099 ms) : 0, 27099
AppSec [candidate] (29.485 ms) : 0, 29485
Debugger [baseline] (8.335 ms) : 0, 8335
Debugger [candidate] (6.549 ms) : 0, 6549
Remote Config [baseline] (589.934 µs) : 0, 590
Remote Config [candidate] (583.35 µs) : 0, 583
Telemetry [baseline] (8.181 ms) : 0, 8181
Telemetry [candidate] (8.103 ms) : 0, 8103
IAST [baseline] (28.443 ms) : 0, 28443
IAST [candidate] (27.351 ms) : 0, 27351
section profiling
ProfilingAgent [baseline] (107.877 ms) : 0, 107877
ProfilingAgent [candidate] (109.178 ms) : 0, 109178
crashtracking [baseline] (1.403 ms) : 0, 1403
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (758.798 ms) : 0, 758798
BytebuddyAgent [candidate] (770.289 ms) : 0, 770289
GlobalTracer [baseline] (222.157 ms) : 0, 222157
GlobalTracer [candidate] (223.867 ms) : 0, 223867
AppSec [baseline] (29.888 ms) : 0, 29888
AppSec [candidate] (30.45 ms) : 0, 30450
Debugger [baseline] (6.251 ms) : 0, 6251
Debugger [candidate] (6.358 ms) : 0, 6358
Remote Config [baseline] (680.252 µs) : 0, 680
Remote Config [candidate] (688.103 µs) : 0, 688
Telemetry [baseline] (15.792 ms) : 0, 15792
Telemetry [candidate] (15.378 ms) : 0, 15378
Profiling [baseline] (108.495 ms) : 0, 108495
Profiling [candidate] (109.853 ms) : 0, 109853
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~aa98b0ed9d, baseline=1.53.0-SNAPSHOT~c6140367d1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047721
Total [baseline] (8.573 s) : 0, 8572659
Agent [candidate] (1.042 s) : 0, 1042241
Total [candidate] (8.579 s) : 0, 8578828
section iast
Agent [baseline] (1.171 s) : 0, 1171158
Total [baseline] (9.323 s) : 0, 9322587
Agent [candidate] (1.173 s) : 0, 1172966
Total [candidate] (9.296 s) : 0, 9295935
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~aa98b0ed9d, baseline=1.53.0-SNAPSHOT~c6140367d1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (733.221 ms) : 0, 733221
BytebuddyAgent [candidate] (730.111 ms) : 0, 730111
GlobalTracer [baseline] (242.525 ms) : 0, 242525
GlobalTracer [candidate] (241.975 ms) : 0, 241975
AppSec [baseline] (30.2 ms) : 0, 30200
AppSec [candidate] (29.933 ms) : 0, 29933
Debugger [baseline] (6.018 ms) : 0, 6018
Debugger [candidate] (5.993 ms) : 0, 5993
Remote Config [baseline] (656.498 µs) : 0, 656
Remote Config [candidate] (655.382 µs) : 0, 655
Telemetry [baseline] (12.707 ms) : 0, 12707
Telemetry [candidate] (11.258 ms) : 0, 11258
section iast
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (845.714 ms) : 0, 845714
BytebuddyAgent [candidate] (846.971 ms) : 0, 846971
GlobalTracer [baseline] (231.661 ms) : 0, 231661
GlobalTracer [candidate] (231.685 ms) : 0, 231685
AppSec [baseline] (25.167 ms) : 0, 25167
AppSec [candidate] (28.481 ms) : 0, 28481
Debugger [baseline] (5.813 ms) : 0, 5813
Debugger [candidate] (5.787 ms) : 0, 5787
Remote Config [baseline] (584.574 µs) : 0, 585
Remote Config [candidate] (602.541 µs) : 0, 603
Telemetry [baseline] (8.041 ms) : 0, 8041
Telemetry [candidate] (8.106 ms) : 0, 8106
IAST [baseline] (31.938 ms) : 0, 31938
IAST [candidate] (28.951 ms) : 0, 28951
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~aa98b0ed9d, baseline=1.53.0-SNAPSHOT~c6140367d1
dateFormat X
axisFormat %s
section baseline
no_agent (4.432 ms) : 4382, 4483
. : milestone, 4432,
iast (9.41 ms) : 9253, 9566
. : milestone, 9410,
iast_FULL (14.314 ms) : 14030, 14597
. : milestone, 14314,
iast_GLOBAL (10.03 ms) : 9854, 10206
. : milestone, 10030,
profiling (9.017 ms) : 8876, 9157
. : milestone, 9017,
tracing (7.49 ms) : 7387, 7593
. : milestone, 7490,
section candidate
no_agent (4.348 ms) : 4296, 4400
. : milestone, 4348,
iast (9.438 ms) : 9282, 9594
. : milestone, 9438,
iast_FULL (14.364 ms) : 14078, 14649
. : milestone, 14364,
iast_GLOBAL (10.604 ms) : 10417, 10792
. : milestone, 10604,
profiling (8.635 ms) : 8502, 8767
. : milestone, 8635,
tracing (7.541 ms) : 7435, 7646
. : milestone, 7541,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~aa98b0ed9d, baseline=1.53.0-SNAPSHOT~c6140367d1
dateFormat X
axisFormat %s
section baseline
no_agent (37.571 ms) : 37254, 37888
. : milestone, 37571,
appsec (47.151 ms) : 46735, 47567
. : milestone, 47151,
code_origins (45.355 ms) : 44959, 45751
. : milestone, 45355,
iast (46.79 ms) : 46376, 47204
. : milestone, 46790,
profiling (48.382 ms) : 47894, 48870
. : milestone, 48382,
tracing (44.501 ms) : 44124, 44878
. : milestone, 44501,
section candidate
no_agent (36.576 ms) : 36293, 36858
. : milestone, 36576,
appsec (48.756 ms) : 48347, 49165
. : milestone, 48756,
code_origins (45.289 ms) : 44901, 45677
. : milestone, 45289,
iast (45.48 ms) : 45081, 45879
. : milestone, 45480,
profiling (47.764 ms) : 47308, 48221
. : milestone, 47764,
tracing (43.942 ms) : 43555, 44328
. : milestone, 43942,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~aa98b0ed9d, baseline=1.53.0-SNAPSHOT~c6140367d1
dateFormat X
axisFormat %s
section baseline
no_agent (15.543 s) : 15543000, 15543000
. : milestone, 15543000,
appsec (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
iast (18.404 s) : 18404000, 18404000
. : milestone, 18404000,
iast_GLOBAL (17.926 s) : 17926000, 17926000
. : milestone, 17926000,
profiling (15.915 s) : 15915000, 15915000
. : milestone, 15915000,
tracing (14.872 s) : 14872000, 14872000
. : milestone, 14872000,
section candidate
no_agent (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
appsec (14.653 s) : 14653000, 14653000
. : milestone, 14653000,
iast (18.409 s) : 18409000, 18409000
. : milestone, 18409000,
iast_GLOBAL (18.258 s) : 18258000, 18258000
. : milestone, 18258000,
profiling (15.293 s) : 15293000, 15293000
. : milestone, 15293000,
tracing (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~aa98b0ed9d, baseline=1.53.0-SNAPSHOT~c6140367d1
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.631 ms) : 3415, 3847
. : milestone, 3631,
iast (2.198 ms) : 2135, 2261
. : milestone, 2198,
iast_GLOBAL (2.236 ms) : 2172, 2299
. : milestone, 2236,
profiling (2.04 ms) : 1990, 2091
. : milestone, 2040,
tracing (2.012 ms) : 1963, 2061
. : milestone, 2012,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.641 ms) : 3424, 3857
. : milestone, 3641,
iast (2.202 ms) : 2139, 2264
. : milestone, 2202,
iast_GLOBAL (2.241 ms) : 2178, 2305
. : milestone, 2241,
profiling (2.06 ms) : 2007, 2112
. : milestone, 2060,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
|
What Does This Do
Avoid using https://github.com/planetscale/ghcommit because
ghcommit
can only add files whereas this workflow needs to add a directory. Also use add-octo-sts
token instead ofGITHUB_TOKEN
for PR creation (e.g. #9288). The policy for this workflow corresponds to #9303, which is already merged tomaster
.Motivation
Fix failing workflow: https://github.com/DataDog/dd-trace-java/actions/runs/16732671104/job/47364223082
Additional Notes
Because we're not using
ghcommit
, I expect the commits created in this PR to be unsigned. They will need to be manually signed before merging until #9302 is resolved.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-722