Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys #9321

na-ji · 2025-08-06T10:08:06Z

What Does This Do

Modify the way we append/prepend the DBM tracing comment into queries.

Motivation

When tracing the JDBC statement execute methods, we prepend a comment to the SQL query used for DBM trace propagation.
However, there is a bug in the SQL Server JDBC driver that prevents the generated keys from being returned when the SQL comment is prepended to the SQL query.
I decided to only append the comment in this specific case to avoid the comment from being truncated.

See microsoft/mssql-jdbc#2729

Additional Notes

This is the code that used to crash on the injected app when DBM trace propagation was enabled

Statement stmt = conn.createStatement();
stmt.executeUpdate(INSERT_QUERY, Statement.RETURN_GENERATED_KEYS);
ResultSet rs = stmt.getGeneratedKeys();

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

@see

…nerated keys When tracing the JDBC statement execute methods, we prepend a comment to the SQL query used for DBM trace propagation. However, there is a bug in the SQL Server JDBC driver that prevents the generated keys from being returned when the SQL comment is prepended to the SQL query. I decided to only append the comment in this specific case to avoid the comment from being truncated. @see microsoft/mssql-jdbc#2729

datadog-official · 2025-08-06T10:30:59Z

Code coverage: total 68.77%, base diff 11.50%, patch 100.00% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: eebbd7e | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-06T10:44:32Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/sqlserver-jdbc-generated-keys-workaround
git_commit_date	1754423381	1754474989
git_commit_sha	`d6b43cb`	`eebbd7e`
release_version	1.53.0-SNAPSHOT~d6b43cba5c	1.53.0-SNAPSHOT~eebbd7e676

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1754476755	1754476755
ci_job_id	1066491171	1066491171
ci_pipeline_id	72826710	72826710
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-xo8dcu8v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-xo8dcu8v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 13 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:iast:Remote Config	better [-50.557µs; -13.171µs] or [-8.311%; -2.165%]	576.470µs	608.334µs

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~eebbd7e676, baseline=1.53.0-SNAPSHOT~d6b43cba5c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042693
Total [baseline] (8.572 s) : 0, 8571799
Agent [candidate] (1.051 s) : 0, 1050860
Total [candidate] (8.604 s) : 0, 8603881
section iast
Agent [baseline] (1.186 s) : 0, 1185715
Total [baseline] (9.397 s) : 0, 9396610
Agent [candidate] (1.175 s) : 0, 1175437
Total [candidate] (9.374 s) : 0, 9373603

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.186 s	143.022 ms (13.7%)
Total	tracing	8.572 s	-
Total	iast	9.397 s	824.811 ms (9.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	iast	1.175 s	124.576 ms (11.9%)
Total	tracing	8.604 s	-
Total	iast	9.374 s	769.722 ms (8.9%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~eebbd7e676, baseline=1.53.0-SNAPSHOT~d6b43cba5c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (730.379 ms) : 0, 730379
BytebuddyAgent [candidate] (733.47 ms) : 0, 733470
GlobalTracer [baseline] (241.603 ms) : 0, 241603
GlobalTracer [candidate] (243.999 ms) : 0, 243999
AppSec [baseline] (29.839 ms) : 0, 29839
AppSec [candidate] (30.413 ms) : 0, 30413
Debugger [baseline] (6.02 ms) : 0, 6020
Debugger [candidate] (6.072 ms) : 0, 6072
Remote Config [baseline] (647.536 µs) : 0, 648
Remote Config [candidate] (656.515 µs) : 0, 657
Telemetry [baseline] (11.858 ms) : 0, 11858
Telemetry [candidate] (13.801 ms) : 0, 13801
section iast
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (855.0 ms) : 0, 855000
BytebuddyAgent [candidate] (848.214 ms) : 0, 848214
GlobalTracer [baseline] (234.667 ms) : 0, 234667
GlobalTracer [candidate] (231.893 ms) : 0, 231893
AppSec [baseline] (26.027 ms) : 0, 26027
AppSec [candidate] (29.529 ms) : 0, 29529
Debugger [baseline] (9.313 ms) : 0, 9313
Debugger [candidate] (6.76 ms) : 0, 6760
Remote Config [baseline] (600.402 µs) : 0, 600
Remote Config [candidate] (618.376 µs) : 0, 618
Telemetry [baseline] (8.303 ms) : 0, 8303
Telemetry [candidate] (8.494 ms) : 0, 8494
IAST [baseline] (29.365 ms) : 0, 29365
IAST [candidate] (27.471 ms) : 0, 27471

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~eebbd7e676, baseline=1.53.0-SNAPSHOT~d6b43cba5c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054454
Total [baseline] (10.75 s) : 0, 10750130
Agent [candidate] (1.043 s) : 0, 1042964
Total [candidate] (10.803 s) : 0, 10802637
section appsec
Agent [baseline] (1.222 s) : 0, 1222487
Total [baseline] (10.806 s) : 0, 10806150
Agent [candidate] (1.226 s) : 0, 1226439
Total [candidate] (10.744 s) : 0, 10744034
section iast
Agent [baseline] (1.183 s) : 0, 1183255
Total [baseline] (10.924 s) : 0, 10923943
Agent [candidate] (1.174 s) : 0, 1174143
Total [candidate] (10.875 s) : 0, 10874729
section profiling
Agent [baseline] (1.197 s) : 0, 1196534
Total [baseline] (10.925 s) : 0, 10924760
Agent [candidate] (1.195 s) : 0, 1195083
Total [candidate] (10.921 s) : 0, 10921029

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	appsec	1.222 s	168.033 ms (15.9%)
Agent	iast	1.183 s	128.801 ms (12.2%)
Agent	profiling	1.197 s	142.08 ms (13.5%)
Total	tracing	10.75 s	-
Total	appsec	10.806 s	56.019 ms (0.5%)
Total	iast	10.924 s	173.812 ms (1.6%)
Total	profiling	10.925 s	174.629 ms (1.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.226 s	183.475 ms (17.6%)
Agent	iast	1.174 s	131.178 ms (12.6%)
Agent	profiling	1.195 s	152.119 ms (14.6%)
Total	tracing	10.803 s	-
Total	appsec	10.744 s	-58.603 ms (-0.5%)
Total	iast	10.875 s	72.091 ms (0.7%)
Total	profiling	10.921 s	118.392 ms (1.1%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~eebbd7e676, baseline=1.53.0-SNAPSHOT~d6b43cba5c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (737.278 ms) : 0, 737278
BytebuddyAgent [candidate] (730.252 ms) : 0, 730252
GlobalTracer [baseline] (244.03 ms) : 0, 244030
GlobalTracer [candidate] (242.116 ms) : 0, 242116
AppSec [baseline] (30.292 ms) : 0, 30292
AppSec [candidate] (29.941 ms) : 0, 29941
Debugger [baseline] (6.054 ms) : 0, 6054
Debugger [candidate] (6.03 ms) : 0, 6030
Remote Config [baseline] (650.037 µs) : 0, 650
Remote Config [candidate] (651.209 µs) : 0, 651
Telemetry [baseline] (13.578 ms) : 0, 13578
Telemetry [candidate] (11.53 ms) : 0, 11530
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (754.183 ms) : 0, 754183
BytebuddyAgent [candidate] (756.951 ms) : 0, 756951
GlobalTracer [baseline] (236.022 ms) : 0, 236022
GlobalTracer [candidate] (236.39 ms) : 0, 236390
AppSec [baseline] (169.233 ms) : 0, 169233
AppSec [candidate] (168.159 ms) : 0, 168159
Debugger [baseline] (7.248 ms) : 0, 7248
Debugger [candidate] (8.75 ms) : 0, 8750
Remote Config [baseline] (609.425 µs) : 0, 609
Remote Config [candidate] (617.772 µs) : 0, 618
Telemetry [baseline] (9.145 ms) : 0, 9145
Telemetry [candidate] (9.177 ms) : 0, 9177
IAST [baseline] (23.535 ms) : 0, 23535
IAST [candidate] (23.855 ms) : 0, 23855
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (854.869 ms) : 0, 854869
BytebuddyAgent [candidate] (847.327 ms) : 0, 847327
GlobalTracer [baseline] (233.93 ms) : 0, 233930
GlobalTracer [candidate] (231.684 ms) : 0, 231684
AppSec [baseline] (27.864 ms) : 0, 27864
AppSec [candidate] (26.339 ms) : 0, 26339
Debugger [baseline] (6.69 ms) : 0, 6690
Debugger [candidate] (8.482 ms) : 0, 8482
Remote Config [baseline] (608.334 µs) : 0, 608
Remote Config [candidate] (576.47 µs) : 0, 576
Telemetry [baseline] (8.276 ms) : 0, 8276
Telemetry [candidate] (8.174 ms) : 0, 8174
IAST [baseline] (28.461 ms) : 0, 28461
IAST [candidate] (29.072 ms) : 0, 29072
section profiling
crashtracking [baseline] (1.418 ms) : 0, 1418
crashtracking [candidate] (1.414 ms) : 0, 1414
BytebuddyAgent [baseline] (760.62 ms) : 0, 760620
BytebuddyAgent [candidate] (761.745 ms) : 0, 761745
GlobalTracer [baseline] (223.179 ms) : 0, 223179
GlobalTracer [candidate] (221.485 ms) : 0, 221485
AppSec [baseline] (30.222 ms) : 0, 30222
AppSec [candidate] (29.758 ms) : 0, 29758
Debugger [baseline] (6.3 ms) : 0, 6300
Debugger [candidate] (6.287 ms) : 0, 6287
Remote Config [baseline] (702.927 µs) : 0, 703
Remote Config [candidate] (672.221 µs) : 0, 672
Telemetry [baseline] (16.303 ms) : 0, 16303
Telemetry [candidate] (16.015 ms) : 0, 16015
ProfilingAgent [baseline] (108.342 ms) : 0, 108342
ProfilingAgent [candidate] (108.027 ms) : 0, 108027
Profiling [baseline] (108.984 ms) : 0, 108984
Profiling [candidate] (108.684 ms) : 0, 108684

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/sqlserver-jdbc-generated-keys-workaround
git_commit_date	1754423381	1754474989
git_commit_sha	`d6b43cb`	`eebbd7e`
release_version	1.53.0-SNAPSHOT~d6b43cba5c	1.53.0-SNAPSHOT~eebbd7e676

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1754476515	1754476515
ci_job_id	1066491172	1066491172
ci_pipeline_id	72826710	72826710
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-7i186dsj 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-7i186dsj 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	better [-504.587µs; -216.942µs] or [-5.810%; -2.498%]	unstable [-50.276op/s; +96.026op/s] or [-9.413%; +17.979%]	8.324ms	556.969op/s	8.685ms	534.094op/s
scenario:load:petclinic:profiling:high_load	better [-2.503ms; -1.509ms] or [-5.009%; -3.020%]	unstable [-3.126op/s; +10.926op/s] or [-3.337%; +11.664%]	47.955ms	97.575op/s	49.961ms	93.675op/s
scenario:load:petclinic:iast:high_load	better [-3.667ms; -2.859ms] or [-7.975%; -6.217%]	unstable [+0.138op/s; +15.362op/s] or [+0.136%; +15.092%]	42.719ms	109.537op/s	45.982ms	101.787op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~eebbd7e676, baseline=1.53.0-SNAPSHOT~d6b43cba5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.353 ms) : 4305, 4402
.   : milestone, 4353,
iast (9.411 ms) : 9260, 9563
.   : milestone, 9411,
iast_FULL (14.146 ms) : 13861, 14431
.   : milestone, 14146,
iast_GLOBAL (10.228 ms) : 10049, 10407
.   : milestone, 10228,
profiling (8.685 ms) : 8545, 8825
.   : milestone, 8685,
tracing (7.624 ms) : 7508, 7740
.   : milestone, 7624,
section candidate
no_agent (4.419 ms) : 4361, 4476
.   : milestone, 4419,
iast (9.488 ms) : 9335, 9641
.   : milestone, 9488,
iast_FULL (14.275 ms) : 13991, 14560
.   : milestone, 14275,
iast_GLOBAL (10.204 ms) : 10026, 10383
.   : milestone, 10204,
profiling (8.324 ms) : 8198, 8451
.   : milestone, 8324,
tracing (7.453 ms) : 7340, 7566
.   : milestone, 7453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.353 ms [4.305 ms, 4.402 ms]	-
iast	9.411 ms [9.26 ms, 9.563 ms]	5.058 ms (116.2%)
iast_FULL	14.146 ms [13.861 ms, 14.431 ms]	9.792 ms (224.9%)
iast_GLOBAL	10.228 ms [10.049 ms, 10.407 ms]	5.875 ms (134.9%)
profiling	8.685 ms [8.545 ms, 8.825 ms]	4.332 ms (99.5%)
tracing	7.624 ms [7.508 ms, 7.74 ms]	3.27 ms (75.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.419 ms [4.361 ms, 4.476 ms]	-
iast	9.488 ms [9.335 ms, 9.641 ms]	5.069 ms (114.7%)
iast_FULL	14.275 ms [13.991 ms, 14.56 ms]	9.856 ms (223.1%)
iast_GLOBAL	10.204 ms [10.026 ms, 10.383 ms]	5.785 ms (130.9%)
profiling	8.324 ms [8.198 ms, 8.451 ms]	3.906 ms (88.4%)
tracing	7.453 ms [7.34 ms, 7.566 ms]	3.034 ms (68.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~eebbd7e676, baseline=1.53.0-SNAPSHOT~d6b43cba5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.851 ms) : 36552, 37151
.   : milestone, 36851,
appsec (48.22 ms) : 47785, 48654
.   : milestone, 48220,
code_origins (44.336 ms) : 43946, 44726
.   : milestone, 44336,
iast (45.982 ms) : 45589, 46374
.   : milestone, 45982,
profiling (49.961 ms) : 49502, 50420
.   : milestone, 49961,
tracing (45.675 ms) : 45283, 46068
.   : milestone, 45675,
section candidate
no_agent (37.791 ms) : 37483, 38098
.   : milestone, 37791,
appsec (49.117 ms) : 48680, 49554
.   : milestone, 49117,
code_origins (45.492 ms) : 45109, 45875
.   : milestone, 45492,
iast (42.719 ms) : 42361, 43076
.   : milestone, 42719,
profiling (47.955 ms) : 47491, 48420
.   : milestone, 47955,
tracing (44.929 ms) : 44547, 45310
.   : milestone, 44929,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.851 ms [36.552 ms, 37.151 ms]	-
appsec	48.22 ms [47.785 ms, 48.654 ms]	11.368 ms (30.8%)
code_origins	44.336 ms [43.946 ms, 44.726 ms]	7.485 ms (20.3%)
iast	45.982 ms [45.589 ms, 46.374 ms]	9.13 ms (24.8%)
profiling	49.961 ms [49.502 ms, 50.42 ms]	13.11 ms (35.6%)
tracing	45.675 ms [45.283 ms, 46.068 ms]	8.824 ms (23.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.791 ms [37.483 ms, 38.098 ms]	-
appsec	49.117 ms [48.68 ms, 49.554 ms]	11.327 ms (30.0%)
code_origins	45.492 ms [45.109 ms, 45.875 ms]	7.702 ms (20.4%)
iast	42.719 ms [42.361 ms, 43.076 ms]	4.928 ms (13.0%)
profiling	47.955 ms [47.491 ms, 48.42 ms]	10.165 ms (26.9%)
tracing	44.929 ms [44.547 ms, 45.31 ms]	7.138 ms (18.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/sqlserver-jdbc-generated-keys-workaround
git_commit_date	1754423381	1754474989
git_commit_sha	`d6b43cb`	`eebbd7e`
release_version	1.53.0-SNAPSHOT~d6b43cba5c	1.53.0-SNAPSHOT~eebbd7e676

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1754476971	1754476971
ci_job_id	1066491173	1066491173
ci_pipeline_id	72826710	72826710
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-br2xce6b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-br2xce6b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~eebbd7e676, baseline=1.53.0-SNAPSHOT~d6b43cba5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.421 s) : 15421000, 15421000
.   : milestone, 15421000,
appsec (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
iast (18.388 s) : 18388000, 18388000
.   : milestone, 18388000,
iast_GLOBAL (18.326 s) : 18326000, 18326000
.   : milestone, 18326000,
profiling (15.366 s) : 15366000, 15366000
.   : milestone, 15366000,
tracing (14.931 s) : 14931000, 14931000
.   : milestone, 14931000,
section candidate
no_agent (15.528 s) : 15528000, 15528000
.   : milestone, 15528000,
appsec (14.719 s) : 14719000, 14719000
.   : milestone, 14719000,
iast (18.199 s) : 18199000, 18199000
.   : milestone, 18199000,
iast_GLOBAL (17.972 s) : 17972000, 17972000
.   : milestone, 17972000,
profiling (15.229 s) : 15229000, 15229000
.   : milestone, 15229000,
tracing (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.421 s [15.421 s, 15.421 s]	-
appsec	14.966 s [14.966 s, 14.966 s]	-455.0 ms (-3.0%)
iast	18.388 s [18.388 s, 18.388 s]	2.967 s (19.2%)
iast_GLOBAL	18.326 s [18.326 s, 18.326 s]	2.905 s (18.8%)
profiling	15.366 s [15.366 s, 15.366 s]	-55.0 ms (-0.4%)
tracing	14.931 s [14.931 s, 14.931 s]	-490.0 ms (-3.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.528 s [15.528 s, 15.528 s]	-
appsec	14.719 s [14.719 s, 14.719 s]	-809.0 ms (-5.2%)
iast	18.199 s [18.199 s, 18.199 s]	2.671 s (17.2%)
iast_GLOBAL	17.972 s [17.972 s, 17.972 s]	2.444 s (15.7%)
profiling	15.229 s [15.229 s, 15.229 s]	-299.0 ms (-1.9%)
tracing	14.985 s [14.985 s, 14.985 s]	-543.0 ms (-3.5%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~eebbd7e676, baseline=1.53.0-SNAPSHOT~d6b43cba5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (3.675 ms) : 3455, 3896
.   : milestone, 3675,
iast (2.202 ms) : 2139, 2265
.   : milestone, 2202,
iast_GLOBAL (2.24 ms) : 2177, 2303
.   : milestone, 2240,
profiling (2.445 ms) : 2292, 2599
.   : milestone, 2445,
tracing (2.013 ms) : 1964, 2061
.   : milestone, 2013,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (3.654 ms) : 3438, 3869
.   : milestone, 3654,
iast (2.201 ms) : 2139, 2263
.   : milestone, 2201,
iast_GLOBAL (2.236 ms) : 2174, 2299
.   : milestone, 2236,
profiling (2.491 ms) : 2324, 2658
.   : milestone, 2491,
tracing (2.016 ms) : 1967, 2064
.   : milestone, 2016,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	3.675 ms [3.455 ms, 3.896 ms]	2.202 ms (149.5%)
iast	2.202 ms [2.139 ms, 2.265 ms]	729.148 µs (49.5%)
iast_GLOBAL	2.24 ms [2.177 ms, 2.303 ms]	766.763 µs (52.1%)
profiling	2.445 ms [2.292 ms, 2.599 ms]	972.414 µs (66.0%)
tracing	2.013 ms [1.964 ms, 2.061 ms]	539.628 µs (36.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	3.654 ms [3.438 ms, 3.869 ms]	2.18 ms (147.8%)
iast	2.201 ms [2.139 ms, 2.263 ms]	726.788 µs (49.3%)
iast_GLOBAL	2.236 ms [2.174 ms, 2.299 ms]	762.244 µs (51.7%)
profiling	2.491 ms [2.324 ms, 2.658 ms]	1.017 ms (69.0%)
tracing	2.016 ms [1.967 ms, 2.064 ms]	541.552 µs (36.7%)

na-ji · 2025-08-06T13:29:43Z

...entation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/StatementInstrumentation.java

@@ -75,6 +76,7 @@ public static class StatementAdvice {
    @Advice.OnMethodEnter(suppress = Throwable.class)
    public static AgentScope onEnter(
        @Advice.Argument(value = 0, readOnly = false) String sql,
+        @Advice.AllArguments(typing = DYNAMIC) Object[] args,


I've decided to use AllArguments here, because some of the execute methods we are hooking accepts an int for the generatedKeys, while others accept an array of ints for columnIndexes or and array of strings for columnNames

getting byte-buddy to pack all arguments into an array could affect performance - have you done any benchmarking of this?

An alternative approach that would avoid this would be to write different advices for the different method signatures - you can still share code between the advices by moving that code to the decorator (or similar helper)

~~While this would take longer to write, it would be much more performant... also you'd only write the code once while this advice will be invoked many millions of time~~

FYI, I did some benchmarking with an existing setup and the overhead is minor

@na-ji btw, is the typing = DYNAMIC needed?

I found a couple of existing instrumentations that use @Advice.AllArguments and they don't need typing = DYNAMIC

mcculls

~~I'm wary about the change to add~~

@Advice.AllArguments(typing = DYNAMIC) Object[] args

and would prefer to see this covered by more focused advice, because that would avoid the additional byte-buddy allocation of an array to hold all the arguments and copying them in individually - this is a hot method and additional allocations could easily affect latency.

~~But if a benchmark of a DB application being traced before this change and after doesn't show any difference then I'm ok with this change (I'd just like to get confirmation of that)~~

Also :dd-java-agent:instrumentation:jdbc:forkedTest is failing on CI for this branch - that needs fixing before this could be merged and backported

I did some benchmarking with an existing setup and the overhead is minor.

So it's just the :dd-java-agent:instrumentation:jdbc:forkedTest that needs fixing

na-ji added type: bug Bug report and fix inst: jdbc JDBC instrumentation comp: database Database Monitoring labels Aug 6, 2025

na-ji force-pushed the naji.astier/sqlserver-jdbc-generated-keys-workaround branch from 0a8f95f to eebbd7e Compare August 6, 2025 10:09

na-ji marked this pull request as ready for review August 6, 2025 11:33

na-ji requested a review from a team as a code owner August 6, 2025 11:33

na-ji commented Aug 6, 2025

View reviewed changes

mcculls previously requested changes Aug 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys #9321

Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys #9321

na-ji commented Aug 6, 2025

Uh oh!

datadog-official bot commented Aug 6, 2025

Uh oh!

pr-commenter bot commented Aug 6, 2025

Uh oh!

na-ji Aug 6, 2025

Uh oh!

mcculls Aug 13, 2025

Uh oh!

mcculls Aug 13, 2025 •

edited

Loading

Uh oh!

mcculls Aug 13, 2025

Uh oh!

mcculls Aug 13, 2025

Uh oh!

mcculls left a comment •

edited

Loading

Uh oh!

Uh oh!

Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys #9321

Are you sure you want to change the base?

Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys #9321

Conversation

na-ji commented Aug 6, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Aug 6, 2025

Uh oh!

pr-commenter bot commented Aug 6, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

na-ji Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

mcculls Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

mcculls Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcculls Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

mcculls Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

mcculls left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mcculls Aug 13, 2025 •

edited

Loading

mcculls left a comment •

edited

Loading