-
Notifications
You must be signed in to change notification settings - Fork 311
ConfigProvider.Source bubbles up parsing errors to ConfigProvider with ConfigSourceException #9325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d throw this exception, and introduce tests
Code coverage: total 57.25%, patch 70.77% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 922c780 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~922c7805be, baseline=1.53.0-SNAPSHOT~86fb978afd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050770
Total [baseline] (8.645 s) : 0, 8644521
Agent [candidate] (1.049 s) : 0, 1048979
Total [candidate] (8.584 s) : 0, 8583610
section iast
Agent [baseline] (1.185 s) : 0, 1185238
Total [baseline] (9.32 s) : 0, 9320474
Agent [candidate] (1.182 s) : 0, 1182386
Total [candidate] (9.335 s) : 0, 9334749
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~922c7805be, baseline=1.53.0-SNAPSHOT~86fb978afd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (734.497 ms) : 0, 734497
BytebuddyAgent [candidate] (733.158 ms) : 0, 733158
GlobalTracer [baseline] (243.192 ms) : 0, 243192
GlobalTracer [candidate] (242.916 ms) : 0, 242916
AppSec [baseline] (30.262 ms) : 0, 30262
AppSec [candidate] (30.141 ms) : 0, 30141
Debugger [baseline] (6.072 ms) : 0, 6072
Debugger [candidate] (6.075 ms) : 0, 6075
Remote Config [baseline] (657.931 µs) : 0, 658
Remote Config [candidate] (687.185 µs) : 0, 687
Telemetry [baseline] (13.579 ms) : 0, 13579
Telemetry [candidate] (13.539 ms) : 0, 13539
section iast
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (856.268 ms) : 0, 856268
BytebuddyAgent [candidate] (853.663 ms) : 0, 853663
GlobalTracer [baseline] (233.681 ms) : 0, 233681
GlobalTracer [candidate] (234.004 ms) : 0, 234004
IAST [baseline] (26.965 ms) : 0, 26965
IAST [candidate] (25.443 ms) : 0, 25443
AppSec [baseline] (28.52 ms) : 0, 28520
AppSec [candidate] (27.693 ms) : 0, 27693
Debugger [baseline] (8.296 ms) : 0, 8296
Debugger [candidate] (10.047 ms) : 0, 10047
Remote Config [baseline] (592.354 µs) : 0, 592
Remote Config [candidate] (586.35 µs) : 0, 586
Telemetry [baseline] (8.369 ms) : 0, 8369
Telemetry [candidate] (8.345 ms) : 0, 8345
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~922c7805be, baseline=1.53.0-SNAPSHOT~86fb978afd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043668
Total [baseline] (10.736 s) : 0, 10735529
Agent [candidate] (1.048 s) : 0, 1047816
Total [candidate] (10.789 s) : 0, 10789148
section appsec
Agent [baseline] (1.217 s) : 0, 1216604
Total [baseline] (10.801 s) : 0, 10801246
Agent [candidate] (1.222 s) : 0, 1222255
Total [candidate] (10.776 s) : 0, 10776420
section iast
Agent [baseline] (1.189 s) : 0, 1188944
Total [baseline] (10.999 s) : 0, 10998655
Agent [candidate] (1.19 s) : 0, 1189863
Total [candidate] (11.009 s) : 0, 11008624
section profiling
Agent [baseline] (1.194 s) : 0, 1193590
Total [baseline] (10.95 s) : 0, 10950500
Agent [candidate] (1.208 s) : 0, 1207759
Total [candidate] (11.008 s) : 0, 11008264
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~922c7805be, baseline=1.53.0-SNAPSHOT~86fb978afd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (730.858 ms) : 0, 730858
BytebuddyAgent [candidate] (735.193 ms) : 0, 735193
GlobalTracer [baseline] (241.667 ms) : 0, 241667
GlobalTracer [candidate] (242.007 ms) : 0, 242007
AppSec [baseline] (29.941 ms) : 0, 29941
AppSec [candidate] (30.026 ms) : 0, 30026
Debugger [baseline] (6.022 ms) : 0, 6022
Debugger [candidate] (6.025 ms) : 0, 6025
Remote Config [baseline] (645.371 µs) : 0, 645
Remote Config [candidate] (652.298 µs) : 0, 652
Telemetry [baseline] (12.139 ms) : 0, 12139
Telemetry [candidate] (11.372 ms) : 0, 11372
section appsec
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (750.606 ms) : 0, 750606
BytebuddyAgent [candidate] (753.43 ms) : 0, 753430
GlobalTracer [baseline] (234.592 ms) : 0, 234592
GlobalTracer [candidate] (235.871 ms) : 0, 235871
IAST [baseline] (23.459 ms) : 0, 23459
IAST [candidate] (23.645 ms) : 0, 23645
AppSec [baseline] (168.03 ms) : 0, 168030
AppSec [candidate] (164.296 ms) : 0, 164296
Debugger [baseline] (8.664 ms) : 0, 8664
Debugger [candidate] (11.83 ms) : 0, 11830
Remote Config [baseline] (610.73 µs) : 0, 611
Remote Config [candidate] (621.62 µs) : 0, 622
Telemetry [baseline] (8.306 ms) : 0, 8306
Telemetry [candidate] (10.052 ms) : 0, 10052
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (859.436 ms) : 0, 859436
BytebuddyAgent [candidate] (859.176 ms) : 0, 859176
GlobalTracer [baseline] (234.218 ms) : 0, 234218
GlobalTracer [candidate] (234.951 ms) : 0, 234951
IAST [baseline] (26.96 ms) : 0, 26960
IAST [candidate] (29.616 ms) : 0, 29616
AppSec [baseline] (26.79 ms) : 0, 26790
AppSec [candidate] (26.943 ms) : 0, 26943
Debugger [baseline] (9.107 ms) : 0, 9107
Debugger [candidate] (7.524 ms) : 0, 7524
Remote Config [baseline] (591.983 µs) : 0, 592
Remote Config [candidate] (613.286 µs) : 0, 613
Telemetry [baseline] (9.173 ms) : 0, 9173
Telemetry [candidate] (8.44 ms) : 0, 8440
section profiling
crashtracking [baseline] (1.417 ms) : 0, 1417
crashtracking [candidate] (1.415 ms) : 0, 1415
BytebuddyAgent [baseline] (759.265 ms) : 0, 759265
BytebuddyAgent [candidate] (769.9 ms) : 0, 769900
GlobalTracer [baseline] (221.895 ms) : 0, 221895
GlobalTracer [candidate] (223.527 ms) : 0, 223527
AppSec [baseline] (30.253 ms) : 0, 30253
AppSec [candidate] (30.515 ms) : 0, 30515
Debugger [baseline] (6.308 ms) : 0, 6308
Debugger [candidate] (6.321 ms) : 0, 6321
Remote Config [baseline] (701.327 µs) : 0, 701
Remote Config [candidate] (691.551 µs) : 0, 692
Telemetry [baseline] (16.209 ms) : 0, 16209
Telemetry [candidate] (16.06 ms) : 0, 16060
ProfilingAgent [baseline] (108.272 ms) : 0, 108272
ProfilingAgent [candidate] (109.252 ms) : 0, 109252
Profiling [baseline] (108.916 ms) : 0, 108916
Profiling [candidate] (109.893 ms) : 0, 109893
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~922c7805be, baseline=1.53.0-SNAPSHOT~86fb978afd
dateFormat X
axisFormat %s
section baseline
no_agent (4.429 ms) : 4374, 4485
. : milestone, 4429,
iast (9.519 ms) : 9359, 9679
. : milestone, 9519,
iast_FULL (14.286 ms) : 14005, 14567
. : milestone, 14286,
iast_GLOBAL (10.073 ms) : 9880, 10266
. : milestone, 10073,
profiling (8.847 ms) : 8709, 8984
. : milestone, 8847,
tracing (7.582 ms) : 7470, 7695
. : milestone, 7582,
section candidate
no_agent (4.36 ms) : 4312, 4408
. : milestone, 4360,
iast (9.083 ms) : 8932, 9235
. : milestone, 9083,
iast_FULL (13.958 ms) : 13677, 14238
. : milestone, 13958,
iast_GLOBAL (10.428 ms) : 10244, 10611
. : milestone, 10428,
profiling (8.961 ms) : 8812, 9109
. : milestone, 8961,
tracing (7.232 ms) : 7133, 7331
. : milestone, 7232,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~922c7805be, baseline=1.53.0-SNAPSHOT~86fb978afd
dateFormat X
axisFormat %s
section baseline
no_agent (37.564 ms) : 37261, 37867
. : milestone, 37564,
appsec (45.963 ms) : 45555, 46370
. : milestone, 45963,
code_origins (43.452 ms) : 43063, 43841
. : milestone, 43452,
iast (45.483 ms) : 45082, 45884
. : milestone, 45483,
profiling (48.849 ms) : 48380, 49317
. : milestone, 48849,
tracing (43.741 ms) : 43371, 44111
. : milestone, 43741,
section candidate
no_agent (37.829 ms) : 37518, 38140
. : milestone, 37829,
appsec (48.153 ms) : 47731, 48576
. : milestone, 48153,
code_origins (44.558 ms) : 44156, 44961
. : milestone, 44558,
iast (44.751 ms) : 44358, 45143
. : milestone, 44751,
profiling (47.557 ms) : 47130, 47985
. : milestone, 47557,
tracing (45.385 ms) : 45002, 45768
. : milestone, 45385,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~922c7805be, baseline=1.53.0-SNAPSHOT~86fb978afd
dateFormat X
axisFormat %s
section baseline
no_agent (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
appsec (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
iast (19.009 s) : 19009000, 19009000
. : milestone, 19009000,
iast_GLOBAL (17.772 s) : 17772000, 17772000
. : milestone, 17772000,
profiling (15.197 s) : 15197000, 15197000
. : milestone, 15197000,
tracing (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
section candidate
no_agent (15.616 s) : 15616000, 15616000
. : milestone, 15616000,
appsec (14.755 s) : 14755000, 14755000
. : milestone, 14755000,
iast (18.29 s) : 18290000, 18290000
. : milestone, 18290000,
iast_GLOBAL (18.076 s) : 18076000, 18076000
. : milestone, 18076000,
profiling (15.343 s) : 15343000, 15343000
. : milestone, 15343000,
tracing (15.113 s) : 15113000, 15113000
. : milestone, 15113000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~922c7805be, baseline=1.53.0-SNAPSHOT~86fb978afd
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.674 ms) : 3456, 3893
. : milestone, 3674,
iast (2.199 ms) : 2137, 2261
. : milestone, 2199,
iast_GLOBAL (2.256 ms) : 2193, 2320
. : milestone, 2256,
profiling (2.04 ms) : 1990, 2090
. : milestone, 2040,
tracing (2.022 ms) : 1974, 2070
. : milestone, 2022,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.665 ms) : 3449, 3880
. : milestone, 3665,
iast (2.2 ms) : 2138, 2263
. : milestone, 2200,
iast_GLOBAL (2.254 ms) : 2192, 2317
. : milestone, 2254,
profiling (2.486 ms) : 2320, 2653
. : milestone, 2486,
tracing (2.014 ms) : 1966, 2062
. : milestone, 2014,
|
What Does This Do
Modifies ConfigProvider.Source.get method to throw a ConfigSourceException. When thrown, the ConfigProvider can use the rawValue on the exception to report about the configured source to telemetry.
Motivation
Previously, ConfigProvider.Sources were abstracting away the scenario where a value was set, but it was invalid (e.g. it's a string when we need an int). We need to surface this information up to the ConfigProvider level in order to report about all configured sources to telemetry.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]