-
Notifications
You must be signed in to change notification settings - Fork 311
ConfigProvider iterates over all sources and reports all non-null val… #9327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ues to ConfigCollector
…ring, ConfigSetting>>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 47 metrics, 11 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~1b98073404, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054336
Total [baseline] (10.645 s) : 0, 10645017
Agent [candidate] (1.047 s) : 0, 1047307
Total [candidate] (10.695 s) : 0, 10694641
section appsec
Agent [baseline] (1.226 s) : 0, 1226304
Total [baseline] (10.854 s) : 0, 10854124
Agent [candidate] (1.228 s) : 0, 1227980
Total [candidate] (10.723 s) : 0, 10722783
section iast
Agent [baseline] (1.172 s) : 0, 1172011
Total [baseline] (10.82 s) : 0, 10820370
Agent [candidate] (1.174 s) : 0, 1173952
Total [candidate] (10.882 s) : 0, 10882115
section profiling
Agent [baseline] (1.199 s) : 0, 1199373
Total [baseline] (11.059 s) : 0, 11058619
Agent [candidate] (1.191 s) : 0, 1190731
Total [candidate] (10.828 s) : 0, 10827651
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~1b98073404, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (739.789 ms) : 0, 739789
BytebuddyAgent [candidate] (732.462 ms) : 0, 732462
GlobalTracer [baseline] (244.063 ms) : 0, 244063
GlobalTracer [candidate] (242.384 ms) : 0, 242384
AppSec [baseline] (30.523 ms) : 0, 30523
AppSec [candidate] (30.024 ms) : 0, 30024
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (5.946 ms) : 0, 5946
Remote Config [baseline] (658.456 µs) : 0, 658
Remote Config [candidate] (676.676 µs) : 0, 677
Telemetry [baseline] (10.655 ms) : 0, 10655
Telemetry [candidate] (13.429 ms) : 0, 13429
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (757.754 ms) : 0, 757754
BytebuddyAgent [candidate] (759.703 ms) : 0, 759703
GlobalTracer [baseline] (236.152 ms) : 0, 236152
GlobalTracer [candidate] (236.566 ms) : 0, 236566
IAST [baseline] (23.875 ms) : 0, 23875
IAST [candidate] (23.662 ms) : 0, 23662
AppSec [baseline] (168.176 ms) : 0, 168176
AppSec [candidate] (169.327 ms) : 0, 169327
Debugger [baseline] (7.253 ms) : 0, 7253
Debugger [candidate] (7.138 ms) : 0, 7138
Remote Config [baseline] (615.879 µs) : 0, 616
Remote Config [candidate] (595.896 µs) : 0, 596
Telemetry [baseline] (9.879 ms) : 0, 9879
Telemetry [candidate] (8.386 ms) : 0, 8386
section iast
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (846.902 ms) : 0, 846902
BytebuddyAgent [candidate] (847.829 ms) : 0, 847829
GlobalTracer [baseline] (231.253 ms) : 0, 231253
GlobalTracer [candidate] (231.974 ms) : 0, 231974
IAST [baseline] (28.155 ms) : 0, 28155
IAST [candidate] (31.502 ms) : 0, 31502
AppSec [baseline] (27.232 ms) : 0, 27232
AppSec [candidate] (24.816 ms) : 0, 24816
Debugger [baseline] (7.339 ms) : 0, 7339
Debugger [candidate] (6.677 ms) : 0, 6677
Remote Config [baseline] (569.296 µs) : 0, 569
Remote Config [candidate] (573.382 µs) : 0, 573
Telemetry [baseline] (8.242 ms) : 0, 8242
Telemetry [candidate] (8.224 ms) : 0, 8224
section profiling
crashtracking [baseline] (1.393 ms) : 0, 1393
crashtracking [candidate] (1.417 ms) : 0, 1417
BytebuddyAgent [baseline] (764.456 ms) : 0, 764456
BytebuddyAgent [candidate] (758.99 ms) : 0, 758990
GlobalTracer [baseline] (222.536 ms) : 0, 222536
GlobalTracer [candidate] (220.705 ms) : 0, 220705
AppSec [baseline] (30.249 ms) : 0, 30249
AppSec [candidate] (29.829 ms) : 0, 29829
Debugger [baseline] (6.269 ms) : 0, 6269
Debugger [candidate] (6.2 ms) : 0, 6200
Remote Config [baseline] (678.835 µs) : 0, 679
Remote Config [candidate] (645.933 µs) : 0, 646
Telemetry [baseline] (15.45 ms) : 0, 15450
Telemetry [candidate] (15.891 ms) : 0, 15891
ProfilingAgent [baseline] (108.934 ms) : 0, 108934
ProfilingAgent [candidate] (106.915 ms) : 0, 106915
Profiling [baseline] (109.563 ms) : 0, 109563
Profiling [candidate] (107.501 ms) : 0, 107501
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~1b98073404, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040773
Total [baseline] (8.567 s) : 0, 8567455
Agent [candidate] (1.044 s) : 0, 1044475
Total [candidate] (8.58 s) : 0, 8579529
section iast
Agent [baseline] (1.176 s) : 0, 1175617
Total [baseline] (9.318 s) : 0, 9317677
Agent [candidate] (1.172 s) : 0, 1172312
Total [candidate] (9.281 s) : 0, 9280845
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~1b98073404, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.416 ms) : 0, 1416
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (728.669 ms) : 0, 728669
BytebuddyAgent [candidate] (732.049 ms) : 0, 732049
GlobalTracer [baseline] (240.763 ms) : 0, 240763
GlobalTracer [candidate] (242.445 ms) : 0, 242445
AppSec [baseline] (29.803 ms) : 0, 29803
AppSec [candidate] (30.246 ms) : 0, 30246
Debugger [baseline] (5.987 ms) : 0, 5987
Debugger [candidate] (5.997 ms) : 0, 5997
Remote Config [baseline] (645.067 µs) : 0, 645
Remote Config [candidate] (688.892 µs) : 0, 689
Telemetry [baseline] (12.627 ms) : 0, 12627
Telemetry [candidate] (10.732 ms) : 0, 10732
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (849.338 ms) : 0, 849338
BytebuddyAgent [candidate] (846.621 ms) : 0, 846621
GlobalTracer [baseline] (231.981 ms) : 0, 231981
GlobalTracer [candidate] (231.688 ms) : 0, 231688
IAST [baseline] (30.861 ms) : 0, 30861
IAST [candidate] (29.167 ms) : 0, 29167
AppSec [baseline] (26.582 ms) : 0, 26582
AppSec [candidate] (25.578 ms) : 0, 25578
Debugger [baseline] (5.725 ms) : 0, 5725
Debugger [candidate] (8.235 ms) : 0, 8235
Remote Config [baseline] (580.203 µs) : 0, 580
Remote Config [candidate] (555.717 µs) : 0, 556
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.173 ms) : 0, 8173
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~1b98073404, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (4.456 ms) : 4405, 4508
. : milestone, 4456,
iast (9.078 ms) : 8931, 9226
. : milestone, 9078,
iast_FULL (13.777 ms) : 13503, 14052
. : milestone, 13777,
iast_GLOBAL (10.163 ms) : 9988, 10339
. : milestone, 10163,
profiling (8.966 ms) : 8819, 9113
. : milestone, 8966,
tracing (7.559 ms) : 7453, 7664
. : milestone, 7559,
section candidate
no_agent (4.419 ms) : 4361, 4476
. : milestone, 4419,
iast (9.606 ms) : 9445, 9767
. : milestone, 9606,
iast_FULL (13.409 ms) : 13145, 13672
. : milestone, 13409,
iast_GLOBAL (9.967 ms) : 9793, 10140
. : milestone, 9967,
profiling (8.635 ms) : 8494, 8776
. : milestone, 8635,
tracing (7.581 ms) : 7465, 7697
. : milestone, 7581,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~1b98073404, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (37.019 ms) : 36730, 37308
. : milestone, 37019,
appsec (49.759 ms) : 49318, 50201
. : milestone, 49759,
code_origins (44.113 ms) : 43746, 44481
. : milestone, 44113,
iast (43.616 ms) : 43230, 44003
. : milestone, 43616,
profiling (47.591 ms) : 47144, 48038
. : milestone, 47591,
tracing (43.714 ms) : 43354, 44074
. : milestone, 43714,
section candidate
no_agent (36.504 ms) : 36211, 36796
. : milestone, 36504,
appsec (47.343 ms) : 46926, 47760
. : milestone, 47343,
code_origins (45.124 ms) : 44745, 45503
. : milestone, 45124,
iast (44.798 ms) : 44416, 45180
. : milestone, 44798,
profiling (46.616 ms) : 46201, 47031
. : milestone, 46616,
tracing (44.139 ms) : 43756, 44523
. : milestone, 44139,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~1b98073404, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.658 ms) : 3445, 3871
. : milestone, 3658,
iast (2.199 ms) : 2136, 2262
. : milestone, 2199,
iast_GLOBAL (2.235 ms) : 2173, 2298
. : milestone, 2235,
profiling (2.038 ms) : 1987, 2088
. : milestone, 2038,
tracing (2.016 ms) : 1968, 2065
. : milestone, 2016,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.65 ms) : 3434, 3866
. : milestone, 3650,
iast (2.188 ms) : 2126, 2250
. : milestone, 2188,
iast_GLOBAL (2.237 ms) : 2174, 2299
. : milestone, 2237,
profiling (2.053 ms) : 2002, 2105
. : milestone, 2053,
tracing (2.014 ms) : 1966, 2062
. : milestone, 2014,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~1b98073404, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
appsec (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
iast (18.098 s) : 18098000, 18098000
. : milestone, 18098000,
iast_GLOBAL (17.816 s) : 17816000, 17816000
. : milestone, 17816000,
profiling (15.208 s) : 15208000, 15208000
. : milestone, 15208000,
tracing (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
appsec (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
iast (18.361 s) : 18361000, 18361000
. : milestone, 18361000,
iast_GLOBAL (17.966 s) : 17966000, 17966000
. : milestone, 17966000,
profiling (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
tracing (15.114 s) : 15114000, 15114000
. : milestone, 15114000,
|
Code coverage: total 56.78%, base diff -0.49%, patch 82.86% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 1b98073 | Docs | Was this helpful? Give us feedback! |
@@ -16,42 +16,52 @@ public class ConfigCollector { | |||
private static final AtomicReferenceFieldUpdater<ConfigCollector, Map> COLLECTED_UPDATER = | |||
AtomicReferenceFieldUpdater.newUpdater(ConfigCollector.class, Map.class, "collected"); | |||
|
|||
private volatile Map<String, ConfigSetting> collected = new ConcurrentHashMap<>(); | |||
private volatile Map<ConfigOrigin, Map<String, ConfigSetting>> collected = | |||
new ConcurrentHashMap<>(); | |||
|
|||
public static ConfigCollector get() { | |||
return INSTANCE; | |||
} | |||
|
|||
public void put(String key, Object value, ConfigOrigin origin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I mark this one as deprecated?
…ues to ConfigCollector# What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]