Skip to content

Fix for play-2.8 'Source directory xxx is not a directory.` #9357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 14, 2025

Conversation

AlexeyKuznetsov-DD
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Aug 12, 2025

What Does This Do

Another attempt to fix the issue.

Motivation

Green CI.

Additional Notes

Task that actually failed is :dd-smoke-tests:play-2.8:processResources. In #9328 was implemented a fix, but it failed again. Trying to tweak it a bit.

Now with this PR I can see in build logs:

2025-08-12T23:02:18.136807Z 01O > Task :dd-smoke-tests:play-2.8:fixPlayRoutesDirectory
2025-08-12T23:02:18.136810Z 01O > Task :dd-smoke-tests:play-2.8:processResources

Hope this should fix this issue.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Aug 12, 2025

No data reported at this time.
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: da12ecd | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Aug 12, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/play-2.8-fix-2
git_commit_date 1755177341 1755179023
git_commit_sha abb3a35 da12ecd
release_version 1.53.0-SNAPSHOT~abb3a3537d 1.53.0-SNAPSHOT~da12ecd8d1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1755180909 1755180909
ci_job_id 1080469548 1080469548
ci_pipeline_id 73682104 73682104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-k62a1tkc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-k62a1tkc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041405
Total [baseline] (10.64 s) : 0, 10639843
Agent [candidate] (1.049 s) : 0, 1049447
Total [candidate] (10.732 s) : 0, 10731912
section appsec
Agent [baseline] (1.219 s) : 0, 1218825
Total [baseline] (10.787 s) : 0, 10786544
Agent [candidate] (1.22 s) : 0, 1220056
Total [candidate] (10.758 s) : 0, 10758452
section iast
Agent [baseline] (1.177 s) : 0, 1176854
Total [baseline] (10.929 s) : 0, 10929376
Agent [candidate] (1.18 s) : 0, 1179725
Total [candidate] (11.003 s) : 0, 11002584
section profiling
Agent [baseline] (1.192 s) : 0, 1191846
Total [baseline] (10.823 s) : 0, 10822737
Agent [candidate] (1.209 s) : 0, 1208753
Total [candidate] (10.911 s) : 0, 10911362
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.219 s 177.42 ms (17.0%)
Agent iast 1.177 s 135.449 ms (13.0%)
Agent profiling 1.192 s 150.441 ms (14.4%)
Total tracing 10.64 s -
Total appsec 10.787 s 146.7 ms (1.4%)
Total iast 10.929 s 289.533 ms (2.7%)
Total profiling 10.823 s 182.894 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.22 s 170.609 ms (16.3%)
Agent iast 1.18 s 130.278 ms (12.4%)
Agent profiling 1.209 s 159.306 ms (15.2%)
Total tracing 10.732 s -
Total appsec 10.758 s 26.54 ms (0.2%)
Total iast 11.003 s 270.672 ms (2.5%)
Total profiling 10.911 s 179.45 ms (1.7%)
gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (729.17 ms) : 0, 729170
BytebuddyAgent [candidate] (734.623 ms) : 0, 734623
GlobalTracer [baseline] (241.219 ms) : 0, 241219
GlobalTracer [candidate] (242.526 ms) : 0, 242526
AppSec [baseline] (30.064 ms) : 0, 30064
AppSec [candidate] (30.334 ms) : 0, 30334
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (6.064 ms) : 0, 6064
Remote Config [baseline] (652.424 µs) : 0, 652
Remote Config [candidate] (658.88 µs) : 0, 659
Telemetry [baseline] (11.968 ms) : 0, 11968
Telemetry [candidate] (12.798 ms) : 0, 12798
section appsec
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (752.969 ms) : 0, 752969
BytebuddyAgent [candidate] (754.721 ms) : 0, 754721
GlobalTracer [baseline] (234.026 ms) : 0, 234026
GlobalTracer [candidate] (234.163 ms) : 0, 234163
IAST [baseline] (23.554 ms) : 0, 23554
IAST [candidate] (23.4 ms) : 0, 23400
AppSec [baseline] (168.848 ms) : 0, 168848
AppSec [candidate] (169.796 ms) : 0, 169796
Debugger [baseline] (5.748 ms) : 0, 5748
Debugger [candidate] (6.435 ms) : 0, 6435
Remote Config [baseline] (622.833 µs) : 0, 623
Remote Config [candidate] (609.102 µs) : 0, 609
Telemetry [baseline] (10.572 ms) : 0, 10572
Telemetry [candidate] (8.351 ms) : 0, 8351
section iast
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (849.808 ms) : 0, 849808
BytebuddyAgent [candidate] (851.31 ms) : 0, 851310
GlobalTracer [baseline] (232.184 ms) : 0, 232184
GlobalTracer [candidate] (233.307 ms) : 0, 233307
IAST [baseline] (26.747 ms) : 0, 26747
IAST [candidate] (29.138 ms) : 0, 29138
AppSec [baseline] (28.393 ms) : 0, 28393
AppSec [candidate] (26.091 ms) : 0, 26091
Debugger [baseline] (8.326 ms) : 0, 8326
Debugger [candidate] (8.382 ms) : 0, 8382
Remote Config [baseline] (568.522 µs) : 0, 569
Remote Config [candidate] (579.842 µs) : 0, 580
Telemetry [baseline] (8.301 ms) : 0, 8301
Telemetry [candidate] (8.415 ms) : 0, 8415
section profiling
crashtracking [baseline] (1.389 ms) : 0, 1389
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (759.609 ms) : 0, 759609
BytebuddyAgent [candidate] (771.038 ms) : 0, 771038
GlobalTracer [baseline] (221.515 ms) : 0, 221515
GlobalTracer [candidate] (223.826 ms) : 0, 223826
AppSec [baseline] (29.901 ms) : 0, 29901
AppSec [candidate] (30.413 ms) : 0, 30413
Debugger [baseline] (6.266 ms) : 0, 6266
Debugger [candidate] (6.457 ms) : 0, 6457
Remote Config [baseline] (695.363 µs) : 0, 695
Remote Config [candidate] (679.272 µs) : 0, 679
Telemetry [baseline] (15.902 ms) : 0, 15902
Telemetry [candidate] (16.183 ms) : 0, 16183
ProfilingAgent [baseline] (107.201 ms) : 0, 107201
ProfilingAgent [candidate] (108.73 ms) : 0, 108730
Profiling [baseline] (107.823 ms) : 0, 107823
Profiling [candidate] (109.398 ms) : 0, 109398
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048512
Total [baseline] (8.571 s) : 0, 8570787
Agent [candidate] (1.057 s) : 0, 1056735
Total [candidate] (8.591 s) : 0, 8590593
section iast
Agent [baseline] (1.179 s) : 0, 1179426
Total [baseline] (9.324 s) : 0, 9324056
Agent [candidate] (1.175 s) : 0, 1175271
Total [candidate] (9.291 s) : 0, 9290890
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.179 s 130.914 ms (12.5%)
Total tracing 8.571 s -
Total iast 9.324 s 753.27 ms (8.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.175 s 118.536 ms (11.2%)
Total tracing 8.591 s -
Total iast 9.291 s 700.297 ms (8.2%)
gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (734.589 ms) : 0, 734589
BytebuddyAgent [candidate] (741.221 ms) : 0, 741221
GlobalTracer [baseline] (242.401 ms) : 0, 242401
GlobalTracer [candidate] (244.264 ms) : 0, 244264
AppSec [baseline] (30.37 ms) : 0, 30370
AppSec [candidate] (30.343 ms) : 0, 30343
Debugger [baseline] (6.045 ms) : 0, 6045
Debugger [candidate] (6.075 ms) : 0, 6075
Remote Config [baseline] (657.109 µs) : 0, 657
Remote Config [candidate] (663.034 µs) : 0, 663
Telemetry [baseline] (12.079 ms) : 0, 12079
Telemetry [candidate] (11.553 ms) : 0, 11553
section iast
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (852.119 ms) : 0, 852119
BytebuddyAgent [candidate] (848.645 ms) : 0, 848645
GlobalTracer [baseline] (233.185 ms) : 0, 233185
GlobalTracer [candidate] (232.386 ms) : 0, 232386
AppSec [baseline] (28.428 ms) : 0, 28428
AppSec [candidate] (28.004 ms) : 0, 28004
Debugger [baseline] (6.565 ms) : 0, 6565
Debugger [candidate] (6.612 ms) : 0, 6612
Remote Config [baseline] (589.35 µs) : 0, 589
Remote Config [candidate] (576.755 µs) : 0, 577
Telemetry [baseline] (8.336 ms) : 0, 8336
Telemetry [candidate] (8.348 ms) : 0, 8348
IAST [baseline] (27.716 ms) : 0, 27716
IAST [candidate] (28.371 ms) : 0, 28371
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/play-2.8-fix-2
git_commit_date 1755177341 1755179023
git_commit_sha abb3a35 da12ecd
release_version 1.53.0-SNAPSHOT~abb3a3537d 1.53.0-SNAPSHOT~da12ecd8d1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1755180587 1755180587
ci_job_id 1080469549 1080469549
ci_pipeline_id 73682104 73682104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-xxnhdq53 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-xxnhdq53 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load worse
[+366.551µs; +658.430µs] or [+4.329%; +7.776%]
unstable
[-96.356op/s; +34.668op/s] or [-17.599%; +6.332%]
8.980ms 516.656op/s 8.467ms 547.500op/s
scenario:load:insecure-bank:iast_FULL:high_load better
[-941.138µs; -346.611µs] or [-6.601%; -2.431%]
unstable
[-19.756op/s; +50.506op/s] or [-6.043%; +15.450%]
13.614ms 342.281op/s 14.258ms 326.906op/s
scenario:load:petclinic:tracing:high_load better
[-1.905ms; -1.107ms] or [-4.251%; -2.470%]
unstable
[-4.169op/s; +11.369op/s] or [-3.993%; +10.890%]
43.313ms 108.000op/s 44.819ms 104.400op/s
scenario:load:petclinic:code_origins:high_load better
[-1.888ms; -1.057ms] or [-4.150%; -2.322%]
unstable
[-4.096op/s; +10.971op/s] or [-3.985%; +10.672%]
44.030ms 106.237op/s 45.502ms 102.800op/s
scenario:load:petclinic:appsec:high_load better
[-2.270ms; -1.371ms] or [-4.684%; -2.830%]
unstable
[-3.434op/s; +10.834op/s] or [-3.555%; +11.214%]
46.643ms 100.312op/s 48.464ms 96.612op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.792 ms) : 36494, 37089
.   : milestone, 36792,
appsec (48.464 ms) : 48046, 48882
.   : milestone, 48464,
code_origins (45.502 ms) : 45106, 45899
.   : milestone, 45502,
iast (44.943 ms) : 44551, 45335
.   : milestone, 44943,
profiling (47.612 ms) : 47185, 48038
.   : milestone, 47612,
tracing (44.819 ms) : 44439, 45200
.   : milestone, 44819,
section candidate
no_agent (37.287 ms) : 36983, 37590
.   : milestone, 37287,
appsec (46.643 ms) : 46226, 47060
.   : milestone, 46643,
code_origins (44.03 ms) : 43654, 44406
.   : milestone, 44030,
iast (45.875 ms) : 45479, 46270
.   : milestone, 45875,
profiling (48.022 ms) : 47566, 48478
.   : milestone, 48022,
tracing (43.313 ms) : 42952, 43674
.   : milestone, 43313,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.792 ms [36.494 ms, 37.089 ms] -
appsec 48.464 ms [48.046 ms, 48.882 ms] 11.672 ms (31.7%)
code_origins 45.502 ms [45.106 ms, 45.899 ms] 8.711 ms (23.7%)
iast 44.943 ms [44.551 ms, 45.335 ms] 8.151 ms (22.2%)
profiling 47.612 ms [47.185 ms, 48.038 ms] 10.82 ms (29.4%)
tracing 44.819 ms [44.439 ms, 45.2 ms] 8.027 ms (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.287 ms [36.983 ms, 37.59 ms] -
appsec 46.643 ms [46.226 ms, 47.06 ms] 9.356 ms (25.1%)
code_origins 44.03 ms [43.654 ms, 44.406 ms] 6.743 ms (18.1%)
iast 45.875 ms [45.479 ms, 46.27 ms] 8.588 ms (23.0%)
profiling 48.022 ms [47.566 ms, 48.478 ms] 10.735 ms (28.8%)
tracing 43.313 ms [42.952 ms, 43.674 ms] 6.026 ms (16.2%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.314 ms) : 4257, 4371
.   : milestone, 4314,
iast (9.368 ms) : 9215, 9521
.   : milestone, 9368,
iast_FULL (14.258 ms) : 13973, 14542
.   : milestone, 14258,
iast_GLOBAL (10.089 ms) : 9916, 10261
.   : milestone, 10089,
profiling (8.467 ms) : 8338, 8597
.   : milestone, 8467,
tracing (7.72 ms) : 7611, 7830
.   : milestone, 7720,
section candidate
no_agent (4.257 ms) : 4202, 4312
.   : milestone, 4257,
iast (9.539 ms) : 9382, 9696
.   : milestone, 9539,
iast_FULL (13.614 ms) : 13346, 13882
.   : milestone, 13614,
iast_GLOBAL (9.917 ms) : 9747, 10086
.   : milestone, 9917,
profiling (8.98 ms) : 8839, 9121
.   : milestone, 8980,
tracing (7.674 ms) : 7565, 7784
.   : milestone, 7674,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.314 ms [4.257 ms, 4.371 ms] -
iast 9.368 ms [9.215 ms, 9.521 ms] 5.054 ms (117.2%)
iast_FULL 14.258 ms [13.973 ms, 14.542 ms] 9.944 ms (230.5%)
iast_GLOBAL 10.089 ms [9.916 ms, 10.261 ms] 5.775 ms (133.9%)
profiling 8.467 ms [8.338 ms, 8.597 ms] 4.154 ms (96.3%)
tracing 7.72 ms [7.611 ms, 7.83 ms] 3.406 ms (79.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.257 ms [4.202 ms, 4.312 ms] -
iast 9.539 ms [9.382 ms, 9.696 ms] 5.282 ms (124.1%)
iast_FULL 13.614 ms [13.346 ms, 13.882 ms] 9.357 ms (219.8%)
iast_GLOBAL 9.917 ms [9.747 ms, 10.086 ms] 5.66 ms (133.0%)
profiling 8.98 ms [8.839 ms, 9.121 ms] 4.723 ms (111.0%)
tracing 7.674 ms [7.565 ms, 7.784 ms] 3.417 ms (80.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/play-2.8-fix-2
git_commit_date 1755177341 1755179023
git_commit_sha abb3a35 da12ecd
release_version 1.53.0-SNAPSHOT~abb3a3537d 1.53.0-SNAPSHOT~da12ecd8d1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1755181112 1755181112
ci_job_id 1080469550 1080469550
ci_pipeline_id 73682104 73682104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-ka3jsvni 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-ka3jsvni 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.747 s) : 14747000, 14747000
.   : milestone, 14747000,
appsec (14.92 s) : 14920000, 14920000
.   : milestone, 14920000,
iast (18.637 s) : 18637000, 18637000
.   : milestone, 18637000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
.   : milestone, 17994000,
profiling (15.299 s) : 15299000, 15299000
.   : milestone, 15299000,
tracing (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
section candidate
no_agent (15.673 s) : 15673000, 15673000
.   : milestone, 15673000,
appsec (14.95 s) : 14950000, 14950000
.   : milestone, 14950000,
iast (18.408 s) : 18408000, 18408000
.   : milestone, 18408000,
iast_GLOBAL (18.365 s) : 18365000, 18365000
.   : milestone, 18365000,
profiling (15.341 s) : 15341000, 15341000
.   : milestone, 15341000,
tracing (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.747 s [14.747 s, 14.747 s] -
appsec 14.92 s [14.92 s, 14.92 s] 173.0 ms (1.2%)
iast 18.637 s [18.637 s, 18.637 s] 3.89 s (26.4%)
iast_GLOBAL 17.994 s [17.994 s, 17.994 s] 3.247 s (22.0%)
profiling 15.299 s [15.299 s, 15.299 s] 552.0 ms (3.7%)
tracing 15.013 s [15.013 s, 15.013 s] 266.0 ms (1.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.673 s [15.673 s, 15.673 s] -
appsec 14.95 s [14.95 s, 14.95 s] -723.0 ms (-4.6%)
iast 18.408 s [18.408 s, 18.408 s] 2.735 s (17.5%)
iast_GLOBAL 18.365 s [18.365 s, 18.365 s] 2.692 s (17.2%)
profiling 15.341 s [15.341 s, 15.341 s] -332.0 ms (-2.1%)
tracing 15.027 s [15.027 s, 15.027 s] -646.0 ms (-4.1%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.647 ms) : 3431, 3863
.   : milestone, 3647,
iast (2.202 ms) : 2139, 2265
.   : milestone, 2202,
iast_GLOBAL (2.237 ms) : 2173, 2300
.   : milestone, 2237,
profiling (2.492 ms) : 2324, 2660
.   : milestone, 2492,
tracing (2.022 ms) : 1972, 2071
.   : milestone, 2022,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (3.659 ms) : 3441, 3877
.   : milestone, 3659,
iast (2.193 ms) : 2131, 2256
.   : milestone, 2193,
iast_GLOBAL (2.239 ms) : 2175, 2302
.   : milestone, 2239,
profiling (2.027 ms) : 1977, 2078
.   : milestone, 2027,
tracing (2.021 ms) : 1972, 2070
.   : milestone, 2021,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 3.647 ms [3.431 ms, 3.863 ms] 2.172 ms (147.3%)
iast 2.202 ms [2.139 ms, 2.265 ms] 727.281 µs (49.3%)
iast_GLOBAL 2.237 ms [2.173 ms, 2.3 ms] 761.727 µs (51.6%)
profiling 2.492 ms [2.324 ms, 2.66 ms] 1.017 ms (69.0%)
tracing 2.022 ms [1.972 ms, 2.071 ms] 546.735 µs (37.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 3.659 ms [3.441 ms, 3.877 ms] 2.186 ms (148.4%)
iast 2.193 ms [2.131 ms, 2.256 ms] 720.539 µs (48.9%)
iast_GLOBAL 2.239 ms [2.175 ms, 2.302 ms] 765.95 µs (52.0%)
profiling 2.027 ms [1.977 ms, 2.078 ms] 554.444 µs (37.6%)
tracing 2.021 ms [1.972 ms, 2.07 ms] 548.172 µs (37.2%)

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Aug 12, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added comp: testing Testing tag: do not merge Do not merge changes tag: no release notes Changes to exclude from release notes labels Aug 12, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review August 13, 2025 16:35
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested a review from a team as a code owner August 13, 2025 16:35
@@ -3,6 +3,7 @@ plugins {
}

apply from: "$rootDir/gradle/java.gradle"
apply from: "$rootDir/gradle/fix-play-routes.gradle"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding, is the logic moving to a separate file necessary or for organizational / readability purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahchen6 I moved to separate file because I'm already using it 2 times and there is a chance that in future I will need it for all play-xxx modules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 suggestion: ‏I would recommend to move it to a dd-smoke-tests/play-common then.
It will be easier to find (same logic as the instrumentations) and won't mix with the overall project build scripts.

Copy link
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@@ -3,6 +3,7 @@ plugins {
}

apply from: "$rootDir/gradle/java.gradle"
apply from: "$rootDir/gradle/fix-play-routes.gradle"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 suggestion: ‏I would recommend to move it to a dd-smoke-tests/play-common then.
It will be easier to find (same logic as the instrumentations) and won't mix with the overall project build scripts.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD merged commit dda3d7a into master Aug 14, 2025
499 checks passed
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD deleted the alexeyk/play-2.8-fix-2 branch August 14, 2025 15:30
@github-actions github-actions bot added this to the 1.53.0 milestone Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants