-
Notifications
You must be signed in to change notification settings - Fork 312
Fix for play-2.8 'Source directory xxx is not a directory.` #9357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041405
Total [baseline] (10.64 s) : 0, 10639843
Agent [candidate] (1.049 s) : 0, 1049447
Total [candidate] (10.732 s) : 0, 10731912
section appsec
Agent [baseline] (1.219 s) : 0, 1218825
Total [baseline] (10.787 s) : 0, 10786544
Agent [candidate] (1.22 s) : 0, 1220056
Total [candidate] (10.758 s) : 0, 10758452
section iast
Agent [baseline] (1.177 s) : 0, 1176854
Total [baseline] (10.929 s) : 0, 10929376
Agent [candidate] (1.18 s) : 0, 1179725
Total [candidate] (11.003 s) : 0, 11002584
section profiling
Agent [baseline] (1.192 s) : 0, 1191846
Total [baseline] (10.823 s) : 0, 10822737
Agent [candidate] (1.209 s) : 0, 1208753
Total [candidate] (10.911 s) : 0, 10911362
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (729.17 ms) : 0, 729170
BytebuddyAgent [candidate] (734.623 ms) : 0, 734623
GlobalTracer [baseline] (241.219 ms) : 0, 241219
GlobalTracer [candidate] (242.526 ms) : 0, 242526
AppSec [baseline] (30.064 ms) : 0, 30064
AppSec [candidate] (30.334 ms) : 0, 30334
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (6.064 ms) : 0, 6064
Remote Config [baseline] (652.424 µs) : 0, 652
Remote Config [candidate] (658.88 µs) : 0, 659
Telemetry [baseline] (11.968 ms) : 0, 11968
Telemetry [candidate] (12.798 ms) : 0, 12798
section appsec
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (752.969 ms) : 0, 752969
BytebuddyAgent [candidate] (754.721 ms) : 0, 754721
GlobalTracer [baseline] (234.026 ms) : 0, 234026
GlobalTracer [candidate] (234.163 ms) : 0, 234163
IAST [baseline] (23.554 ms) : 0, 23554
IAST [candidate] (23.4 ms) : 0, 23400
AppSec [baseline] (168.848 ms) : 0, 168848
AppSec [candidate] (169.796 ms) : 0, 169796
Debugger [baseline] (5.748 ms) : 0, 5748
Debugger [candidate] (6.435 ms) : 0, 6435
Remote Config [baseline] (622.833 µs) : 0, 623
Remote Config [candidate] (609.102 µs) : 0, 609
Telemetry [baseline] (10.572 ms) : 0, 10572
Telemetry [candidate] (8.351 ms) : 0, 8351
section iast
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (849.808 ms) : 0, 849808
BytebuddyAgent [candidate] (851.31 ms) : 0, 851310
GlobalTracer [baseline] (232.184 ms) : 0, 232184
GlobalTracer [candidate] (233.307 ms) : 0, 233307
IAST [baseline] (26.747 ms) : 0, 26747
IAST [candidate] (29.138 ms) : 0, 29138
AppSec [baseline] (28.393 ms) : 0, 28393
AppSec [candidate] (26.091 ms) : 0, 26091
Debugger [baseline] (8.326 ms) : 0, 8326
Debugger [candidate] (8.382 ms) : 0, 8382
Remote Config [baseline] (568.522 µs) : 0, 569
Remote Config [candidate] (579.842 µs) : 0, 580
Telemetry [baseline] (8.301 ms) : 0, 8301
Telemetry [candidate] (8.415 ms) : 0, 8415
section profiling
crashtracking [baseline] (1.389 ms) : 0, 1389
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (759.609 ms) : 0, 759609
BytebuddyAgent [candidate] (771.038 ms) : 0, 771038
GlobalTracer [baseline] (221.515 ms) : 0, 221515
GlobalTracer [candidate] (223.826 ms) : 0, 223826
AppSec [baseline] (29.901 ms) : 0, 29901
AppSec [candidate] (30.413 ms) : 0, 30413
Debugger [baseline] (6.266 ms) : 0, 6266
Debugger [candidate] (6.457 ms) : 0, 6457
Remote Config [baseline] (695.363 µs) : 0, 695
Remote Config [candidate] (679.272 µs) : 0, 679
Telemetry [baseline] (15.902 ms) : 0, 15902
Telemetry [candidate] (16.183 ms) : 0, 16183
ProfilingAgent [baseline] (107.201 ms) : 0, 107201
ProfilingAgent [candidate] (108.73 ms) : 0, 108730
Profiling [baseline] (107.823 ms) : 0, 107823
Profiling [candidate] (109.398 ms) : 0, 109398
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048512
Total [baseline] (8.571 s) : 0, 8570787
Agent [candidate] (1.057 s) : 0, 1056735
Total [candidate] (8.591 s) : 0, 8590593
section iast
Agent [baseline] (1.179 s) : 0, 1179426
Total [baseline] (9.324 s) : 0, 9324056
Agent [candidate] (1.175 s) : 0, 1175271
Total [candidate] (9.291 s) : 0, 9290890
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (734.589 ms) : 0, 734589
BytebuddyAgent [candidate] (741.221 ms) : 0, 741221
GlobalTracer [baseline] (242.401 ms) : 0, 242401
GlobalTracer [candidate] (244.264 ms) : 0, 244264
AppSec [baseline] (30.37 ms) : 0, 30370
AppSec [candidate] (30.343 ms) : 0, 30343
Debugger [baseline] (6.045 ms) : 0, 6045
Debugger [candidate] (6.075 ms) : 0, 6075
Remote Config [baseline] (657.109 µs) : 0, 657
Remote Config [candidate] (663.034 µs) : 0, 663
Telemetry [baseline] (12.079 ms) : 0, 12079
Telemetry [candidate] (11.553 ms) : 0, 11553
section iast
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (852.119 ms) : 0, 852119
BytebuddyAgent [candidate] (848.645 ms) : 0, 848645
GlobalTracer [baseline] (233.185 ms) : 0, 233185
GlobalTracer [candidate] (232.386 ms) : 0, 232386
AppSec [baseline] (28.428 ms) : 0, 28428
AppSec [candidate] (28.004 ms) : 0, 28004
Debugger [baseline] (6.565 ms) : 0, 6565
Debugger [candidate] (6.612 ms) : 0, 6612
Remote Config [baseline] (589.35 µs) : 0, 589
Remote Config [candidate] (576.755 µs) : 0, 577
Telemetry [baseline] (8.336 ms) : 0, 8336
Telemetry [candidate] (8.348 ms) : 0, 8348
IAST [baseline] (27.716 ms) : 0, 27716
IAST [candidate] (28.371 ms) : 0, 28371
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
dateFormat X
axisFormat %s
section baseline
no_agent (36.792 ms) : 36494, 37089
. : milestone, 36792,
appsec (48.464 ms) : 48046, 48882
. : milestone, 48464,
code_origins (45.502 ms) : 45106, 45899
. : milestone, 45502,
iast (44.943 ms) : 44551, 45335
. : milestone, 44943,
profiling (47.612 ms) : 47185, 48038
. : milestone, 47612,
tracing (44.819 ms) : 44439, 45200
. : milestone, 44819,
section candidate
no_agent (37.287 ms) : 36983, 37590
. : milestone, 37287,
appsec (46.643 ms) : 46226, 47060
. : milestone, 46643,
code_origins (44.03 ms) : 43654, 44406
. : milestone, 44030,
iast (45.875 ms) : 45479, 46270
. : milestone, 45875,
profiling (48.022 ms) : 47566, 48478
. : milestone, 48022,
tracing (43.313 ms) : 42952, 43674
. : milestone, 43313,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
dateFormat X
axisFormat %s
section baseline
no_agent (4.314 ms) : 4257, 4371
. : milestone, 4314,
iast (9.368 ms) : 9215, 9521
. : milestone, 9368,
iast_FULL (14.258 ms) : 13973, 14542
. : milestone, 14258,
iast_GLOBAL (10.089 ms) : 9916, 10261
. : milestone, 10089,
profiling (8.467 ms) : 8338, 8597
. : milestone, 8467,
tracing (7.72 ms) : 7611, 7830
. : milestone, 7720,
section candidate
no_agent (4.257 ms) : 4202, 4312
. : milestone, 4257,
iast (9.539 ms) : 9382, 9696
. : milestone, 9539,
iast_FULL (13.614 ms) : 13346, 13882
. : milestone, 13614,
iast_GLOBAL (9.917 ms) : 9747, 10086
. : milestone, 9917,
profiling (8.98 ms) : 8839, 9121
. : milestone, 8980,
tracing (7.674 ms) : 7565, 7784
. : milestone, 7674,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
dateFormat X
axisFormat %s
section baseline
no_agent (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
appsec (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
iast (18.637 s) : 18637000, 18637000
. : milestone, 18637000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
. : milestone, 17994000,
profiling (15.299 s) : 15299000, 15299000
. : milestone, 15299000,
tracing (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
section candidate
no_agent (15.673 s) : 15673000, 15673000
. : milestone, 15673000,
appsec (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
iast (18.408 s) : 18408000, 18408000
. : milestone, 18408000,
iast_GLOBAL (18.365 s) : 18365000, 18365000
. : milestone, 18365000,
profiling (15.341 s) : 15341000, 15341000
. : milestone, 15341000,
tracing (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~da12ecd8d1, baseline=1.53.0-SNAPSHOT~abb3a3537d
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.647 ms) : 3431, 3863
. : milestone, 3647,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.237 ms) : 2173, 2300
. : milestone, 2237,
profiling (2.492 ms) : 2324, 2660
. : milestone, 2492,
tracing (2.022 ms) : 1972, 2071
. : milestone, 2022,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.659 ms) : 3441, 3877
. : milestone, 3659,
iast (2.193 ms) : 2131, 2256
. : milestone, 2193,
iast_GLOBAL (2.239 ms) : 2175, 2302
. : milestone, 2239,
profiling (2.027 ms) : 1977, 2078
. : milestone, 2027,
tracing (2.021 ms) : 1972, 2070
. : milestone, 2021,
|
@@ -3,6 +3,7 @@ plugins { | |||
} | |||
|
|||
apply from: "$rootDir/gradle/java.gradle" | |||
apply from: "$rootDir/gradle/fix-play-routes.gradle" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding, is the logic moving to a separate file necessary or for organizational / readability purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahchen6 I moved to separate file because I'm already using it 2 times and there is a chance that in future I will need it for all play-xxx
modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 suggestion: I would recommend to move it to a dd-smoke-tests/play-common
then.
It will be easier to find (same logic as the instrumentations) and won't mix with the overall project build scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
@@ -3,6 +3,7 @@ plugins { | |||
} | |||
|
|||
apply from: "$rootDir/gradle/java.gradle" | |||
apply from: "$rootDir/gradle/fix-play-routes.gradle" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 suggestion: I would recommend to move it to a dd-smoke-tests/play-common
then.
It will be easier to find (same logic as the instrumentations) and won't mix with the overall project build scripts.
What Does This Do
Another attempt to fix the issue.
Motivation
Green CI.
Additional Notes
Task that actually failed is
:dd-smoke-tests:play-2.8:processResources
. In #9328 was implemented a fix, but it failed again. Trying to tweak it a bit.Now with this PR I can see in build logs:
Hope this should fix this issue.