Migrate instrumentations to Context API #9358

PerfectSlayer · 2025-08-13T07:39:31Z

What Does This Do

Migrate HttpServerDecorator.onRequest() to the Context API.

In particular, get rid of the duplicate version using AgentSpan.Extracted instead.
This lead to overridden decorators no longer being called when moved to the Context based version -- unclear how tests did not catch it.

Motivation

Move instrumentation API to the Context API to decouple products and move toward better performance.

Additional Notes

Follow up PR of #9211

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: LANGPLAT-680

datadog-official · 2025-08-13T08:12:28Z

Code coverage: total 57.30%, base diff -0.03%, patch 80.77% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c23bbe5 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-13T08:23:28Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755127609	1755162669
git_commit_sha	`0f3ab90`	`c23bbe5`
release_version	1.53.0-SNAPSHOT~0f3ab90a6f	1.53.0-SNAPSHOT~c23bbe5d77

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755164377	1755164377
ci_job_id	1080029087	1080029087
ci_pipeline_id	73655446	73655446
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-bvxkl3q6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-bvxkl3q6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~c23bbe5d77, baseline=1.53.0-SNAPSHOT~0f3ab90a6f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049903
Total [baseline] (10.756 s) : 0, 10756239
Agent [candidate] (1.046 s) : 0, 1046499
Total [candidate] (10.711 s) : 0, 10710541
section appsec
Agent [baseline] (1.218 s) : 0, 1218158
Total [baseline] (10.77 s) : 0, 10770384
Agent [candidate] (1.222 s) : 0, 1222461
Total [candidate] (10.786 s) : 0, 10786219
section iast
Agent [baseline] (1.178 s) : 0, 1178020
Total [baseline] (10.939 s) : 0, 10939452
Agent [candidate] (1.178 s) : 0, 1178003
Total [candidate] (10.979 s) : 0, 10979374
section profiling
Agent [baseline] (1.194 s) : 0, 1193839
Total [baseline] (10.935 s) : 0, 10934689
Agent [candidate] (1.197 s) : 0, 1197205
Total [candidate] (10.903 s) : 0, 10903494

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	appsec	1.218 s	168.255 ms (16.0%)
Agent	iast	1.178 s	128.117 ms (12.2%)
Agent	profiling	1.194 s	143.936 ms (13.7%)
Total	tracing	10.756 s	-
Total	appsec	10.77 s	14.145 ms (0.1%)
Total	iast	10.939 s	183.214 ms (1.7%)
Total	profiling	10.935 s	178.45 ms (1.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.222 s	175.962 ms (16.8%)
Agent	iast	1.178 s	131.504 ms (12.6%)
Agent	profiling	1.197 s	150.705 ms (14.4%)
Total	tracing	10.711 s	-
Total	appsec	10.786 s	75.678 ms (0.7%)
Total	iast	10.979 s	268.833 ms (2.5%)
Total	profiling	10.903 s	192.953 ms (1.8%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~c23bbe5d77, baseline=1.53.0-SNAPSHOT~0f3ab90a6f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (736.216 ms) : 0, 736216
BytebuddyAgent [candidate] (732.651 ms) : 0, 732651
GlobalTracer [baseline] (243.546 ms) : 0, 243546
GlobalTracer [candidate] (242.051 ms) : 0, 242051
AppSec [baseline] (30.244 ms) : 0, 30244
AppSec [candidate] (30.044 ms) : 0, 30044
Debugger [baseline] (6.041 ms) : 0, 6041
Debugger [candidate] (6.019 ms) : 0, 6019
Remote Config [baseline] (650.77 µs) : 0, 651
Remote Config [candidate] (647.468 µs) : 0, 647
Telemetry [baseline] (10.639 ms) : 0, 10639
Telemetry [candidate] (12.577 ms) : 0, 12577
section appsec
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (751.852 ms) : 0, 751852
BytebuddyAgent [candidate] (755.527 ms) : 0, 755527
GlobalTracer [baseline] (234.816 ms) : 0, 234816
GlobalTracer [candidate] (235.51 ms) : 0, 235510
IAST [baseline] (23.471 ms) : 0, 23471
IAST [candidate] (23.338 ms) : 0, 23338
AppSec [baseline] (168.647 ms) : 0, 168647
AppSec [candidate] (169.358 ms) : 0, 169358
Debugger [baseline] (7.147 ms) : 0, 7147
Debugger [candidate] (7.213 ms) : 0, 7213
Remote Config [baseline] (610.861 µs) : 0, 611
Remote Config [candidate] (626.765 µs) : 0, 627
Telemetry [baseline] (9.105 ms) : 0, 9105
Telemetry [candidate] (8.412 ms) : 0, 8412
section iast
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (849.956 ms) : 0, 849956
BytebuddyAgent [candidate] (850.53 ms) : 0, 850530
GlobalTracer [baseline] (233.004 ms) : 0, 233004
GlobalTracer [candidate] (232.974 ms) : 0, 232974
IAST [baseline] (26.727 ms) : 0, 26727
IAST [candidate] (31.353 ms) : 0, 31353
AppSec [baseline] (26.947 ms) : 0, 26947
AppSec [candidate] (25.998 ms) : 0, 25998
Debugger [baseline] (9.178 ms) : 0, 9178
Debugger [candidate] (5.781 ms) : 0, 5781
Remote Config [baseline] (584.035 µs) : 0, 584
Remote Config [candidate] (576.935 µs) : 0, 577
Telemetry [baseline] (9.12 ms) : 0, 9120
Telemetry [candidate] (8.334 ms) : 0, 8334
section profiling
crashtracking [baseline] (1.399 ms) : 0, 1399
crashtracking [candidate] (1.401 ms) : 0, 1401
BytebuddyAgent [baseline] (759.888 ms) : 0, 759888
BytebuddyAgent [candidate] (763.724 ms) : 0, 763724
GlobalTracer [baseline] (221.381 ms) : 0, 221381
GlobalTracer [candidate] (221.54 ms) : 0, 221540
AppSec [baseline] (29.903 ms) : 0, 29903
AppSec [candidate] (29.838 ms) : 0, 29838
Debugger [baseline] (6.244 ms) : 0, 6244
Debugger [candidate] (6.3 ms) : 0, 6300
Remote Config [baseline] (718.774 µs) : 0, 719
Remote Config [candidate] (706.393 µs) : 0, 706
Telemetry [baseline] (15.951 ms) : 0, 15951
Telemetry [candidate] (16.081 ms) : 0, 16081
ProfilingAgent [baseline] (108.819 ms) : 0, 108819
ProfilingAgent [candidate] (107.763 ms) : 0, 107763
Profiling [baseline] (109.458 ms) : 0, 109458
Profiling [candidate] (108.39 ms) : 0, 108390

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~c23bbe5d77, baseline=1.53.0-SNAPSHOT~0f3ab90a6f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044497
Total [baseline] (8.623 s) : 0, 8623095
Agent [candidate] (1.046 s) : 0, 1045565
Total [candidate] (8.63 s) : 0, 8629858
section iast
Agent [baseline] (1.184 s) : 0, 1184427
Total [baseline] (9.361 s) : 0, 9360799
Agent [candidate] (1.185 s) : 0, 1185290
Total [candidate] (9.387 s) : 0, 9386766

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.184 s	139.931 ms (13.4%)
Total	tracing	8.623 s	-
Total	iast	9.361 s	737.704 ms (8.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	iast	1.185 s	139.725 ms (13.4%)
Total	tracing	8.63 s	-
Total	iast	9.387 s	756.908 ms (8.8%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~c23bbe5d77, baseline=1.53.0-SNAPSHOT~0f3ab90a6f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (730.827 ms) : 0, 730827
BytebuddyAgent [candidate] (732.217 ms) : 0, 732217
GlobalTracer [baseline] (241.799 ms) : 0, 241799
GlobalTracer [candidate] (242.757 ms) : 0, 242757
AppSec [baseline] (29.99 ms) : 0, 29990
AppSec [candidate] (30.155 ms) : 0, 30155
Debugger [baseline] (6.033 ms) : 0, 6033
Debugger [candidate] (6.026 ms) : 0, 6026
Remote Config [baseline] (655.516 µs) : 0, 656
Remote Config [candidate] (654.336 µs) : 0, 654
Telemetry [baseline] (12.864 ms) : 0, 12864
Telemetry [candidate] (11.356 ms) : 0, 11356
section iast
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (856.073 ms) : 0, 856073
BytebuddyAgent [candidate] (855.569 ms) : 0, 855569
GlobalTracer [baseline] (234.755 ms) : 0, 234755
GlobalTracer [candidate] (234.57 ms) : 0, 234570
AppSec [baseline] (28.188 ms) : 0, 28188
AppSec [candidate] (29.38 ms) : 0, 29380
Debugger [baseline] (5.697 ms) : 0, 5697
Debugger [candidate] (6.537 ms) : 0, 6537
Remote Config [baseline] (564.205 µs) : 0, 564
Remote Config [candidate] (578.88 µs) : 0, 579
Telemetry [baseline] (8.249 ms) : 0, 8249
Telemetry [candidate] (9.104 ms) : 0, 9104
IAST [baseline] (28.408 ms) : 0, 28408
IAST [candidate] (27.046 ms) : 0, 27046

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755127609	1755162669
git_commit_sha	`0f3ab90`	`c23bbe5`
release_version	1.53.0-SNAPSHOT~0f3ab90a6f	1.53.0-SNAPSHOT~c23bbe5d77

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755164125	1755164125
ci_job_id	1080029088	1080029088
ci_pipeline_id	73655446	73655446
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-fk8jqrr9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-fk8jqrr9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	better [-750.593µs; -461.340µs] or [-8.314%; -5.110%]	unstable [-23.882op/s; +119.195op/s] or [-4.749%; +23.700%]	8.422ms	550.594op/s	9.028ms	502.938op/s
scenario:load:petclinic:no_agent:high_load	better [-1.823ms; -1.202ms] or [-4.931%; -3.251%]	unstable [-3.458op/s; +14.233op/s] or [-2.734%; +11.253%]	35.454ms	131.875op/s	36.966ms	126.487op/s
scenario:load:petclinic:appsec:high_load	worse [+1.022ms; +1.959ms] or [+2.158%; +4.136%]	unstable [-10.353op/s; +4.278op/s] or [-10.473%; +4.328%]	48.861ms	95.812op/s	47.370ms	98.850op/s
scenario:load:petclinic:profiling:high_load	worse [+1.429ms; +2.445ms] or [+2.903%; +4.966%]	unstable [-10.402op/s; +3.227op/s] or [-10.943%; +3.395%]	51.177ms	91.475op/s	49.239ms	95.062op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~c23bbe5d77, baseline=1.53.0-SNAPSHOT~0f3ab90a6f
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.181 ms) : 4132, 4229
.   : milestone, 4181,
iast (9.323 ms) : 9168, 9478
.   : milestone, 9323,
iast_FULL (13.885 ms) : 13614, 14156
.   : milestone, 13885,
iast_GLOBAL (10.015 ms) : 9838, 10192
.   : milestone, 10015,
profiling (9.028 ms) : 8888, 9167
.   : milestone, 9028,
tracing (7.481 ms) : 7364, 7597
.   : milestone, 7481,
section candidate
no_agent (4.27 ms) : 4224, 4317
.   : milestone, 4270,
iast (9.613 ms) : 9456, 9771
.   : milestone, 9613,
iast_FULL (14.203 ms) : 13919, 14487
.   : milestone, 14203,
iast_GLOBAL (10.264 ms) : 10084, 10445
.   : milestone, 10264,
profiling (8.422 ms) : 8293, 8551
.   : milestone, 8422,
tracing (7.455 ms) : 7350, 7559
.   : milestone, 7455,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.181 ms [4.132 ms, 4.229 ms]	-
iast	9.323 ms [9.168 ms, 9.478 ms]	5.142 ms (123.0%)
iast_FULL	13.885 ms [13.614 ms, 14.156 ms]	9.704 ms (232.1%)
iast_GLOBAL	10.015 ms [9.838 ms, 10.192 ms]	5.834 ms (139.5%)
profiling	9.028 ms [8.888 ms, 9.167 ms]	4.847 ms (115.9%)
tracing	7.481 ms [7.364 ms, 7.597 ms]	3.3 ms (78.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.27 ms [4.224 ms, 4.317 ms]	-
iast	9.613 ms [9.456 ms, 9.771 ms]	5.343 ms (125.1%)
iast_FULL	14.203 ms [13.919 ms, 14.487 ms]	9.932 ms (232.6%)
iast_GLOBAL	10.264 ms [10.084 ms, 10.445 ms]	5.994 ms (140.4%)
profiling	8.422 ms [8.293 ms, 8.551 ms]	4.151 ms (97.2%)
tracing	7.455 ms [7.35 ms, 7.559 ms]	3.184 ms (74.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~c23bbe5d77, baseline=1.53.0-SNAPSHOT~0f3ab90a6f
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.966 ms) : 36674, 37258
.   : milestone, 36966,
appsec (47.37 ms) : 46945, 47795
.   : milestone, 47370,
code_origins (45.487 ms) : 45092, 45883
.   : milestone, 45487,
iast (43.705 ms) : 43333, 44078
.   : milestone, 43705,
profiling (49.239 ms) : 48785, 49694
.   : milestone, 49239,
tracing (43.644 ms) : 43274, 44013
.   : milestone, 43644,
section candidate
no_agent (35.454 ms) : 35168, 35739
.   : milestone, 35454,
appsec (48.861 ms) : 48415, 49307
.   : milestone, 48861,
code_origins (44.578 ms) : 44182, 44973
.   : milestone, 44578,
iast (44.646 ms) : 44250, 45042
.   : milestone, 44646,
profiling (51.177 ms) : 50688, 51665
.   : milestone, 51177,
tracing (43.625 ms) : 43262, 43987
.   : milestone, 43625,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.966 ms [36.674 ms, 37.258 ms]	-
appsec	47.37 ms [46.945 ms, 47.795 ms]	10.404 ms (28.1%)
code_origins	45.487 ms [45.092 ms, 45.883 ms]	8.522 ms (23.1%)
iast	43.705 ms [43.333 ms, 44.078 ms]	6.739 ms (18.2%)
profiling	49.239 ms [48.785 ms, 49.694 ms]	12.273 ms (33.2%)
tracing	43.644 ms [43.274 ms, 44.013 ms]	6.678 ms (18.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.454 ms [35.168 ms, 35.739 ms]	-
appsec	48.861 ms [48.415 ms, 49.307 ms]	13.407 ms (37.8%)
code_origins	44.578 ms [44.182 ms, 44.973 ms]	9.124 ms (25.7%)
iast	44.646 ms [44.25 ms, 45.042 ms]	9.192 ms (25.9%)
profiling	51.177 ms [50.688 ms, 51.665 ms]	15.723 ms (44.3%)
tracing	43.625 ms [43.262 ms, 43.987 ms]	8.171 ms (23.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755127609	1755162669
git_commit_sha	`0f3ab90`	`c23bbe5`
release_version	1.53.0-SNAPSHOT~0f3ab90a6f	1.53.0-SNAPSHOT~c23bbe5d77

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755164524	1755164524
ci_job_id	1080029089	1080029089
ci_pipeline_id	73655446	73655446
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-s0o38dwt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-s0o38dwt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~c23bbe5d77, baseline=1.53.0-SNAPSHOT~0f3ab90a6f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.423 ms) : 2373, 2474
.   : milestone, 2423,
iast (2.218 ms) : 2155, 2281
.   : milestone, 2218,
iast_GLOBAL (2.262 ms) : 2198, 2326
.   : milestone, 2262,
profiling (2.052 ms) : 2001, 2102
.   : milestone, 2052,
tracing (2.028 ms) : 1979, 2078
.   : milestone, 2028,
section candidate
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (3.669 ms) : 3452, 3887
.   : milestone, 3669,
iast (2.209 ms) : 2146, 2272
.   : milestone, 2209,
iast_GLOBAL (2.249 ms) : 2186, 2312
.   : milestone, 2249,
profiling (2.038 ms) : 1988, 2088
.   : milestone, 2038,
tracing (2.026 ms) : 1977, 2075
.   : milestone, 2026,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.465 ms, 1.488 ms]	-
appsec	2.423 ms [2.373 ms, 2.474 ms]	946.794 µs (64.1%)
iast	2.218 ms [2.155 ms, 2.281 ms]	741.566 µs (50.2%)
iast_GLOBAL	2.262 ms [2.198 ms, 2.326 ms]	785.08 µs (53.2%)
profiling	2.052 ms [2.001 ms, 2.102 ms]	574.965 µs (38.9%)
tracing	2.028 ms [1.979 ms, 2.078 ms]	551.742 µs (37.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.467 ms, 1.49 ms]	-
appsec	3.669 ms [3.452 ms, 3.887 ms]	2.191 ms (148.2%)
iast	2.209 ms [2.146 ms, 2.272 ms]	730.79 µs (49.4%)
iast_GLOBAL	2.249 ms [2.186 ms, 2.312 ms]	770.534 µs (52.1%)
profiling	2.038 ms [1.988 ms, 2.088 ms]	559.905 µs (37.9%)
tracing	2.026 ms [1.977 ms, 2.075 ms]	547.669 µs (37.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~c23bbe5d77, baseline=1.53.0-SNAPSHOT~0f3ab90a6f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
appsec (14.81 s) : 14810000, 14810000
.   : milestone, 14810000,
iast (18.535 s) : 18535000, 18535000
.   : milestone, 18535000,
iast_GLOBAL (18.168 s) : 18168000, 18168000
.   : milestone, 18168000,
profiling (15.682 s) : 15682000, 15682000
.   : milestone, 15682000,
tracing (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
section candidate
no_agent (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
appsec (14.861 s) : 14861000, 14861000
.   : milestone, 14861000,
iast (18.423 s) : 18423000, 18423000
.   : milestone, 18423000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
.   : milestone, 17985000,
profiling (15.323 s) : 15323000, 15323000
.   : milestone, 15323000,
tracing (14.827 s) : 14827000, 14827000
.   : milestone, 14827000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.089 s [15.089 s, 15.089 s]	-
appsec	14.81 s [14.81 s, 14.81 s]	-279.0 ms (-1.8%)
iast	18.535 s [18.535 s, 18.535 s]	3.446 s (22.8%)
iast_GLOBAL	18.168 s [18.168 s, 18.168 s]	3.079 s (20.4%)
profiling	15.682 s [15.682 s, 15.682 s]	593.0 ms (3.9%)
tracing	15.023 s [15.023 s, 15.023 s]	-66.0 ms (-0.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.963 s [14.963 s, 14.963 s]	-
appsec	14.861 s [14.861 s, 14.861 s]	-102.0 ms (-0.7%)
iast	18.423 s [18.423 s, 18.423 s]	3.46 s (23.1%)
iast_GLOBAL	17.985 s [17.985 s, 17.985 s]	3.022 s (20.2%)
profiling	15.323 s [15.323 s, 15.323 s]	360.0 ms (2.4%)
tracing	14.827 s [14.827 s, 14.827 s]	-136.0 ms (-0.9%)

smola

I did an overall review, particularly focusing on the AppSec instrumentations, looks good to me.

smola · 2025-08-13T09:08:17Z

...umentation/axway-api/src/main/java/datadog/trace/instrumentation/axway/HTTPPluginAdvice.java

 import net.bytebuddy.asm.Advice;

 public class HTTPPluginAdvice {

  @Advice.OnMethodEnter(suppress = Throwable.class)
  public static AgentScope onEnter(@Advice.Argument(value = 2) final Object serverTransaction) {
-    final AgentSpan span = startSpan(DECORATE.spanName()).setMeasured(true);
+    final AgentSpan span = startSpan("axway-api", DECORATE.spanName()).setMeasured(true);


I didn't verify axway-api is the correct integration name just based on the diff, but worth a double check.

Yes it is:

dd-trace-java/dd-java-agent/instrumentation/axway-api/src/main/java/datadog/trace/instrumentation/axway/AxwayHTTPPluginInstrumentation.java

Line 18 in e8df8a0

super("axway-api");

Not sure why I fixed this call in particular 🤷 Found a warning while reading the code and can't help myself 😅 But it's more to the IDM team to fix it.

sarahchen6 · 2025-08-13T21:23:54Z

...rtx-web-3.4/src/main/java/datadog/trace/instrumentation/vertx_3_4/server/VertxDecorator.java

@@ -58,7 +57,7 @@ public AgentSpan onRequest(
      final AgentSpan span,
      final RoutingContext connection,
      final RoutingContext routingContext,
-      AgentSpanContext.Extracted context) {
+      final datadog.context.Context context) {


so small, but could import Context here as well?

Sure, will fix it

feat(bootstrap): Migrate Spray instrumentation to Context API

dc9d144

PerfectSlayer added the tag: do not merge Do not merge changes label Aug 13, 2025

PerfectSlayer added 2 commits August 13, 2025 09:47

feat(bootstrap): Migrate Tomcat instrumentation to Context API

a5d200d

feat(bootstrap): Migrate Liberty instrumentations to Context API

9994ab4

feat(bootstrap): Migrate instrumentations to Context API

c82297c

PerfectSlayer added type: refactoring comp: context propagation Trace context propagation and removed tag: do not merge Do not merge changes labels Aug 13, 2025

PerfectSlayer marked this pull request as ready for review August 13, 2025 09:00

PerfectSlayer requested review from a team as code owners August 13, 2025 09:00

PerfectSlayer requested a review from smola August 13, 2025 09:00

smola requested review from a team, jandro996, ygree and smola and removed request for smola and a team August 13, 2025 09:00

smola approved these changes Aug 13, 2025

View reviewed changes

PerfectSlayer mentioned this pull request Aug 13, 2025

Improve Instrumenter API to use Context instead of Span #9211

Merged

PerfectSlayer added 2 commits August 13, 2025 12:24

fix(bootstrap): Fix unexpected call to IG callback

a565097

feat(play): Simplify testing

f3a982f

AlexeyKuznetsov-DD approved these changes Aug 13, 2025

View reviewed changes

sarahchen6 reviewed Aug 13, 2025

View reviewed changes

sarahchen6 approved these changes Aug 13, 2025

View reviewed changes

PerfectSlayer mentioned this pull request Aug 14, 2025

[Java] Fix exception replay snapshots DataDog/system-tests#5066

Open

6 tasks

fix(bootstrap): Fix import

9f10e63

chore: Upgrade system tests

c23bbe5

PerfectSlayer requested a review from a team as a code owner August 14, 2025 09:11

PerfectSlayer requested review from bric3 and removed request for a team August 14, 2025 09:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate instrumentations to Context API #9358

Migrate instrumentations to Context API #9358

PerfectSlayer commented Aug 13, 2025 •

edited by jira bot

Loading

Uh oh!

datadog-official bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

smola left a comment

Uh oh!

smola Aug 13, 2025

Uh oh!

PerfectSlayer Aug 13, 2025 •

edited

Loading

Uh oh!

sarahchen6 Aug 13, 2025

Uh oh!

PerfectSlayer Aug 14, 2025

Uh oh!

Uh oh!

Migrate instrumentations to Context API #9358

Are you sure you want to change the base?

Migrate instrumentations to Context API #9358

Conversation

PerfectSlayer commented Aug 13, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

smola left a comment

Choose a reason for hiding this comment

Uh oh!

smola Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sarahchen6 Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PerfectSlayer commented Aug 13, 2025 •

edited by jira bot

Loading

datadog-official bot commented Aug 13, 2025 •

edited

Loading

pr-commenter bot commented Aug 13, 2025 •

edited

Loading

PerfectSlayer Aug 13, 2025 •

edited

Loading