Introduce ConfigOrigin.CALCULATED #9371

mtoffl01 · 2025-08-15T19:04:54Z

What Does This Do

Introduces a new ConfigOrigin enum, "calculated". This origin is used in ConfigProvider.getOrderedMap and ConfigProvider.getMerged* methods.

Motivation

ConfigProvider methods like getOrderedMap and getMergedMap were reporting misleading data to telemetry about configurations that were calculated from multiple sources. This PR changes the behavior such that, if multiple sources are used to calculate a value, the telemetry reports origin "calculated" instead.

This is inspired by "calculated" origins that already exist in dd-trace-dotnet and dd-trace-js.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2025-08-15T19:26:06Z

🎯 Code Coverage
• Patch Coverage: 92.31%
• Total Coverage: 57.33% (-0.02%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 65484b5 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-15T19:38:31Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/configorigin-calculated
git_commit_date	1755621799	1755635661
git_commit_sha	`27cd7f4`	`65484b5`
release_version	1.53.0-SNAPSHOT~27cd7f43d9	1.53.0-SNAPSHOT~65484b52b9

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755637667	1755637667
ci_job_id	1088321216	1088321216
ci_pipeline_id	74178340	74178340
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-si9w3b5e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-si9w3b5e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~65484b52b9, baseline=1.53.0-SNAPSHOT~27cd7f43d9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047630
Total [baseline] (10.714 s) : 0, 10714036
Agent [candidate] (1.051 s) : 0, 1050617
Total [candidate] (10.677 s) : 0, 10676898
section appsec
Agent [baseline] (1.225 s) : 0, 1225308
Total [baseline] (10.807 s) : 0, 10807161
Agent [candidate] (1.229 s) : 0, 1228765
Total [candidate] (10.776 s) : 0, 10775684
section iast
Agent [baseline] (1.196 s) : 0, 1195567
Total [baseline] (11.037 s) : 0, 11036611
Agent [candidate] (1.189 s) : 0, 1188719
Total [candidate] (10.953 s) : 0, 10953134
section profiling
Agent [baseline] (1.2 s) : 0, 1199694
Total [baseline] (10.902 s) : 0, 10902255
Agent [candidate] (1.2 s) : 0, 1200308
Total [candidate] (10.905 s) : 0, 10904526

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	appsec	1.225 s	177.678 ms (17.0%)
Agent	iast	1.196 s	147.937 ms (14.1%)
Agent	profiling	1.2 s	152.064 ms (14.5%)
Total	tracing	10.714 s	-
Total	appsec	10.807 s	93.125 ms (0.9%)
Total	iast	11.037 s	322.576 ms (3.0%)
Total	profiling	10.902 s	188.22 ms (1.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	appsec	1.229 s	178.149 ms (17.0%)
Agent	iast	1.189 s	138.103 ms (13.1%)
Agent	profiling	1.2 s	149.691 ms (14.2%)
Total	tracing	10.677 s	-
Total	appsec	10.776 s	98.786 ms (0.9%)
Total	iast	10.953 s	276.235 ms (2.6%)
Total	profiling	10.905 s	227.627 ms (2.1%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~65484b52b9, baseline=1.53.0-SNAPSHOT~27cd7f43d9

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (732.709 ms) : 0, 732709
BytebuddyAgent [candidate] (734.07 ms) : 0, 734070
GlobalTracer [baseline] (242.632 ms) : 0, 242632
GlobalTracer [candidate] (242.861 ms) : 0, 242861
AppSec [baseline] (30.069 ms) : 0, 30069
AppSec [candidate] (30.152 ms) : 0, 30152
Debugger [baseline] (6.06 ms) : 0, 6060
Debugger [candidate] (6.047 ms) : 0, 6047
Remote Config [baseline] (663.824 µs) : 0, 664
Remote Config [candidate] (657.638 µs) : 0, 658
Telemetry [baseline] (12.995 ms) : 0, 12995
Telemetry [candidate] (14.283 ms) : 0, 14283
section appsec
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (756.984 ms) : 0, 756984
BytebuddyAgent [candidate] (759.258 ms) : 0, 759258
GlobalTracer [baseline] (235.756 ms) : 0, 235756
GlobalTracer [candidate] (237.022 ms) : 0, 237022
AppSec [baseline] (170.492 ms) : 0, 170492
AppSec [candidate] (170.582 ms) : 0, 170582
Debugger [baseline] (5.752 ms) : 0, 5752
Debugger [candidate] (5.689 ms) : 0, 5689
Remote Config [baseline] (646.295 µs) : 0, 646
Remote Config [candidate] (636.076 µs) : 0, 636
Telemetry [baseline] (9.333 ms) : 0, 9333
Telemetry [candidate] (8.409 ms) : 0, 8409
IAST [baseline] (23.736 ms) : 0, 23736
IAST [candidate] (23.707 ms) : 0, 23707
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (862.721 ms) : 0, 862721
BytebuddyAgent [candidate] (858.335 ms) : 0, 858335
GlobalTracer [baseline] (236.181 ms) : 0, 236181
GlobalTracer [candidate] (234.519 ms) : 0, 234519
AppSec [baseline] (25.658 ms) : 0, 25658
AppSec [candidate] (25.974 ms) : 0, 25974
Debugger [baseline] (8.54 ms) : 0, 8540
Debugger [candidate] (8.447 ms) : 0, 8447
Remote Config [baseline] (627.247 µs) : 0, 627
Remote Config [candidate] (611.848 µs) : 0, 612
Telemetry [baseline] (8.422 ms) : 0, 8422
Telemetry [candidate] (8.335 ms) : 0, 8335
IAST [baseline] (30.681 ms) : 0, 30681
IAST [candidate] (29.76 ms) : 0, 29760
section profiling
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.417 ms) : 0, 1417
BytebuddyAgent [baseline] (763.915 ms) : 0, 763915
BytebuddyAgent [candidate] (764.781 ms) : 0, 764781
GlobalTracer [baseline] (222.898 ms) : 0, 222898
GlobalTracer [candidate] (222.622 ms) : 0, 222622
AppSec [baseline] (30.22 ms) : 0, 30220
AppSec [candidate] (30.288 ms) : 0, 30288
Debugger [baseline] (7.064 ms) : 0, 7064
Debugger [candidate] (6.339 ms) : 0, 6339
Remote Config [baseline] (709.4 µs) : 0, 709
Remote Config [candidate] (694.296 µs) : 0, 694
Telemetry [baseline] (15.734 ms) : 0, 15734
Telemetry [candidate] (16.128 ms) : 0, 16128
ProfilingAgent [baseline] (108.071 ms) : 0, 108071
ProfilingAgent [candidate] (108.193 ms) : 0, 108193
Profiling [baseline] (108.724 ms) : 0, 108724
Profiling [candidate] (108.849 ms) : 0, 108849

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~65484b52b9, baseline=1.53.0-SNAPSHOT~27cd7f43d9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047697
Total [baseline] (8.654 s) : 0, 8653693
Agent [candidate] (1.05 s) : 0, 1050234
Total [candidate] (8.61 s) : 0, 8609903
section iast
Agent [baseline] (1.19 s) : 0, 1190473
Total [baseline] (9.32 s) : 0, 9319798
Agent [candidate] (1.189 s) : 0, 1188663
Total [candidate] (9.358 s) : 0, 9357605

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.19 s	142.776 ms (13.6%)
Total	tracing	8.654 s	-
Total	iast	9.32 s	666.105 ms (7.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.189 s	138.429 ms (13.2%)
Total	tracing	8.61 s	-
Total	iast	9.358 s	747.702 ms (8.7%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~65484b52b9, baseline=1.53.0-SNAPSHOT~27cd7f43d9

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (732.623 ms) : 0, 732623
BytebuddyAgent [candidate] (734.234 ms) : 0, 734234
GlobalTracer [baseline] (241.826 ms) : 0, 241826
GlobalTracer [candidate] (242.869 ms) : 0, 242869
AppSec [baseline] (30.123 ms) : 0, 30123
AppSec [candidate] (30.342 ms) : 0, 30342
Debugger [baseline] (6.015 ms) : 0, 6015
Debugger [candidate] (6.06 ms) : 0, 6060
Remote Config [baseline] (668.866 µs) : 0, 669
Remote Config [candidate] (672.527 µs) : 0, 673
Telemetry [baseline] (14.016 ms) : 0, 14016
Telemetry [candidate] (13.642 ms) : 0, 13642
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (859.984 ms) : 0, 859984
BytebuddyAgent [candidate] (858.525 ms) : 0, 858525
GlobalTracer [baseline] (234.5 ms) : 0, 234500
GlobalTracer [candidate] (234.237 ms) : 0, 234237
AppSec [baseline] (28.01 ms) : 0, 28010
AppSec [candidate] (27.773 ms) : 0, 27773
Debugger [baseline] (8.301 ms) : 0, 8301
Debugger [candidate] (7.677 ms) : 0, 7677
Remote Config [baseline] (601.048 µs) : 0, 601
Remote Config [candidate] (615.323 µs) : 0, 615
Telemetry [baseline] (8.405 ms) : 0, 8405
Telemetry [candidate] (8.501 ms) : 0, 8501
IAST [baseline] (28.054 ms) : 0, 28054
IAST [candidate] (28.823 ms) : 0, 28823

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/configorigin-calculated
git_commit_date	1755621799	1755635661
git_commit_sha	`27cd7f4`	`65484b5`
release_version	1.53.0-SNAPSHOT~27cd7f43d9	1.53.0-SNAPSHOT~65484b52b9

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755637335	1755637335
ci_job_id	1088321218	1088321218
ci_pipeline_id	74178340	74178340
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-fd2m2566 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-fd2m2566 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	worse [+159.053µs; +386.125µs] or [+2.140%; +5.196%]	unstable [-92.587op/s; +49.087op/s] or [-14.864%; +7.881%]	7.704ms	601.125op/s	7.431ms	622.875op/s
scenario:load:insecure-bank:profiling:high_load	worse [+265.650µs; +560.059µs] or [+3.094%; +6.523%]	unstable [-90.409op/s; +41.471op/s] or [-16.739%; +7.679%]	8.999ms	515.625op/s	8.586ms	540.094op/s
scenario:load:petclinic:tracing:high_load	better [-2.642ms; -1.813ms] or [-5.798%; -3.978%]	unstable [-2.068op/s; +12.568op/s] or [-2.014%; +12.242%]	43.347ms	107.912op/s	45.574ms	102.662op/s
scenario:load:petclinic:profiling:high_load	worse [+1.884ms; +2.914ms] or [+3.828%; +5.920%]	unstable [-11.018op/s; +2.218op/s] or [-11.588%; +2.333%]	51.618ms	90.688op/s	49.219ms	95.088op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~65484b52b9, baseline=1.53.0-SNAPSHOT~27cd7f43d9
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.762 ms) : 36466, 37059
.   : milestone, 36762,
appsec (47.203 ms) : 46772, 47633
.   : milestone, 47203,
code_origins (44.782 ms) : 44388, 45176
.   : milestone, 44782,
iast (44.291 ms) : 43905, 44676
.   : milestone, 44291,
profiling (49.219 ms) : 48724, 49714
.   : milestone, 49219,
tracing (45.574 ms) : 45182, 45967
.   : milestone, 45574,
section candidate
no_agent (36.116 ms) : 35826, 36407
.   : milestone, 36116,
appsec (47.792 ms) : 47360, 48225
.   : milestone, 47792,
code_origins (45.312 ms) : 44930, 45694
.   : milestone, 45312,
iast (44.675 ms) : 44281, 45069
.   : milestone, 44675,
profiling (51.618 ms) : 51156, 52080
.   : milestone, 51618,
tracing (43.347 ms) : 42969, 43725
.   : milestone, 43347,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.762 ms [36.466 ms, 37.059 ms]	-
appsec	47.203 ms [46.772 ms, 47.633 ms]	10.44 ms (28.4%)
code_origins	44.782 ms [44.388 ms, 45.176 ms]	8.02 ms (21.8%)
iast	44.291 ms [43.905 ms, 44.676 ms]	7.528 ms (20.5%)
profiling	49.219 ms [48.724 ms, 49.714 ms]	12.457 ms (33.9%)
tracing	45.574 ms [45.182 ms, 45.967 ms]	8.812 ms (24.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.116 ms [35.826 ms, 36.407 ms]	-
appsec	47.792 ms [47.36 ms, 48.225 ms]	11.676 ms (32.3%)
code_origins	45.312 ms [44.93 ms, 45.694 ms]	9.196 ms (25.5%)
iast	44.675 ms [44.281 ms, 45.069 ms]	8.559 ms (23.7%)
profiling	51.618 ms [51.156 ms, 52.08 ms]	15.502 ms (42.9%)
tracing	43.347 ms [42.969 ms, 43.725 ms]	7.23 ms (20.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~65484b52b9, baseline=1.53.0-SNAPSHOT~27cd7f43d9
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.361 ms) : 4312, 4410
.   : milestone, 4361,
iast (9.308 ms) : 9149, 9468
.   : milestone, 9308,
iast_FULL (14.385 ms) : 14098, 14672
.   : milestone, 14385,
iast_GLOBAL (10.104 ms) : 9929, 10278
.   : milestone, 10104,
profiling (8.586 ms) : 8454, 8719
.   : milestone, 8586,
tracing (7.431 ms) : 7328, 7535
.   : milestone, 7431,
section candidate
no_agent (4.425 ms) : 4373, 4476
.   : milestone, 4425,
iast (9.239 ms) : 9081, 9398
.   : milestone, 9239,
iast_FULL (14.15 ms) : 13868, 14432
.   : milestone, 14150,
iast_GLOBAL (10.303 ms) : 10122, 10483
.   : milestone, 10303,
profiling (8.999 ms) : 8858, 9140
.   : milestone, 8999,
tracing (7.704 ms) : 7597, 7811
.   : milestone, 7704,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.361 ms [4.312 ms, 4.41 ms]	-
iast	9.308 ms [9.149 ms, 9.468 ms]	4.947 ms (113.4%)
iast_FULL	14.385 ms [14.098 ms, 14.672 ms]	10.024 ms (229.9%)
iast_GLOBAL	10.104 ms [9.929 ms, 10.278 ms]	5.743 ms (131.7%)
profiling	8.586 ms [8.454 ms, 8.719 ms]	4.225 ms (96.9%)
tracing	7.431 ms [7.328 ms, 7.535 ms]	3.07 ms (70.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.425 ms [4.373 ms, 4.476 ms]	-
iast	9.239 ms [9.081 ms, 9.398 ms]	4.814 ms (108.8%)
iast_FULL	14.15 ms [13.868 ms, 14.432 ms]	9.725 ms (219.8%)
iast_GLOBAL	10.303 ms [10.122 ms, 10.483 ms]	5.878 ms (132.8%)
profiling	8.999 ms [8.858 ms, 9.14 ms]	4.574 ms (103.4%)
tracing	7.704 ms [7.597 ms, 7.811 ms]	3.279 ms (74.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/configorigin-calculated
git_commit_date	1755621799	1755635661
git_commit_sha	`27cd7f4`	`65484b5`
release_version	1.53.0-SNAPSHOT~27cd7f43d9	1.53.0-SNAPSHOT~65484b52b9

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755637859	1755637859
ci_job_id	1088321219	1088321219
ci_pipeline_id	74178340	74178340
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-76j88ner 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-76j88ner 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~65484b52b9, baseline=1.53.0-SNAPSHOT~27cd7f43d9
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
appsec (14.972 s) : 14972000, 14972000
.   : milestone, 14972000,
iast (18.345 s) : 18345000, 18345000
.   : milestone, 18345000,
iast_GLOBAL (18.0 s) : 18000000, 18000000
.   : milestone, 18000000,
profiling (15.256 s) : 15256000, 15256000
.   : milestone, 15256000,
tracing (14.934 s) : 14934000, 14934000
.   : milestone, 14934000,
section candidate
no_agent (15.591 s) : 15591000, 15591000
.   : milestone, 15591000,
appsec (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
iast (18.399 s) : 18399000, 18399000
.   : milestone, 18399000,
iast_GLOBAL (18.08 s) : 18080000, 18080000
.   : milestone, 18080000,
profiling (15.402 s) : 15402000, 15402000
.   : milestone, 15402000,
tracing (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.991 s [14.991 s, 14.991 s]	-
appsec	14.972 s [14.972 s, 14.972 s]	-19.0 ms (-0.1%)
iast	18.345 s [18.345 s, 18.345 s]	3.354 s (22.4%)
iast_GLOBAL	18.0 s [18.0 s, 18.0 s]	3.009 s (20.1%)
profiling	15.256 s [15.256 s, 15.256 s]	265.0 ms (1.8%)
tracing	14.934 s [14.934 s, 14.934 s]	-57.0 ms (-0.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.591 s [15.591 s, 15.591 s]	-
appsec	15.138 s [15.138 s, 15.138 s]	-453.0 ms (-2.9%)
iast	18.399 s [18.399 s, 18.399 s]	2.808 s (18.0%)
iast_GLOBAL	18.08 s [18.08 s, 18.08 s]	2.489 s (16.0%)
profiling	15.402 s [15.402 s, 15.402 s]	-189.0 ms (-1.2%)
tracing	14.922 s [14.922 s, 14.922 s]	-669.0 ms (-4.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~65484b52b9, baseline=1.53.0-SNAPSHOT~27cd7f43d9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (3.633 ms) : 3418, 3849
.   : milestone, 3633,
iast (2.189 ms) : 2126, 2252
.   : milestone, 2189,
iast_GLOBAL (2.23 ms) : 2167, 2293
.   : milestone, 2230,
profiling (2.045 ms) : 1994, 2095
.   : milestone, 2045,
tracing (2.016 ms) : 1967, 2065
.   : milestone, 2016,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (3.633 ms) : 3418, 3848
.   : milestone, 3633,
iast (2.196 ms) : 2133, 2259
.   : milestone, 2196,
iast_GLOBAL (2.236 ms) : 2172, 2299
.   : milestone, 2236,
profiling (2.056 ms) : 2004, 2107
.   : milestone, 2056,
tracing (2.003 ms) : 1954, 2051
.   : milestone, 2003,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	3.633 ms [3.418 ms, 3.849 ms]	2.16 ms (146.6%)
iast	2.189 ms [2.126 ms, 2.252 ms]	715.365 µs (48.5%)
iast_GLOBAL	2.23 ms [2.167 ms, 2.293 ms]	756.795 µs (51.4%)
profiling	2.045 ms [1.994 ms, 2.095 ms]	571.039 µs (38.8%)
tracing	2.016 ms [1.967 ms, 2.065 ms]	542.143 µs (36.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	3.633 ms [3.418 ms, 3.848 ms]	2.162 ms (146.9%)
iast	2.196 ms [2.133 ms, 2.259 ms]	724.238 µs (49.2%)
iast_GLOBAL	2.236 ms [2.172 ms, 2.299 ms]	763.97 µs (51.9%)
profiling	2.056 ms [2.004 ms, 2.107 ms]	583.943 µs (39.7%)
tracing	2.003 ms [1.954 ms, 2.051 ms]	531.116 µs (36.1%)

mcculls · 2025-08-19T19:32:43Z

internal-api/src/main/java/datadog/trace/api/ConfigOrigin.java

-  DEFAULT("default");
+  DEFAULT("default"),
+  /** set when the config is calculated from other configs */
+  CALCULATED("calculated");


nitpick: I would put this new entry before DEFAULT (i.e. keep DEFAULT as the last entry)

mcculls · 2025-08-19T19:43:30Z

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/ConfigProvider.java

+          // If we have already found a non-default origin, the value is calculated from multiple
+          // sources.


this might keep the comment on one line...

Suggested change

// If we have already found a non-default origin, the value is calculated from multiple

// sources.

// if we already have a non-default origin, the value is calculated from multiple sources

(I'll avoid adding multiple comments, but the same applies to other occurrences below)

mcculls

nice improvement!

github-actions · 2025-08-19T20:44:27Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

mtoffl01 added 2 commits August 15, 2025 15:04

Use origin CALCULATED for merged methods

ba01e5b

fix javadoc for ConfigOrigin.CALCULATED

f35d25e

mcculls reviewed Aug 19, 2025

View reviewed changes

mcculls approved these changes Aug 19, 2025

View reviewed changes

apply github suggestions

65484b5

mtoffl01 marked this pull request as ready for review August 19, 2025 20:44

mtoffl01 requested review from a team as code owners August 19, 2025 20:44

mtoffl01 requested a review from ygree August 19, 2025 20:44

mtoffl01 enabled auto-merge (squash) August 19, 2025 20:44

mcculls added type: enhancement Enhancements and improvements comp: core Tracer core comp: telemetry Telemetry tag: no release notes Changes to exclude from release notes and removed comp: core Tracer core labels Aug 20, 2025

mtoffl01 merged commit f98f7dd into master Aug 20, 2025
667 of 670 checks passed

mtoffl01 deleted the mtoff/configorigin-calculated branch August 20, 2025 15:25

github-actions bot added this to the 1.53.0 milestone Aug 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Introduce ConfigOrigin.CALCULATED #9371

Introduce ConfigOrigin.CALCULATED #9371

Uh oh!

mtoffl01 commented Aug 15, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 15, 2025 •

edited by datadog-official bot

Loading

Uh oh!

pr-commenter bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

mcculls Aug 19, 2025

Uh oh!

mcculls Aug 19, 2025 •

edited

Loading

Uh oh!

mcculls left a comment

Uh oh!

github-actions bot commented Aug 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// If we have already found a non-default origin, the value is calculated from multiple
		// sources.

	// If we have already found a non-default origin, the value is calculated from multiple
	// sources.
	// if we already have a non-default origin, the value is calculated from multiple sources

Introduce ConfigOrigin.CALCULATED #9371

Introduce ConfigOrigin.CALCULATED #9371

Uh oh!

Conversation

mtoffl01 commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 15, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

mcculls Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

mcculls Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mtoffl01 commented Aug 15, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Aug 15, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Aug 15, 2025 •

edited

Loading

mcculls Aug 19, 2025 •

edited

Loading