Skip to content

Migrate instrumentations to Context API #9378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 19, 2025
Merged

Migrate instrumentations to Context API #9378

merged 4 commits into from
Aug 19, 2025

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Aug 18, 2025 •
edited
Loading

What Does This Do

This PR keeps migrating instrumentations to the Context API

Motivation

Decoupling DSM from Tracing.
This PR will focus on instrumentation that tightly coupled DSM and Tracing to introduce Context tracking instead.

Additional Notes

This PR also rework DSM coding style (enum values in upper-case).
The introduced TODO is a marker for following work with the DSM team.

This is a follow up PR of:

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer requested review from a team as code owners August 18, 2025 12:36
@PerfectSlayer PerfectSlayer added the comp: context propagation Trace context propagation label Aug 18, 2025
@PerfectSlayer PerfectSlayer marked this pull request as draft August 18, 2025 12:36
@PerfectSlayer
Copy link
Contributor Author

Converting as draft as there is another AWS instrumentation to convert for this PR. Review still welcomed about the actual content.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Aug 18, 2025 •
edited
Loading

Code coverage: total 57.33%, base diff -0.02%, patch 66.67% (view details)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d73f349 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Aug 18, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context
git_commit_date 1755523005 1755586841
git_commit_sha e125ff7 d73f349
release_version 1.53.0-SNAPSHOT~e125ff7b82 1.53.0-SNAPSHOT~d73f349ab9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1755588831 1755588831
ci_job_id 1086281414 1086281414
ci_pipeline_id 74076535 74076535
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-pm1devly 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-pm1devly 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~d73f349ab9, baseline=1.53.0-SNAPSHOT~e125ff7b82

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047223
Total [baseline] (8.631 s) : 0, 8631179
Agent [candidate] (1.057 s) : 0, 1057130
Total [candidate] (8.576 s) : 0, 8576220
section iast
Agent [baseline] (1.181 s) : 0, 1181428
Total [baseline] (9.294 s) : 0, 9294469
Agent [candidate] (1.188 s) : 0, 1188479
Total [candidate] (9.292 s) : 0, 9291985
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.181 s 134.205 ms (12.8%)
Total tracing 8.631 s -
Total iast 9.294 s 663.29 ms (7.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.188 s 131.349 ms (12.4%)
Total tracing 8.576 s -
Total iast 9.292 s 715.766 ms (8.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~d73f349ab9, baseline=1.53.0-SNAPSHOT~e125ff7b82

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (734.258 ms) : 0, 734258
BytebuddyAgent [candidate] (738.662 ms) : 0, 738662
GlobalTracer [baseline] (242.257 ms) : 0, 242257
GlobalTracer [candidate] (244.04 ms) : 0, 244040
AppSec [baseline] (30.082 ms) : 0, 30082
AppSec [candidate] (30.457 ms) : 0, 30457
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (6.093 ms) : 0, 6093
Remote Config [baseline] (669.336 µs) : 0, 669
Remote Config [candidate] (676.705 µs) : 0, 677
Telemetry [baseline] (11.481 ms) : 0, 11481
Telemetry [candidate] (14.62 ms) : 0, 14620
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (852.18 ms) : 0, 852180
BytebuddyAgent [candidate] (858.366 ms) : 0, 858366
GlobalTracer [baseline] (233.574 ms) : 0, 233574
GlobalTracer [candidate] (234.124 ms) : 0, 234124
IAST [baseline] (27.721 ms) : 0, 27721
IAST [candidate] (31.692 ms) : 0, 31692
AppSec [baseline] (29.535 ms) : 0, 29535
AppSec [candidate] (26.895 ms) : 0, 26895
Debugger [baseline] (6.785 ms) : 0, 6785
Debugger [candidate] (5.793 ms) : 0, 5793
Remote Config [baseline] (626.456 µs) : 0, 626
Remote Config [candidate] (614.048 µs) : 0, 614
Telemetry [baseline] (8.453 ms) : 0, 8453
Telemetry [candidate] (8.427 ms) : 0, 8427
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~d73f349ab9, baseline=1.53.0-SNAPSHOT~e125ff7b82

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055493
Total [baseline] (10.778 s) : 0, 10777893
Agent [candidate] (1.063 s) : 0, 1062720
Total [candidate] (10.774 s) : 0, 10773881
section appsec
Agent [baseline] (1.232 s) : 0, 1232248
Total [baseline] (10.822 s) : 0, 10821680
Agent [candidate] (1.227 s) : 0, 1226690
Total [candidate] (10.809 s) : 0, 10808636
section iast
Agent [baseline] (1.179 s) : 0, 1178864
Total [baseline] (10.952 s) : 0, 10951708
Agent [candidate] (1.18 s) : 0, 1180155
Total [candidate] (10.975 s) : 0, 10974713
section profiling
Agent [baseline] (1.199 s) : 0, 1198886
Total [baseline] (10.922 s) : 0, 10922211
Agent [candidate] (1.196 s) : 0, 1195881
Total [candidate] (10.843 s) : 0, 10842866
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.232 s 176.755 ms (16.7%)
Agent iast 1.179 s 123.371 ms (11.7%)
Agent profiling 1.199 s 143.393 ms (13.6%)
Total tracing 10.778 s -
Total appsec 10.822 s 43.787 ms (0.4%)
Total iast 10.952 s 173.814 ms (1.6%)
Total profiling 10.922 s 144.317 ms (1.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.227 s 163.97 ms (15.4%)
Agent iast 1.18 s 117.435 ms (11.1%)
Agent profiling 1.196 s 133.162 ms (12.5%)
Total tracing 10.774 s -
Total appsec 10.809 s 34.755 ms (0.3%)
Total iast 10.975 s 200.832 ms (1.9%)
Total profiling 10.843 s 68.985 ms (0.6%) 
gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~d73f349ab9, baseline=1.53.0-SNAPSHOT~e125ff7b82

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (737.798 ms) : 0, 737798
BytebuddyAgent [candidate] (743.168 ms) : 0, 743168
GlobalTracer [baseline] (243.881 ms) : 0, 243881
GlobalTracer [candidate] (245.36 ms) : 0, 245360
AppSec [baseline] (30.493 ms) : 0, 30493
AppSec [candidate] (30.779 ms) : 0, 30779
Debugger [baseline] (6.083 ms) : 0, 6083
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (679.695 µs) : 0, 680
Remote Config [candidate] (689.229 µs) : 0, 689
Telemetry [baseline] (13.811 ms) : 0, 13811
Telemetry [candidate] (13.826 ms) : 0, 13826
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (761.57 ms) : 0, 761570
BytebuddyAgent [candidate] (757.714 ms) : 0, 757714
GlobalTracer [baseline] (237.333 ms) : 0, 237333
GlobalTracer [candidate] (236.089 ms) : 0, 236089
IAST [baseline] (23.807 ms) : 0, 23807
IAST [candidate] (23.653 ms) : 0, 23653
AppSec [baseline] (169.556 ms) : 0, 169556
AppSec [candidate] (170.158 ms) : 0, 170158
Debugger [baseline] (7.288 ms) : 0, 7288
Debugger [candidate] (7.3 ms) : 0, 7300
Remote Config [baseline] (645.008 µs) : 0, 645
Remote Config [candidate] (634.082 µs) : 0, 634
Telemetry [baseline] (9.289 ms) : 0, 9289
Telemetry [candidate] (8.515 ms) : 0, 8515
section iast
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (850.376 ms) : 0, 850376
BytebuddyAgent [candidate] (851.957 ms) : 0, 851957
GlobalTracer [baseline] (232.949 ms) : 0, 232949
GlobalTracer [candidate] (233.409 ms) : 0, 233409
IAST [baseline] (32.08 ms) : 0, 32080
IAST [candidate] (29.97 ms) : 0, 29970
AppSec [baseline] (25.149 ms) : 0, 25149
AppSec [candidate] (27.641 ms) : 0, 27641
Debugger [baseline] (6.688 ms) : 0, 6688
Debugger [candidate] (5.791 ms) : 0, 5791
Remote Config [baseline] (617.53 µs) : 0, 618
Remote Config [candidate] (615.461 µs) : 0, 615
Telemetry [baseline] (8.488 ms) : 0, 8488
Telemetry [candidate] (8.297 ms) : 0, 8297
section profiling
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.413 ms) : 0, 1413
BytebuddyAgent [baseline] (763.453 ms) : 0, 763453
BytebuddyAgent [candidate] (761.616 ms) : 0, 761616
GlobalTracer [baseline] (222.566 ms) : 0, 222566
GlobalTracer [candidate] (222.303 ms) : 0, 222303
AppSec [baseline] (30.202 ms) : 0, 30202
AppSec [candidate] (30.074 ms) : 0, 30074
Debugger [baseline] (6.307 ms) : 0, 6307
Debugger [candidate] (6.323 ms) : 0, 6323
Remote Config [baseline] (724.581 µs) : 0, 725
Remote Config [candidate] (701.263 µs) : 0, 701
Telemetry [baseline] (15.658 ms) : 0, 15658
Telemetry [candidate] (16.171 ms) : 0, 16171
ProfilingAgent [baseline] (108.723 ms) : 0, 108723
ProfilingAgent [candidate] (107.712 ms) : 0, 107712
Profiling [baseline] (109.35 ms) : 0, 109350
Profiling [candidate] (108.365 ms) : 0, 108365
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context
git_commit_date 1755523005 1755586841
git_commit_sha e125ff7 d73f349
release_version 1.53.0-SNAPSHOT~e125ff7b82 1.53.0-SNAPSHOT~d73f349ab9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1755588504 1755588504
ci_job_id 1086281415 1086281415
ci_pipeline_id 74076535 74076535
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-h77sv2xn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-h77sv2xn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:tracing:high_load better
[-473.083µs; -227.709µs] or [-6.014%; -2.895%]		 unstable
[-45.298op/s; +99.861op/s] or [-7.694%; +16.961%]		 7.516ms 616.031op/s 7.867ms 588.750op/s
scenario:load:insecure-bank:no_agent:high_load worse
[+128.543µs; +236.373µs] or [+2.999%; +5.514%]		 unstable
[-156.155op/s; +70.467op/s] or [-14.594%; +6.586%]		 4.469ms 1027.125op/s 4.286ms 1069.969op/s
scenario:load:petclinic:iast:high_load worse
[+1.064ms; +1.925ms] or [+2.399%; +4.342%]		 unstable
[-10.942op/s; +4.292op/s] or [-10.371%; +4.068%]		 45.834ms 102.188op/s 44.339ms 105.513op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d73f349ab9, baseline=1.53.0-SNAPSHOT~e125ff7b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.286 ms) : 4238, 4335
.   : milestone, 4286,
iast (9.491 ms) : 9333, 9650
.   : milestone, 9491,
iast_FULL (13.818 ms) : 13540, 14095
.   : milestone, 13818,
iast_GLOBAL (10.261 ms) : 10076, 10445
.   : milestone, 10261,
profiling (8.507 ms) : 8360, 8654
.   : milestone, 8507,
tracing (7.867 ms) : 7753, 7981
.   : milestone, 7867,
section candidate
no_agent (4.469 ms) : 4418, 4520
.   : milestone, 4469,
iast (9.135 ms) : 8981, 9289
.   : milestone, 9135,
iast_FULL (13.659 ms) : 13386, 13931
.   : milestone, 13659,
iast_GLOBAL (10.38 ms) : 10194, 10565
.   : milestone, 10380,
profiling (8.59 ms) : 8460, 8721
.   : milestone, 8590,
tracing (7.516 ms) : 7402, 7630
.   : milestone, 7516,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.286 ms [4.238 ms, 4.335 ms] -
iast 9.491 ms [9.333 ms, 9.65 ms] 5.205 ms (121.4%)
iast_FULL 13.818 ms [13.54 ms, 14.095 ms] 9.531 ms (222.4%)
iast_GLOBAL 10.261 ms [10.076 ms, 10.445 ms] 5.974 ms (139.4%)
profiling 8.507 ms [8.36 ms, 8.654 ms] 4.221 ms (98.5%)
tracing 7.867 ms [7.753 ms, 7.981 ms] 3.58 ms (83.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.469 ms [4.418 ms, 4.52 ms] -
iast 9.135 ms [8.981 ms, 9.289 ms] 4.666 ms (104.4%)
iast_FULL 13.659 ms [13.386 ms, 13.931 ms] 9.19 ms (205.6%)
iast_GLOBAL 10.38 ms [10.194 ms, 10.565 ms] 5.911 ms (132.3%)
profiling 8.59 ms [8.46 ms, 8.721 ms] 4.122 ms (92.2%)
tracing 7.516 ms [7.402 ms, 7.63 ms] 3.047 ms (68.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d73f349ab9, baseline=1.53.0-SNAPSHOT~e125ff7b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.648 ms) : 36360, 36937
.   : milestone, 36648,
appsec (46.624 ms) : 46203, 47045
.   : milestone, 46624,
code_origins (44.131 ms) : 43744, 44518
.   : milestone, 44131,
iast (44.339 ms) : 43940, 44739
.   : milestone, 44339,
profiling (49.96 ms) : 49490, 50430
.   : milestone, 49960,
tracing (45.543 ms) : 45143, 45942
.   : milestone, 45543,
section candidate
no_agent (36.067 ms) : 35777, 36358
.   : milestone, 36067,
appsec (47.595 ms) : 47179, 48010
.   : milestone, 47595,
code_origins (44.578 ms) : 44206, 44950
.   : milestone, 44578,
iast (45.834 ms) : 45433, 46235
.   : milestone, 45834,
profiling (50.048 ms) : 49516, 50580
.   : milestone, 50048,
tracing (45.078 ms) : 44695, 45461
.   : milestone, 45078,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.648 ms [36.36 ms, 36.937 ms] -
appsec 46.624 ms [46.203 ms, 47.045 ms] 9.976 ms (27.2%)
code_origins 44.131 ms [43.744 ms, 44.518 ms] 7.483 ms (20.4%)
iast 44.339 ms [43.94 ms, 44.739 ms] 7.691 ms (21.0%)
profiling 49.96 ms [49.49 ms, 50.43 ms] 13.312 ms (36.3%)
tracing 45.543 ms [45.143 ms, 45.942 ms] 8.894 ms (24.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.067 ms [35.777 ms, 36.358 ms] -
appsec 47.595 ms [47.179 ms, 48.01 ms] 11.527 ms (32.0%)
code_origins 44.578 ms [44.206 ms, 44.95 ms] 8.511 ms (23.6%)
iast 45.834 ms [45.433 ms, 46.235 ms] 9.767 ms (27.1%)
profiling 50.048 ms [49.516 ms, 50.58 ms] 13.98 ms (38.8%)
tracing 45.078 ms [44.695 ms, 45.461 ms] 9.011 ms (25.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context
git_commit_date 1755523005 1755586841
git_commit_sha e125ff7 d73f349
release_version 1.53.0-SNAPSHOT~e125ff7b82 1.53.0-SNAPSHOT~d73f349ab9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1755589002 1755589002
ci_job_id 1086281416 1086281416
ci_pipeline_id 74076535 74076535
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-5gt7d65n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-5gt7d65n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d73f349ab9, baseline=1.53.0-SNAPSHOT~e125ff7b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.669 ms) : 3453, 3886
.   : milestone, 3669,
iast (2.203 ms) : 2140, 2266
.   : milestone, 2203,
iast_GLOBAL (2.243 ms) : 2180, 2307
.   : milestone, 2243,
profiling (2.051 ms) : 2000, 2103
.   : milestone, 2051,
tracing (2.01 ms) : 1961, 2058
.   : milestone, 2010,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (3.59 ms) : 3377, 3804
.   : milestone, 3590,
iast (2.205 ms) : 2142, 2268
.   : milestone, 2205,
iast_GLOBAL (2.247 ms) : 2183, 2310
.   : milestone, 2247,
profiling (2.054 ms) : 2003, 2105
.   : milestone, 2054,
tracing (2.023 ms) : 1974, 2072
.   : milestone, 2023,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 3.669 ms [3.453 ms, 3.886 ms] 2.19 ms (148.0%)
iast 2.203 ms [2.14 ms, 2.266 ms] 723.33 µs (48.9%)
iast_GLOBAL 2.243 ms [2.18 ms, 2.307 ms] 763.948 µs (51.6%)
profiling 2.051 ms [2.0 ms, 2.103 ms] 571.882 µs (38.7%)
tracing 2.01 ms [1.961 ms, 2.058 ms] 530.108 µs (35.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 3.59 ms [3.377 ms, 3.804 ms] 2.118 ms (143.9%)
iast 2.205 ms [2.142 ms, 2.268 ms] 733.22 µs (49.8%)
iast_GLOBAL 2.247 ms [2.183 ms, 2.31 ms] 774.432 µs (52.6%)
profiling 2.054 ms [2.003 ms, 2.105 ms] 582.055 µs (39.5%)
tracing 2.023 ms [1.974 ms, 2.072 ms] 551.047 µs (37.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d73f349ab9, baseline=1.53.0-SNAPSHOT~e125ff7b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.537 s) : 15537000, 15537000
.   : milestone, 15537000,
appsec (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
iast (18.489 s) : 18489000, 18489000
.   : milestone, 18489000,
iast_GLOBAL (18.252 s) : 18252000, 18252000
.   : milestone, 18252000,
profiling (15.454 s) : 15454000, 15454000
.   : milestone, 15454000,
tracing (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,
section candidate
no_agent (15.397 s) : 15397000, 15397000
.   : milestone, 15397000,
appsec (14.786 s) : 14786000, 14786000
.   : milestone, 14786000,
iast (18.361 s) : 18361000, 18361000
.   : milestone, 18361000,
iast_GLOBAL (18.212 s) : 18212000, 18212000
.   : milestone, 18212000,
profiling (15.607 s) : 15607000, 15607000
.   : milestone, 15607000,
tracing (14.837 s) : 14837000, 14837000
.   : milestone, 14837000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.537 s [15.537 s, 15.537 s] -
appsec 14.959 s [14.959 s, 14.959 s] -578.0 ms (-3.7%)
iast 18.489 s [18.489 s, 18.489 s] 2.952 s (19.0%)
iast_GLOBAL 18.252 s [18.252 s, 18.252 s] 2.715 s (17.5%)
profiling 15.454 s [15.454 s, 15.454 s] -83.0 ms (-0.5%)
tracing 15.01 s [15.01 s, 15.01 s] -527.0 ms (-3.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.397 s [15.397 s, 15.397 s] -
appsec 14.786 s [14.786 s, 14.786 s] -611.0 ms (-4.0%)
iast 18.361 s [18.361 s, 18.361 s] 2.964 s (19.3%)
iast_GLOBAL 18.212 s [18.212 s, 18.212 s] 2.815 s (18.3%)
profiling 15.607 s [15.607 s, 15.607 s] 210.0 ms (1.4%)
tracing 14.837 s [14.837 s, 14.837 s] -560.0 ms (-3.6%)

@pr-commenter
Copy link

pr-commenter bot commented Aug 18, 2025 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context
git_commit_date 1755513833 1755531480
git_commit_sha 6d0e730 11d43a3
See matching parameters
Baseline Candidate
ci_job_date 1755532499 1755532499
ci_job_id 1084905185 1084905185
ci_pipeline_id 73980893 73980893
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Aug 18, 2025 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context
git_commit_date 1755513833 1755586841
git_commit_sha 6d0e730 d73f349
See matching parameters
Baseline Candidate
ci_job_date 1755588094 1755588094
ci_job_id 1086281420 1086281420
ci_pipeline_id 74076535 74076535
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@PerfectSlayer PerfectSlayer marked this pull request as ready for review August 19, 2025 08:27
amarziali
amarziali reviewed Aug 19, 2025
View reviewed changes
...aws-java-sdk-1.11.0/src/main/java/datadog/trace/instrumentation/aws/v0/OnErrorDecorator.java
new HandlerContextKey<>("DatadogSpan"); // same as TracingRequestHandler.SPAN_CONTEXT_KEY
public static final HandlerContextKey<Context> CONTEXT_CONTEXT_KEY =
new HandlerContextKey<>(
"DatadogContext"); // same as TracingRequestHandler.CONTEXT_CONTEXT_KEY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have key constants on a single class file to have them all in a single place? It will avoid using string values everywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. It feels this would be out of scope this PR... Maybe IDM can pick it up as improvement? WYDT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can be deferred to their backlog

amarziali
amarziali reviewed Aug 19, 2025
View reviewed changes
internal-api/src/main/java/datadog/trace/api/datastreams/DataStreamsTags.java
Unknown,
Inbound,
Outbound,
UNKNOWN,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity are we recommending to have uppercase only for enum names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According the Java’s guideline:

Because they are constants, the names of an enum type's fields are in uppercase letters.

@PerfectSlayer
Copy link
Contributor Author

Merging now to prevent conflict with #9383

@PerfectSlayer PerfectSlayer merged commit 5380221 into master Aug 19, 2025
503 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/context branch August 19, 2025 09:00
@github-actions github-actions bot added this to the 1.53.0 milestone Aug 19, 2025
This was referenced Aug 19, 2025
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
comp: context propagation Trace context propagation type: refactoring
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerfectSlayer @amarziali