Update Spock to 2.4-M6 by nikita-tkachenko-datadog · Pull Request #9516 · DataDog/dd-trace-java

nikita-tkachenko-datadog · 2025-09-11T17:14:00Z

What Does This Do

Updates Spock version used by the tracer from 2.3 to 2.4-M6.

Motivation

Improve CI stability: Spock 2.3 suffers from a deadlock problem fixed in 2.4 (PR in Spock).

Additional Notes

Kudos to @AlexeyKuznetsov-DD for laying the groundwork.

While migrating, 4 problems had to be solved:

some instrumentation modules used JUnit and Mockito version incompatible with Spock 2.4
some smoke test modules used SpringBoot Gradle plugin which pulled in JUnit version incompatible with Spock 2.4
spying on spans in InstrumentationSpecification was broken due to the changes in how mocking works in Spock 2.4
Spock instrumentation did not work with with Spock 2.4

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

… compatible with Spock 2.4

nikita-tkachenko-datadog · 2025-09-11T17:19:18Z

...nstrumentation-testing/src/main/groovy/datadog/trace/agent/test/TrackingSpanDecorator.groovy

This class used to be a Spy created with Spock. Due to the changes in mocking in Spock 2.4 it is no longer possible to spy on DDSpan (it has final methods and no 0-arg constructor, so Spock's new ByteBuddy and Mockito mockers cannot handle it), which is why it was replaced with a regular class replicating the same logic.

nikita-tkachenko-datadog · 2025-09-11T17:19:25Z

...on-testing/src/main/groovy/datadog/trace/agent/test/ValidatingRequestContextDecorator.groovy

This class used to be a Spy created with Spock. Due to the changes in mocking in Spock 2.4 it is no longer possible to spy on DDSpan (it has final methods and no 0-arg constructor, so Spock's new ByteBuddy and Mockito mockers cannot handle it), which is why it was replaced with a regular class replicating the same logic.

datadog-official · 2025-09-11T17:34:36Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 60.11% (-0.04%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 559008b | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-11T17:44:21Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nikita-tkachenko/spock-2.4-M6-update
git_commit_date	1757617724	1757617797
git_commit_sha	`f7ec25f`	`559008b`
release_version	1.54.0-SNAPSHOT~f7ec25f082	1.54.0-SNAPSHOT~559008b07e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1757620023	1757620023
ci_job_id	1125453708	1125453708
ci_pipeline_id	76240042	76240042
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-ci6s9v2k 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-ci6s9v2k 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~559008b07e, baseline=1.54.0-SNAPSHOT~f7ec25f082

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069860
Total [baseline] (10.737 s) : 0, 10737419
Agent [candidate] (1.063 s) : 0, 1062670
Total [candidate] (10.625 s) : 0, 10624705
section appsec
Agent [baseline] (1.237 s) : 0, 1236599
Total [baseline] (11.02 s) : 0, 11020456
Agent [candidate] (1.234 s) : 0, 1234486
Total [candidate] (10.837 s) : 0, 10837404
section iast
Agent [baseline] (1.193 s) : 0, 1192997
Total [baseline] (11.095 s) : 0, 11094506
Agent [candidate] (1.191 s) : 0, 1191099
Total [candidate] (11.108 s) : 0, 11107820
section profiling
Agent [baseline] (1.209 s) : 0, 1208762
Total [baseline] (10.867 s) : 0, 10867039
Agent [candidate] (1.213 s) : 0, 1212557
Total [candidate] (10.879 s) : 0, 10879335

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.07 s	-
Agent	appsec	1.237 s	166.739 ms (15.6%)
Agent	iast	1.193 s	123.136 ms (11.5%)
Agent	profiling	1.209 s	138.902 ms (13.0%)
Total	tracing	10.737 s	-
Total	appsec	11.02 s	283.038 ms (2.6%)
Total	iast	11.095 s	357.087 ms (3.3%)
Total	profiling	10.867 s	129.62 ms (1.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	appsec	1.234 s	171.817 ms (16.2%)
Agent	iast	1.191 s	128.429 ms (12.1%)
Agent	profiling	1.213 s	149.887 ms (14.1%)
Total	tracing	10.625 s	-
Total	appsec	10.837 s	212.699 ms (2.0%)
Total	iast	11.108 s	483.116 ms (4.5%)
Total	profiling	10.879 s	254.631 ms (2.4%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~559008b07e, baseline=1.54.0-SNAPSHOT~f7ec25f082

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (738.424 ms) : 0, 738424
BytebuddyAgent [candidate] (733.307 ms) : 0, 733307
GlobalTracer [baseline] (254.361 ms) : 0, 254361
GlobalTracer [candidate] (252.901 ms) : 0, 252901
AppSec [baseline] (30.792 ms) : 0, 30792
AppSec [candidate] (30.575 ms) : 0, 30575
Debugger [baseline] (6.443 ms) : 0, 6443
Debugger [candidate] (6.411 ms) : 0, 6411
Remote Config [baseline] (706.884 µs) : 0, 707
Remote Config [candidate] (677.755 µs) : 0, 678
Telemetry [baseline] (16.431 ms) : 0, 16431
Telemetry [candidate] (16.259 ms) : 0, 16259
section appsec
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (756.912 ms) : 0, 756912
BytebuddyAgent [candidate] (755.707 ms) : 0, 755707
GlobalTracer [baseline] (246.046 ms) : 0, 246046
GlobalTracer [candidate] (245.733 ms) : 0, 245733
AppSec [baseline] (171.85 ms) : 0, 171850
AppSec [candidate] (170.685 ms) : 0, 170685
Debugger [baseline] (6.104 ms) : 0, 6104
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (650.82 µs) : 0, 651
Remote Config [candidate] (629.549 µs) : 0, 630
Telemetry [baseline] (8.519 ms) : 0, 8519
Telemetry [candidate] (9.279 ms) : 0, 9279
IAST [baseline] (23.855 ms) : 0, 23855
IAST [candidate] (23.76 ms) : 0, 23760
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (854.088 ms) : 0, 854088
BytebuddyAgent [candidate] (852.001 ms) : 0, 852001
GlobalTracer [baseline] (248.161 ms) : 0, 248161
GlobalTracer [candidate] (246.285 ms) : 0, 246285
AppSec [baseline] (25.491 ms) : 0, 25491
AppSec [candidate] (25.603 ms) : 0, 25603
Debugger [baseline] (6.05 ms) : 0, 6050
Debugger [candidate] (6.131 ms) : 0, 6131
Remote Config [baseline] (630.067 µs) : 0, 630
Remote Config [candidate] (606.878 µs) : 0, 607
Telemetry [baseline] (8.185 ms) : 0, 8185
Telemetry [candidate] (8.219 ms) : 0, 8219
IAST [baseline] (27.896 ms) : 0, 27896
IAST [candidate] (29.783 ms) : 0, 29783
section profiling
ProfilingAgent [baseline] (107.593 ms) : 0, 107593
ProfilingAgent [candidate] (107.247 ms) : 0, 107247
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (761.683 ms) : 0, 761683
BytebuddyAgent [candidate] (764.673 ms) : 0, 764673
GlobalTracer [baseline] (233.002 ms) : 0, 233002
GlobalTracer [candidate] (233.662 ms) : 0, 233662
AppSec [baseline] (31.105 ms) : 0, 31105
AppSec [candidate] (31.331 ms) : 0, 31331
Debugger [baseline] (9.073 ms) : 0, 9073
Debugger [candidate] (8.205 ms) : 0, 8205
Remote Config [baseline] (735.173 µs) : 0, 735
Remote Config [candidate] (726.44 µs) : 0, 726
Telemetry [baseline] (13.238 ms) : 0, 13238
Telemetry [candidate] (14.066 ms) : 0, 14066
Profiling [baseline] (108.245 ms) : 0, 108245
Profiling [candidate] (107.914 ms) : 0, 107914

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~559008b07e, baseline=1.54.0-SNAPSHOT~f7ec25f082

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062135
Total [baseline] (8.614 s) : 0, 8614263
Agent [candidate] (1.06 s) : 0, 1059790
Total [candidate] (8.611 s) : 0, 8611176
section iast
Agent [baseline] (1.198 s) : 0, 1198019
Total [baseline] (9.278 s) : 0, 9277964
Agent [candidate] (1.194 s) : 0, 1193658
Total [candidate] (9.341 s) : 0, 9341340

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	iast	1.198 s	135.884 ms (12.8%)
Total	tracing	8.614 s	-
Total	iast	9.278 s	663.701 ms (7.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	iast	1.194 s	133.868 ms (12.6%)
Total	tracing	8.611 s	-
Total	iast	9.341 s	730.164 ms (8.5%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~559008b07e, baseline=1.54.0-SNAPSHOT~f7ec25f082

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (733.248 ms) : 0, 733248
BytebuddyAgent [candidate] (731.341 ms) : 0, 731341
GlobalTracer [baseline] (252.326 ms) : 0, 252326
GlobalTracer [candidate] (252.13 ms) : 0, 252130
AppSec [baseline] (30.678 ms) : 0, 30678
AppSec [candidate] (30.545 ms) : 0, 30545
Debugger [baseline] (6.411 ms) : 0, 6411
Debugger [candidate] (6.427 ms) : 0, 6427
Remote Config [baseline] (693.127 µs) : 0, 693
Remote Config [candidate] (692.595 µs) : 0, 693
Telemetry [baseline] (16.306 ms) : 0, 16306
Telemetry [candidate] (16.201 ms) : 0, 16201
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (858.931 ms) : 0, 858931
BytebuddyAgent [candidate] (855.972 ms) : 0, 855972
GlobalTracer [baseline] (247.468 ms) : 0, 247468
GlobalTracer [candidate] (247.301 ms) : 0, 247301
IAST [baseline] (27.926 ms) : 0, 27926
IAST [candidate] (28.496 ms) : 0, 28496
AppSec [baseline] (26.376 ms) : 0, 26376
AppSec [candidate] (24.727 ms) : 0, 24727
Debugger [baseline] (6.057 ms) : 0, 6057
Debugger [candidate] (6.031 ms) : 0, 6031
Remote Config [baseline] (606.413 µs) : 0, 606
Remote Config [candidate] (611.961 µs) : 0, 612
Telemetry [baseline] (8.131 ms) : 0, 8131
Telemetry [candidate] (8.07 ms) : 0, 8070

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nikita-tkachenko/spock-2.4-M6-update
git_commit_date	1757617724	1757617797
git_commit_sha	`f7ec25f`	`559008b`
release_version	1.54.0-SNAPSHOT~f7ec25f082	1.54.0-SNAPSHOT~559008b07e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1757619699	1757619699
ci_job_id	1125453710	1125453710
ci_pipeline_id	76240042	76240042
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-wfd7aese 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-wfd7aese 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load	worse [+517.433µs; +1134.673µs] or [+3.734%; +8.189%]	unstable [-55.282op/s; +18.345op/s] or [-16.439%; +5.455%]	14.682ms	317.812op/s	13.856ms	336.281op/s
scenario:load:petclinic:no_agent:high_load	better [-2.843ms; -2.193ms] or [-7.307%; -5.636%]	unstable [-0.928op/s; +17.453op/s] or [-0.773%; +14.528%]	36.394ms	128.400op/s	38.912ms	120.138op/s
scenario:load:petclinic:code_origins:high_load	better [-2.084ms; -1.254ms] or [-4.457%; -2.682%]	unstable [-3.822op/s; +11.347op/s] or [-3.820%; +11.340%]	45.087ms	103.825op/s	46.756ms	100.062op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~559008b07e, baseline=1.54.0-SNAPSHOT~f7ec25f082
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.348 ms) : 4299, 4397
.   : milestone, 4348,
iast (9.227 ms) : 9069, 9385
.   : milestone, 9227,
iast_FULL (13.856 ms) : 13582, 14129
.   : milestone, 13856,
iast_GLOBAL (10.882 ms) : 10690, 11074
.   : milestone, 10882,
profiling (8.727 ms) : 8590, 8864
.   : milestone, 8727,
tracing (7.548 ms) : 7443, 7653
.   : milestone, 7548,
section candidate
no_agent (4.475 ms) : 4421, 4528
.   : milestone, 4475,
iast (9.442 ms) : 9288, 9596
.   : milestone, 9442,
iast_FULL (14.682 ms) : 14382, 14981
.   : milestone, 14682,
iast_GLOBAL (10.514 ms) : 10325, 10704
.   : milestone, 10514,
profiling (8.862 ms) : 8724, 8999
.   : milestone, 8862,
tracing (7.585 ms) : 7479, 7690
.   : milestone, 7585,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.348 ms [4.299 ms, 4.397 ms]	-
iast	9.227 ms [9.069 ms, 9.385 ms]	4.879 ms (112.2%)
iast_FULL	13.856 ms [13.582 ms, 14.129 ms]	9.507 ms (218.7%)
iast_GLOBAL	10.882 ms [10.69 ms, 11.074 ms]	6.534 ms (150.3%)
profiling	8.727 ms [8.59 ms, 8.864 ms]	4.378 ms (100.7%)
tracing	7.548 ms [7.443 ms, 7.653 ms]	3.2 ms (73.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.475 ms [4.421 ms, 4.528 ms]	-
iast	9.442 ms [9.288 ms, 9.596 ms]	4.968 ms (111.0%)
iast_FULL	14.682 ms [14.382 ms, 14.981 ms]	10.207 ms (228.1%)
iast_GLOBAL	10.514 ms [10.325 ms, 10.704 ms]	6.04 ms (135.0%)
profiling	8.862 ms [8.724 ms, 8.999 ms]	4.387 ms (98.0%)
tracing	7.585 ms [7.479 ms, 7.69 ms]	3.11 ms (69.5%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~559008b07e, baseline=1.54.0-SNAPSHOT~f7ec25f082
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.912 ms) : 38601, 39224
.   : milestone, 38912,
appsec (49.327 ms) : 48908, 49746
.   : milestone, 49327,
code_origins (46.756 ms) : 46358, 47154
.   : milestone, 46756,
iast (44.559 ms) : 44172, 44945
.   : milestone, 44559,
profiling (48.302 ms) : 47836, 48768
.   : milestone, 48302,
tracing (44.037 ms) : 43672, 44402
.   : milestone, 44037,
section candidate
no_agent (36.394 ms) : 36102, 36686
.   : milestone, 36394,
appsec (47.96 ms) : 47557, 48364
.   : milestone, 47960,
code_origins (45.087 ms) : 44714, 45460
.   : milestone, 45087,
iast (45.568 ms) : 45180, 45956
.   : milestone, 45568,
profiling (48.813 ms) : 48362, 49265
.   : milestone, 48813,
tracing (45.089 ms) : 44730, 45448
.   : milestone, 45089,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.912 ms [38.601 ms, 39.224 ms]	-
appsec	49.327 ms [48.908 ms, 49.746 ms]	10.415 ms (26.8%)
code_origins	46.756 ms [46.358 ms, 47.154 ms]	7.844 ms (20.2%)
iast	44.559 ms [44.172 ms, 44.945 ms]	5.646 ms (14.5%)
profiling	48.302 ms [47.836 ms, 48.768 ms]	9.39 ms (24.1%)
tracing	44.037 ms [43.672 ms, 44.402 ms]	5.125 ms (13.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.394 ms [36.102 ms, 36.686 ms]	-
appsec	47.96 ms [47.557 ms, 48.364 ms]	11.566 ms (31.8%)
code_origins	45.087 ms [44.714 ms, 45.46 ms]	8.693 ms (23.9%)
iast	45.568 ms [45.18 ms, 45.956 ms]	9.174 ms (25.2%)
profiling	48.813 ms [48.362 ms, 49.265 ms]	12.419 ms (34.1%)
tracing	45.089 ms [44.73 ms, 45.448 ms]	8.695 ms (23.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nikita-tkachenko/spock-2.4-M6-update
git_commit_date	1757617724	1757617797
git_commit_sha	`f7ec25f`	`559008b`
release_version	1.54.0-SNAPSHOT~f7ec25f082	1.54.0-SNAPSHOT~559008b07e

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1757620281	1757620281
ci_job_id	1125453712	1125453712
ci_pipeline_id	76240042	76240042
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-lqrdmerf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-lqrdmerf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:dacapo:tomcat:appsec	better [-1.437ms; -1.094ms] or [-38.494%; -29.305%]	2.467ms	3.732ms

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~559008b07e, baseline=1.54.0-SNAPSHOT~f7ec25f082
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.529 s) : 15529000, 15529000
.   : milestone, 15529000,
appsec (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
iast (18.368 s) : 18368000, 18368000
.   : milestone, 18368000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
.   : milestone, 18100000,
profiling (15.895 s) : 15895000, 15895000
.   : milestone, 15895000,
tracing (14.904 s) : 14904000, 14904000
.   : milestone, 14904000,
section candidate
no_agent (15.525 s) : 15525000, 15525000
.   : milestone, 15525000,
appsec (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
iast (18.625 s) : 18625000, 18625000
.   : milestone, 18625000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
.   : milestone, 17958000,
profiling (15.335 s) : 15335000, 15335000
.   : milestone, 15335000,
tracing (15.146 s) : 15146000, 15146000
.   : milestone, 15146000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.529 s [15.529 s, 15.529 s]	-
appsec	15.149 s [15.149 s, 15.149 s]	-380.0 ms (-2.4%)
iast	18.368 s [18.368 s, 18.368 s]	2.839 s (18.3%)
iast_GLOBAL	18.1 s [18.1 s, 18.1 s]	2.571 s (16.6%)
profiling	15.895 s [15.895 s, 15.895 s]	366.0 ms (2.4%)
tracing	14.904 s [14.904 s, 14.904 s]	-625.0 ms (-4.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.525 s [15.525 s, 15.525 s]	-
appsec	15.04 s [15.04 s, 15.04 s]	-485.0 ms (-3.1%)
iast	18.625 s [18.625 s, 18.625 s]	3.1 s (20.0%)
iast_GLOBAL	17.958 s [17.958 s, 17.958 s]	2.433 s (15.7%)
profiling	15.335 s [15.335 s, 15.335 s]	-190.0 ms (-1.2%)
tracing	15.146 s [15.146 s, 15.146 s]	-379.0 ms (-2.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~559008b07e, baseline=1.54.0-SNAPSHOT~f7ec25f082
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (3.732 ms) : 3513, 3952
.   : milestone, 3732,
iast (2.216 ms) : 2153, 2278
.   : milestone, 2216,
iast_GLOBAL (2.259 ms) : 2196, 2323
.   : milestone, 2259,
profiling (2.064 ms) : 2013, 2114
.   : milestone, 2064,
tracing (2.034 ms) : 1985, 2083
.   : milestone, 2034,
section candidate
no_agent (1.481 ms) : 1469, 1492
.   : milestone, 1481,
appsec (2.467 ms) : 2417, 2517
.   : milestone, 2467,
iast (2.213 ms) : 2151, 2276
.   : milestone, 2213,
iast_GLOBAL (2.263 ms) : 2199, 2326
.   : milestone, 2263,
profiling (2.069 ms) : 2017, 2121
.   : milestone, 2069,
tracing (2.031 ms) : 1983, 2080
.   : milestone, 2031,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.47 ms, 1.493 ms]	-
appsec	3.732 ms [3.513 ms, 3.952 ms]	2.251 ms (152.0%)
iast	2.216 ms [2.153 ms, 2.278 ms]	734.497 µs (49.6%)
iast_GLOBAL	2.259 ms [2.196 ms, 2.323 ms]	778.316 µs (52.5%)
profiling	2.064 ms [2.013 ms, 2.114 ms]	582.34 µs (39.3%)
tracing	2.034 ms [1.985 ms, 2.083 ms]	552.693 µs (37.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.469 ms, 1.492 ms]	-
appsec	2.467 ms [2.417 ms, 2.517 ms]	986.245 µs (66.6%)
iast	2.213 ms [2.151 ms, 2.276 ms]	732.312 µs (49.5%)
iast_GLOBAL	2.263 ms [2.199 ms, 2.326 ms]	781.803 µs (52.8%)
profiling	2.069 ms [2.017 ms, 2.121 ms]	588.328 µs (39.7%)
tracing	2.031 ms [1.983 ms, 2.08 ms]	550.539 µs (37.2%)

AlexeyKuznetsov-DD and others added 5 commits September 10, 2025 09:12

Update Spock to 2.4-M6 to fix deadlock issues on CI.

a38aee5

Update JUnit and Mockito versions to be compatible with Spock 2.4

2395beb

Update JUnit dependencies pulled in by SpringBoot Gradle plugin to be…

bcea04f

… compatible with Spock 2.4

Fix Spock mocking issue in InstrumentationSpecification

fd84df9

Fix Spock instrumentation to work with version 2.4

d983a67

nikita-tkachenko-datadog added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Sep 11, 2025

nikita-tkachenko-datadog commented Sep 11, 2025

View reviewed changes

AlexeyKuznetsov-DD approved these changes Sep 11, 2025

View reviewed changes

nikita-tkachenko-datadog mentioned this pull request Sep 11, 2025

Update Spock to 2.4-M6 to fix deadlock issues on CI. #9507

Closed

nikita-tkachenko-datadog marked this pull request as ready for review September 11, 2025 19:06

nikita-tkachenko-datadog requested review from a team as code owners September 11, 2025 19:06

nikita-tkachenko-datadog requested review from amarziali and daniel-mohedano September 11, 2025 19:06

Merge branch 'master' into nikita-tkachenko/spock-2.4-M6-update

559008b

nikita-tkachenko-datadog merged commit f7aa6d2 into master Sep 12, 2025
504 checks passed

nikita-tkachenko-datadog deleted the nikita-tkachenko/spock-2.4-M6-update branch September 12, 2025 08:50

github-actions bot added this to the 1.54.0 milestone Sep 12, 2025

AlexeyKuznetsov-DD mentioned this pull request Sep 12, 2025

Reverted not needed changes. #9522

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Spock to 2.4-M6#9516

Update Spock to 2.4-M6#9516
nikita-tkachenko-datadog merged 6 commits intomasterfrom
nikita-tkachenko/spock-2.4-M6-update

nikita-tkachenko-datadog commented Sep 11, 2025

Uh oh!

nikita-tkachenko-datadog Sep 11, 2025

Uh oh!

nikita-tkachenko-datadog Sep 11, 2025

Uh oh!

datadog-official bot commented Sep 11, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

pr-commenter bot commented Sep 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nikita-tkachenko-datadog commented Sep 11, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

nikita-tkachenko-datadog Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

nikita-tkachenko-datadog Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

datadog-official bot commented Sep 11, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datadog-official bot commented Sep 11, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Sep 11, 2025 •

edited

Loading