Fixed race condition on dumping future cleanup. #9607

AlexeyKuznetsov-DD · 2025-09-24T18:01:27Z

What Does This Do

I found that my initial implementation (see #9414) is producing not needed thread dumps.
After some investigation and various attempts I found that cleanup was executed for the wrong futures.
In order to fix that we need to register exactly one dump per test task.

Motivation

CI usability.

Additional Notes

The best solution so far is to refactor to Kotlin plugin.

datadog-official · 2025-09-24T18:25:24Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 57.97% (-0.00%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 6a92882 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-24T18:37:41Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/debug-dump-logic
git_commit_date	1759335243	1759337909
git_commit_sha	`6c26663`	`6a92882`
release_version	1.54.0-SNAPSHOT~6c26663efe	1.54.0-SNAPSHOT~6a92882fae

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1759339864	1759339864
ci_job_id	1158033527	1158033527
ci_pipeline_id	78105188	78105188
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-2ed4a4k9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-2ed4a4k9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~6a92882fae, baseline=1.54.0-SNAPSHOT~6c26663efe

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017415
Total [baseline] (8.684 s) : 0, 8684136
Agent [candidate] (1.017 s) : 0, 1017224
Total [candidate] (8.631 s) : 0, 8630982
section iast
Agent [baseline] (1.152 s) : 0, 1151574
Total [baseline] (9.25 s) : 0, 9250119
Agent [candidate] (1.151 s) : 0, 1150925
Total [candidate] (9.297 s) : 0, 9296569

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.017 s	-
Agent	iast	1.152 s	134.159 ms (13.2%)
Total	tracing	8.684 s	-
Total	iast	9.25 s	565.982 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.017 s	-
Agent	iast	1.151 s	133.701 ms (13.1%)
Total	tracing	8.631 s	-
Total	iast	9.297 s	665.586 ms (7.7%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~6a92882fae, baseline=1.54.0-SNAPSHOT~6c26663efe

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (692.758 ms) : 0, 692758
BytebuddyAgent [candidate] (691.483 ms) : 0, 691483
GlobalTracer [baseline] (242.765 ms) : 0, 242765
GlobalTracer [candidate] (242.846 ms) : 0, 242846
AppSec [baseline] (32.755 ms) : 0, 32755
AppSec [candidate] (33.105 ms) : 0, 33105
Debugger [baseline] (6.463 ms) : 0, 6463
Debugger [candidate] (6.451 ms) : 0, 6451
Remote Config [baseline] (696.23 µs) : 0, 696
Remote Config [candidate] (700.209 µs) : 0, 700
Telemetry [baseline] (9.234 ms) : 0, 9234
Telemetry [candidate] (9.177 ms) : 0, 9177
Flare Poller [baseline] (10.16 ms) : 0, 10160
Flare Poller [candidate] (10.935 ms) : 0, 10935
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (815.639 ms) : 0, 815639
BytebuddyAgent [candidate] (814.294 ms) : 0, 814294
GlobalTracer [baseline] (232.757 ms) : 0, 232757
GlobalTracer [candidate] (232.888 ms) : 0, 232888
AppSec [baseline] (35.033 ms) : 0, 35033
AppSec [candidate] (35.48 ms) : 0, 35480
Debugger [baseline] (6.056 ms) : 0, 6056
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (593.772 µs) : 0, 594
Remote Config [candidate] (583.978 µs) : 0, 584
Telemetry [baseline] (8.241 ms) : 0, 8241
Telemetry [candidate] (8.348 ms) : 0, 8348
Flare Poller [baseline] (4.273 ms) : 0, 4273
Flare Poller [candidate] (4.281 ms) : 0, 4281
IAST [baseline] (26.136 ms) : 0, 26136
IAST [candidate] (26.271 ms) : 0, 26271

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~6a92882fae, baseline=1.54.0-SNAPSHOT~6c26663efe

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022581
Total [baseline] (10.704 s) : 0, 10704366
Agent [candidate] (1.021 s) : 0, 1020810
Total [candidate] (10.643 s) : 0, 10643371
section appsec
Agent [baseline] (1.199 s) : 0, 1198633
Total [baseline] (11.068 s) : 0, 11067853
Agent [candidate] (1.189 s) : 0, 1189200
Total [candidate] (11.033 s) : 0, 11032674
section iast
Agent [baseline] (1.154 s) : 0, 1153923
Total [baseline] (10.917 s) : 0, 10917005
Agent [candidate] (1.149 s) : 0, 1148626
Total [candidate] (10.933 s) : 0, 10933063
section profiling
Agent [baseline] (1.162 s) : 0, 1162432
Total [baseline] (11.024 s) : 0, 11024220
Agent [candidate] (1.162 s) : 0, 1161867
Total [candidate] (11.024 s) : 0, 11023764

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.023 s	-
Agent	appsec	1.199 s	176.052 ms (17.2%)
Agent	iast	1.154 s	131.342 ms (12.8%)
Agent	profiling	1.162 s	139.851 ms (13.7%)
Total	tracing	10.704 s	-
Total	appsec	11.068 s	363.487 ms (3.4%)
Total	iast	10.917 s	212.639 ms (2.0%)
Total	profiling	11.024 s	319.854 ms (3.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	appsec	1.189 s	168.39 ms (16.5%)
Agent	iast	1.149 s	127.816 ms (12.5%)
Agent	profiling	1.162 s	141.057 ms (13.8%)
Total	tracing	10.643 s	-
Total	appsec	11.033 s	389.303 ms (3.7%)
Total	iast	10.933 s	289.692 ms (2.7%)
Total	profiling	11.024 s	380.393 ms (3.6%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~6a92882fae, baseline=1.54.0-SNAPSHOT~6c26663efe

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (694.901 ms) : 0, 694901
BytebuddyAgent [candidate] (693.996 ms) : 0, 693996
GlobalTracer [baseline] (243.953 ms) : 0, 243953
GlobalTracer [candidate] (243.832 ms) : 0, 243832
AppSec [baseline] (33.052 ms) : 0, 33052
AppSec [candidate] (32.998 ms) : 0, 32998
Debugger [baseline] (6.538 ms) : 0, 6538
Debugger [candidate] (6.417 ms) : 0, 6417
Remote Config [baseline] (698.034 µs) : 0, 698
Remote Config [candidate] (690.352 µs) : 0, 690
Telemetry [baseline] (9.171 ms) : 0, 9171
Telemetry [candidate] (9.118 ms) : 0, 9118
Flare Poller [baseline] (11.663 ms) : 0, 11663
Flare Poller [candidate] (11.078 ms) : 0, 11078
section appsec
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (720.085 ms) : 0, 720085
BytebuddyAgent [candidate] (714.281 ms) : 0, 714281
GlobalTracer [baseline] (236.395 ms) : 0, 236395
GlobalTracer [candidate] (234.621 ms) : 0, 234621
AppSec [baseline] (174.087 ms) : 0, 174087
AppSec [candidate] (173.481 ms) : 0, 173481
Debugger [baseline] (6.094 ms) : 0, 6094
Debugger [candidate] (5.985 ms) : 0, 5985
Remote Config [baseline] (659.36 µs) : 0, 659
Remote Config [candidate] (639.147 µs) : 0, 639
Telemetry [baseline] (9.253 ms) : 0, 9253
Telemetry [candidate] (8.245 ms) : 0, 8245
Flare Poller [baseline] (4.074 ms) : 0, 4074
Flare Poller [candidate] (4.745 ms) : 0, 4745
IAST [baseline] (25.309 ms) : 0, 25309
IAST [candidate] (24.634 ms) : 0, 24634
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (816.529 ms) : 0, 816529
BytebuddyAgent [candidate] (812.244 ms) : 0, 812244
GlobalTracer [baseline] (233.839 ms) : 0, 233839
GlobalTracer [candidate] (232.972 ms) : 0, 232972
AppSec [baseline] (35.113 ms) : 0, 35113
AppSec [candidate] (35.17 ms) : 0, 35170
Debugger [baseline] (6.032 ms) : 0, 6032
Debugger [candidate] (6.059 ms) : 0, 6059
Remote Config [baseline] (595.857 µs) : 0, 596
Remote Config [candidate] (595.035 µs) : 0, 595
Telemetry [baseline] (8.237 ms) : 0, 8237
Telemetry [candidate] (8.371 ms) : 0, 8371
Flare Poller [baseline] (4.26 ms) : 0, 4260
Flare Poller [candidate] (4.285 ms) : 0, 4285
IAST [baseline] (26.464 ms) : 0, 26464
IAST [candidate] (26.208 ms) : 0, 26208
section profiling
crashtracking [baseline] (1.409 ms) : 0, 1409
crashtracking [candidate] (1.41 ms) : 0, 1410
BytebuddyAgent [baseline] (720.498 ms) : 0, 720498
BytebuddyAgent [candidate] (720.442 ms) : 0, 720442
GlobalTracer [baseline] (219.502 ms) : 0, 219502
GlobalTracer [candidate] (219.099 ms) : 0, 219099
AppSec [baseline] (32.851 ms) : 0, 32851
AppSec [candidate] (32.749 ms) : 0, 32749
Debugger [baseline] (6.587 ms) : 0, 6587
Debugger [candidate] (7.31 ms) : 0, 7310
Remote Config [baseline] (803.021 µs) : 0, 803
Remote Config [candidate] (785.577 µs) : 0, 786
Telemetry [baseline] (16.56 ms) : 0, 16560
Telemetry [candidate] (14.887 ms) : 0, 14887
Flare Poller [baseline] (4.212 ms) : 0, 4212
Flare Poller [candidate] (4.959 ms) : 0, 4959
ProfilingAgent [baseline] (105.937 ms) : 0, 105937
ProfilingAgent [candidate] (105.643 ms) : 0, 105643
Profiling [baseline] (108.15 ms) : 0, 108150
Profiling [candidate] (108.33 ms) : 0, 108330

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/debug-dump-logic
git_commit_date	1759335243	1759337909
git_commit_sha	`6c26663`	`6a92882`
release_version	1.54.0-SNAPSHOT~6c26663efe	1.54.0-SNAPSHOT~6a92882fae

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1759339624	1759339624
ci_job_id	1158033529	1158033529
ci_pipeline_id	78105188	78105188
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-xbjjjaai 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-xbjjjaai 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling:high_load	better [-4.854ms; -3.903ms] or [-9.636%; -7.748%]	unstable [+1.789op/s; +15.861op/s] or [+1.925%; +17.074%]	45.999ms	101.725op/s	50.377ms	92.900op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~6a92882fae, baseline=1.54.0-SNAPSHOT~6c26663efe
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.609 ms) : 36320, 36899
.   : milestone, 36609,
appsec (49.079 ms) : 48657, 49500
.   : milestone, 49079,
code_origins (43.903 ms) : 43523, 44283
.   : milestone, 43903,
iast (45.67 ms) : 45284, 46056
.   : milestone, 45670,
profiling (50.377 ms) : 49890, 50864
.   : milestone, 50377,
tracing (44.888 ms) : 44507, 45269
.   : milestone, 44888,
section candidate
no_agent (36.289 ms) : 35994, 36584
.   : milestone, 36289,
appsec (48.965 ms) : 48529, 49401
.   : milestone, 48965,
code_origins (45.103 ms) : 44717, 45488
.   : milestone, 45103,
iast (44.662 ms) : 44294, 45029
.   : milestone, 44662,
profiling (45.999 ms) : 45606, 46391
.   : milestone, 45999,
tracing (45.85 ms) : 45459, 46241
.   : milestone, 45850,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.609 ms [36.32 ms, 36.899 ms]	-
appsec	49.079 ms [48.657 ms, 49.5 ms]	12.469 ms (34.1%)
code_origins	43.903 ms [43.523 ms, 44.283 ms]	7.294 ms (19.9%)
iast	45.67 ms [45.284 ms, 46.056 ms]	9.061 ms (24.7%)
profiling	50.377 ms [49.89 ms, 50.864 ms]	13.768 ms (37.6%)
tracing	44.888 ms [44.507 ms, 45.269 ms]	8.278 ms (22.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.289 ms [35.994 ms, 36.584 ms]	-
appsec	48.965 ms [48.529 ms, 49.401 ms]	12.676 ms (34.9%)
code_origins	45.103 ms [44.717 ms, 45.488 ms]	8.814 ms (24.3%)
iast	44.662 ms [44.294 ms, 45.029 ms]	8.373 ms (23.1%)
profiling	45.999 ms [45.606 ms, 46.391 ms]	9.71 ms (26.8%)
tracing	45.85 ms [45.459 ms, 46.241 ms]	9.561 ms (26.3%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~6a92882fae, baseline=1.54.0-SNAPSHOT~6c26663efe
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.37 ms) : 4314, 4426
.   : milestone, 4370,
iast (9.779 ms) : 9614, 9944
.   : milestone, 9779,
iast_FULL (15.219 ms) : 14913, 15525
.   : milestone, 15219,
iast_GLOBAL (10.95 ms) : 10758, 11142
.   : milestone, 10950,
profiling (9.344 ms) : 9184, 9504
.   : milestone, 9344,
tracing (7.947 ms) : 7825, 8069
.   : milestone, 7947,
section candidate
no_agent (4.469 ms) : 4417, 4522
.   : milestone, 4469,
iast (10.003 ms) : 9831, 10175
.   : milestone, 10003,
iast_FULL (14.882 ms) : 14587, 15176
.   : milestone, 14882,
iast_GLOBAL (10.676 ms) : 10482, 10870
.   : milestone, 10676,
profiling (9.289 ms) : 9130, 9448
.   : milestone, 9289,
tracing (7.91 ms) : 7799, 8022
.   : milestone, 7910,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.37 ms [4.314 ms, 4.426 ms]	-
iast	9.779 ms [9.614 ms, 9.944 ms]	5.409 ms (123.8%)
iast_FULL	15.219 ms [14.913 ms, 15.525 ms]	10.849 ms (248.3%)
iast_GLOBAL	10.95 ms [10.758 ms, 11.142 ms]	6.58 ms (150.6%)
profiling	9.344 ms [9.184 ms, 9.504 ms]	4.974 ms (113.8%)
tracing	7.947 ms [7.825 ms, 8.069 ms]	3.577 ms (81.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.469 ms [4.417 ms, 4.522 ms]	-
iast	10.003 ms [9.831 ms, 10.175 ms]	5.534 ms (123.8%)
iast_FULL	14.882 ms [14.587 ms, 15.176 ms]	10.412 ms (233.0%)
iast_GLOBAL	10.676 ms [10.482 ms, 10.87 ms]	6.206 ms (138.9%)
profiling	9.289 ms [9.13 ms, 9.448 ms]	4.82 ms (107.8%)
tracing	7.91 ms [7.799 ms, 8.022 ms]	3.441 ms (77.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/debug-dump-logic
git_commit_date	1759335243	1759337909
git_commit_sha	`6c26663`	`6a92882`
release_version	1.54.0-SNAPSHOT~6c26663efe	1.54.0-SNAPSHOT~6a92882fae

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1759340200	1759340200
ci_job_id	1158033532	1158033532
ci_pipeline_id	78105188	78105188
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-0dq86cle 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-0dq86cle 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~6a92882fae, baseline=1.54.0-SNAPSHOT~6c26663efe
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.763 s) : 14763000, 14763000
.   : milestone, 14763000,
appsec (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
iast (18.935 s) : 18935000, 18935000
.   : milestone, 18935000,
iast_GLOBAL (18.125 s) : 18125000, 18125000
.   : milestone, 18125000,
profiling (15.362 s) : 15362000, 15362000
.   : milestone, 15362000,
tracing (15.14 s) : 15140000, 15140000
.   : milestone, 15140000,
section candidate
no_agent (15.683 s) : 15683000, 15683000
.   : milestone, 15683000,
appsec (15.49 s) : 15490000, 15490000
.   : milestone, 15490000,
iast (18.293 s) : 18293000, 18293000
.   : milestone, 18293000,
iast_GLOBAL (18.063 s) : 18063000, 18063000
.   : milestone, 18063000,
profiling (15.215 s) : 15215000, 15215000
.   : milestone, 15215000,
tracing (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.763 s [14.763 s, 14.763 s]	-
appsec	15.002 s [15.002 s, 15.002 s]	239.0 ms (1.6%)
iast	18.935 s [18.935 s, 18.935 s]	4.172 s (28.3%)
iast_GLOBAL	18.125 s [18.125 s, 18.125 s]	3.362 s (22.8%)
profiling	15.362 s [15.362 s, 15.362 s]	599.0 ms (4.1%)
tracing	15.14 s [15.14 s, 15.14 s]	377.0 ms (2.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.683 s [15.683 s, 15.683 s]	-
appsec	15.49 s [15.49 s, 15.49 s]	-193.0 ms (-1.2%)
iast	18.293 s [18.293 s, 18.293 s]	2.61 s (16.6%)
iast_GLOBAL	18.063 s [18.063 s, 18.063 s]	2.38 s (15.2%)
profiling	15.215 s [15.215 s, 15.215 s]	-468.0 ms (-3.0%)
tracing	15.014 s [15.014 s, 15.014 s]	-669.0 ms (-4.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~6a92882fae, baseline=1.54.0-SNAPSHOT~6c26663efe
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.683 ms) : 3465, 3902
.   : milestone, 3683,
iast (2.208 ms) : 2145, 2271
.   : milestone, 2208,
iast_GLOBAL (2.246 ms) : 2183, 2310
.   : milestone, 2246,
profiling (2.077 ms) : 2025, 2129
.   : milestone, 2077,
tracing (2.023 ms) : 1974, 2072
.   : milestone, 2023,
section candidate
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (3.724 ms) : 3506, 3943
.   : milestone, 3724,
iast (2.208 ms) : 2145, 2271
.   : milestone, 2208,
iast_GLOBAL (2.251 ms) : 2187, 2314
.   : milestone, 2251,
profiling (2.051 ms) : 2000, 2102
.   : milestone, 2051,
tracing (2.012 ms) : 1963, 2061
.   : milestone, 2012,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.683 ms [3.465 ms, 3.902 ms]	2.208 ms (149.6%)
iast	2.208 ms [2.145 ms, 2.271 ms]	732.404 µs (49.6%)
iast_GLOBAL	2.246 ms [2.183 ms, 2.31 ms]	770.564 µs (52.2%)
profiling	2.077 ms [2.025 ms, 2.129 ms]	601.239 µs (40.7%)
tracing	2.023 ms [1.974 ms, 2.072 ms]	547.142 µs (37.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.466 ms, 1.489 ms]	-
appsec	3.724 ms [3.506 ms, 3.943 ms]	2.247 ms (152.1%)
iast	2.208 ms [2.145 ms, 2.271 ms]	730.911 µs (49.5%)
iast_GLOBAL	2.251 ms [2.187 ms, 2.314 ms]	773.55 µs (52.4%)
profiling	2.051 ms [2.0 ms, 2.102 ms]	573.959 µs (38.9%)
tracing	2.012 ms [1.963 ms, 2.061 ms]	534.831 µs (36.2%)

gradle/dump_hanging_test.gradle

bric3

Looks good on my end, some polish and nitpicks though. Nice work :)

buildSrc/src/main/kotlin/datadog/gradle/plugin/dump/DumpHangedTestPlugin.kt

ygree

Nice!

bric3

Cool! Thanks for the improvement.

buildSrc/src/main/kotlin/datadog/gradle/plugin/dump/DumpHangedTestPlugin.kt

AlexeyKuznetsov-DD added 10 commits September 23, 2025 13:11

Debug dump cancellation logic.

53f8800

Debug dump cancellation logic.

88ceeb6

Debug dump cancellation logic.

623bfcf

WIP 4.

421ef58

WIP 5.

ac925ba

WIP 6.

03d94c5

Merge branch 'master' into alexeyk/debug-dump-logic

f517caf

WIP 7.

8417a81

WIP 8.

f15d8b2

WIP 9.

6806086

AlexeyKuznetsov-DD self-assigned this Sep 24, 2025

AlexeyKuznetsov-DD added type: bug Bug report and fix comp: testing Testing tag: no release notes Changes to exclude from release notes labels Sep 24, 2025

AlexeyKuznetsov-DD marked this pull request as ready for review September 24, 2025 18:01

AlexeyKuznetsov-DD requested a review from a team as a code owner September 24, 2025 18:01

AlexeyKuznetsov-DD requested a review from ygree September 24, 2025 18:01

Merge branch 'master' into alexeyk/debug-dump-logic

2aab088

AlexeyKuznetsov-DD requested review from PerfectSlayer, bric3 and sarahchen6 September 24, 2025 18:16

sarahchen6 reviewed Sep 24, 2025

View reviewed changes

gradle/dump_hanging_test.gradle Outdated Show resolved Hide resolved

sarahchen6 approved these changes Sep 24, 2025

View reviewed changes

AlexeyKuznetsov-DD added 2 commits September 24, 2025 15:42

Merge branch 'master' into alexeyk/debug-dump-logic

d6a1e75

WIP 10.

383fc15

AlexeyKuznetsov-DD requested a review from sarahchen6 September 25, 2025 00:50

bric3 reviewed Sep 25, 2025

View reviewed changes

gradle/dump_hanging_test.gradle Outdated Show resolved Hide resolved

gradle/dump_hanging_test.gradle Outdated Show resolved Hide resolved

gradle/dump_hanging_test.gradle Outdated Show resolved Hide resolved

Merge branch 'master' into alexeyk/debug-dump-logic

274c614

Refactored to Kotlin plugin

370d08e

AlexeyKuznetsov-DD requested a review from bric3 September 25, 2025 22:14

AlexeyKuznetsov-DD added 2 commits September 25, 2025 21:21

Merge branch 'master' into alexeyk/debug-dump-logic

4132ac3

Refactored to use Gradle lifecycle.

cd4d8d3

bric3 reviewed Sep 26, 2025

View reviewed changes

AlexeyKuznetsov-DD added 2 commits September 26, 2025 08:45

Merge branch 'master' into alexeyk/debug-dump-logic

424563b

Applied review comments and covered with tests.

059ce54

AlexeyKuznetsov-DD requested a review from bric3 September 26, 2025 20:00

ygree approved these changes Sep 29, 2025

View reviewed changes

bric3 approved these changes Oct 1, 2025

View reviewed changes

buildSrc/src/main/kotlin/datadog/gradle/plugin/dump/DumpHangedTestPlugin.kt Outdated Show resolved Hide resolved

AlexeyKuznetsov-DD added 2 commits October 1, 2025 10:49

Fixed review notes.

e1ce1f1

Merge branch 'master' into alexeyk/debug-dump-logic

6a92882

AlexeyKuznetsov-DD merged commit c096994 into master Oct 1, 2025
534 checks passed

AlexeyKuznetsov-DD deleted the alexeyk/debug-dump-logic branch October 1, 2025 17:53

github-actions bot added this to the 1.54.0 milestone Oct 1, 2025

Fixed race condition on dumping future cleanup. #9607

Fixed race condition on dumping future cleanup. #9607

Uh oh!

Conversation

AlexeyKuznetsov-DD commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

datadog-official bot commented Sep 24, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ygree left a comment

Choose a reason for hiding this comment

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AlexeyKuznetsov-DD commented Sep 24, 2025 •

edited

Loading

datadog-official bot commented Sep 24, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Sep 24, 2025 •

edited

Loading