Skip to content

Simplify type outlines to not implement type.getDeclaringType() and type.getEnclosingType() #9644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcculls merged 2 commits into from
Oct 2, 2025
Merged

Simplify type outlines to not implement type.getDeclaringType() and type.getEnclosingType() #9644

mcculls merged 2 commits into from
Oct 2, 2025

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 1, 2025 •
edited
Loading

Motivation

These methods are not used for matching purposes, so don't need to be maintained in outlines.

There is one use of type.isAnonymousType() in IAST, but this is under a support flag - I could not find any active use of that support flag. To satisfy the original use-case (involving MyBatis) we add a simple anonymous type heuristic to that particular instrumentation, based on the '$number' Java language convention for anonymous class names.

( If necessary we can further enhance that specialized matcher without incurring overhead for all outline parsing )

Note: if anything does touch type.getDeclaringType() / type.getEnclosingType() later on when doing the final transformation then the outline type is automatically inflated to a full type. (This is already the case for other methods that aren't available in type outlines.)

We also drop type.getClassFileVersion() from outlines for the same reason.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Oct 1, 2025
@datadog-official
Copy link

datadog-official bot commented Oct 1, 2025 •
edited by datadog-datadog-prod-us1 bot
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 63.42%

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8f62fe5 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-type-outlines
git_commit_date 1759351021 1759351383
git_commit_sha e814315 8f62fe5
release_version 1.54.0-SNAPSHOT~e814315ae4 1.54.0-SNAPSHOT~8f62fe5b71
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759353150 1759353150
ci_job_id 1158613318 1158613318
ci_pipeline_id 78134968 78134968
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-pn7gkkim 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-pn7gkkim 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~8f62fe5b71, baseline=1.54.0-SNAPSHOT~e814315ae4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.01 s) : 0, 1009608
Total [baseline] (8.687 s) : 0, 8687148
Agent [candidate] (1.01 s) : 0, 1010462
Total [candidate] (8.66 s) : 0, 8660082
section iast
Agent [baseline] (1.144 s) : 0, 1144363
Total [baseline] (9.26 s) : 0, 9259894
Agent [candidate] (1.144 s) : 0, 1144378
Total [candidate] (9.215 s) : 0, 9214870
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.01 s -
Agent iast 1.144 s 134.755 ms (13.3%)
Total tracing 8.687 s -
Total iast 9.26 s 572.746 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.01 s -
Agent iast 1.144 s 133.916 ms (13.3%)
Total tracing 8.66 s -
Total iast 9.215 s 554.788 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~8f62fe5b71, baseline=1.54.0-SNAPSHOT~e814315ae4

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (691.685 ms) : 0, 691685
BytebuddyAgent [candidate] (690.722 ms) : 0, 690722
GlobalTracer [baseline] (237.192 ms) : 0, 237192
GlobalTracer [candidate] (237.054 ms) : 0, 237054
AppSec [baseline] (33.001 ms) : 0, 33001
AppSec [candidate] (32.844 ms) : 0, 32844
Debugger [baseline] (6.414 ms) : 0, 6414
Debugger [candidate] (6.367 ms) : 0, 6367
Remote Config [baseline] (687.485 µs) : 0, 687
Remote Config [candidate] (672.056 µs) : 0, 672
Telemetry [baseline] (9.173 ms) : 0, 9173
Telemetry [candidate] (9.073 ms) : 0, 9073
Flare Poller [baseline] (8.792 ms) : 0, 8792
Flare Poller [candidate] (10.992 ms) : 0, 10992
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (813.129 ms) : 0, 813129
BytebuddyAgent [candidate] (813.244 ms) : 0, 813244
GlobalTracer [baseline] (227.51 ms) : 0, 227510
GlobalTracer [candidate] (227.662 ms) : 0, 227662
IAST [baseline] (26.454 ms) : 0, 26454
IAST [candidate] (26.444 ms) : 0, 26444
AppSec [baseline] (35.35 ms) : 0, 35350
AppSec [candidate] (35.194 ms) : 0, 35194
Debugger [baseline] (6.068 ms) : 0, 6068
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (590.214 µs) : 0, 590
Remote Config [candidate] (585.657 µs) : 0, 586
Telemetry [baseline] (8.316 ms) : 0, 8316
Telemetry [candidate] (8.217 ms) : 0, 8217
Flare Poller [baseline] (4.242 ms) : 0, 4242
Flare Poller [candidate] (4.329 ms) : 0, 4329
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~8f62fe5b71, baseline=1.54.0-SNAPSHOT~e814315ae4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.011 s) : 0, 1011106
Total [baseline] (10.653 s) : 0, 10652578
Agent [candidate] (1.011 s) : 0, 1011253
Total [candidate] (10.766 s) : 0, 10766267
section appsec
Agent [baseline] (1.186 s) : 0, 1186456
Total [baseline] (11.012 s) : 0, 11012440
Agent [candidate] (1.188 s) : 0, 1188271
Total [candidate] (11.082 s) : 0, 11082053
section iast
Agent [baseline] (1.145 s) : 0, 1145178
Total [baseline] (11.007 s) : 0, 11007291
Agent [candidate] (1.151 s) : 0, 1150612
Total [candidate] (10.988 s) : 0, 10988275
section profiling
Agent [baseline] (1.156 s) : 0, 1156108
Total [baseline] (11.05 s) : 0, 11049537
Agent [candidate] (1.156 s) : 0, 1156036
Total [candidate] (11.082 s) : 0, 11081803
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.011 s -
Agent appsec 1.186 s 175.351 ms (17.3%)
Agent iast 1.145 s 134.073 ms (13.3%)
Agent profiling 1.156 s 145.003 ms (14.3%)
Total tracing 10.653 s -
Total appsec 11.012 s 359.862 ms (3.4%)
Total iast 11.007 s 354.713 ms (3.3%)
Total profiling 11.05 s 396.959 ms (3.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.011 s -
Agent appsec 1.188 s 177.018 ms (17.5%)
Agent iast 1.151 s 139.359 ms (13.8%)
Agent profiling 1.156 s 144.782 ms (14.3%)
Total tracing 10.766 s -
Total appsec 11.082 s 315.785 ms (2.9%)
Total iast 10.988 s 222.008 ms (2.1%)
Total profiling 11.082 s 315.536 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~8f62fe5b71, baseline=1.54.0-SNAPSHOT~e814315ae4

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (692.234 ms) : 0, 692234
BytebuddyAgent [candidate] (691.029 ms) : 0, 691029
GlobalTracer [baseline] (237.442 ms) : 0, 237442
GlobalTracer [candidate] (238.308 ms) : 0, 238308
AppSec [baseline] (32.995 ms) : 0, 32995
AppSec [candidate] (33.427 ms) : 0, 33427
Debugger [baseline] (6.407 ms) : 0, 6407
Debugger [candidate] (6.447 ms) : 0, 6447
Remote Config [baseline] (687.365 µs) : 0, 687
Remote Config [candidate] (698.492 µs) : 0, 698
Telemetry [baseline] (9.188 ms) : 0, 9188
Telemetry [candidate] (9.035 ms) : 0, 9035
Flare Poller [baseline] (9.449 ms) : 0, 9449
Flare Poller [candidate] (9.568 ms) : 0, 9568
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (714.448 ms) : 0, 714448
BytebuddyAgent [candidate] (717.522 ms) : 0, 717522
GlobalTracer [baseline] (229.36 ms) : 0, 229360
GlobalTracer [candidate] (229.07 ms) : 0, 229070
IAST [baseline] (25.226 ms) : 0, 25226
IAST [candidate] (25.154 ms) : 0, 25154
AppSec [baseline] (172.502 ms) : 0, 172502
AppSec [candidate] (174.18 ms) : 0, 174180
Debugger [baseline] (6.137 ms) : 0, 6137
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (642.993 µs) : 0, 643
Remote Config [candidate] (665.717 µs) : 0, 666
Telemetry [baseline] (9.956 ms) : 0, 9956
Telemetry [candidate] (9.008 ms) : 0, 9008
Flare Poller [baseline] (5.6 ms) : 0, 5600
Flare Poller [candidate] (3.977 ms) : 0, 3977
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (813.187 ms) : 0, 813187
BytebuddyAgent [candidate] (818.42 ms) : 0, 818420
GlobalTracer [baseline] (228.169 ms) : 0, 228169
GlobalTracer [candidate] (228.717 ms) : 0, 228717
IAST [baseline] (26.539 ms) : 0, 26539
IAST [candidate] (26.474 ms) : 0, 26474
AppSec [baseline] (35.413 ms) : 0, 35413
AppSec [candidate] (35.058 ms) : 0, 35058
Debugger [baseline] (6.044 ms) : 0, 6044
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (600.355 µs) : 0, 600
Remote Config [candidate] (583.821 µs) : 0, 584
Telemetry [baseline] (8.242 ms) : 0, 8242
Telemetry [candidate] (8.201 ms) : 0, 8201
Flare Poller [baseline] (4.283 ms) : 0, 4283
Flare Poller [candidate] (4.328 ms) : 0, 4328
section profiling
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (720.162 ms) : 0, 720162
BytebuddyAgent [candidate] (720.261 ms) : 0, 720261
GlobalTracer [baseline] (213.459 ms) : 0, 213459
GlobalTracer [candidate] (213.423 ms) : 0, 213423
AppSec [baseline] (32.764 ms) : 0, 32764
AppSec [candidate] (32.478 ms) : 0, 32478
Debugger [baseline] (6.544 ms) : 0, 6544
Debugger [candidate] (7.324 ms) : 0, 7324
Remote Config [baseline] (836.522 µs) : 0, 837
Remote Config [candidate] (769.653 µs) : 0, 770
Telemetry [baseline] (15.621 ms) : 0, 15621
Telemetry [candidate] (15.795 ms) : 0, 15795
Flare Poller [baseline] (5.041 ms) : 0, 5041
Flare Poller [candidate] (4.226 ms) : 0, 4226
ProfilingAgent [baseline] (105.575 ms) : 0, 105575
ProfilingAgent [candidate] (104.681 ms) : 0, 104681
Profiling [baseline] (108.282 ms) : 0, 108282
Profiling [candidate] (108.015 ms) : 0, 108015
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-type-outlines
git_commit_date 1759351021 1759351383
git_commit_sha e814315 8f62fe5
release_version 1.54.0-SNAPSHOT~e814315ae4 1.54.0-SNAPSHOT~8f62fe5b71
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759352905 1759352905
ci_job_id 1158613319 1158613319
ci_pipeline_id 78134968 78134968
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-u0qbaykr 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-u0qbaykr 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load better
[-239.361µs; -130.326µs] or [-5.251%; -2.859%]		 unstable
[-86.013op/s; +169.075op/s] or [-8.537%; +16.781%]		 4.374ms 1049.062op/s 4.559ms 1007.531op/s
scenario:load:insecure-bank:tracing:high_load better
[-429.551µs; -185.540µs] or [-5.431%; -2.346%]		 unstable
[-55.307op/s; +102.182op/s] or [-9.444%; +17.447%]		 7.602ms 609.094op/s 7.910ms 585.656op/s
scenario:load:petclinic:tracing:high_load worse
[+1.518ms; +2.332ms] or [+3.530%; +5.424%]		 unstable
[-12.058op/s; +2.808op/s] or [-11.084%; +2.581%]		 44.920ms 104.162op/s 42.995ms 108.787op/s
scenario:load:petclinic:profiling:high_load worse
[+1.237ms; +2.285ms] or [+2.491%; +4.600%]		 unstable
[-9.828op/s; +3.428op/s] or [-10.433%; +3.639%]		 51.434ms 91.000op/s 49.673ms 94.200op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~8f62fe5b71, baseline=1.54.0-SNAPSHOT~e814315ae4
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.559 ms) : 4507, 4611
.   : milestone, 4559,
iast (9.951 ms) : 9785, 10117
.   : milestone, 9951,
iast_FULL (14.153 ms) : 13873, 14433
.   : milestone, 14153,
iast_GLOBAL (10.686 ms) : 10490, 10883
.   : milestone, 10686,
profiling (9.146 ms) : 8996, 9295
.   : milestone, 9146,
tracing (7.91 ms) : 7795, 8025
.   : milestone, 7910,
section candidate
no_agent (4.374 ms) : 4325, 4423
.   : milestone, 4374,
iast (9.97 ms) : 9804, 10136
.   : milestone, 9970,
iast_FULL (14.16 ms) : 13875, 14446
.   : milestone, 14160,
iast_GLOBAL (11.107 ms) : 10906, 11308
.   : milestone, 11107,
profiling (9.274 ms) : 9120, 9428
.   : milestone, 9274,
tracing (7.602 ms) : 7490, 7714
.   : milestone, 7602,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.559 ms [4.507 ms, 4.611 ms] -
iast 9.951 ms [9.785 ms, 10.117 ms] 5.393 ms (118.3%)
iast_FULL 14.153 ms [13.873 ms, 14.433 ms] 9.594 ms (210.5%)
iast_GLOBAL 10.686 ms [10.49 ms, 10.883 ms] 6.128 ms (134.4%)
profiling 9.146 ms [8.996 ms, 9.295 ms] 4.587 ms (100.6%)
tracing 7.91 ms [7.795 ms, 8.025 ms] 3.351 ms (73.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.374 ms [4.325 ms, 4.423 ms] -
iast 9.97 ms [9.804 ms, 10.136 ms] 5.596 ms (127.9%)
iast_FULL 14.16 ms [13.875 ms, 14.446 ms] 9.787 ms (223.8%)
iast_GLOBAL 11.107 ms [10.906 ms, 11.308 ms] 6.733 ms (153.9%)
profiling 9.274 ms [9.12 ms, 9.428 ms] 4.9 ms (112.0%)
tracing 7.602 ms [7.49 ms, 7.714 ms] 3.228 ms (73.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~8f62fe5b71, baseline=1.54.0-SNAPSHOT~e814315ae4
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.697 ms) : 36398, 36996
.   : milestone, 36697,
appsec (49.353 ms) : 48938, 49769
.   : milestone, 49353,
code_origins (44.248 ms) : 43876, 44620
.   : milestone, 44248,
iast (45.496 ms) : 45108, 45884
.   : milestone, 45496,
profiling (49.673 ms) : 49210, 50136
.   : milestone, 49673,
tracing (42.995 ms) : 42634, 43356
.   : milestone, 42995,
section candidate
no_agent (37.188 ms) : 36898, 37479
.   : milestone, 37188,
appsec (49.959 ms) : 49516, 50402
.   : milestone, 49959,
code_origins (45.207 ms) : 44797, 45616
.   : milestone, 45207,
iast (45.655 ms) : 45266, 46045
.   : milestone, 45655,
profiling (51.434 ms) : 50925, 51943
.   : milestone, 51434,
tracing (44.92 ms) : 44525, 45315
.   : milestone, 44920,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.697 ms [36.398 ms, 36.996 ms] -
appsec 49.353 ms [48.938 ms, 49.769 ms] 12.656 ms (34.5%)
code_origins 44.248 ms [43.876 ms, 44.62 ms] 7.551 ms (20.6%)
iast 45.496 ms [45.108 ms, 45.884 ms] 8.798 ms (24.0%)
profiling 49.673 ms [49.21 ms, 50.136 ms] 12.976 ms (35.4%)
tracing 42.995 ms [42.634 ms, 43.356 ms] 6.298 ms (17.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.188 ms [36.898 ms, 37.479 ms] -
appsec 49.959 ms [49.516 ms, 50.402 ms] 12.77 ms (34.3%)
code_origins 45.207 ms [44.797 ms, 45.616 ms] 8.019 ms (21.6%)
iast 45.655 ms [45.266 ms, 46.045 ms] 8.467 ms (22.8%)
profiling 51.434 ms [50.925 ms, 51.943 ms] 14.246 ms (38.3%)
tracing 44.92 ms [44.525 ms, 45.315 ms] 7.732 ms (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-type-outlines
git_commit_date 1759351021 1759351383
git_commit_sha e814315 8f62fe5
release_version 1.54.0-SNAPSHOT~e814315ae4 1.54.0-SNAPSHOT~8f62fe5b71
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1759353440 1759353440
ci_job_id 1158613320 1158613320
ci_pipeline_id 78134968 78134968
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-45qnjr30 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-45qnjr30 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~8f62fe5b71, baseline=1.54.0-SNAPSHOT~e814315ae4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (3.638 ms) : 3425, 3850
.   : milestone, 3638,
iast (2.211 ms) : 2147, 2274
.   : milestone, 2211,
iast_GLOBAL (2.246 ms) : 2182, 2310
.   : milestone, 2246,
profiling (2.497 ms) : 2330, 2664
.   : milestone, 2497,
tracing (2.019 ms) : 1970, 2068
.   : milestone, 2019,
section candidate
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (3.665 ms) : 3452, 3877
.   : milestone, 3665,
iast (2.205 ms) : 2142, 2268
.   : milestone, 2205,
iast_GLOBAL (2.249 ms) : 2186, 2313
.   : milestone, 2249,
profiling (2.067 ms) : 2014, 2120
.   : milestone, 2067,
tracing (2.017 ms) : 1968, 2066
.   : milestone, 2017,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 3.638 ms [3.425 ms, 3.85 ms] 2.16 ms (146.2%)
iast 2.211 ms [2.147 ms, 2.274 ms] 733.18 µs (49.6%)
iast_GLOBAL 2.246 ms [2.182 ms, 2.31 ms] 768.661 µs (52.0%)
profiling 2.497 ms [2.33 ms, 2.664 ms] 1.02 ms (69.0%)
tracing 2.019 ms [1.97 ms, 2.068 ms] 541.287 µs (36.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 3.665 ms [3.452 ms, 3.877 ms] 2.187 ms (148.0%)
iast 2.205 ms [2.142 ms, 2.268 ms] 727.583 µs (49.2%)
iast_GLOBAL 2.249 ms [2.186 ms, 2.313 ms] 771.885 µs (52.2%)
profiling 2.067 ms [2.014 ms, 2.12 ms] 589.503 µs (39.9%)
tracing 2.017 ms [1.968 ms, 2.066 ms] 539.76 µs (36.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~8f62fe5b71, baseline=1.54.0-SNAPSHOT~e814315ae4
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.021 s) : 15021000, 15021000
.   : milestone, 15021000,
appsec (15.041 s) : 15041000, 15041000
.   : milestone, 15041000,
iast (18.257 s) : 18257000, 18257000
.   : milestone, 18257000,
iast_GLOBAL (17.92 s) : 17920000, 17920000
.   : milestone, 17920000,
profiling (15.207 s) : 15207000, 15207000
.   : milestone, 15207000,
tracing (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
section candidate
no_agent (15.189 s) : 15189000, 15189000
.   : milestone, 15189000,
appsec (15.066 s) : 15066000, 15066000
.   : milestone, 15066000,
iast (18.745 s) : 18745000, 18745000
.   : milestone, 18745000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
.   : milestone, 18003000,
profiling (15.513 s) : 15513000, 15513000
.   : milestone, 15513000,
tracing (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.021 s [15.021 s, 15.021 s] -
appsec 15.041 s [15.041 s, 15.041 s] 20.0 ms (0.1%)
iast 18.257 s [18.257 s, 18.257 s] 3.236 s (21.5%)
iast_GLOBAL 17.92 s [17.92 s, 17.92 s] 2.899 s (19.3%)
profiling 15.207 s [15.207 s, 15.207 s] 186.0 ms (1.2%)
tracing 15.114 s [15.114 s, 15.114 s] 93.0 ms (0.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.189 s [15.189 s, 15.189 s] -
appsec 15.066 s [15.066 s, 15.066 s] -123.0 ms (-0.8%)
iast 18.745 s [18.745 s, 18.745 s] 3.556 s (23.4%)
iast_GLOBAL 18.003 s [18.003 s, 18.003 s] 2.814 s (18.5%)
profiling 15.513 s [15.513 s, 15.513 s] 324.0 ms (2.1%)
tracing 15.166 s [15.166 s, 15.166 s] -23.0 ms (-0.2%)

@mcculls mcculls marked this pull request as ready for review October 1, 2025 15:25
@mcculls mcculls requested a review from a team as a code owner October 1, 2025 15:25
@mcculls mcculls force-pushed the mcculls/simplify-type-outlines branch from 4626764 to 37116b5 Compare October 1, 2025 18:07
@mcculls mcculls requested a review from a team as a code owner October 1, 2025 18:07
@mcculls mcculls requested review from jandro996 and smola October 1, 2025 18:07
@mcculls mcculls force-pushed the mcculls/simplify-type-outlines branch 2 times, most recently from 163cb99 to d2b5d1d Compare October 1, 2025 18:42
mcculls added 2 commits October 1, 2025 21:42
@mcculls
Simplify type outlines to not implement type.getDeclaringType() and t…
2f91337 
…ype.getEnclosingType()

These methods are not used for matching purposes, so don't need to be maintained in outlines.
There is one use of type.isAnonymousType() in IAST, but this use is under a feature flag that
is off by default. To satisfy that use we provide a simple isAnonymousType() implementation
which is based on the '$number' convention for anonymous class names.

Note: if anything does touch type.getDeclaringType() / type.getEnclosingType() later on when
doing the final transformation then the outline type is automatically inflated to a full type.
(This is already the case for other methods that aren't available in type outlines.)

We also drop type.getClassFileVersion() from outlines for the same reason.
@mcculls
Move isAnonymousType check to the only place that uses it: IastInstru…
8f62fe5 
…mentation
@mcculls mcculls force-pushed the mcculls/simplify-type-outlines branch from d2b5d1d to 8f62fe5 Compare October 1, 2025 20:43
PerfectSlayer
PerfectSlayer approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Nice clean up. The less features there are, the less you would have to port to the new instrument library 😄

@mcculls mcculls merged commit 713a41a into master Oct 2, 2025
534 checks passed
@mcculls mcculls deleted the mcculls/simplify-type-outlines branch October 2, 2025 13:49
@github-actions github-actions bot added this to the 1.54.0 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali Awaiting requested review from amarziali

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mcculls @bric3 @PerfectSlayer