Extract Spark Plan "simpleString" into traces#9645
Conversation
| import scala.collection.JavaConverters; | ||
|
|
||
| public class SparkSQLUtils { | ||
| private static final Logger log = LoggerFactory.getLogger(SparkSQLUtils.class); |
There was a problem hiding this comment.
This doesn't seem to be used anywhere?
There was a problem hiding this comment.
Ah, snuck in from up the stack - fixed! bbc21f9 (#9645)
There was a problem hiding this comment.
FYI, just rebased a bit to clean the commits up a little and squish things together so that commit will no longer exist but this has been fixed!
|
🎯 Code Coverage 🔗 Commit SHA: afc6103 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 6 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 7 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~afc6103109, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1012211
Total [baseline] (10.699 s) : 0, 10698718
Agent [candidate] (1.006 s) : 0, 1006469
Total [candidate] (10.677 s) : 0, 10677389
section appsec
Agent [baseline] (1.189 s) : 0, 1189144
Total [baseline] (11.094 s) : 0, 11094490
Agent [candidate] (1.184 s) : 0, 1184284
Total [candidate] (11.058 s) : 0, 11058295
section iast
Agent [baseline] (1.142 s) : 0, 1142195
Total [baseline] (10.887 s) : 0, 10887177
Agent [candidate] (1.14 s) : 0, 1139984
Total [candidate] (10.85 s) : 0, 10849780
section profiling
Agent [baseline] (1.164 s) : 0, 1164278
Total [baseline] (11.061 s) : 0, 11061425
Agent [candidate] (1.148 s) : 0, 1148268
Total [candidate] (11.035 s) : 0, 11034504
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~afc6103109, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (692.196 ms) : 0, 692196
BytebuddyAgent [candidate] (689.364 ms) : 0, 689364
GlobalTracer [baseline] (237.268 ms) : 0, 237268
GlobalTracer [candidate] (237.269 ms) : 0, 237269
AppSec [baseline] (33.023 ms) : 0, 33023
AppSec [candidate] (31.507 ms) : 0, 31507
Debugger [baseline] (6.416 ms) : 0, 6416
Debugger [candidate] (6.317 ms) : 0, 6317
Remote Config [baseline] (678.744 µs) : 0, 679
Remote Config [candidate] (675.384 µs) : 0, 675
Telemetry [baseline] (9.044 ms) : 0, 9044
Telemetry [candidate] (9.137 ms) : 0, 9137
Flare Poller [baseline] (10.85 ms) : 0, 10850
Flare Poller [candidate] (9.5 ms) : 0, 9500
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (716.848 ms) : 0, 716848
BytebuddyAgent [candidate] (714.674 ms) : 0, 714674
GlobalTracer [baseline] (229.817 ms) : 0, 229817
GlobalTracer [candidate] (228.835 ms) : 0, 228835
IAST [baseline] (25.189 ms) : 0, 25189
IAST [candidate] (25.029 ms) : 0, 25029
AppSec [baseline] (174.819 ms) : 0, 174819
AppSec [candidate] (173.042 ms) : 0, 173042
Debugger [baseline] (6.104 ms) : 0, 6104
Debugger [candidate] (6.149 ms) : 0, 6149
Remote Config [baseline] (644.918 µs) : 0, 645
Remote Config [candidate] (624.658 µs) : 0, 625
Telemetry [baseline] (8.286 ms) : 0, 8286
Telemetry [candidate] (8.443 ms) : 0, 8443
Flare Poller [baseline] (4.771 ms) : 0, 4771
Flare Poller [candidate] (4.841 ms) : 0, 4841
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (812.035 ms) : 0, 812035
BytebuddyAgent [candidate] (810.996 ms) : 0, 810996
GlobalTracer [baseline] (226.726 ms) : 0, 226726
GlobalTracer [candidate] (226.898 ms) : 0, 226898
IAST [baseline] (26.426 ms) : 0, 26426
IAST [candidate] (26.646 ms) : 0, 26646
AppSec [baseline] (35.201 ms) : 0, 35201
AppSec [candidate] (33.74 ms) : 0, 33740
Debugger [baseline] (5.997 ms) : 0, 5997
Debugger [candidate] (6.027 ms) : 0, 6027
Remote Config [baseline] (616.165 µs) : 0, 616
Remote Config [candidate] (590.39 µs) : 0, 590
Telemetry [baseline] (8.102 ms) : 0, 8102
Telemetry [candidate] (8.094 ms) : 0, 8094
Flare Poller [baseline] (4.314 ms) : 0, 4314
Flare Poller [candidate] (4.236 ms) : 0, 4236
section profiling
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (726.247 ms) : 0, 726247
BytebuddyAgent [candidate] (720.687 ms) : 0, 720687
GlobalTracer [baseline] (215.032 ms) : 0, 215032
GlobalTracer [candidate] (212.808 ms) : 0, 212808
AppSec [baseline] (32.964 ms) : 0, 32964
AppSec [candidate] (31.135 ms) : 0, 31135
Debugger [baseline] (6.581 ms) : 0, 6581
Debugger [candidate] (6.431 ms) : 0, 6431
Remote Config [baseline] (858.187 µs) : 0, 858
Remote Config [candidate] (709.985 µs) : 0, 710
Telemetry [baseline] (15.533 ms) : 0, 15533
Telemetry [candidate] (16.385 ms) : 0, 16385
Flare Poller [baseline] (5.005 ms) : 0, 5005
Flare Poller [candidate] (4.27 ms) : 0, 4270
ProfilingAgent [baseline] (106.178 ms) : 0, 106178
ProfilingAgent [candidate] (101.832 ms) : 0, 101832
Profiling [baseline] (108.272 ms) : 0, 108272
Profiling [candidate] (102.436 ms) : 0, 102436
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~afc6103109, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1023638
Total [baseline] (8.646 s) : 0, 8645595
Agent [candidate] (1.014 s) : 0, 1014348
Total [candidate] (8.645 s) : 0, 8645377
section iast
Agent [baseline] (1.145 s) : 0, 1144661
Total [baseline] (9.244 s) : 0, 9244303
Agent [candidate] (1.139 s) : 0, 1139164
Total [candidate] (9.236 s) : 0, 9236339
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~afc6103109, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (699.275 ms) : 0, 699275
BytebuddyAgent [candidate] (695.501 ms) : 0, 695501
GlobalTracer [baseline] (239.743 ms) : 0, 239743
GlobalTracer [candidate] (239.161 ms) : 0, 239161
AppSec [baseline] (33.45 ms) : 0, 33450
AppSec [candidate] (31.867 ms) : 0, 31867
Debugger [baseline] (6.496 ms) : 0, 6496
Debugger [candidate] (6.375 ms) : 0, 6375
Remote Config [baseline] (697.174 µs) : 0, 697
Remote Config [candidate] (686.687 µs) : 0, 687
Telemetry [baseline] (9.208 ms) : 0, 9208
Telemetry [candidate] (9.185 ms) : 0, 9185
Flare Poller [baseline] (11.981 ms) : 0, 11981
Flare Poller [candidate] (8.778 ms) : 0, 8778
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (814.381 ms) : 0, 814381
BytebuddyAgent [candidate] (810.489 ms) : 0, 810489
GlobalTracer [baseline] (227.022 ms) : 0, 227022
GlobalTracer [candidate] (226.43 ms) : 0, 226430
IAST [baseline] (26.313 ms) : 0, 26313
IAST [candidate] (26.55 ms) : 0, 26550
AppSec [baseline] (35.233 ms) : 0, 35233
AppSec [candidate] (33.939 ms) : 0, 33939
Debugger [baseline] (6.043 ms) : 0, 6043
Debugger [candidate] (5.991 ms) : 0, 5991
Remote Config [baseline] (585.847 µs) : 0, 586
Remote Config [candidate] (587.525 µs) : 0, 588
Telemetry [baseline] (8.108 ms) : 0, 8108
Telemetry [candidate] (8.21 ms) : 0, 8210
Flare Poller [baseline] (4.246 ms) : 0, 4246
Flare Poller [candidate] (4.276 ms) : 0, 4276
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~afc6103109, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section baseline
no_agent (35.653 ms) : 35366, 35940
. : milestone, 35653,
appsec (47.131 ms) : 46730, 47531
. : milestone, 47131,
code_origins (44.203 ms) : 43837, 44570
. : milestone, 44203,
iast (46.838 ms) : 46439, 47236
. : milestone, 46838,
profiling (49.592 ms) : 49167, 50016
. : milestone, 49592,
tracing (45.787 ms) : 45394, 46180
. : milestone, 45787,
section candidate
no_agent (37.411 ms) : 37105, 37718
. : milestone, 37411,
appsec (46.131 ms) : 45744, 46518
. : milestone, 46131,
code_origins (42.88 ms) : 42506, 43254
. : milestone, 42880,
iast (45.276 ms) : 44896, 45656
. : milestone, 45276,
profiling (47.837 ms) : 47410, 48264
. : milestone, 47837,
tracing (44.513 ms) : 44134, 44892
. : milestone, 44513,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~afc6103109, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section baseline
no_agent (4.422 ms) : 4365, 4480
. : milestone, 4422,
iast (9.386 ms) : 9232, 9539
. : milestone, 9386,
iast_FULL (14.427 ms) : 14133, 14721
. : milestone, 14427,
iast_GLOBAL (11.055 ms) : 10853, 11256
. : milestone, 11055,
profiling (8.565 ms) : 8432, 8699
. : milestone, 8565,
tracing (7.745 ms) : 7635, 7856
. : milestone, 7745,
section candidate
no_agent (4.59 ms) : 4539, 4641
. : milestone, 4590,
iast (9.936 ms) : 9767, 10104
. : milestone, 9936,
iast_FULL (14.09 ms) : 13808, 14372
. : milestone, 14090,
iast_GLOBAL (10.709 ms) : 10520, 10898
. : milestone, 10709,
profiling (8.872 ms) : 8733, 9011
. : milestone, 8872,
tracing (7.902 ms) : 7789, 8016
. : milestone, 7902,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~afc6103109, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section baseline
no_agent (15.579 s) : 15579000, 15579000
. : milestone, 15579000,
appsec (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
iast (18.722 s) : 18722000, 18722000
. : milestone, 18722000,
iast_GLOBAL (17.803 s) : 17803000, 17803000
. : milestone, 17803000,
profiling (15.404 s) : 15404000, 15404000
. : milestone, 15404000,
tracing (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
section candidate
no_agent (15.554 s) : 15554000, 15554000
. : milestone, 15554000,
appsec (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
iast (18.682 s) : 18682000, 18682000
. : milestone, 18682000,
iast_GLOBAL (18.308 s) : 18308000, 18308000
. : milestone, 18308000,
profiling (15.426 s) : 15426000, 15426000
. : milestone, 15426000,
tracing (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~afc6103109, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.763 ms) : 3543, 3984
. : milestone, 3763,
iast (2.231 ms) : 2167, 2295
. : milestone, 2231,
iast_GLOBAL (2.269 ms) : 2205, 2332
. : milestone, 2269,
profiling (2.057 ms) : 2006, 2107
. : milestone, 2057,
tracing (2.037 ms) : 1987, 2086
. : milestone, 2037,
section candidate
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.736 ms) : 3517, 3955
. : milestone, 3736,
iast (2.219 ms) : 2155, 2282
. : milestone, 2219,
iast_GLOBAL (2.266 ms) : 2202, 2330
. : milestone, 2266,
profiling (2.067 ms) : 2016, 2118
. : milestone, 2067,
tracing (2.03 ms) : 1981, 2080
. : milestone, 2030,
|
bbc21f9 to
bae8145
Compare
bae8145 to
afc6103
Compare

What Does This Do
simpleStringfromSparkPlanInfoand places it into the generated JSON SQL Plan that is appended to traces asnodeDetailString_dd.spark.physical_plantag we added to the spans in a previous PRMotivation
We would like to be able to provide more details into the execution of the Spark query. The
simpleStringtypically contains a wealth of info that can help users pinpoint where exactly in their code the stage or job corresponds to. This is typically the arguments to the low-level API call (e.g. BroadcastHashJoin, Sort, MergeJoin, etc) that Spark already surfaces in the Spark UI.In a future, stacked PR we will improve this to attempt and parse the
simpleStringin known cases into a structured object.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DJM-969