-
Notifications
You must be signed in to change notification settings - Fork 323
Fix the flaky StackedOperatorsTest on CI #9648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~ca66190ab3, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047362
Total [baseline] (10.868 s) : 0, 10867617
Agent [candidate] (1.026 s) : 0, 1026466
Total [candidate] (10.801 s) : 0, 10801211
section appsec
Agent [baseline] (1.202 s) : 0, 1201838
Total [baseline] (11.015 s) : 0, 11015018
Agent [candidate] (1.212 s) : 0, 1211660
Total [candidate] (10.972 s) : 0, 10971817
section iast
Agent [baseline] (1.16 s) : 0, 1159607
Total [baseline] (11.07 s) : 0, 11069912
Agent [candidate] (1.159 s) : 0, 1159409
Total [candidate] (11.143 s) : 0, 11143134
section profiling
Agent [baseline] (1.188 s) : 0, 1188085
Total [baseline] (11.09 s) : 0, 11089658
Agent [candidate] (1.173 s) : 0, 1173229
Total [candidate] (10.958 s) : 0, 10957510
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~ca66190ab3, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.5 ms) : 0, 1500
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (715.095 ms) : 0, 715095
BytebuddyAgent [candidate] (699.863 ms) : 0, 699863
GlobalTracer [baseline] (248.803 ms) : 0, 248803
GlobalTracer [candidate] (244.218 ms) : 0, 244218
AppSec [baseline] (32.766 ms) : 0, 32766
AppSec [candidate] (32.132 ms) : 0, 32132
Debugger [baseline] (6.547 ms) : 0, 6547
Debugger [candidate] (6.372 ms) : 0, 6372
Remote Config [baseline] (692.038 µs) : 0, 692
Remote Config [candidate] (685.7 µs) : 0, 686
Telemetry [baseline] (13.869 ms) : 0, 13869
Telemetry [candidate] (12.804 ms) : 0, 12804
Flare Poller [baseline] (6.509 ms) : 0, 6509
Flare Poller [candidate] (7.789 ms) : 0, 7789
section appsec
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (725.657 ms) : 0, 725657
BytebuddyAgent [candidate] (732.17 ms) : 0, 732170
GlobalTracer [baseline] (235.75 ms) : 0, 235750
GlobalTracer [candidate] (237.436 ms) : 0, 237436
IAST [baseline] (24.837 ms) : 0, 24837
IAST [candidate] (25.279 ms) : 0, 25279
AppSec [baseline] (174.233 ms) : 0, 174233
AppSec [candidate] (175.111 ms) : 0, 175111
Debugger [baseline] (5.875 ms) : 0, 5875
Debugger [candidate] (5.926 ms) : 0, 5926
Remote Config [baseline] (625.442 µs) : 0, 625
Remote Config [candidate] (628.399 µs) : 0, 628
Telemetry [baseline] (8.351 ms) : 0, 8351
Telemetry [candidate] (8.423 ms) : 0, 8423
Flare Poller [baseline] (3.918 ms) : 0, 3918
Flare Poller [candidate] (3.902 ms) : 0, 3902
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (822.46 ms) : 0, 822460
BytebuddyAgent [candidate] (822.276 ms) : 0, 822276
GlobalTracer [baseline] (233.611 ms) : 0, 233611
GlobalTracer [candidate] (233.903 ms) : 0, 233903
IAST [baseline] (32.603 ms) : 0, 32603
IAST [candidate] (31.594 ms) : 0, 31594
AppSec [baseline] (28.769 ms) : 0, 28769
AppSec [candidate] (29.633 ms) : 0, 29633
Debugger [baseline] (6.166 ms) : 0, 6166
Debugger [candidate] (6.115 ms) : 0, 6115
Remote Config [baseline] (594.796 µs) : 0, 595
Remote Config [candidate] (593.032 µs) : 0, 593
Telemetry [baseline] (8.471 ms) : 0, 8471
Telemetry [candidate] (8.429 ms) : 0, 8429
Flare Poller [baseline] (4.152 ms) : 0, 4152
Flare Poller [candidate] (4.108 ms) : 0, 4108
section profiling
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (733.281 ms) : 0, 733281
BytebuddyAgent [candidate] (726.526 ms) : 0, 726526
GlobalTracer [baseline] (224.172 ms) : 0, 224172
GlobalTracer [candidate] (220.456 ms) : 0, 220456
AppSec [baseline] (34.724 ms) : 0, 34724
AppSec [candidate] (32.298 ms) : 0, 32298
Debugger [baseline] (12.339 ms) : 0, 12339
Debugger [candidate] (12.898 ms) : 0, 12898
Remote Config [baseline] (721.388 µs) : 0, 721
Remote Config [candidate] (697.475 µs) : 0, 697
Telemetry [baseline] (9.175 ms) : 0, 9175
Telemetry [candidate] (9.736 ms) : 0, 9736
Flare Poller [baseline] (4.213 ms) : 0, 4213
Flare Poller [candidate] (4.127 ms) : 0, 4127
ProfilingAgent [baseline] (111.902 ms) : 0, 111902
ProfilingAgent [candidate] (109.712 ms) : 0, 109712
Profiling [baseline] (112.568 ms) : 0, 112568
Profiling [candidate] (110.331 ms) : 0, 110331
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~ca66190ab3, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050510
Total [baseline] (8.714 s) : 0, 8713866
Agent [candidate] (1.028 s) : 0, 1027775
Total [candidate] (8.683 s) : 0, 8683340
section iast
Agent [baseline] (1.166 s) : 0, 1166309
Total [baseline] (9.382 s) : 0, 9381675
Agent [candidate] (1.16 s) : 0, 1159627
Total [candidate] (9.361 s) : 0, 9361259
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~ca66190ab3, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (716.742 ms) : 0, 716742
BytebuddyAgent [candidate] (700.8 ms) : 0, 700800
GlobalTracer [baseline] (248.91 ms) : 0, 248910
GlobalTracer [candidate] (244.47 ms) : 0, 244470
AppSec [baseline] (33.11 ms) : 0, 33110
AppSec [candidate] (32.143 ms) : 0, 32143
Debugger [baseline] (6.639 ms) : 0, 6639
Debugger [candidate] (6.353 ms) : 0, 6353
Remote Config [baseline] (698.276 µs) : 0, 698
Remote Config [candidate] (674.204 µs) : 0, 674
Telemetry [baseline] (12.514 ms) : 0, 12514
Telemetry [candidate] (15.103 ms) : 0, 15103
Flare Poller [baseline] (8.833 ms) : 0, 8833
Flare Poller [candidate] (5.636 ms) : 0, 5636
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (827.367 ms) : 0, 827367
BytebuddyAgent [candidate] (822.375 ms) : 0, 822375
GlobalTracer [baseline] (234.609 ms) : 0, 234609
GlobalTracer [candidate] (233.655 ms) : 0, 233655
AppSec [baseline] (31.671 ms) : 0, 31671
AppSec [candidate] (29.942 ms) : 0, 29942
Debugger [baseline] (6.109 ms) : 0, 6109
Debugger [candidate] (6.088 ms) : 0, 6088
Remote Config [baseline] (616.236 µs) : 0, 616
Remote Config [candidate] (597.918 µs) : 0, 598
Telemetry [baseline] (8.473 ms) : 0, 8473
Telemetry [candidate] (8.425 ms) : 0, 8425
Flare Poller [baseline] (4.229 ms) : 0, 4229
Flare Poller [candidate] (4.139 ms) : 0, 4139
IAST [baseline] (30.274 ms) : 0, 30274
IAST [candidate] (31.673 ms) : 0, 31673
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~ca66190ab3, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section baseline
no_agent (36.139 ms) : 35854, 36424
. : milestone, 36139,
appsec (48.95 ms) : 48506, 49393
. : milestone, 48950,
code_origins (42.896 ms) : 42530, 43262
. : milestone, 42896,
iast (46.117 ms) : 45725, 46510
. : milestone, 46117,
profiling (47.794 ms) : 47378, 48210
. : milestone, 47794,
tracing (43.18 ms) : 42818, 43542
. : milestone, 43180,
section candidate
no_agent (38.274 ms) : 37970, 38578
. : milestone, 38274,
appsec (46.841 ms) : 46414, 47267
. : milestone, 46841,
code_origins (43.97 ms) : 43579, 44361
. : milestone, 43970,
iast (45.077 ms) : 44673, 45481
. : milestone, 45077,
profiling (48.729 ms) : 48288, 49169
. : milestone, 48729,
tracing (44.18 ms) : 43785, 44575
. : milestone, 44180,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~ca66190ab3, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section baseline
no_agent (4.321 ms) : 4267, 4376
. : milestone, 4321,
iast (9.977 ms) : 9809, 10145
. : milestone, 9977,
iast_FULL (14.023 ms) : 13746, 14301
. : milestone, 14023,
iast_GLOBAL (10.372 ms) : 10187, 10556
. : milestone, 10372,
profiling (9.006 ms) : 8855, 9156
. : milestone, 9006,
tracing (8.003 ms) : 7883, 8123
. : milestone, 8003,
section candidate
no_agent (4.425 ms) : 4376, 4475
. : milestone, 4425,
iast (9.768 ms) : 9600, 9936
. : milestone, 9768,
iast_FULL (14.817 ms) : 14524, 15109
. : milestone, 14817,
iast_GLOBAL (10.845 ms) : 10651, 11039
. : milestone, 10845,
profiling (9.013 ms) : 8866, 9161
. : milestone, 9013,
tracing (7.965 ms) : 7851, 8078
. : milestone, 7965,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~ca66190ab3, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section baseline
no_agent (15.491 s) : 15491000, 15491000
. : milestone, 15491000,
appsec (14.702 s) : 14702000, 14702000
. : milestone, 14702000,
iast (18.61 s) : 18610000, 18610000
. : milestone, 18610000,
iast_GLOBAL (18.273 s) : 18273000, 18273000
. : milestone, 18273000,
profiling (15.181 s) : 15181000, 15181000
. : milestone, 15181000,
tracing (15.324 s) : 15324000, 15324000
. : milestone, 15324000,
section candidate
no_agent (15.483 s) : 15483000, 15483000
. : milestone, 15483000,
appsec (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
iast (18.665 s) : 18665000, 18665000
. : milestone, 18665000,
iast_GLOBAL (18.109 s) : 18109000, 18109000
. : milestone, 18109000,
profiling (15.453 s) : 15453000, 15453000
. : milestone, 15453000,
tracing (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~ca66190ab3, baseline=1.55.0-SNAPSHOT~9f0225c968
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1498
. : milestone, 1486,
appsec (3.734 ms) : 3515, 3953
. : milestone, 3734,
iast (2.229 ms) : 2165, 2292
. : milestone, 2229,
iast_GLOBAL (2.256 ms) : 2192, 2320
. : milestone, 2256,
profiling (2.082 ms) : 2030, 2135
. : milestone, 2082,
tracing (2.033 ms) : 1984, 2082
. : milestone, 2033,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.737 ms) : 3518, 3955
. : milestone, 3737,
iast (2.214 ms) : 2150, 2277
. : milestone, 2214,
iast_GLOBAL (2.26 ms) : 2196, 2324
. : milestone, 2260,
profiling (2.089 ms) : 2036, 2142
. : milestone, 2089,
tracing (2.032 ms) : 1982, 2081
. : milestone, 2032,
|
d49ccdb to
2183ae2
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be nice to have some explanation in PR's description.
07e4c13 to
1803b53
Compare
1803b53 to
ca66190
Compare
What Does This Do
Resolve the issue with the StackedOperatorsTest being flaky by removing the subscribe spans. This is because their parent may be either the connect parent or the upstream parent, both of which may fluctuate when executed with a concurrent scheduler.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]