Keep the correct profiling context on vthread mount/unmount#9699
Closed
Keep the correct profiling context on vthread mount/unmount#9699
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 35ba4e5 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 4 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~35ba4e5156, baseline=1.55.0-SNAPSHOT~a56894b54b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017016
Total [baseline] (8.708 s) : 0, 8707554
Agent [candidate] (1.017 s) : 0, 1017112
Total [candidate] (8.643 s) : 0, 8643347
section iast
Agent [baseline] (1.152 s) : 0, 1151632
Total [baseline] (9.271 s) : 0, 9270856
Agent [candidate] (1.148 s) : 0, 1147894
Total [candidate] (9.248 s) : 0, 9247647
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~35ba4e5156, baseline=1.55.0-SNAPSHOT~a56894b54b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (692.596 ms) : 0, 692596
BytebuddyAgent [candidate] (693.369 ms) : 0, 693369
GlobalTracer [baseline] (241.656 ms) : 0, 241656
GlobalTracer [candidate] (241.397 ms) : 0, 241397
AppSec [baseline] (32.537 ms) : 0, 32537
AppSec [candidate] (32.761 ms) : 0, 32761
Debugger [baseline] (6.421 ms) : 0, 6421
Debugger [candidate] (6.373 ms) : 0, 6373
Remote Config [baseline] (699.784 µs) : 0, 700
Remote Config [candidate] (697.449 µs) : 0, 697
Telemetry [baseline] (9.313 ms) : 0, 9313
Telemetry [candidate] (9.183 ms) : 0, 9183
Flare Poller [baseline] (11.174 ms) : 0, 11174
Flare Poller [candidate] (10.867 ms) : 0, 10867
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (815.755 ms) : 0, 815755
BytebuddyAgent [candidate] (812.651 ms) : 0, 812651
GlobalTracer [baseline] (231.767 ms) : 0, 231767
GlobalTracer [candidate] (231.196 ms) : 0, 231196
AppSec [baseline] (35.411 ms) : 0, 35411
AppSec [candidate] (35.613 ms) : 0, 35613
Debugger [baseline] (6.11 ms) : 0, 6110
Debugger [candidate] (6.117 ms) : 0, 6117
Remote Config [baseline] (620.249 µs) : 0, 620
Remote Config [candidate] (596.22 µs) : 0, 596
Telemetry [baseline] (8.596 ms) : 0, 8596
Telemetry [candidate] (8.596 ms) : 0, 8596
Flare Poller [baseline] (4.221 ms) : 0, 4221
Flare Poller [candidate] (4.163 ms) : 0, 4163
IAST [baseline] (26.33 ms) : 0, 26330
IAST [candidate] (26.392 ms) : 0, 26392
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~35ba4e5156, baseline=1.55.0-SNAPSHOT~a56894b54b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024298
Total [baseline] (10.772 s) : 0, 10772471
Agent [candidate] (1.019 s) : 0, 1018713
Total [candidate] (10.716 s) : 0, 10715901
section appsec
Agent [baseline] (1.199 s) : 0, 1199220
Total [baseline] (11.076 s) : 0, 11076469
Agent [candidate] (1.194 s) : 0, 1194044
Total [candidate] (11.076 s) : 0, 11075510
section iast
Agent [baseline] (1.151 s) : 0, 1151107
Total [baseline] (10.972 s) : 0, 10971707
Agent [candidate] (1.147 s) : 0, 1147429
Total [candidate] (10.951 s) : 0, 10951080
section profiling
Agent [baseline] (1.16 s) : 0, 1160011
Total [baseline] (11.142 s) : 0, 11142179
Agent [candidate] (1.16 s) : 0, 1159972
Total [candidate] (11.011 s) : 0, 11010723
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~35ba4e5156, baseline=1.55.0-SNAPSHOT~a56894b54b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (697.838 ms) : 0, 697838
BytebuddyAgent [candidate] (695.537 ms) : 0, 695537
GlobalTracer [baseline] (242.859 ms) : 0, 242859
GlobalTracer [candidate] (241.781 ms) : 0, 241781
AppSec [baseline] (32.775 ms) : 0, 32775
AppSec [candidate] (32.734 ms) : 0, 32734
Debugger [baseline] (6.46 ms) : 0, 6460
Debugger [candidate] (6.431 ms) : 0, 6431
Remote Config [baseline] (715.453 µs) : 0, 715
Remote Config [candidate] (682.956 µs) : 0, 683
Telemetry [baseline] (9.249 ms) : 0, 9249
Telemetry [candidate] (9.292 ms) : 0, 9292
Flare Poller [baseline] (11.594 ms) : 0, 11594
Flare Poller [candidate] (9.545 ms) : 0, 9545
section appsec
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (720.728 ms) : 0, 720728
BytebuddyAgent [candidate] (717.277 ms) : 0, 717277
GlobalTracer [baseline] (235.524 ms) : 0, 235524
GlobalTracer [candidate] (233.942 ms) : 0, 233942
AppSec [baseline] (176.153 ms) : 0, 176153
AppSec [candidate] (176.019 ms) : 0, 176019
Debugger [baseline] (6.127 ms) : 0, 6127
Debugger [candidate] (6.216 ms) : 0, 6216
Remote Config [baseline] (656.153 µs) : 0, 656
Remote Config [candidate] (650.103 µs) : 0, 650
Telemetry [baseline] (8.49 ms) : 0, 8490
Telemetry [candidate] (8.596 ms) : 0, 8596
Flare Poller [baseline] (3.954 ms) : 0, 3954
Flare Poller [candidate] (4.009 ms) : 0, 4009
IAST [baseline] (24.95 ms) : 0, 24950
IAST [candidate] (24.776 ms) : 0, 24776
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (815.367 ms) : 0, 815367
BytebuddyAgent [candidate] (812.256 ms) : 0, 812256
GlobalTracer [baseline] (231.953 ms) : 0, 231953
GlobalTracer [candidate] (231.212 ms) : 0, 231212
AppSec [baseline] (35.222 ms) : 0, 35222
AppSec [candidate] (35.454 ms) : 0, 35454
Debugger [baseline] (6.017 ms) : 0, 6017
Debugger [candidate] (6.028 ms) : 0, 6028
Remote Config [baseline] (617.419 µs) : 0, 617
Remote Config [candidate] (584.852 µs) : 0, 585
Telemetry [baseline] (8.367 ms) : 0, 8367
Telemetry [candidate] (8.511 ms) : 0, 8511
Flare Poller [baseline] (4.203 ms) : 0, 4203
Flare Poller [candidate] (4.227 ms) : 0, 4227
IAST [baseline] (26.493 ms) : 0, 26493
IAST [candidate] (26.494 ms) : 0, 26494
section profiling
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (719.441 ms) : 0, 719441
BytebuddyAgent [candidate] (720.623 ms) : 0, 720623
GlobalTracer [baseline] (217.163 ms) : 0, 217163
GlobalTracer [candidate] (216.185 ms) : 0, 216185
AppSec [baseline] (32.522 ms) : 0, 32522
AppSec [candidate] (32.955 ms) : 0, 32955
Debugger [baseline] (6.399 ms) : 0, 6399
Debugger [candidate] (6.416 ms) : 0, 6416
Remote Config [baseline] (687.092 µs) : 0, 687
Remote Config [candidate] (1.534 ms) : 0, 1534
Telemetry [baseline] (16.696 ms) : 0, 16696
Telemetry [candidate] (15.763 ms) : 0, 15763
Flare Poller [baseline] (4.296 ms) : 0, 4296
Flare Poller [candidate] (4.187 ms) : 0, 4187
ProfilingAgent [baseline] (108.006 ms) : 0, 108006
ProfilingAgent [candidate] (107.306 ms) : 0, 107306
Profiling [baseline] (109.406 ms) : 0, 109406
Profiling [candidate] (109.002 ms) : 0, 109002
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 4 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~35ba4e5156, baseline=1.55.0-SNAPSHOT~a56894b54b
dateFormat X
axisFormat %s
section baseline
no_agent (37.065 ms) : 36758, 37372
. : milestone, 37065,
appsec (49.993 ms) : 49555, 50431
. : milestone, 49993,
code_origins (43.063 ms) : 42696, 43429
. : milestone, 43063,
iast (46.012 ms) : 45610, 46414
. : milestone, 46012,
profiling (48.232 ms) : 47817, 48647
. : milestone, 48232,
tracing (44.258 ms) : 43873, 44644
. : milestone, 44258,
section candidate
no_agent (35.023 ms) : 34747, 35300
. : milestone, 35023,
appsec (47.738 ms) : 47309, 48167
. : milestone, 47738,
code_origins (45.59 ms) : 45188, 45991
. : milestone, 45590,
iast (45.085 ms) : 44697, 45473
. : milestone, 45085,
profiling (48.889 ms) : 48447, 49331
. : milestone, 48889,
tracing (45.934 ms) : 45527, 46340
. : milestone, 45934,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~35ba4e5156, baseline=1.55.0-SNAPSHOT~a56894b54b
dateFormat X
axisFormat %s
section baseline
no_agent (4.425 ms) : 4375, 4475
. : milestone, 4425,
iast (9.499 ms) : 9343, 9656
. : milestone, 9499,
iast_FULL (14.082 ms) : 13803, 14360
. : milestone, 14082,
iast_GLOBAL (11.483 ms) : 11278, 11688
. : milestone, 11483,
profiling (8.939 ms) : 8796, 9081
. : milestone, 8939,
tracing (7.975 ms) : 7853, 8096
. : milestone, 7975,
section candidate
no_agent (4.306 ms) : 4255, 4358
. : milestone, 4306,
iast (9.905 ms) : 9736, 10073
. : milestone, 9905,
iast_FULL (14.815 ms) : 14522, 15108
. : milestone, 14815,
iast_GLOBAL (10.601 ms) : 10411, 10792
. : milestone, 10601,
profiling (9.262 ms) : 9106, 9419
. : milestone, 9262,
tracing (7.743 ms) : 7627, 7858
. : milestone, 7743,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~35ba4e5156, baseline=1.55.0-SNAPSHOT~a56894b54b
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.518 ms) : 2465, 2572
. : milestone, 2518,
iast (2.212 ms) : 2148, 2276
. : milestone, 2212,
iast_GLOBAL (2.258 ms) : 2194, 2322
. : milestone, 2258,
profiling (2.062 ms) : 2011, 2113
. : milestone, 2062,
tracing (2.03 ms) : 1981, 2079
. : milestone, 2030,
section candidate
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.747 ms) : 3528, 3966
. : milestone, 3747,
iast (2.216 ms) : 2153, 2280
. : milestone, 2216,
iast_GLOBAL (2.261 ms) : 2197, 2326
. : milestone, 2261,
profiling (2.083 ms) : 2029, 2137
. : milestone, 2083,
tracing (2.033 ms) : 1984, 2083
. : milestone, 2033,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~35ba4e5156, baseline=1.55.0-SNAPSHOT~a56894b54b
dateFormat X
axisFormat %s
section baseline
no_agent (15.664 s) : 15664000, 15664000
. : milestone, 15664000,
appsec (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
iast (18.334 s) : 18334000, 18334000
. : milestone, 18334000,
iast_GLOBAL (18.186 s) : 18186000, 18186000
. : milestone, 18186000,
profiling (15.265 s) : 15265000, 15265000
. : milestone, 15265000,
tracing (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
section candidate
no_agent (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
appsec (15.244 s) : 15244000, 15244000
. : milestone, 15244000,
iast (18.565 s) : 18565000, 18565000
. : milestone, 18565000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
. : milestone, 18054000,
profiling (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
tracing (14.968 s) : 14968000, 14968000
. : milestone, 14968000,
|
Contributor
Author
|
Thanks to the magic of the Loom scheduler which turns each VT quantum into a scheduled future task, our existing context propagation just works ... Still, this kind of instrumentation may come handy in the future if we decide to eg. measure how long a VT was 'unmounted'. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]