Update GHA workflows to use commit-headless#9702
Conversation
| env: | ||
| GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
| command: push | ||
| commits: "${{ steps.create-commit.outputs.commit }}" |
There was a problem hiding this comment.
This workflow does not push with a dd-octo-sts token because we don't need to sign commits to the Cloud Foundry repo, unlike to Datadog repos. As a follow-up, we should be able to delete the corresponding policy: https://github.com/DataDog/dd-trace-java/blob/master/.github/chainguard/self.add-release-to-cloudfoundry.sts.yaml.
There was a problem hiding this comment.
For clarification, it's the same repo but an unprotected branch.
There was a problem hiding this comment.
Oh right thanks 😅
cc21133 to
1048b04
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: e0ca046 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~e0ca046838, baseline=1.55.0-SNAPSHOT~2e10824bcf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018333
Total [baseline] (8.705 s) : 0, 8704706
Agent [candidate] (1.024 s) : 0, 1024438
Total [candidate] (8.703 s) : 0, 8703375
section iast
Agent [baseline] (1.154 s) : 0, 1153701
Total [baseline] (9.345 s) : 0, 9344761
Agent [candidate] (1.156 s) : 0, 1156446
Total [candidate] (9.292 s) : 0, 9292350
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~e0ca046838, baseline=1.55.0-SNAPSHOT~2e10824bcf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (693.366 ms) : 0, 693366
BytebuddyAgent [candidate] (697.851 ms) : 0, 697851
GlobalTracer [baseline] (241.692 ms) : 0, 241692
GlobalTracer [candidate] (242.86 ms) : 0, 242860
AppSec [baseline] (32.586 ms) : 0, 32586
AppSec [candidate] (32.875 ms) : 0, 32875
Debugger [baseline] (6.434 ms) : 0, 6434
Debugger [candidate] (6.473 ms) : 0, 6473
Remote Config [baseline] (702.965 µs) : 0, 703
Remote Config [candidate] (691.351 µs) : 0, 691
Telemetry [baseline] (9.288 ms) : 0, 9288
Telemetry [candidate] (9.357 ms) : 0, 9357
Flare Poller [baseline] (11.707 ms) : 0, 11707
Flare Poller [candidate] (11.66 ms) : 0, 11660
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (817.114 ms) : 0, 817114
BytebuddyAgent [candidate] (819.22 ms) : 0, 819220
GlobalTracer [baseline] (232.404 ms) : 0, 232404
GlobalTracer [candidate] (232.742 ms) : 0, 232742
AppSec [baseline] (35.15 ms) : 0, 35150
AppSec [candidate] (35.282 ms) : 0, 35282
Debugger [baseline] (6.159 ms) : 0, 6159
Debugger [candidate] (6.147 ms) : 0, 6147
Remote Config [baseline] (608.491 µs) : 0, 608
Remote Config [candidate] (624.949 µs) : 0, 625
Telemetry [baseline] (8.695 ms) : 0, 8695
Telemetry [candidate] (8.689 ms) : 0, 8689
Flare Poller [baseline] (4.261 ms) : 0, 4261
Flare Poller [candidate] (4.268 ms) : 0, 4268
IAST [baseline] (26.579 ms) : 0, 26579
IAST [candidate] (26.699 ms) : 0, 26699
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~e0ca046838, baseline=1.55.0-SNAPSHOT~2e10824bcf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016763
Total [baseline] (10.76 s) : 0, 10760436
Agent [candidate] (1.017 s) : 0, 1017389
Total [candidate] (10.684 s) : 0, 10683599
section appsec
Agent [baseline] (1.193 s) : 0, 1192715
Total [baseline] (11.072 s) : 0, 11072316
Agent [candidate] (1.194 s) : 0, 1194282
Total [candidate] (11.048 s) : 0, 11047720
section iast
Agent [baseline] (1.15 s) : 0, 1150067
Total [baseline] (11.01 s) : 0, 11010400
Agent [candidate] (1.149 s) : 0, 1148644
Total [candidate] (11.056 s) : 0, 11056450
section profiling
Agent [baseline] (1.161 s) : 0, 1160712
Total [baseline] (11.062 s) : 0, 11062173
Agent [candidate] (1.164 s) : 0, 1164158
Total [candidate] (11.086 s) : 0, 11086271
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~e0ca046838, baseline=1.55.0-SNAPSHOT~2e10824bcf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (692.881 ms) : 0, 692881
BytebuddyAgent [candidate] (693.2 ms) : 0, 693200
GlobalTracer [baseline] (241.631 ms) : 0, 241631
GlobalTracer [candidate] (241.547 ms) : 0, 241547
AppSec [baseline] (32.416 ms) : 0, 32416
AppSec [candidate] (32.509 ms) : 0, 32509
Debugger [baseline] (6.398 ms) : 0, 6398
Debugger [candidate] (6.41 ms) : 0, 6410
Remote Config [baseline] (698.495 µs) : 0, 698
Remote Config [candidate] (691.273 µs) : 0, 691
Telemetry [baseline] (9.28 ms) : 0, 9280
Telemetry [candidate] (9.306 ms) : 0, 9306
Flare Poller [baseline] (10.862 ms) : 0, 10862
Flare Poller [candidate] (11.042 ms) : 0, 11042
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (716.151 ms) : 0, 716151
BytebuddyAgent [candidate] (718.331 ms) : 0, 718331
GlobalTracer [baseline] (234.75 ms) : 0, 234750
GlobalTracer [candidate] (234.525 ms) : 0, 234525
AppSec [baseline] (175.291 ms) : 0, 175291
AppSec [candidate] (175.077 ms) : 0, 175077
Debugger [baseline] (6.145 ms) : 0, 6145
Debugger [candidate] (6.144 ms) : 0, 6144
Remote Config [baseline] (625.301 µs) : 0, 625
Remote Config [candidate] (630.701 µs) : 0, 631
Telemetry [baseline] (8.46 ms) : 0, 8460
Telemetry [candidate] (8.425 ms) : 0, 8425
Flare Poller [baseline] (3.967 ms) : 0, 3967
Flare Poller [candidate] (3.884 ms) : 0, 3884
IAST [baseline] (24.84 ms) : 0, 24840
IAST [candidate] (24.743 ms) : 0, 24743
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (814.384 ms) : 0, 814384
BytebuddyAgent [candidate] (812.559 ms) : 0, 812559
GlobalTracer [baseline] (231.804 ms) : 0, 231804
GlobalTracer [candidate] (232.012 ms) : 0, 232012
AppSec [baseline] (35.083 ms) : 0, 35083
AppSec [candidate] (35.095 ms) : 0, 35095
Debugger [baseline] (6.083 ms) : 0, 6083
Debugger [candidate] (6.142 ms) : 0, 6142
Remote Config [baseline] (604.351 µs) : 0, 604
Remote Config [candidate] (606.433 µs) : 0, 606
Telemetry [baseline] (8.557 ms) : 0, 8557
Telemetry [candidate] (8.635 ms) : 0, 8635
Flare Poller [baseline] (4.266 ms) : 0, 4266
Flare Poller [candidate] (4.264 ms) : 0, 4264
IAST [baseline] (26.478 ms) : 0, 26478
IAST [candidate] (26.56 ms) : 0, 26560
section profiling
crashtracking [baseline] (1.441 ms) : 0, 1441
crashtracking [candidate] (1.419 ms) : 0, 1419
BytebuddyAgent [baseline] (720.984 ms) : 0, 720984
BytebuddyAgent [candidate] (722.894 ms) : 0, 722894
GlobalTracer [baseline] (217.059 ms) : 0, 217059
GlobalTracer [candidate] (217.788 ms) : 0, 217788
AppSec [baseline] (32.698 ms) : 0, 32698
AppSec [candidate] (32.688 ms) : 0, 32688
Debugger [baseline] (7.203 ms) : 0, 7203
Debugger [candidate] (7.226 ms) : 0, 7226
Remote Config [baseline] (698.638 µs) : 0, 699
Remote Config [candidate] (696.496 µs) : 0, 696
Telemetry [baseline] (15.157 ms) : 0, 15157
Telemetry [candidate] (15.931 ms) : 0, 15931
Flare Poller [baseline] (4.99 ms) : 0, 4990
Flare Poller [candidate] (4.228 ms) : 0, 4228
ProfilingAgent [baseline] (107.533 ms) : 0, 107533
ProfilingAgent [candidate] (108.521 ms) : 0, 108521
Profiling [baseline] (108.519 ms) : 0, 108519
Profiling [candidate] (109.245 ms) : 0, 109245
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e0ca046838, baseline=1.55.0-SNAPSHOT~2e10824bcf
dateFormat X
axisFormat %s
section baseline
no_agent (35.563 ms) : 35278, 35847
. : milestone, 35563,
appsec (49.565 ms) : 49116, 50015
. : milestone, 49565,
code_origins (43.158 ms) : 42782, 43534
. : milestone, 43158,
iast (45.867 ms) : 45468, 46267
. : milestone, 45867,
profiling (48.135 ms) : 47713, 48556
. : milestone, 48135,
tracing (44.884 ms) : 44496, 45273
. : milestone, 44884,
section candidate
no_agent (37.879 ms) : 37566, 38191
. : milestone, 37879,
appsec (50.033 ms) : 49579, 50487
. : milestone, 50033,
code_origins (44.654 ms) : 44273, 45035
. : milestone, 44654,
iast (45.05 ms) : 44661, 45439
. : milestone, 45050,
profiling (47.616 ms) : 47167, 48065
. : milestone, 47616,
tracing (43.766 ms) : 43391, 44141
. : milestone, 43766,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e0ca046838, baseline=1.55.0-SNAPSHOT~2e10824bcf
dateFormat X
axisFormat %s
section baseline
no_agent (4.38 ms) : 4330, 4431
. : milestone, 4380,
iast (10.073 ms) : 9902, 10244
. : milestone, 10073,
iast_FULL (14.11 ms) : 13829, 14391
. : milestone, 14110,
iast_GLOBAL (11.124 ms) : 10922, 11327
. : milestone, 11124,
profiling (8.672 ms) : 8540, 8803
. : milestone, 8672,
tracing (7.915 ms) : 7800, 8030
. : milestone, 7915,
section candidate
no_agent (4.428 ms) : 4375, 4481
. : milestone, 4428,
iast (9.374 ms) : 9220, 9528
. : milestone, 9374,
iast_FULL (13.755 ms) : 13485, 14025
. : milestone, 13755,
iast_GLOBAL (10.671 ms) : 10481, 10861
. : milestone, 10671,
profiling (8.783 ms) : 8627, 8939
. : milestone, 8783,
tracing (7.805 ms) : 7694, 7917
. : milestone, 7805,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e0ca046838, baseline=1.55.0-SNAPSHOT~2e10824bcf
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.726 ms) : 3507, 3944
. : milestone, 3726,
iast (2.219 ms) : 2155, 2282
. : milestone, 2219,
iast_GLOBAL (2.261 ms) : 2197, 2326
. : milestone, 2261,
profiling (2.067 ms) : 2016, 2118
. : milestone, 2067,
tracing (2.029 ms) : 1979, 2078
. : milestone, 2029,
section candidate
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (3.726 ms) : 3509, 3944
. : milestone, 3726,
iast (2.222 ms) : 2158, 2285
. : milestone, 2222,
iast_GLOBAL (2.253 ms) : 2190, 2317
. : milestone, 2253,
profiling (2.073 ms) : 2021, 2126
. : milestone, 2073,
tracing (2.036 ms) : 1987, 2086
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e0ca046838, baseline=1.55.0-SNAPSHOT~2e10824bcf
dateFormat X
axisFormat %s
section baseline
no_agent (15.721 s) : 15721000, 15721000
. : milestone, 15721000,
appsec (14.879 s) : 14879000, 14879000
. : milestone, 14879000,
iast (18.372 s) : 18372000, 18372000
. : milestone, 18372000,
iast_GLOBAL (18.142 s) : 18142000, 18142000
. : milestone, 18142000,
profiling (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
tracing (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
section candidate
no_agent (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
appsec (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
iast (18.912 s) : 18912000, 18912000
. : milestone, 18912000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
. : milestone, 17904000,
profiling (15.107 s) : 15107000, 15107000
. : milestone, 15107000,
tracing (15.302 s) : 15302000, 15302000
. : milestone, 15302000,
|
What Does This Do
Update the following workflows to use
commit-headless(https://github.com/DataDog/commit-headless/tree/action):Motivation
Replace use of third party
ghcommittool with Datadogcommit-headlesstoolAdditional Notes
Unfortunately with the
dd-octo-stspolicies, I can only test these workflows when run viamaster, not on a branch. TheAdd release to cloudfoundryworkflow can only be tested during releases. However, if it fails, all steps can be manually done as well.This PR is pretty much the same as #9302, but it was easier for me to restart than address merge / rebase conflicts.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-701